void marked 5 inline comments as done. void added inline comments.
================ Comment at: llvm/lib/CodeGen/MachineBasicBlock.cpp:1115-1116 + if (Succ->hasAddressTaken()) + if (auto *bb = Succ->getBasicBlock()) + if (auto *cbr = dyn_cast<CallBrInst>(getBasicBlock()->getTerminator())) + if (cbr->getDefaultDest() != bb) ---------------- nickdesaulniers wrote: > I think it may be worthwhile to swap these conditions with each other, too. > It's highly unlikely the BB is terminated with a `CallBrInst`, yet highly > likely the MBB refers to a BB. Okay. No one likes this addition. I'm going to remove it and just check `IsInlineAsmBrIndirectTarget`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69868/new/ https://reviews.llvm.org/D69868 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
