dblaikie accepted this revision.
dblaikie added a subscriber: rnk.
dblaikie added a comment.
This revision is now accepted and ready to land.
Looks pretty good to me - couple of minor things. If you want to check with
@rnk (best point of contact on the inalloca feature in general), that'd
probably be good.
Might've been a bit easier to review with the renamings in separate patches,
but this makes it easier to see all the call sites, which is handy.
================
Comment at: llvm/lib/IR/Attributes.cpp:885
+ return I.getValueAsType();
+ return 0;
+}
----------------
Probably use nullptr, rather than 0 here.
================
Comment at: llvm/lib/IR/Core.cpp:150-155
+ } else if (AttrKind == Attribute::AttrKind::InAlloca) {
+ // Similarly inalloca for now.
+ return wrap(Attribute::getWithInAllocaType(Ctx, NULL));
} else {
return wrap(Attribute::get(Ctx, AttrKind, Val));
}
----------------
could drop the else-after-returns here, but I realize it's consistent with
existing style, so maybe better in a separate pre/post patch
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72331/new/
https://reviews.llvm.org/D72331
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
