[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX updated this revision to Diff 220613. SouraVX added a comment. Updated AST to use DWARF language enums. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67613/new/ https://reviews.llvm.org/D67613 Files: include/clang/AST/DeclCXX.h lib/AST/DeclPrinter.cpp lib/AST/JSONNodeDump

[PATCH] D67627: Clang-format: Add Whitesmiths indentation style

timwoj updated this revision to Diff 220610. timwoj added a comment. Marked failing tests as FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67627/new/ https://reviews.llvm.org/D67627 Files: clang/docs/ClangFormatStyleOptions.rst clang/inc

Re: r372185 - Revert "Create UsersManual section entitled 'Controlling Floating Point"

On Tue, 17 Sep 2019, 15:25 Erich Keane via cfe-commits, < cfe-commits@lists.llvm.org> wrote: > Author: erichkeane > Date: Tue Sep 17 14:27:07 2019 > New Revision: 372185 > > URL: http://llvm.org/viewvc/llvm-project?rev=372185&view=rev > Log: > Revert "Create UsersManual section entitled 'Controlli

r372197 - [X86] Prevent assertion when calling a function that returns double with -mno-sse2 on x86-64.

Author: ctopper Date: Tue Sep 17 18:57:46 2019 New Revision: 372197 URL: http://llvm.org/viewvc/llvm-project?rev=372197&view=rev Log: [X86] Prevent assertion when calling a function that returns double with -mno-sse2 on x86-64. As seen in the most recent updates to PR10498 Added: cfe/trunk/

[PATCH] D66121: Debug Info: Nest Objective-C property function decls inside their container.

rjmccall added a comment. In D66121#1673233 , @aprantl wrote: > I'm afraid I'm going to give up on fixing the AST and return to my > debuginfo-only patch. > > While I was correct in figuring out that ObjCMethodDecl implementations are > not linked up as

[PATCH] D67647: [Consumed] Refactor handleCall to take function argument list. NFC.

comex added a comment. Ugh, it looks like `getArgs()` is a massive strict aliasing violation. And it's used in enough different places in Clang that fixing the violation may require extensive refactoring... I've reported the issue as https://bugs.llvm.org/show_bug.cgi?id=43344, but I don't rea

[PATCH] D67683: [Timers] Fix printing some `-ftime-report` sections twice. Fixes PR40328.

vsapsai added a comment. Thanks for the fast review. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67683/new/ https://reviews.llvm.org/D67683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D67683: [Timers] Fix printing some `-ftime-report` sections twice. Fixes PR40328.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372191: [Timers] Fix printing some `-ftime-report` sections twice. Fixes PR40328. (authored by vsapsai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

r372191 - [Timers] Fix printing some `-ftime-report` sections twice. Fixes PR40328.

Author: vsapsai Date: Tue Sep 17 17:05:45 2019 New Revision: 372191 URL: http://llvm.org/viewvc/llvm-project?rev=372191&view=rev Log: [Timers] Fix printing some `-ftime-report` sections twice. Fixes PR40328. Starting from r324788 timer groups aren't cleared automatically when printed out. As a re

[PATCH] D67683: [Timers] Fix printing some `-ftime-report` sections twice. Fixes PR40328.

thegameg accepted this revision. thegameg added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67683/new/ https://reviews.llvm.org/D67683 ___ cfe-commits mailing list

[PATCH] D67683: [Timers] Fix printing some `-ftime-report` sections twice. Fixes PR40328.

vsapsai created this revision. vsapsai added reviewers: thegameg, george.karpenkov. Herald added subscribers: ributzka, dexonsmith, jkorous, aprantl. Starting from r324788 timer groups aren't cleared automatically when printed out. As a result some timer groups were printed one more time. For exam

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

kito-cheng added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1548 +{M.gccSuffix(), + "/../../../../riscv64-unknown-elf/lib" + M.gccSuffix()}); + }); It could be "riscv32-unknown-elf" other than "riscv6

[PATCH] D67467: [ARM] Update clang for removal of vfp2d16 and vfp2d16sp

This revision was automatically updated to reflect the committed changes. Closed by commit rL372187: [ARM] Update clang for removal of vfp2d16 and vfp2d16sp (authored by efriedma, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

r372187 - [ARM] Update clang for removal of vfp2d16 and vfp2d16sp

Author: efriedma Date: Tue Sep 17 14:43:19 2019 New Revision: 372187 URL: http://llvm.org/viewvc/llvm-project?rev=372187&view=rev Log: [ARM] Update clang for removal of vfp2d16 and vfp2d16sp Matching fix for https://reviews.llvm.org/D67375 (r372186). Differential Revision: https://reviews.llvm.o

[PATCH] D66121: Debug Info: Nest Objective-C property function decls inside their container.

aprantl added a comment. I'm afraid I'm going to give up on fixing the AST and return to my debuginfo-only patch. While I was correct in figuring out that ObjCMethodDecl implementations are not linked up as redeclarations of ObjCMethodDecl decls in the interface, that wasn't the whole story: `

r372185 - Revert "Create UsersManual section entitled 'Controlling Floating Point"

Author: erichkeane Date: Tue Sep 17 14:27:07 2019 New Revision: 372185 URL: http://llvm.org/viewvc/llvm-project?rev=372185&view=rev Log: Revert "Create UsersManual section entitled 'Controlling Floating Point" This reverts commit a08d5a4b0ebd44dc64f41049ed4e97a3c6d31498. Modified: cfe/trunk/

[PATCH] D66121: Debug Info: Nest Objective-C property function decls inside their container.

aprantl added a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66121/new/ https://reviews.llvm.org/D66121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53768: Add VerboseOutputStream to CompilerInstance

dblaikie added inline comments. Comment at: include/clang/Frontend/CompilerInstance.h:158-159 + /// Whether we should delete VerboseOutputStream on destruction. + bool OwnsVerboseOutputStream = false; + Rather than a bool, this could be a unique_ptr, perhaps?

[PATCH] D67559: [Sema] Split of versions of -Wimplicit-{float,int}-conversion for Objective-C BOOL

erik.pilkington marked an inline comment as done. erik.pilkington added inline comments. Comment at: clang/test/Sema/objc-bool-constant-conversion-fixit.m:37 + + b = 1 ? 2 : 3; + // CHECK: b = 1 ? 2 ? YES : NO : 3 ? YES : NO; aaron.ballman wrote: > What about:

[PATCH] D67559: [Sema] Split of versions of -Wimplicit-{float,int}-conversion for Objective-C BOOL

This revision was automatically updated to reflect the committed changes. Closed by commit rL372183: [Sema] Split of versions of -Wimplicit-{float,int}-conversion for Objective-C… (authored by epilk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed p

r372183 - [Sema] Split of versions of -Wimplicit-{float, int}-conversion for Objective-C BOOL

Author: epilk Date: Tue Sep 17 14:11:51 2019 New Revision: 372183 URL: http://llvm.org/viewvc/llvm-project?rev=372183&view=rev Log: [Sema] Split of versions of -Wimplicit-{float,int}-conversion for Objective-C BOOL Also, add a diagnostic group, -Wobjc-signed-char-bool, to control all these relat

[PATCH] D52281: [clang-tidy] Add modernize check to use std::invoke in generic code

boga95 abandoned this revision. boga95 marked 4 inline comments as done. boga95 added inline comments. Comment at: clang-tidy/modernize/ReplaceGenericFunctorCallCheck.cpp:72 + +const Expr *Obj = BinOp->getLHS(); +const std::string ObjName = I found an int

[PATCH] D67670: [clang-format][PR41964] Fix crash with SIGFPE when TabWidth is set to 0 and line starts with tab

MyDeveloperDay updated this revision to Diff 220571. MyDeveloperDay added a comment. I should have known it was more involved. v % 0 and v / 0 are both undefined behavior CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67670/new/ https://reviews.llvm.org/D67670 Files: clang/lib/Format

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

stephanemoore added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/google-objc-require-category-method-prefixes.rst:41 + +.. option:: ExpectedPrefixes + aaron.ballman wrote: > stephanemoore wrote: > > This option seems to describe a list o

[PATCH] D67647: [Consumed] Refactor handleCall to take function argument list. NFC.

dblaikie added inline comments. Comment at: lib/Analysis/Consumed.cpp:752 + handleCall(Call, nullptr, + llvm::makeArrayRef(Call->getArgs(), Call->getNumArgs()), + FunDecl); probably use "Call->arguments()" here & in the other places that

r372180 - Create UsersManual section entitled 'Controlling Floating Point

Author: erichkeane Date: Tue Sep 17 13:45:23 2019 New Revision: 372180 URL: http://llvm.org/viewvc/llvm-project?rev=372180&view=rev Log: Create UsersManual section entitled 'Controlling Floating Point Behavior' Create a new section for documenting the floating point options. Move all the floating

[PATCH] D62394: [ARM][CMSE] Add CMSE header & builtins

sigvartmh resigned from this revision. sigvartmh added a comment. Not used to phabricator tried to remove my request for change. So no one is working on upstreaming CMSE to LLVM now? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62394/new/ https://reviews.llvm.org/D62394 __

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

rsmith created this revision. rsmith added a reviewer: SjoerdMeijer. Herald added a subscriber: kristof.beyls. Herald added a project: clang. For ARM compilations with NEON enabled, for now we retain the old default of -flax-vector-conversions=all, because our intrinsic header relies on it, and i

[PATCH] D61717: Fix arm_neon.h to be clean under -fno-lax-vector-conversions.

rsmith added a comment. In D61717#1668980 , @SjoerdMeijer wrote: > Do you perhaps have a test case or error that I can look at? Perhaps I or > someone else here can help out a bit here. You can reproduce the problem with, for example: echo '#include

[PATCH] D67590: Properly ignore mismatched exception specifiers in MSVC Compat mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372178: Ignore exception specifier mismatch when merging redeclarations (authored by rnk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r372178 - Ignore exception specifier mismatch when merging redeclarations

Author: rnk Date: Tue Sep 17 13:29:10 2019 New Revision: 372178 URL: http://llvm.org/viewvc/llvm-project?rev=372178&view=rev Log: Ignore exception specifier mismatch when merging redeclarations Exception specifiers are now part of the function type in C++17. Normally, it is illegal to redeclare t

[PATCH] D67590: Properly ignore mismatched exception specifiers in MSVC Compat mode.

rnk updated this revision to Diff 220564. rnk added a comment. - simplify merging check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67590/new/ https://reviews.llvm.org/D67590 Files: clang/lib/Sema/SemaDecl.cpp clang/test/SemaCXX/ms-exception

[PATCH] D67522: [clang-scan-deps] Verbose mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b87364f511a: [clang-scan-deps] Add verbose mode (authored by jkorous). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D67522?vs

r372174 - [clang-scan-deps] Add verbose mode

Author: jkorous Date: Tue Sep 17 12:45:24 2019 New Revision: 372174 URL: http://llvm.org/viewvc/llvm-project?rev=372174&view=rev Log: [clang-scan-deps] Add verbose mode When running in the default mode we don't print anything other than actual output to stdout to make automated processing easier

[PATCH] D67670: [clang-format][PR41964] Fix crash with SIGFPE when TabWidth is set to 0 and line starts with tab

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.cpp:660 case '\t': -Column += Style.TabWidth - Column % Style.TabWidth; +Column += Style.TabWidth - (Column ? Column % Style

[PATCH] D66564: [clang-tidy] new FPGA struct pack align check

ffrankies added a subscriber: alexandre.isoard. ffrankies added a comment. Herald added a subscriber: usaxena95. @alexandre.isoard wrote: > I'm not sure what is the advantage of this compared to -Wpadded? This option only warns when padding exists. Our check does two things; it warns when ther

[PATCH] D67670: [clang-format][PR41964] Fix crash with SIGFPE when TabWidth is set to 0 and line starts with tab

klimek added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.cpp:660 case '\t': -Column += Style.TabWidth - Column % Style.TabWidth; +Column += Style.TabWidth - (Column ? Column % Style.TabWidth : 0); break; Shouldn'

[PATCH] D67559: [Sema] Split of versions of -Wimplicit-{float,int}-conversion for Objective-C BOOL

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/Sema/objc-bool-constant-conversion-fixit.m:37 + + b = 1 ? 2 : 3; + // CHECK: b = 1 ? 2 ? YES : NO : 3 ? YES : NO; ---

[PATCH] D63607: [clang][driver] Add basic --driver-mode=fortran support for flang

richard.barton.arm added a comment. Herald added a subscriber: usaxena95. Hi Peter The overall approach seems good to me and matches how the driver is integrated in the original flang project so not too many surprises. I left a few comments mostly about the scope of the original patch. I wonder

r372152 - Use 'BOOL' instead of BOOL in diagnostic messages

Author: epilk Date: Tue Sep 17 11:02:45 2019 New Revision: 372152 URL: http://llvm.org/viewvc/llvm-project?rev=372152&view=rev Log: Use 'BOOL' instead of BOOL in diagnostic messages Type names should be enclosed in single quotes. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D62394: [ARM][CMSE] Add CMSE header & builtins

dmgreen added a subscriber: chill. dmgreen added a comment. I'm afraid the upstreaming of CMSE has stalled, and this is not all that would be needed to get it working. This adds some header files and clang builtins, the selection of them in the backend isn't yet present, hence the error you are

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX marked 2 inline comments as done. SouraVX added inline comments. Comment at: include/clang/AST/DeclCXX.h:2931 +lang_cxx_11 = /* DW_LANG_C_plus_plus_11 */ 0x001a, +lang_cxx_14 = /* DW_LANG_C_plus_plus_14 */ 0x0021 }; aprantl wrote: > SouraVX wro

[PATCH] D67670: [clang-format][PR41964] Fix crash with SIGFPE when TabWidth is set to 0 and line starts with tab

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: owenpan, klimek, russellmcc, timwoj. MyDeveloperDay added a project: clang-tools-extra. Herald added a project: clang. clang-format 8.0 crashes with SIGFPE (floating point exception) when formatting following file: app.cpp: voi

[PATCH] D67584: [Support] Replace function with function_ref in writeFileAtomically. NFC

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. Good point! Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67584/new/ https://reviews.llvm.org/D67584 __

r372148 - [OPENMP] Rework the test, NFC.

Author: abataev Date: Tue Sep 17 10:44:27 2019 New Revision: 372148 URL: http://llvm.org/viewvc/llvm-project?rev=372148&view=rev Log: [OPENMP] Rework the test, NFC. Modified: cfe/trunk/test/OpenMP/parallel_for_codegen.cpp Modified: cfe/trunk/test/OpenMP/parallel_for_codegen.cpp URL: http://

r372147 - [OPENMP5.0]Introduce attribute for declare variant directive.

Author: abataev Date: Tue Sep 17 10:36:49 2019 New Revision: 372147 URL: http://llvm.org/viewvc/llvm-project?rev=372147&view=rev Log: [OPENMP5.0]Introduce attribute for declare variant directive. Added attribute for declare variant directive. It will allow to handle declare variant directive at t

[PATCH] D67559: [Sema] Split of versions of -Wimplicit-{float,int}-conversion for Objective-C BOOL

erik.pilkington added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3312 +def warn_impcast_float_to_objc_signed_char_bool : Warning< + "implicit conversion from floating-point type %0 to BOOL">, + InGroup; aaron.ballman wrote: >

[PATCH] D67559: [Sema] Split of versions of -Wimplicit-{float,int}-conversion for Objective-C BOOL

erik.pilkington updated this revision to Diff 220534. erik.pilkington marked 5 inline comments as done. erik.pilkington added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67559/new/ https://reviews.llvm.org/D67559 Files: clang/include/clang/Basic/

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

aprantl added inline comments. Comment at: include/clang/AST/DeclCXX.h:2931 +lang_cxx_11 = /* DW_LANG_C_plus_plus_11 */ 0x001a, +lang_cxx_14 = /* DW_LANG_C_plus_plus_14 */ 0x0021 }; SouraVX wrote: > aprantl wrote: > > SouraVX wrote: > > > aprantl wrote

[PATCH] D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h

lebedev.ri added a comment. Inline asm is //really// unfriendly to the optimizer. Ideally the plan should be to incrementally getting rid of it as soon as backend learns to properly match particular builtin. Comment at: clang-tools-extra/clang-include-fixer/find-all-symbols/S

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX marked an inline comment as done. SouraVX added inline comments. Comment at: include/clang/AST/DeclCXX.h:2931 +lang_cxx_11 = /* DW_LANG_C_plus_plus_11 */ 0x001a, +lang_cxx_14 = /* DW_LANG_C_plus_plus_14 */ 0x0021 }; aprantl wrote: > SouraVX wro

[PATCH] D67590: Properly ignore mismatched exception specifiers in MSVC Compat mode.

zahen added a comment. I just checked a trivial mismatch example in clang 8.0 (https://godbolt.org/z/wiSAp6) and I missed how the compatibility mode operates. I withdraw my suggestion since the patch keeps consistency with the existing behavior. Thanks for the `-Werror=microsoft-exception-spe

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

aprantl added inline comments. Comment at: include/clang/AST/DeclCXX.h:2931 +lang_cxx_11 = /* DW_LANG_C_plus_plus_11 */ 0x001a, +lang_cxx_14 = /* DW_LANG_C_plus_plus_14 */ 0x0021 }; SouraVX wrote: > aprantl wrote: > > I understand that DWARF does not d

[PATCH] D67590: Properly ignore mismatched exception specifiers in MSVC Compat mode.

thakis added a comment. In D67590#1672691 , @zahen wrote: > Is there any interest in supporting the cl.exe flag `/permissive-`? I > considered a hard error on mismatched exception specifier in clang-cl a > feature, not a bug. If msvc compat mode respec

[PATCH] D67659: [clang-format] Fix cleanup of `AnnotatedLine` to include children nodes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372129: [clang-format] Fix cleanup of `AnnotatedLine` to include children nodes. (authored by ymandel, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

r372130 - [OPENMP]Try to rework the test to pacify the buildbots, NFC.

Author: abataev Date: Tue Sep 17 08:11:52 2019 New Revision: 372130 URL: http://llvm.org/viewvc/llvm-project?rev=372130&view=rev Log: [OPENMP]Try to rework the test to pacify the buildbots, NFC. Modified: cfe/trunk/test/OpenMP/parallel_for_codegen.cpp Modified: cfe/trunk/test/OpenMP/parallel

r372129 - [clang-format] Fix cleanup of `AnnotatedLine` to include children nodes.

Author: ymandel Date: Tue Sep 17 08:10:39 2019 New Revision: 372129 URL: http://llvm.org/viewvc/llvm-project?rev=372129&view=rev Log: [clang-format] Fix cleanup of `AnnotatedLine` to include children nodes. Summary: AnnotatedLine has a tree structure, and things like the body of a lambda will be

[PATCH] D67590: Properly ignore mismatched exception specifiers in MSVC Compat mode.

zahen added a comment. Is there any interest in supporting the cl.exe flag `/permissive-`? I considered a hard error on mismatched exception specifier in clang-cl a feature, not a bug. If msvc compat mode respected that flag this could continue to be an error with that flag set (and upgraded

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp:53 +CheckFactories.registerCheck( +"cert-default-operator-new"); CheckFactories.registerCheck( balazske wrote: > aaron.ballman wrote: > > balazs

[PATCH] D67659: [clang-format] Fix cleanup of `AnnotatedLine` to include children nodes.

ymandel updated this revision to Diff 220504. ymandel added a comment. Fixed auto use. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67659/new/ https://reviews.llvm.org/D67659 Files: clang/lib/Format/Format.cpp clang/unittests/Format/CleanupTe

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp:53 +CheckFactories.registerCheck( +"cert-default-operator-new"); CheckFactories.registerCheck( aaron.ballm

[PATCH] D67659: [clang-format] Fix cleanup of `AnnotatedLine` to include children nodes.

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang/lib/Format/Format.cpp:1420 -for (auto &Line : AnnotatedLines) { - if (Line->Affected) { -cleanupRight(Line->First, tok::comma, tok::comma); -cleanupRight(Line->Fi

[clang-tools-extra] r372128 - [clangd] Fix another TSAN issue

Author: d0k Date: Tue Sep 17 07:56:11 2019 New Revision: 372128 URL: http://llvm.org/viewvc/llvm-project?rev=372128&view=rev Log: [clangd] Fix another TSAN issue Modified: clang-tools-extra/trunk/clangd/unittests/TUSchedulerTests.cpp Modified: clang-tools-extra/trunk/clangd/unittests/TUSched

[PATCH] D67660: [clang-format]

MyDeveloperDay created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D67660 Files: clang/lib/Format/FormatTokenLexer.cpp clang/lib/Format/FormatTokenLexer.h clang/lib/Format/TokenAnnotator.cpp clang/u

[PATCH] D63508: make -frewrite-includes also rewrite conditions in #if/#elif

torarnv added a comment. Thank you for the explanation! 🙂 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63508/new/ https://reviews.llvm.org/D63508 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D67659: [clang-format] Fix cleanup of `AnnotatedLine` to include children nodes.

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! Comment at: clang/lib/Format/Format.cpp:1420 -for (auto &Line : AnnotatedLines) { - if (Line->Affected) { -cleanupRight(Line->First, tok::co

[PATCH] D62394: [ARM][CMSE] Add CMSE header & builtins

sigvartmh added a comment. In D62394#1672570 , @javed.absar wrote: > In D62394#1672551 , @sigvartmh wrote: > > > Maybe I'm doing something wrong tried to apply these patches but when > > trying to build code which

[PATCH] D67659: [clang-format] Fix cleanup of `AnnotatedLine` to include children nodes.

ymandel created this revision. ymandel added a reviewer: krasimir. Herald added a project: clang. AnnotatedLine has a tree structure, and things like the body of a lambda will be a child of the lambda expression. For example, [&]() { foo(a); }; will have an AnnotatedLine with a child: [&]()

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

aaron.ballman added a comment. Thank you for working on this check! In D67545#1672106 , @balazske wrote: > C++17 makes things more difficult because the align is probably handled by > `operator new`, probably not, depending on the defined allocation func

[PATCH] D38446: update comments in clang-format.py for python3 compatibility

pseyfert added a comment. ping? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D38446/new/ https://reviews.llvm.org/D38446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

r372124 - Add SpellingNotCalculated to Attribute Enums to suppress UBSan warnings

Author: erichkeane Date: Tue Sep 17 07:11:51 2019 New Revision: 372124 URL: http://llvm.org/viewvc/llvm-project?rev=372124&view=rev Log: Add SpellingNotCalculated to Attribute Enums to suppress UBSan warnings UBSan downstreams noticed that the assignment of SpellingNotCalculated to the spellings

[PATCH] D62394: [ARM][CMSE] Add CMSE header & builtins

javed.absar added a comment. In D62394#1672551 , @sigvartmh wrote: > Maybe I'm doing something wrong tried to apply these patches but when trying > to build code which uses cmse I get > > Cannot select: intrinsic %llvm.arm.cmse.tt > fatal error: error in

[PATCH] D62394: [ARM][CMSE] Add CMSE header & builtins

sigvartmh requested changes to this revision. sigvartmh added a comment. This revision now requires changes to proceed. Maybe I'm doing something wrong tried to apply these patches but when trying to build code which uses cmse I get Cannot select: intrinsic %llvm.arm.cmse.tt fatal error: error i

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

alexfh added a comment. A couple of drive-by comments. Comment at: clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp:22-33 +constexpr llvm::StringLiteral FuncExprName = "entire-called-function-expr"; +constexpr llvm::StringLiteral CastExprName = "cast-expr

r372119 - [OpenCL] Tidy up some comments; NFC

Author: svenvh Date: Tue Sep 17 06:32:56 2019 New Revision: 372119 URL: http://llvm.org/viewvc/llvm-project?rev=372119&view=rev Log: [OpenCL] Tidy up some comments; NFC Modified: cfe/trunk/lib/Sema/OpenCLBuiltins.td Modified: cfe/trunk/lib/Sema/OpenCLBuiltins.td URL: http://llvm.org/viewvc/

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines-init-variables.rst:40 + +Options +--- This is still missing the documentation for `MathHeader` and its default value. CHANGES SINCE LAST ACTION ht

[PATCH] D67159: [clang] New __attribute__((__clang_arm_mve_alias)).

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:596 } +def ArmMveAlias : InheritableAttr, TargetSpecificAttr { + let Spellings = [Clang<"__clang_arm_mve_alias">]; Add a newline before the attribute definition for some separati

[libclc] r372115 - Creating release candidate rc6 from release_900 branch

Author: hans Date: Tue Sep 17 06:09:16 2019 New Revision: 372115 URL: http://llvm.org/viewvc/llvm-project?rev=372115&view=rev Log: Creating release candidate rc6 from release_900 branch Added: libclc/tags/RELEASE_900/rc6/ - copied from r372114, libclc/branches/release_90/ _

[libunwind] r372115 - Creating release candidate rc6 from release_900 branch

Author: hans Date: Tue Sep 17 06:09:16 2019 New Revision: 372115 URL: http://llvm.org/viewvc/llvm-project?rev=372115&view=rev Log: Creating release candidate rc6 from release_900 branch Added: libunwind/tags/RELEASE_900/rc6/ - copied from r372114, libunwind/branches/release_90/ ___

r372113 - Hide implementation details in namespaces.

Author: d0k Date: Tue Sep 17 05:56:29 2019 New Revision: 372113 URL: http://llvm.org/viewvc/llvm-project?rev=372113&view=rev Log: Hide implementation details in namespaces. Modified: cfe/trunk/lib/Sema/SemaLookup.cpp Modified: cfe/trunk/lib/Sema/SemaLookup.cpp URL: http://llvm.org/viewvc/ll

[PATCH] D67632: [libTooling] Introduce new library of source-code builders.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/lib/Tooling/Refactoring/SourceCodeBuilders.cpp:77 + + if (Text.empty()) return std::string(); + // Add leading '*'. Eugene.Zelenko wrote: > Could return {}. Same in other

[PATCH] D67651: [clangd] No ExtractFunction on empty selections.

hokein added a comment. In D67651#1672403 , @kadircet wrote: > this one is actually specific to vardecl's and has a pending fix in D66872 > > > I would rather wait for it to land, instead of adding another branch. WDYT?

[PATCH] D67632: [libTooling] Introduce new library of source-code builders.

ymandel updated this revision to Diff 220488. ymandel added a comment. ran clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67632/new/ https://reviews.llvm.org/D67632 Files: clang/include/clang/Tooling/Refactoring/SourceCodeBuilders.h

[PATCH] D67627: Clang-format: Add Whitesmiths indentation style

krasimir added a comment. Adding @djasper as this is really a re-implementation of https://reviews.llvm.org/D6833. Agree with @MyDeveloperDay that in general we should aim to document all the known cases where a style doesn't work (with FIXMEs etc.), but not submit failing tests. We can have t

[PATCH] D67654: [clang-tidy] Fix a potential infinite loop in readability-isolate-declaration check.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added a subscriber: xazax.hun. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67654 Files: clang-tools-extra/clang-tidy/utils/LexerUtils.h clang-tools-extra/test/clan

[PATCH] D67651: [clangd] No ExtractFunction on empty selections.

kadircet added a comment. this one is actually specific to vardecl's and has a pending fix in D66872 I would rather wait for it to land, instead of adding another branch. WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX updated this revision to Diff 220472. SouraVX set the repository for this revision to rC Clang. SouraVX added a comment. Removed underscores from names. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67613/new/ https://reviews.llvm.org/D67613 Files: inc

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/google-objc-require-category-method-prefixes.rst:41 + +.. option:: ExpectedPrefixes + stephanemoore wrote: > This option seems to describe a list of class prefixes that are

[PATCH] D67627: Clang-format: Add Whitesmiths indentation style

MyDeveloperDay added a comment. when/if you commit can you abandon D6833: Clang-format: Braces Indent Style Whitesmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67627/new/ https://reviews.llvm.org/D67627 ___

[PATCH] D67627: Clang-format: Add Whitesmiths indentation style

MyDeveloperDay added a comment. Thank you for this patch This LGTM, ensure you comment out the failing unit tests and add a FIXME to the test as to why they don't currently work (or fix them if possible), the tests need to keep passing or others will not know they haven't broken things. Normal

[clang-tools-extra] r372102 - Add SemanticRanges to Clangd server.

Author: usaxena95 Date: Tue Sep 17 03:28:05 2019 New Revision: 372102 URL: http://llvm.org/viewvc/llvm-project?rev=372102&view=rev Log: Add SemanticRanges to Clangd server. Summary: Adds Semantic Ranges capabilities to Clangd server. Also adds tests for running it via clangd server. This differs

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

lenary added a comment. I have some nits about explicit comments for arguments and default argument values for backwards compatibility. Other than that, it looks like a nice code cleanup. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6071 // Add the target features -

[PATCH] D67650: [clangd] Add SemanticRanges to Clangd server.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372102: Add SemanticRanges to Clangd server. (authored by usaxena95, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D67650: [clangd] Add SemanticRanges to Clangd server.

usaxena95 updated this revision to Diff 220465. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67650/new/ https://reviews.llvm.org/D67650 Files: clang-tool

[PATCH] D67651: [clangd] No ExtractFunction on empty selections.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67651 Files: clang-tools-extra/clangd/refactor/tweaks/

Re: r371969 - Change signature of __builtin_rotateright64 back to unsigned

Merged to release_90 in r372100. On Mon, Sep 16, 2019 at 11:50 AM Karl-Johan Karlsson via cfe-commits wrote: > > Author: karka > Date: Mon Sep 16 02:52:23 2019 > New Revision: 371969 > > URL: http://llvm.org/viewvc/llvm-project?rev=371969&view=rev > Log: > Change signature of __builtin_rotaterigh

[PATCH] D67650: [clangd] Add SemanticRanges to Clangd server.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! looks good. I think next step is to implement it in the LSP layer. Comment at: clang-tools-extra/clangd/unittests/SemanticSelectionTests.cpp:161 + )cpp"; + Annotati

[PATCH] D67650: Add SemanticRanges to Clangd server.

usaxena95 created this revision. usaxena95 added a reviewer: hokein. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Adds Semantic Ranges capabilities to Clangd server. Also adds tests for running it via clangd server. Th

r372095 - [NFC] Updated test

Author: xbolva00 Date: Tue Sep 17 02:53:14 2019 New Revision: 372095 URL: http://llvm.org/viewvc/llvm-project?rev=372095&view=rev Log: [NFC] Updated test Modified: cfe/trunk/test/CodeGen/tbaa-struct.cpp Modified: cfe/trunk/test/CodeGen/tbaa-struct.cpp URL: http://llvm.org/viewvc/llvm-projec

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/DefaultOperatorNewCheck.cpp:49 + if (HasDefaultOperatorNew && OverAligned) +diag(NewExpr->getBeginLoc(), "using default 'operator new' with over-aligned

  1   2   >