kito-cheng added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1548 + {M.gccSuffix(), + "/../../../../riscv64-unknown-elf/lib" + M.gccSuffix()}); + }); ---------------- It could be "riscv32-unknown-elf" other than "riscv64-unknown-elf". ================ Comment at: clang/lib/Driver/ToolChains/RISCVToolchain.cpp:129 + } + std::string Linker = getToolChain().GetProgramPath(getShortName()); ---------------- This change seems like unrelated to multi-lib, could you split this change into new patch and add a test for that? ================ Comment at: clang/lib/Driver/ToolChains/RISCVToolchain.cpp:132 if (D.isUsingLTO()) { assert(!Inputs.empty() && "Must have at least one input."); ---------------- This part will conflict when apply patch, you might generate patch with https://reviews.llvm.org/D67409, could you rebase the patch with current trunk? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67508/new/ https://reviews.llvm.org/D67508 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits