dblaikie added inline comments.
================ Comment at: include/clang/Frontend/CompilerInstance.h:158-159 + /// Whether we should delete VerboseOutputStream on destruction. + bool OwnsVerboseOutputStream = false; + ---------------- Rather than a bool, this could be a unique_ptr, perhaps? (null when non-owning) ================ Comment at: include/clang/Frontend/CompilerInstance.h:362-363 + /// If not set, this stream defaults to \c llvm::errs(). + void setVerboseOutputStream(raw_ostream &Value, + bool OwnsOutputStream = false); + ---------------- Two functions - one that takes a raw_ostream& and another that takes a unique_ptr<raw_ostream>? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53768/new/ https://reviews.llvm.org/D53768 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
