r371488 - Revert "clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM"

Author: phosek Date: Mon Sep 9 23:25:13 2019 New Revision: 371488 URL: http://llvm.org/viewvc/llvm-project?rev=371488&view=rev Log: Revert "clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM" This reverts commit r371484: this broke sanitizer-x86_64-linux-fast bot. Re

[PATCH] D67079: [analyzer] CastValueChecker: Model inheritance

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:126 + + // If the casts have a common anchestor it could not be a succeeded downcast. + for (const auto &PreviousBase : PreviousRD->bases()) Charusso wrote: > NoQ wrot

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

This revision was automatically updated to reflect the committed changes. Closed by commit rL371484: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D66324?vs=219219&id=219472#to

[PATCH] D60076: [Attributor] Deduce memory behavior function attributes

jdoerfert added a comment. Obsolete, D67384 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60076/new/ https://reviews.llvm.org/D60076 ___ cfe-commits mailing list cfe-

r371484 - clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

Author: phosek Date: Mon Sep 9 20:11:39 2019 New Revision: 371484 URL: http://llvm.org/viewvc/llvm-project?rev=371484&view=rev Log: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM This patch contains the basic functionality for reporting potentially incorrect usage

[PATCH] D59980: [Attributor] Deduce memory behavior argument attributes

jdoerfert abandoned this revision. jdoerfert added a comment. Obsolete, D67384 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59980/new/ https://reviews.llvm.org/D59980 __

[PATCH] D67079: [analyzer] CastValueChecker: Model inheritance

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:174 + +constexpr llvm::StringLiteral Vowels = "aeiou"; + Charusso wrote: > NoQ wrote: > > Omg lol nice. Did you try to figure out how do other people normally do it? > T

Re: r359367 - Reinstate r359059, reverted in r359361, with a fix to properly prevent

On Fri, Apr 26, 2019 at 7:56 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Fri Apr 26 19:58:17 2019 > New Revision: 359367 > > URL: http://llvm.org/viewvc/llvm-project?rev=359367&view=rev > Log: > Reinstate r359059, reverted in r359361, with a fix t

[PATCH] D67336: [analyzer][NFC] Introduce SuperChecker<>, a convenient alternative to Checker<> for storing subcheckers

NoQ added a comment. I have mixed feelings. Removing boilerplate is good, but the very fact that we're legalizing this pattern indicates that our checkers will keep bloating up, while i always wanted to actually split them instead (like, make sub-checkers into their own separate //classes//, po

[PATCH] D67335: [analyzer][NFC] Refactor the checker registration unit test file

NoQ accepted this revision. NoQ added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/StaticAnalyzer/RegisterCustomCheckersTest.cpp:84 -} -} -} +} // namespace +} // namespace ento Szelethus wrote: > Well, according

r371478 - Remove REQUIRES:shell from tests that pass for me on Windows

Author: rnk Date: Mon Sep 9 17:50:32 2019 New Revision: 371478 URL: http://llvm.org/viewvc/llvm-project?rev=371478&view=rev Log: Remove REQUIRES:shell from tests that pass for me on Windows I see in the history for some of these tests REQUIRES:shell was used as a way to disable tests on Windows

[PATCH] D67321: Respect CLANG_LINK_CLANG_DYLIB=ON in libclang and c-index-test

beanz added a comment. @aaronpuchert sounds like a reasonable approach Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67321/new/ https://reviews.llvm.org/D67321 ___ cfe-commits mailing list cfe-commits@

fixing 2 typos

Found 2 typos when I was trying to use the context sensitive profiling feature earlier today: $ git diff docs/UsersManual.rst diff --git a/clang/docs/UsersManual.rst b/clang/docs/UsersManual.rst index f45d2d5ac0e..0f5f315cfcb

[PATCH] D66796: [clang] Loop pragma vectorize(disable)

hsaito added a comment. In D66796#1663868 , @SjoerdMeijer wrote: > That's exactly the reason why I think `vectorize(disable)` should disable > vectorisation for that loop. I just don't see what else a user would expect. I agree with you. Now on the pr

r371476 - Fix crash mangling an explicit lambda non-type template parameter pack

Author: rsmith Date: Mon Sep 9 17:39:53 2019 New Revision: 371476 URL: http://llvm.org/viewvc/llvm-project?rev=371476&view=rev Log: Fix crash mangling an explicit lambda non-type template parameter pack that is not a pack expansion. Modified: cfe/trunk/lib/AST/ItaniumMangle.cpp cfe/trunk

[PATCH] D67321: Respect CLANG_LINK_CLANG_DYLIB=ON in libclang and c-index-test

aaronpuchert added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:115 +clang_target_link_libraries(libclang + PRIVATE + ${CLANG_LIB_DEPS} beanz wrote: > tstellar wrote: > > aaronpuchert wrote: > > > This might not be correct for static builds,

[PATCH] D64991: [analyzer][WIP] Implement a primitive reaching definitions analysis

NoQ added a comment. In D64991#1662185 , @Szelethus wrote: > Hmm, we could make a redundant assignments checker: if a variable has > multiple reaching definitions, but those all assign the same value, emit a > warning. We could even use fixits with that.

[PATCH] D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks"

NoQ added a comment. In D67140#1659982 , @gribozavr wrote: > We should take a page from desktop software here. If the messages were in a > separate file, there would be a lot of people capable of mass-editing them. > When messages are hardcoded in the to

[PATCH] D67382: [analyzer] NFC: Move getStmt() and createEndOfPath() out of PathDiagnostic.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, zzheng, szepet, kristof.beyls. Herald added a project: clang. These static fu

[PATCH] D67381: [analyzer] NFC: Move stack hints to a side map.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. Stack hints are attached to `PathDiagn

[PATCH] D67373: Don't emit .gnu_pubnames when tuning for LLDB

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Seems good to me - thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67373/new/ https://reviews.llvm.org/D67373 _

[PATCH] D67373: Don't emit .gnu_pubnames when tuning for LLDB

JDevlieghere added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3400 if (DwarfFission != DwarfFissionKind::None || - DebuggerTuning == llvm::DebuggerKind::LLDB || (PubnamesArg && checkDebugInfoOption(PubnamesArg, Args, D, TC))) ---

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

rupprecht added a comment. There's definitely a lot of new findings this creates, but it's hard to say exactly how many root causes there are due to the way test failures are (not) grouped well in the way I'm testing. So far they all seem like true positives, so this would be good to submit. Ho

[PATCH] D67373: Don't emit .gnu_pubnames when tuning for LLDB

aprantl added a comment. In D67373#1663924 , @dblaikie wrote: > Have you got a link to the original thread where this was discussed/I > mentioned it? Want to page in some context to double-check if I had any ideas > that might've let this simplify things

r371468 - PR43242: Fix crash when typo-correcting to an operator() that should not

Author: rsmith Date: Mon Sep 9 16:07:22 2019 New Revision: 371468 URL: http://llvm.org/viewvc/llvm-project?rev=371468&view=rev Log: PR43242: Fix crash when typo-correcting to an operator() that should not have been visible. Modified: cfe/trunk/lib/Sema/SemaExpr.cpp cfe/trunk/test/SemaCXX

[PATCH] D67373: Don't emit .gnu_pubnames when tuning for LLDB

dblaikie added a comment. Have you got a link to the original thread where this was discussed/I mentioned it? Want to page in some context to double-check if I had any ideas that might've let this simplify things. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. In D62731#1663748 , @rjmccall wrote: > Hmm, you know, there are enough different FP options that I think we should > probably split them all out into their own section in the manual instead of > just listing them under "code gene

[PATCH] D67373: Don't emit .gnu_pubnames when tuning for LLDB

aprantl created this revision. aprantl added reviewers: jasonmolenda, dblaikie, friss, emaste, JDevlieghere. Herald added a project: clang. LLDB reads the various `.apple*` accelerator tables which should make `.gnu_pubnames` redundant. This changes the Clang driver to no longer pass `-ggnu-pubn

RE: r371080 - [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial

Hi David, I've reverted the patch in r371113. It was causing crashes in asan on Linux & Darwin. Before re-landing the patch, it needs this: https://reviews.llvm.org/D67283 Alex. -Message d'origine- De : David Blaikie Envoyé : September 9, 2019 6:12 PM À : Erik Pilkington Cc : Alexand

Re: r371080 - [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial

Any resolution/discussion on this crash? On Thu, Sep 5, 2019 at 12:49 PM Erik Pilkington via cfe-commits wrote: > > Hi Alexandre, > > Looks like this commit is causing crashes on darwin, can you take a look > please? Here is a failing bot: > http://lab.llvm.org:8080/green/job/clang-stage1-RA/16

[PATCH] D65371: do not emit -Wunused-macros warnings in -frewrite-includes mode (PR15614)

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Fair enough - thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65371/new/ https://reviews.llvm.org/D65371 _

[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

ABataev added a comment. In D66559#1663887 , @cchen wrote: > @ABataev, could you mark it as ready to land, please. Thanks. I accepted it already, don't know what else I can do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

RKSimon added a comment. In D64146#1663867 , @nand wrote: > I am providing definitions in the C++ file - the problem is that they are not > available in the header before the extern declaration. The methods are > available at the site of the extern defin

[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

cchen marked an inline comment as done. cchen added a comment. @ABataev, could you mark it as ready to land, please. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66559/new/ https://reviews.llvm.org/D66559 ___

[PATCH] D66796: [clang] Loop pragma vectorize(disable)

SjoerdMeijer added a comment. And thanks Florian for getting this discussion going again! Will definitely make this clear(er) in this description and commit message once we agree on it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66796/new/ https://reviews.llvm.org/D66796

[PATCH] D66796: [clang] Loop pragma vectorize(disable)

SjoerdMeijer added a comment. Hi Hideki, I think you're comments are spot on: > It all depends on to whom we are providing these pragmas. Pragma's are user-facing "options" to override or force compiler decision making. I don't think there's another way to look at it, but please correct me i

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

nand added a comment. I am providing definitions in the C++ file - the problem is that they are not available in the header before the extern declaration. The methods are available at the site of the extern definition. gcc and clang accept this, so does Visual Studio 2019. This feels like an i

[PATCH] D66696: [ObjC generics] Fix not inheriting type bounds in categories/extensions.

erik.pilkington added a comment. I'm a bit curious about clients that use `getCanonicalType()` to get a full desugaring, instead of doing a single step. It seems like they'd still get the out of date type parameter type. Has that ever worked? CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D67304: Emit -Wmicrosoft-enum-value warning instead of error in MS ABI

rnk requested review of this revision. rnk added a comment. Ptal, new patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67304/new/ https://reviews.llvm.org/D67304 ___ cfe-commits mailing list cfe-com

[PATCH] D67024: [analyzer] NFC: Replace intrusive list of bug reports with a vector of pointers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL371451: [analyzer] NFC: Simplify bug report equivalence classes to not be ilists. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[PATCH] D67304: Unify checking enumerator values in ObjC, C, and MSVC modes

rnk added a comment. In D67304#1663042 , @hans wrote: > Should there be a test exercising this part? The updated tests both have > -fms-compatibility, so were already just warning. Good point, we aren't testing that this unfixed enum behavior is a part

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

rjmccall added a comment. Hmm, you know, there are enough different FP options that I think we should probably split them all out into their own section in the manual instead of just listing them under "code generation". That will also give us an obvious place to describe the basic model, i.e.

[PATCH] D66696: [ObjC generics] Fix not inheriting type bounds in categories/extensions.

vsapsai added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66696/new/ https://reviews.llvm.org/D66696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D67304: Unify checking enumerator values in ObjC, C, and MSVC modes

rnk updated this revision to Diff 219425. rnk added a comment. - rewrite, abandon unification Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67304/new/ https://reviews.llvm.org/D67304 Files: clang/lib/Sema/SemaDecl.cpp clang/test/Sema/Microsoft

[PATCH] D67024: [analyzer] NFC: Replace intrusive list of bug reports with a vector of pointers.

NoQ marked 5 inline comments as done. NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:569 SmallVectorImpl &bugReports) { -return &*eqClass.begin(); +return eqClass.getReports().begin

[PATCH] D66572: [analyzer] NFC: BugReporter Separation Ep.I.

NoQ marked 5 inline comments as done. NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:113 + // encouraged, but the period at the end of the description is still omitted. + StringRef getDescription() const { return Descri

r371451 - [analyzer] NFC: Simplify bug report equivalence classes to not be ilists.

Author: dergachev Date: Mon Sep 9 13:34:44 2019 New Revision: 371451 URL: http://llvm.org/viewvc/llvm-project?rev=371451&view=rev Log: [analyzer] NFC: Simplify bug report equivalence classes to not be ilists. Use a vector of unique pointers instead. Differential Revision: https://reviews.llvm.o

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc marked 2 inline comments as done. mibintc added inline comments. Comment at: clang/docs/UsersManual.rst:1314 + ``-ffp-model=strict``, or merely establish the rounding mode setting + parameter to the llvm floating point constrained intrinsics. + rjmcca

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3002 false); llvm::Constant *Resolver = GetOrCreateLLVMFunction( MangledName + ".resolver", ResolverType, GlobalDecl{}, zsrkmyn wrote: > zsrkmyn wrote: > > er

[PATCH] D65433: [clangd] DefineInline action availability checks

arphaman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:192 + Intent intent() const override { return Intent::Refactor; } + std::string title() const override { return "Inline function definition"; } + sammccall wro

Re: r371437 - [Driver] Add -static-openmp driver option

Hi Joerg, Lines 37, 58, 71 in the test checks this interaction, for instance: // RUN: %clang -target x86_64-linux-gnu -fopenmp=libiomp5 -static -static-openmp %s -o %t -### 2>&1 | FileCheck %s --check-prefix=CHECK-LD-STATIC-IOMP5-NO-BDYNAMIC Are you asking for a different test instead? On Mon, S

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

lebedev.ri added a comment. In D67122#1663619 , @vsk wrote: > > In D67122#1659721 , @vsk wrote: > > > >> Still think this looks good. Have you tried running this on the llvm test > >> suite, or some other interest

Re: r371437 - [Driver] Add -static-openmp driver option

On Mon, Sep 09, 2019 at 06:31:41PM -, Pirama Arumuga Nainar via cfe-commits wrote: > Author: pirama > Date: Mon Sep 9 11:31:41 2019 > New Revision: 371437 > > URL: http://llvm.org/viewvc/llvm-project?rev=371437&view=rev > Log: > [Driver] Add -static-openmp driver option This still needs tes

[PATCH] D66796: [clang] Loop pragma vectorize(disable)

hsaito added a comment. There are two ways to think. 1. vectorize(disable) as in disable the LoopVectorize pass itself. 2. vectorize(disable) as in disabling the loop vectorization transformation It all depends on to whom we are providing these pragmas. If we are providing pragmas for progr

[PATCH] D67364: [Driver] Handle default case in refactored addOpenMPRuntime

This revision was automatically updated to reflect the committed changes. Closed by commit rL371444: [Driver] Handle default case in refactored addOpenMPRuntime (authored by pirama, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

vsk added a comment. > In D67122#1659721 , @vsk wrote: > >> Still think this looks good. Have you tried running this on the llvm test >> suite, or some other interesting corpus? Would be curious to see any >> pre/post patch numbers. > > > There were 1.

r371444 - [Driver] Handle default case in refactored addOpenMPRuntime

Author: pirama Date: Mon Sep 9 12:52:39 2019 New Revision: 371444 URL: http://llvm.org/viewvc/llvm-project?rev=371444&view=rev Log: [Driver] Handle default case in refactored addOpenMPRuntime Summary: Appease failed builds (due to -Werror and -Wswitch) where OMPRT_Unknown is not handled in the s

[PATCH] D67364: [Driver] Handle default case in refactored addOpenMPRuntime

pirama updated this revision to Diff 219413. pirama added a comment. Check for OMPRT_Unknown instead of a default case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67364/new/ https://reviews.llvm.org/D67364 Files: clang/lib/Driver/ToolChains/C

[PATCH] D67364: [Driver] Handle default case in refactored addOpenMPRuntime

pirama created this revision. pirama added reviewers: srhines, danalbert. Herald added a subscriber: guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. Appease failed builds (due to -Werror and -Wswitch) where OMPRT_Unknown is not handled in the switch statement (even tho

[PATCH] D67321: Respect CLANG_LINK_CLANG_DYLIB=ON in libclang and c-index-test

beanz requested changes to this revision. beanz added inline comments. This revision now requires changes to proceed. Comment at: clang/tools/libclang/CMakeLists.txt:115 +clang_target_link_libraries(libclang + PRIVATE + ${CLANG_LIB_DEPS} tstellar wrote: > aaron

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth marked an inline comment as done. paulkirth added inline comments. Comment at: clang/test/Profile/misexpect-branch-cold.c:4 +// RUN: llvm-profdata merge %S/Inputs/misexpect-branch.proftext -o %t.profdata +// RUN: %clang_cc1 %s -O2 -o - -disable-llvm-passes -emit-llvm -

[PATCH] D67200: Add -static-openmp driver option

This revision was automatically updated to reflect the committed changes. Closed by commit rL371437: [Driver] Add -static-openmp driver option (authored by pirama, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

r371437 - [Driver] Add -static-openmp driver option

Author: pirama Date: Mon Sep 9 11:31:41 2019 New Revision: 371437 URL: http://llvm.org/viewvc/llvm-project?rev=371437&view=rev Log: [Driver] Add -static-openmp driver option Summary: For Gnu, FreeBSD and NetBSD, this option forces linking with the static OpenMP host runtime (similar to -static-l

[PATCH] D67358: [clangd] Implement semantic selections.

sammccall marked 3 inline comments as done. sammccall added a comment. Nice! Particularly: great tests. Only big thing is toHalfOpenFileRange should get you substantially better macro handling. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:18 +namespace { +void a

r371430 - [X86] Allow _MM_FROUND_CUR_DIRECTION and _MM_FROUND_NO_EXC to be used together on instructions that only support SAE and not embedded rounding.

Author: ctopper Date: Mon Sep 9 10:48:05 2019 New Revision: 371430 URL: http://llvm.org/viewvc/llvm-project?rev=371430&view=rev Log: [X86] Allow _MM_FROUND_CUR_DIRECTION and _MM_FROUND_NO_EXC to be used together on instructions that only support SAE and not embedded rounding. Current for SAE in

[PATCH] D67079: [analyzer] CastValueChecker: Model inheritance

Charusso added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/DynamicTypeInfo.h:24 + DynamicTypeInfo(QualType ty, bool CanBeSub = true) + : Ty(ty), CanBeASubClass(CanBeSub) {} NoQ wrote: > `Ty(Ty)` is the idiom here. G

[PATCH] D67079: [analyzer] CastValueChecker: Model inheritance

Charusso updated this revision to Diff 219391. Charusso marked 5 inline comments as done. Charusso added a comment. - Fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67079/new/ https://reviews.llvm.org/D67079 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/DynamicCast

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

rjmccall added a subscriber: scanon. rjmccall added a comment. I think this is a step in the right direction, thank you. I'd like @scanon to weigh in on the evolving design here. Comment at: clang/docs/UsersManual.rst:1314 + ``-ffp-model=strict``, or merely establish the ro

[PATCH] D67358: [clangd] Implement semantic selections.

usaxena95 updated this revision to Diff 219386. usaxena95 added a comment. Create range only if it represents a valid file range. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67358/new/ https://reviews.llvm.org/D67358 Files: clang-tools-extra/c

[PATCH] D66796: [clang] Loop pragma vectorize(disable)

fhahn added a comment. IMO it is fine to say ` pragma vectorize(disable)` disables the vectorizer completely, including interleaving. @Meinersbur, what do you think? I think it would be good to make that clear in the commit message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66796/n

[clang-tools-extra] r371422 - [clangd] Attempt to fix failing Windows buildbots.

Author: ibiryukov Date: Mon Sep 9 10:03:49 2019 New Revision: 371422 URL: http://llvm.org/viewvc/llvm-project?rev=371422&view=rev Log: [clangd] Attempt to fix failing Windows buildbots. The assertion is failing on Windows, probably because path separator is different. For the failure see: http

[PATCH] D66572: [analyzer] NFC: BugReporter Separation Ep.I.

gribozavr accepted this revision. gribozavr added a comment. I think this patch is a good improvement, and I don't want to hold it back -- but like we discussed before, and like you wrote on the mailing list, I would want a more simple API for ClangTidy. Comment at: clang/in

[PATCH] D67358: Implement semantic selections.

usaxena95 updated this revision to Diff 219381. usaxena95 added a comment. Removed logs for debugging. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67358/new/ https://reviews.llvm.org/D67358 Files: clang-tools-extra/clangd/CMakeLists.txt clan

[PATCH] D65371: do not emit -Wunused-macros warnings in -frewrite-includes mode (PR15614)

llunak added a comment. In D65371#1659929 , @dblaikie wrote: > A test case would be good (in the clang/test directory - probably near/in the > other tests for -frewrite-includes) Done. > And does the same bug occur for other preprocessor-related warnin

[PATCH] D65371: do not emit -Wunused-macros warnings in -frewrite-includes mode (PR15614)

llunak updated this revision to Diff 219370. llunak added a comment. Added a test. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65371/new/ https://reviews.llvm.org/D65371 Files: clang/lib/Lex/PPDirectives.cpp clang/test/Frontend/rewrite-includes-warnings.c

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

RKSimon added a comment. @nand The MSVC warnings are self explanatory - you've declared a number of methods (visitIndirectMember, emitConv and getPtrConstFn) but not provided definitions, as they're on template classes MSVC complains, a lot. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D62731: [RFC] Add support for options -frounding-math -fp-model= and -fp-exception-behavior= : specify floating point behavior

mibintc updated this revision to Diff 219364. mibintc retitled this revision from "[RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior" to "[RFC] Add support for options -frounding-math -fp-model= and -fp-exception-behavior= : specify floating point be

[PATCH] D67358: Implement semantic selections.

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, mgorny. Herald added a project: clang. For a given cursor position, it returns ranges that are interesting to the user. Currently the semantic ranges correspond to the nodes of the syntax trees.

[PATCH] D66564: [clang-tidy] new FPGA struct pack align check

ffrankies updated this revision to Diff 219358. ffrankies added a comment. Herald added subscribers: kadircet, jkorous. Sorry for the delay. I was mostly having trouble building clang-tidy after pulling from master and having it recognize that the struct-pack-align check exists. I finally realiz

[PATCH] D67264: [clangd] Collect location of macro definition in the ParsedAST

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. We should probably also take a look at highlighting macros inside the preamble part of the main file. @hokein, are you planning to do this or should we just file a bug for

[PATCH] D67341: [clangd] Simplify semantic highlighting visitor

ilya-biryukov added a comment. In D67341#1663104 , @hokein wrote: > Unfortunately, the patch is a bit large, containing refactoring changes and > functionality changes, is it possible to split it into (two) smaller patches? Done. There should be no func

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc marked 3 inline comments as done. mibintc added inline comments. Comment at: clang/docs/UsersManual.rst:1305 + and ``noexcept``. Note that -fp-model=[no]except can be combined with the + other three settings for this option. Details: + andrew.w.kaylor

[PATCH] D67341: [clangd] Simplify semantic highlighting visitor

ilya-biryukov updated this revision to Diff 219363. ilya-biryukov added a comment. - Turn into NFC, do not highlight lambdas differently Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67341/new/ https://reviews.llvm.org/D67341 Files: clang-tools-

r371410 - [NFC] Add aacps bitfields access test

Author: dnsampaio Date: Mon Sep 9 08:39:45 2019 New Revision: 371410 URL: http://llvm.org/viewvc/llvm-project?rev=371410&view=rev Log: [NFC] Add aacps bitfields access test Added: cfe/trunk/test/CodeGen/aapcs-bitfield.c Added: cfe/trunk/test/CodeGen/aapcs-bitfield.c URL: http://llvm.org/v

[PATCH] D67172: [clangd] Use pre-populated mappings for standard symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rL371408: [clangd] Use pre-populated mappings for standard symbols (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[clang-tools-extra] r371408 - [clangd] Use pre-populated mappings for standard symbols

Author: ibiryukov Date: Mon Sep 9 08:32:51 2019 New Revision: 371408 URL: http://llvm.org/viewvc/llvm-project?rev=371408&view=rev Log: [clangd] Use pre-populated mappings for standard symbols Summary: This takes ~5% of time when running clangd unit tests. To achieve this, move mapping of system

[PATCH] D67172: [clangd] Use pre-populated mappings for standard symbols

ilya-biryukov added a comment. Thanks for all suggestions. The final result is rather small and minimal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67172/new/ https://reviews.llvm.org/D67172 ___ cfe

[PATCH] D67172: [clangd] Use pre-populated mappings for standard symbols

ilya-biryukov updated this revision to Diff 219360. ilya-biryukov marked 3 inline comments as done. ilya-biryukov added a comment. - Make MaxSuffixComponents a constant - Put the suffix mapping into a single constant - Initialize all StringMaps directly - Rename to Std...Mapping Repository: rG

[PATCH] D67172: [clangd] Use pre-populated mappings for standard symbols

ilya-biryukov marked 8 inline comments as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/CanonicalIncludes.cpp:41 + if (!SuffixHeaderMapping) +return Header; sammccall wrote: > nit: can we write `if (SuffixHeaderMappi

[PATCH] D67172: [clangd] Use pre-populated mappings for standard symbols

sammccall added a comment. In D67172#1663179 , @ilya-biryukov wrote: > > "we could try" sounds like we *don't* know how to eliminate it. Parsing > > manpages aside, I thought the main problem was these symbols are > > nonstandard and an infinitely porta

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64943/new/ https://reviews.llvm.org/D64943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D67172: [clangd] Use pre-populated mappings for standard symbols

ilya-biryukov added a comment. In D67172#1663096 , @sammccall wrote: > LG, though if we can drop the struct and make MaxSuffixComponents a constant > it'd be simpler still. Done. > Sure. This is going to win a couple of percent I guess: for these cases

[PATCH] D65634: [RISCV] Default to ilp32d/lp64d in RISC-V Linux

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. Herald added a subscriber: pzheng. I think my feeling is that this patch can land and we can change the default abi for baremetal targets in a follow-up patch. Comment at: c

r371403 - Merge note_ovl_builtin_candidate diagnostics; NFC

Author: svenvh Date: Mon Sep 9 07:39:20 2019 New Revision: 371403 URL: http://llvm.org/viewvc/llvm-project?rev=371403&view=rev Log: Merge note_ovl_builtin_candidate diagnostics; NFC There is no difference between the unary and binary case, so merge them. Modified: cfe/trunk/include/clang/Ba

[PATCH] D67290: [clangd] Add a new highlighting kind for typedefs

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:530 + case HighlightingKind::Typedef: +return "entity.name.type.typedef.cpp"; case HighlightingKind::Namespace: ilya-biryukov wrote: > hokein wrote: > > ilya-biryu

[PATCH] D67290: [clangd] Add a new highlighting kind for typedefs

This revision was automatically updated to reflect the committed changes. Closed by commit rL371402: [clangd] Add a new highlighting kind for typedefs (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[clang-tools-extra] r371402 - [clangd] Add a new highlighting kind for typedefs

Author: ibiryukov Date: Mon Sep 9 07:33:10 2019 New Revision: 371402 URL: http://llvm.org/viewvc/llvm-project?rev=371402&view=rev Log: [clangd] Add a new highlighting kind for typedefs Summary: We still attempt to highlight them as underlying types, but fallback to the generic 'typedef' highligh

[PATCH] D67290: [clangd] Add a new highlighting kind for typedefs

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:530 + case HighlightingKind::Typedef: +return "entity.name.type.typedef.cpp"; case HighlightingKind::Namespace: hokein wrote: > ilya-biryukov wrote: > > Not

[PATCH] D67290: [clangd] Add a new highlighting kind for typedefs

ilya-biryukov updated this revision to Diff 219348. ilya-biryukov marked 3 inline comments as done. ilya-biryukov added a comment. - Remove stale comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67290/new/ https://reviews.llvm.org/D67290 File

  1   2   >