rnk added a comment. In D67304#1663042 <https://reviews.llvm.org/D67304#1663042>, @hans wrote:
> Should there be a test exercising this part? The updated tests both have > -fms-compatibility, so were already just warning. Good point, we aren't testing that this unfixed enum behavior is a part of the ABI, not `-fms-compatibility`. After testing this some more, I think I need to back off on my misguided refactoring. I didn't notice that the C99 warning was an off-by-default pedantic warning, and it didn't insert the implicit cast in the case where the value was not representable in int. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67304/new/ https://reviews.llvm.org/D67304 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
