hokein added inline comments.
================ Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:530 + case HighlightingKind::Typedef: + return "entity.name.type.typedef.cpp"; case HighlightingKind::Namespace: ---------------- ilya-biryukov wrote: > hokein wrote: > > ilya-biryukov wrote: > > > Not sure what the rules for the scope names are, happy to change if I'm > > > doing it wrong > > I think the current name is fine, just checked the name for this type in > > vscode highlighting configs, but didn't find a particular name for this > > type (my guess is that regex-based highlighting is not able to catch this > > case). > Ack. Keeping as is, thanks for taking a look. > Is there a way for us to provide a custom color for this in our extension? Or > would we just revert to the default color for `entity.name.type`? > Is there a way for us to provide a custom color for this in our extension? we don't support it yet, this is a feature request in https://github.com/clangd/clangd/issues/143. > Or would we just revert to the default color for entity.name.type? Yes, we will fallback to the color for `entity.name.type`. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67290/new/ https://reviews.llvm.org/D67290 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
