[PATCH] D51262: Implement P0553 and P0556

EricWF added a comment. Herald added a subscriber: dexonsmith. Please use Clang format on these changes. Otherwise the implementation looks great, I've left some nits. Comment at: include/bit:190 +template +struct __bitop_unsigned_integer +: public integral_constant && +

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

NoQ added a comment. //*sloowly catches up >.<*// CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62883/new/ https://reviews.llvm.org/D62883 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D62831: [CodeGen][ObjC] Add attribute "objc_arc_intert" to ObjC globals that are retain-agnostic

ahatanak added a comment. There are many attributes that start with `objc_` including `objc_arc_weak_reference_unavailable`. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62831/new/ https://reviews.llvm.org/D62831 _

[PATCH] D62831: [CodeGen][ObjC] Add attribute "objc_arc_intert" to ObjC globals that are retain-agnostic

ahatanak updated this revision to Diff 204705. ahatanak retitled this revision from "[CodeGen][ObjC] Add attribute "arc_retain_agnostic" to ObjC globals that are retain-agnostic" to "[CodeGen][ObjC] Add attribute "objc_arc_intert" to ObjC globals that are retain-agnostic". Repository: rC Clan

[PATCH] D63316: [clangd] Include the diagnostics's code when comparing diagnostics

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This fixes https://github.com/clangd/clangd/issues/60 Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass everything to see inlined calls

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Great, thanks!! Let's commit this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62926/new/ https://reviews.llvm.org/D62926 ___ cfe-commits ma

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass everything to see inlined calls

Charusso marked an inline comment as done. Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:855 + + CurrentSFC = Node->getStackFrame(); + NoQ wrote: > Mmm, wait a sec. This way the loop condition is trivially

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass everything to see inlined calls

Charusso updated this revision to Diff 204698. Charusso marked an inline comment as done. Charusso added a comment. - Whoops. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62926/new/ https://reviews.llvm.org/D62926 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp clang/

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass everything to see inlined calls

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:855 + + CurrentSFC = Node->getStackFrame(); + Mmm, wait a sec. This way the loop condition is trivially true. The second check on line 862 is also trivially true. I

[PATCH] D58880: [clangd] Type hierarchy subtypes

nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1061 + End.character = CD.End.column(); + // TODO: How to get entire range like in declToTypeHierarchyItem()? + THI.range = {Start, End}; kadircet wrote: > a few different approaches

[PATCH] D58880: [clangd] Type hierarchy subtypes

nridge updated this revision to Diff 204696. nridge marked 13 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58880/new/ https://reviews.llvm.org/D58880 Files: clang-tools-ex

[PATCH] D62839: [clangd] Index API and implementations for relations

nridge updated this revision to Diff 204691. nridge marked 7 inline comments as done. nridge added a comment. Address latest review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62839/new/ https://reviews.llvm.org/D62839 Files: clang-to

[PATCH] D62839: [clangd] Index API and implementations for relations

nridge added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:244 llvm::function_ref Callback) const { trace::Span Tracer("Dex lookup"); for (const auto &ID : Req.IDs) { kadircet wrote: > could you revert these chang

Re: r363295 - C++ DR712 and others: handle non-odr-use resulting from an lvalue-to-rvalue conversion applied to a member access or similar not-quite-trivial lvalue expression.

Hi, this made clang segfault on some inputs seen in ANGLE. I filed PR42276 with a reduced repro and reverted this (and the two dependent changes) in r363352 for now. Nico On Thu, Jun 13, 2019 at 2:56 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date:

r363352 - Revert 363295, it caused PR42276. Also revert follow-ups 363337, 363340.

Author: nico Date: Thu Jun 13 21:05:17 2019 New Revision: 363352 URL: http://llvm.org/viewvc/llvm-project?rev=363352&view=rev Log: Revert 363295, it caused PR42276. Also revert follow-ups 363337, 363340. Revert 363340 "Remove unused SK_LValueToRValue initialization step." Revert 363337 "PR23833,

[PATCH] D61750: [Targets] Move soft-float-abi filtering to `initFeatureMap`

This revision was automatically updated to reflect the committed changes. Closed by commit rL363346: [Targets] Move soft-float-abi filtering to `initFeatureMap` (authored by gbiv, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

r363346 - [Targets] Move soft-float-abi filtering to `initFeatureMap`

Author: gbiv Date: Thu Jun 13 17:35:17 2019 New Revision: 363346 URL: http://llvm.org/viewvc/llvm-project?rev=363346&view=rev Log: [Targets] Move soft-float-abi filtering to `initFeatureMap` ARM has a special target feature called soft-float-abi. This feature is special, since we get it passed to

r363345 - [AMDGPU] gfx1011/gfx1012 clang support

Author: rampitec Date: Thu Jun 13 17:33:59 2019 New Revision: 363345 URL: http://llvm.org/viewvc/llvm-project?rev=363345&view=rev Log: [AMDGPU] gfx1011/gfx1012 clang support Differential Revision: https://reviews.llvm.org/D63308 Modified: cfe/trunk/lib/Basic/Targets/AMDGPU.cpp cfe/trunk/

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

Szelethus added a comment. I took a look at the results. You can take a look at selected ones here: http://cc.elte.hu:15001/Default/#report-hash=&run=LLVM%2FClang%2FClang-tools-extra%20AFTER%20tracking%20conditions&review-status=Confirmed&review-status=False%20positive&review-status=Intentional&d

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

aaronpuchert added a reviewer: tejohnson. aaronpuchert added a comment. Sorry for making the inline comments disappear, but I had to switch to the big repository. @tejohnson Could you have a look at the LTO-related changes (BackendUtil.cpp + all files with LTO in the name)? Repository: rG L

r363343 - Revert "[Remarks] Refactor optimization remarks setup"

Author: thegameg Date: Thu Jun 13 17:05:56 2019 New Revision: 363343 URL: http://llvm.org/viewvc/llvm-project?rev=363343&view=rev Log: Revert "[Remarks] Refactor optimization remarks setup" This reverts commit 6e6e3af55bb97e1a4c97375c15a2b0099120c5a7. This breaks greendragon. Modified: cfe/

[PATCH] D61697: [lit] Disable test on darwin when building shared libs.

phosek added a comment. This broke all our macOS builders: llvm-lit: /b/s/w/ir/k/llvm-project/llvm/utils/lit/lit/TestingConfig.py:102: fatal: unable to parse config file '/b/s/w/ir/k/recipe_cleanup/clangh7IvHV/llvm_build_dir/tools/lld/test/lit.site.cfg.py', traceback: Traceback (most recent

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

aaronpuchert updated this revision to Diff 204661. aaronpuchert added a comment. Herald added subscribers: llvm-commits, dang, dexonsmith, steven_wu, hiraditya, mehdi_amini. Herald added a project: LLVM. Make sure the flags have the same meaning for LTO. Also slightly reworded the HelpText. Re

r363341 - [AMDGPU] gfx1010 wave32 clang support

Author: rampitec Date: Thu Jun 13 16:47:59 2019 New Revision: 363341 URL: http://llvm.org/viewvc/llvm-project?rev=363341&view=rev Log: [AMDGPU] gfx1010 wave32 clang support Differential Revision: https://reviews.llvm.org/D63209 Modified: cfe/trunk/docs/ClangCommandLineReference.rst cfe/t

r363340 - Remove unused SK_LValueToRValue initialization step.

Author: rsmith Date: Thu Jun 13 16:47:42 2019 New Revision: 363340 URL: http://llvm.org/viewvc/llvm-project?rev=363340&view=rev Log: Remove unused SK_LValueToRValue initialization step. In addition to being unused and duplicating code, this was also wrong (it didn't properly mark the operand as b

[PATCH] D61750: [Targets] Move soft-float-abi filtering to `initFeatureMap`

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61750/new/ https://reviews.llvm.org/D61750 ___ cfe-commits mailing list cfe-commi

[PATCH] D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

rsmith added a comment. In D62825#1542662 , @rjmccall wrote: > In D62825#1542639 , @rsmith wrote: > > > In my view, the mistake was specifying `nullptr_t` to have the same size > > and alignment as `void*`; it shou

r363337 - PR23833, DR2140: an lvalue-to-rvalue conversion on a glvalue of type

Author: rsmith Date: Thu Jun 13 16:31:04 2019 New Revision: 363337 URL: http://llvm.org/viewvc/llvm-project?rev=363337&view=rev Log: PR23833, DR2140: an lvalue-to-rvalue conversion on a glvalue of type nullptr_t does not access memory. We now reuse CK_NullToPointer to represent a conversion from

[PATCH] D61750: [Targets] Move soft-float-abi filtering to `initFeatureMap`

george.burgess.iv added a comment. ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61750/new/ https://reviews.llvm.org/D61750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D63012: Use fully qualified name when printing S_CONSTANT records

This revision was automatically updated to reflect the committed changes. Closed by commit rL363335: Use fully qualified name when printing S_CONSTANT records (authored by akhuang, committed by ). Changed prior to commit: https://reviews.llvm.org/D63012?vs=204137&id=204649#toc Repository: rL

r363335 - Use fully qualified name when printing S_CONSTANT records

Author: akhuang Date: Thu Jun 13 15:53:43 2019 New Revision: 363335 URL: http://llvm.org/viewvc/llvm-project?rev=363335&view=rev Log: Use fully qualified name when printing S_CONSTANT records Summary: Before it was using the fully qualified name only for static data members. Now it does for all v

[PATCH] D63260: [Attr] Support _attribute__ ((fallthrough))

xbolva00 updated this revision to Diff 204646. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63260/new/ https://reviews.llvm.org/D63260 Files: include/clang/Basic/Attr.td lib/Sema/AnalysisBasedWarnings.cpp test/Sema/fallthrough-attr.c test/SemaCXX/switch-implicit-fallthrough.cpp

[PATCH] D63260: [Attr] Support _attribute__ ((fallthrough))

xbolva00 updated this revision to Diff 204644. xbolva00 added a comment. fixed testcase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63260/new/ https://reviews.llvm.org/D63260 Files: include/clang/Basic/Attr.td lib/Sema/AnalysisBasedWarnings.cpp test/SemaCXX/switch-implicit-fall

[PATCH] D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

rjmccall added a comment. In D62825#1542639 , @rsmith wrote: > In D62825#1542597 , @rjmccall wrote: > > > In D62825#1542374 , @rsmith wrote: > > > > > In D62825#1542309

[PATCH] D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

rsmith added a comment. In D62825#1542597 , @rjmccall wrote: > In D62825#1542374 , @rsmith wrote: > > > In D62825#1542309 , @rjmccall > > wrote: > > > > > In D62825#1542301

[PATCH] D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

rsmith added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:5360 + // FIXME: Its possible under the C++ standard for 'char' to not be 8 bits, but + // we don't support a host or target where that is the case. Still, we should + // use a more generic type in case

[PATCH] D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

rjmccall added a comment. In D62825#1542374 , @rsmith wrote: > In D62825#1542309 , @rjmccall wrote: > > > In D62825#1542301 , @rsmith wrote: > > > > > In D62825#1542247

[PATCH] D63260: [Attr] Support _attribute__ ((fallthrough))

nickdesaulniers added inline comments. Comment at: test/Sema/fallthrough-attr.c:48 + return n; +} Seems like lines 24-48 were an accidental copy+paste? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63260/new/ https://reviews.llvm.org/D63260 ___

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclarationsOnePerLine

MyDeveloperDay added inline comments. Comment at: lib/Format/FormatToken.h:524 +T = T->getPreviousNonComment(); +return (T->Tok.is(tok::comma) && Tok.is(tok::identifier) && +T->Next->Tok.is(tok::colon)); do you think you might need (T && T->T

[PATCH] D63299: [Clang] Parse GNU fallthrough attributes

xbolva00 added a comment. As we see. this is not good place to parse __attribute__((fallthough), which blocks D63260 . Maybe @aaron.ballman could help us since he knows this code better.. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D63299: [Clang] Parse GNU fallthrough attributes

xbolva00 created this revision. xbolva00 added reviewers: aaron.ballman, rsmith, efriedma, nickdesaulniers. Herald added a project: clang. Herald added a subscriber: cfe-commits. Please https://reviews.llvm.org/D63260 Repository: rC Clang https://reviews.llvm.org/D63299 Files: lib/Parse/Pa

r363328 - [Remarks] Refactor optimization remarks setup

Author: thegameg Date: Thu Jun 13 14:46:57 2019 New Revision: 363328 URL: http://llvm.org/viewvc/llvm-project?rev=363328&view=rev Log: [Remarks] Refactor optimization remarks setup * Add a common function to setup opt-remarks * Rename common options to the same names * Add error types to distingu

[PATCH] D63260: [Attr] Support _attribute__ ((fallthrough))

xbolva00 updated this revision to Diff 204630. xbolva00 added a comment. Split. Now patch only adds _attribute__ ((fallthrough)) support. Parsing will be hopefully solved in second patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63260/new/ https://reviews.llvm.org/D63260 Files:

[PATCH] D63260: [Attr] Support _attribute__ ((fallthrough))

xbolva00 updated this revision to Diff 204631. xbolva00 added a comment. Fixed EOF in test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63260/new/ https://reviews.llvm.org/D63260 Files: include/clang/Basic/Attr.td lib/Sema/AnalysisBasedWarnings.cpp test/Sema/fallthrough-at

[PATCH] D59919: [Attributor] Deduce "returned" argument attribute

jdoerfert updated this revision to Diff 204626. jdoerfert added a comment. Simplify the interface Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59919/new/ https://reviews.llvm.org/D59919 Files: clang/test/CodeGenOpenCL/as_type.cl llvm/include/

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass everything to see inlined calls

Charusso updated this revision to Diff 204625. Charusso marked 3 inline comments as done. Charusso added a comment. - Fixed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62926/new/ https://reviews.llvm.org/D62926 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:1927 + case OMPRTL__kmpc_omp_target_task_alloc: { +// Build kmp_task_t *__kmpc_omp_task_alloc(ident_t *, kmp_int32 gtid, +// kmp_int32 flags, size_t sizeof_kmp_task_t, size_t sizeof_shareds, -

[PATCH] D62697: AMDGPU: Disable errno by default

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62697/new/ https://reviews.llvm.org/D62697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D63288: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator.

gribozavr added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.cpp:33 +StringRef Name, ClangTidyContext *Context) +: ClangTidyCheck(Name, Context), Rule(MakeRule(getLangOpts(), Options)) { + assert(llvm::all_of(Rule.Cases, [](co

[PATCH] D63290: Unify DependencyFileGenerator class and DependencyCollector interface

arphaman updated this revision to Diff 204611. arphaman added a comment. Fix the missing word in the comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63290/new/ https://reviews.llvm.org/D63290 Files: clang/include/clang/Frontend/CompilerInstance.h clang/include/clang/Frontend

[PATCH] D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

erik.pilkington added a comment. In D62825#1528329 , @rsmith wrote: > Can we also use the same bit reader/writer implementation to generalize the > current implementation of `__builtin_memcpy` and friends? (I don't think we > can remove the existing impl

[PATCH] D63167: [Clang] Remove obsolete -enable-split-dwarf={single,split}

aaronpuchert added inline comments. Comment at: include/clang/Basic/CodeGenOptions.def:263 -ENUM_CODEGENOPT(SplitDwarfMode, DwarfFissionKind, 2, NoFission) ///< DWARF fission mode to use. +CODEGENOPT(EnableSplitDwarf, 1, 0) ///< Whether to enable split DWARF. ---

[PATCH] D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

erik.pilkington updated this revision to Diff 204609. erik.pilkington marked 46 inline comments as done. erik.pilkington added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62825/new/ https://reviews.llvm.org/D62825 Files: clang/include/clang-c/Ind

[PATCH] D63295: [clang][HeaderSearch] Shorten paths for includes in mainfile's directory

kadircet created this revision. kadircet added a reviewer: gribozavr. Herald added subscribers: cfe-commits, arphaman, jkorous. Herald added a project: clang. Currently HeaderSearch only looks at SearchDir's passed into it, but in addition to those paths headers can be relative to including file's

[PATCH] D63161: Devirtualize destructor of final class.

rsmith added inline comments. Comment at: lib/CodeGen/CGExprCXX.cpp:1871 + CGF.CGM.getLangOpts().AppleKext))) + Dtor = DevirtualizedDtor; +else { `Dtor` could be the destructor for a type derived from `

[PATCH] D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

jfb added a comment. In D62825#1542377 , @rsmith wrote: > (You might argue that it's ridiculous to require that `nullptr_t` have the > same size and alignment as `void*` but not have the same storage > representation as a null `void*`. I'd agree, and I'v

[PATCH] D61697: [lit] Disable test on darwin when building shared libs.

This revision was automatically updated to reflect the committed changes. Closed by commit rL363298: [lit] Disable test on darwin when building shared libs. (authored by dhinton, committed by ). Changed prior to commit: https://reviews.llvm.org/D61697?vs=198720&id=204602#toc Repository: rL L

[PATCH] D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

rsmith added a comment. (You might argue that it's ridiculous to require that `nullptr_t` have the same size and alignment as `void*` but not have the same storage representation as a null `void*`. I'd agree, and I've raised this in committee before, but without success) Repository: rC Clan

r363298 - [lit] Disable test on darwin when building shared libs.

Author: dhinton Date: Thu Jun 13 12:08:49 2019 New Revision: 363298 URL: http://llvm.org/viewvc/llvm-project?rev=363298&view=rev Log: [lit] Disable test on darwin when building shared libs. Summary: This test fails to link shared libraries because tries to run a copied version of clang-check to s

[PATCH] D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

rsmith added a comment. In D62825#1542309 , @rjmccall wrote: > In D62825#1542301 , @rsmith wrote: > > > In D62825#1542247 , @rjmccall > > wrote: > > > > > In what sense is t

[PATCH] D63287: [clang-tidy] Make ClangTidyCheck::OptionsView public.

This revision was automatically updated to reflect the committed changes. Closed by commit rL363296: [clang-tidy] Make ClangTidyCheck::OptionsView public. (authored by ymandel, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:

[clang-tools-extra] r363296 - [clang-tidy] Make ClangTidyCheck::OptionsView public.

Author: ymandel Date: Thu Jun 13 12:05:02 2019 New Revision: 363296 URL: http://llvm.org/viewvc/llvm-project?rev=363296&view=rev Log: [clang-tidy] Make ClangTidyCheck::OptionsView public. Summary: The `OptionsView` class is currently protected. This constraint prevents tidies from passing the Op

[PATCH] D63164: [HIP] Add option to force lambda nameing following ODR in HIP/CUDA.

hliao added a comment. In D63164#1542361 , @rsmith wrote: > I think this is the wrong way to handle this issue. We need to give lambdas a > mangling if they occur in functions for which there can be definitions in > multiple translation units. In regular

[PATCH] D63157: C++ DR712 and others: handle non-odr-use resulting from an lvalue-to-rvalue conversion applied to a member access or similar not-quite-trivial lvalue expression.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL363295: C++ DR712 and others: handle non-odr-use resulting from an lvalue-to-rvalue… (authored by rsmith, committed by ).

r363295 - C++ DR712 and others: handle non-odr-use resulting from an lvalue-to-rvalue conversion applied to a member access or similar not-quite-trivial lvalue expression.

Author: rsmith Date: Thu Jun 13 12:00:16 2019 New Revision: 363295 URL: http://llvm.org/viewvc/llvm-project?rev=363295&view=rev Log: C++ DR712 and others: handle non-odr-use resulting from an lvalue-to-rvalue conversion applied to a member access or similar not-quite-trivial lvalue expression.

[PATCH] D63164: [HIP] Add option to force lambda nameing following ODR in HIP/CUDA.

rsmith added a comment. I think this is the wrong way to handle this issue. We need to give lambdas a mangling if they occur in functions for which there can be definitions in multiple translation units. In regular C++ code, that's inline functions and function template specializations, so that

[PATCH] D63260: [Attr] Support _attribute__ ((fallthrough))

nickdesaulniers added inline comments. Comment at: test/Sema/address_spaces.c:12 { - _AS2 *x;// expected-warning {{type specifier missing, defaults to 'int'}} + _AS2 *x;// expected-error {{use of undeclared identifier 'x'}} _AS1 float * _AS2 *B; efriedma wr

[PATCH] D63260: [Attr] Support _attribute__ ((fallthrough))

efriedma added inline comments. Comment at: test/Sema/address_spaces.c:12 { - _AS2 *x;// expected-warning {{type specifier missing, defaults to 'int'}} + _AS2 *x;// expected-error {{use of undeclared identifier 'x'}} _AS1 float * _AS2 *B; xbolva00 wrote: >

[PATCH] D63260: [Attr] Support _attribute__ ((fallthrough))

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: lib/Sema/AnalysisBasedWarnings.cpp:1279 continue; - if (S.getLangOpts().CPlusPlus11) { + if (S.getLangOpts().CPlusPlus11 || S.getLangOpts().C99) { const Stmt *Term =

[PATCH] D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

rjmccall added a comment. In D62825#1542301 , @rsmith wrote: > In D62825#1542247 , @rjmccall wrote: > > > In what sense is the bit-pattern of a null pointer indeterminate? > > > The problem is not null pointers, it'

[PATCH] D63260: [Attr] Support _attribute__ ((fallthrough))

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: test/Sema/address_spaces.c:12 { - _AS2 *x;// expected-warning {{type specifier missing, defaults to 'int'}} + _AS2 *x;// expected-error {{use of undeclared identifier 'x'}} _AS1 float * _

[PATCH] D63157: C++ DR712 and others: handle non-odr-use resulting from an lvalue-to-rvalue conversion applied to a member access or similar not-quite-trivial lvalue expression.

rjmccall added a comment. Minor comment request, then LGTM. Comment at: lib/CodeGen/CGDecl.cpp:1102 + // Form a simple per-variable LRU cache of these values in case we find we + // want to reuse them. + llvm::GlobalVariable *&CacheEntry = InitializerConstants[&D]; -

[PATCH] D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

rsmith added a comment. In D62825#1542247 , @rjmccall wrote: > In what sense is the bit-pattern of a null pointer indeterminate? The problem is not null pointers, it's `nullptr_t`, which is required to have the same size and alignment as `void*` but whi

[PATCH] D63290: Unify DependencyFileGenerator class and DependencyCollector interface

arphaman created this revision. arphaman added reviewers: Bigcheese, vsapsai, bruno, aganea. Herald added subscribers: dexonsmith, jkorous. Herald added a project: clang. This NFCI patch makes DependencyFileGenerator a DependencyCollector as it was intended when DependencyCollector was introduced

[PATCH] D63260: [Attr] Support _attribute__ ((fallthrough))

nickdesaulniers added inline comments. Comment at: test/Sema/address_spaces.c:12 { - _AS2 *x;// expected-warning {{type specifier missing, defaults to 'int'}} + _AS2 *x;// expected-error {{use of undeclared identifier 'x'}} _AS1 float * _AS2 *B; efriedma wr

[PATCH] D63157: C++ DR712 and others: handle non-odr-use resulting from an lvalue-to-rvalue conversion applied to a member access or similar not-quite-trivial lvalue expression.

rsmith added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:1429 +/// for instance if a block or lambda or a member of a local class uses a +/// const int variable or constexpr variable from an enclosing function. CodeGenFunction::ConstantEmission rjmccall

[PATCH] D63260: [Attr] Support _attribute__ ((fallthrough))

efriedma added inline comments. Comment at: test/Sema/address_spaces.c:12 { - _AS2 *x;// expected-warning {{type specifier missing, defaults to 'int'}} + _AS2 *x;// expected-error {{use of undeclared identifier 'x'}} _AS1 float * _AS2 *B; xbolva00 wrote: >

[PATCH] D63260: [Attr] Support _attribute__ ((fallthrough))

nickdesaulniers added a comment. > but as part of this commit but *not* as part of this commit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63260/new/ https://reviews.llvm.org/D63260 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63170: [clang][NewPM] Fix broken -O0 test from missing assumptions

This revision was automatically updated to reflect the committed changes. Closed by commit rL363287: [clang][NewPM] Fix broken -O0 test from missing assumptions (authored by leonardchan, committed by ). Changed prior to commit: https://reviews.llvm.org/D63170?vs=204174&id=204590#toc Repository

[PATCH] D63157: C++ DR712 and others: handle non-odr-use resulting from an lvalue-to-rvalue conversion applied to a member access or similar not-quite-trivial lvalue expression.

rsmith updated this revision to Diff 204589. rsmith marked 2 inline comments as done. rsmith added a comment. Updated comment, fixed typo, added use of `[[clang::lifetimebound]]`. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63157/new/ https://reviews.llvm.org/D

[PATCH] D63260: [Attr] Support _attribute__ ((fallthrough))

nickdesaulniers added inline comments. Comment at: lib/Sema/AnalysisBasedWarnings.cpp:1279 continue; - if (S.getLangOpts().CPlusPlus11) { + if (S.getLangOpts().CPlusPlus11 || S.getLangOpts().C99) { const Stmt *Term = B->getTerminatorStmt(); ---

r363288 - PR42182: Allow thread-local to use __cxa_thread_atexit when

Author: erichkeane Date: Thu Jun 13 11:20:19 2019 New Revision: 363288 URL: http://llvm.org/viewvc/llvm-project?rev=363288&view=rev Log: PR42182: Allow thread-local to use __cxa_thread_atexit when -fno-use-cxx-atexit is used This matches the GCC behavior, __cxa_thread_atexit should be permissible

r363287 - [clang][NewPM] Fix broken -O0 test from missing assumptions

Author: leonardchan Date: Thu Jun 13 11:18:40 2019 New Revision: 363287 URL: http://llvm.org/viewvc/llvm-project?rev=363287&view=rev Log: [clang][NewPM] Fix broken -O0 test from missing assumptions Add an AssumptionCache callback to the InlineFuntionInfo used for the AlwaysInlinerPass to match co

[PATCH] D63283: PR42182: Allow thread-local to use __cxa_thread_atexit when -fno-use-cxx-atexit is used

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63283/new/ https://reviews.llvm.org/D63283 ___ cfe-commits mailing list cfe-co

[PATCH] D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

rjmccall added a comment. In what sense is the bit-pattern of a null pointer indeterminate? It's implementation-specified, but the compiler is certainly required to be able to produce that value during the constant initialization phase. If the language committee wants to make this non-constan

[PATCH] D63283: PR42182: Allow thread-local to use __cxa_thread_atexit when -fno-use-cxx-atexit is used

erichkeane updated this revision to Diff 204587. erichkeane marked an inline comment as done. erichkeane added a comment. Update the comment as requested by @rjmccall CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63283/new/ https://reviews.llvm.org/D63283 Files: clang/lib/CodeGen/Ita

[PATCH] D62914: [Sema] Fix diagnostic for addr spaces in reference binding

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. I like this wording of the diagnostic better in general. Could you make the diagnostic change in a separate patch and then fix the address-space problem? Both patches are approved. CHA

[PATCH] D63288: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator.

ymandel marked an inline comment as done. ymandel added a comment. Thanks for the review! Comment at: clang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.cpp:33 +StringRef Name, ClangTidyContext *Context) +: ClangTidyCheck(Name, Context), Rule(MakeRule(getLangO

[PATCH] D63283: PR42182: Allow thread-local to use __cxa_thread_atexit when -fno-use-cxx-atexit is used

rjmccall added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2370 + if (CGM.getCodeGenOpts().CXAAtExit || D.getTLSKind()) return emitGlobalDtorWithCXAAtExit(CGF, dtor, addr, D.getTLSKind()); It's fine to match the GCC behavior, and it's

[PATCH] D62944: [Driver] Fix wchar_t and wint_t definitions on Solaris

efriedma added a comment. For format-strings.c, I'm not really happy suggesting `#if defined(__sun) && !defined(__LP64__)`, but I don't think the alternative is better. We could restrict the test so it doesn't run using a Solaris target triple, but we actually want coverage here: the differenc

[PATCH] D63260: [Attr] Support _attribute__ ((fallthrough))

xbolva00 marked 2 inline comments as done. xbolva00 added inline comments. Comment at: test/Sema/address_spaces.c:12 { - _AS2 *x;// expected-warning {{type specifier missing, defaults to 'int'}} + _AS2 *x;// expected-error {{use of undeclared identifier 'x'}} _AS1 float * _

[PATCH] D63260: [Attr] Support _attribute__ ((fallthrough))

xbolva00 updated this revision to Diff 204584. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63260/new/ https://reviews.llvm.org/D63260 Files: include/clang/Basic/Attr.td lib/Parse/ParseStmt.cpp lib/Sema/AnalysisBasedWarnings.cpp test/Sema/address_spaces.c test/Sema/block-liter

[PATCH] D63260: [Attr] Support _attribute__ ((fallthrough))

xbolva00 updated this revision to Diff 204583. xbolva00 added a comment. Addressed some review notes. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63260/new/ https://reviews.llvm.org/D63260 Files: include/clang/Basic/Attr.td lib/Parse/ParseStmt.cpp lib/Sema/AnalysisBased

[PATCH] D63270: [clangd] Add include-mapping for C symbols.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/include-mapping/cppreference_parser.py:1 -#!/usr/bin/env python -#===- gen_std.py - --*- python -*--===# could we add a similar License and header comme

[PATCH] D63288: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator.

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.cpp:33 +StringRef Name, ClangTidyContext *Context) +: ClangTidyCheck(Name, Context)

[PATCH] D63260: [Attr] Support _attribute__ ((fallthrough))

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: test/Sema/block-literal.c:44 takeblock(^{ x = 4; }); // expected-error {{variable is not assignable (missing __block type specifier)}} - __block y = 7;// expected-warning {{type speci

[PATCH] D63260: [Attr] Support _attribute__ ((fallthrough))

xbolva00 added a comment. __block y = 7; if (Tok.is(tok::kw___attribute)) printf("__attr\n"); Output: __attr Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63260/new/ https://reviews.llvm.org/D63260 ___ cfe-commi

[PATCH] D63288: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a subscriber: xazax.hun. Herald added a project: clang. ymandel added a parent revision: D63287: [clang-tidy] Make ClangTidyCheck::OptionsView public.. Tidy check behavior often depends on language and/or clang-tidy

[PATCH] D63168: [clang][NewPM] Fix split debug test

This revision was automatically updated to reflect the committed changes. Closed by commit rL363281: [clang][NewPM] Fix split debug test (authored by leonardchan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

r363281 - [clang][NewPM] Fix split debug test

Author: leonardchan Date: Thu Jun 13 10:40:03 2019 New Revision: 363281 URL: http://llvm.org/viewvc/llvm-project?rev=363281&view=rev Log: [clang][NewPM] Fix split debug test This contains the part of D62225 which fixes CodeGen/split-debug-single-file.c by not placing .dwo sections when using -ena

  1   2   >