xbolva00 marked an inline comment as done.
xbolva00 added inline comments.
================
Comment at: test/Sema/block-literal.c:44
takeblock(^{ x = 4; }); // expected-error {{variable is not assignable
(missing __block type specifier)}}
- __block y = 7; // expected-warning {{type specifier missing, defaults to
'int'}}
- takeblock(^{ y = 8; });
+ __block y = 7; // expected-error {{use of undeclared identifier 'y'}}
+ takeblock(^{ y = 8; }); // expected-error {{use of undeclared identifier
'y'}}
----------------
xbolva00 wrote:
> xbolva00 wrote:
> > nickdesaulniers wrote:
> > > xbolva00 wrote:
> > > > I tried look at this, but I have no idea how my change to parse GNU
> > > > affects __block.
> > > If you remove your change to `lib/Parse/ParseStmt.cpp`, does this test
> > > still fail in this way? Did you test this on an assertion enabled build
> > > (`-DLLVM_ENABLE_ASSERTIONS=ON`)? (I would have expected the assertion I
> > > commented on above to fail.)
> > Yes, added line "MaybeParseGNUAttributes(Attrs);" cause this changes in
> > block-literal.c and address_spaces.c.
> Yes, LLVM_ENABLE_ASSERTIONS is ticked in cmake-gui.. I have no assert failure
> in that place..
See my comment.. if __block is internally as "kw _ _ attribute", now I know why
this was changed.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63260/new/
https://reviews.llvm.org/D63260
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
