[PATCH] D60179: [clangd] Return clangd::TextEdit in ClangdServer::rename. NFC

ilya-biryukov created this revision. ilya-biryukov added reviewers: hokein, ioeric, sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Instead of tooling::Replacement. To avoid the need to have contents of the file at the caller site. This als

[PATCH] D58121: [analyzer][WIP] Attempt to fix traversing bindings of non-base regions in ClusterAnalysis

xazax.hun added a comment. In D58121#1452483 , @NoQ wrote: > Mmm. I'm also pretty pinned down (it's seasonal), so i'm thinking of > temporarily reverting :( until one of us gets to fixing the accidental effect > on escaping, 'cause it just keeps biting u

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough updated this revision to Diff 193421. Dosi-Dough marked 2 inline comments as done. Dosi-Dough added a comment. added minor style changes and removed unnecessary inline comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ htt

[PATCH] D58121: [analyzer][WIP] Attempt to fix traversing bindings of non-base regions in ClusterAnalysis

NoQ added a comment. Mmm. I'm also pretty pinned down (it's seasonal), so i'm thinking of temporarily reverting :( until one of us gets to fixing the accidental effect on escaping, 'cause it just keeps biting us. Like, i wholeheartedly appreciate the work and i have already noticed a few times

[PATCH] D60110: [analyzer] When failing to evaluate a __builtin_constant_p, presume it's false.

This revision was automatically updated to reflect the committed changes. Closed by commit rL357557: [analyzer] When failing to evaluate a __builtin_constant_p, presume it's false. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chan

r357557 - [analyzer] When failing to evaluate a __builtin_constant_p, presume it's false.

Author: dergachev Date: Tue Apr 2 18:53:40 2019 New Revision: 357557 URL: http://llvm.org/viewvc/llvm-project?rev=357557&view=rev Log: [analyzer] When failing to evaluate a __builtin_constant_p, presume it's false. __builtin_constant_p(x) is a compiler builtin that evaluates to 1 when its argume

[PATCH] D59797: [COFF] Reduce the size of Chunk and SectionChunk, NFC

MaskRay added a comment. > this reduces the sum of heap allocations ... These numbers exclude memory > mapped files May I ask how you counted the memory usage minus memory mapped files? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59797/new/ https://reviews.llv

[PATCH] D56924: Special case ObjCPropertyDecl for printing

arphaman added a comment. Sorry, I missed the pings. It LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D59628: Add support for __attribute__((objc_class_stub))

slavapestov updated this revision to Diff 193407. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59628/new/ https://reviews.llvm.org/D59628 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Basic/ObjCRuntime

r357552 - [WebAssembly] Add Emscripten OS definition + small_printf

Author: azakai Date: Tue Apr 2 18:08:35 2019 New Revision: 357552 URL: http://llvm.org/viewvc/llvm-project?rev=357552&view=rev Log: [WebAssembly] Add Emscripten OS definition + small_printf The Emscripten OS provides a definition of __EMSCRIPTEN__, and also that it supports iprintf optimizations

[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

NoQ added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:2208 +} + CFGBlock *CFGBuilder::VisitStmt(Stmt *S, AddStmtChoice asc) { Tyker wrote: > NoQ wrote: > > Tyker wrote: > > > NoQ wrote: > > > > Tyker wrote: > > > > > riccibruno wrote: > > > > > > I d

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D60104: [libcxx] [test] Use ptrdiff_t rather than int in splice_after_range.pass.cpp to avoid narrowing from pointer subtraction to int warnings.

BillyONeal closed this revision. BillyONeal added a comment. Committed r357546 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60104/new/ https://reviews.llvm.org/D60104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D60023: [libcxx] [test] Fix test bugs in string.cons/copy_alloc.pass.cpp.

BillyONeal updated this revision to Diff 193393. BillyONeal retitled this revision from "[libcxx] [test] Fix inability to rebind poca_alloc in string.cons/copy_alloc.pass.cpp." to "[libcxx] [test] Fix test bugs in string.cons/copy_alloc.pass.cpp.". BillyONeal edited the summary of this revision.

[PATCH] D60023: [libcxx] [test] Fix test bugs in string.cons/copy_alloc.pass.cpp.

BillyONeal closed this revision. BillyONeal added a comment. Committed r357545 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60023/new/ https://reviews.llvm.org/D60023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D60018: [codeview] Remove Type member from CVRecord

aganea accepted this revision. aganea added a comment. This revision is now accepted and ready to land. LGTM. With a few minor comments: Comment at: llvm/include/llvm/DebugInfo/CodeView/TypeDeserializer.h:122 ~FieldListDeserializer() override { -CVType FieldList; -Fi

[PATCH] D60023: [libcxx] [test] Fix inability to rebind poca_alloc in string.cons/copy_alloc.pass.cpp.

BillyONeal added a comment. Tim Song suggests that http://eel.is/c++draft/string.require#2 indicates that basic_string actually does need to provide the strong guarantee here. While I think that wording is a mess I think I'll fix our basic_string to do that instead of that part of this change.

[PATCH] D60018: [codeview] Remove Type member from CVRecord

rnk added inline comments. Comment at: llvm/include/llvm/DebugInfo/CodeView/CVRecord.h:29 +/// Carrying the size separately instead of trusting the size stored in the +/// record prefix provides some extra safety and flexibility. template class CVRecord { agane

[PATCH] D60018: [codeview] Remove Type member from CVRecord

rnk updated this revision to Diff 193390. rnk marked an inline comment as done. rnk added a comment. - one more change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60018/new/ https://reviews.llvm.org/D60018 Files: lld/COFF/PDB.cpp lldb/source

[PATCH] D60018: [codeview] Remove Type member from CVRecord

rnk updated this revision to Diff 193388. rnk marked 4 inline comments as done. rnk added a comment. - Add RecordPrefix ctor, remove all dummy RecordLen assignments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60018/new/ https://reviews.llvm.org/D

[PATCH] D59673: [Driver] Allow setting the DWO name DWARF attribute separately

dblaikie added a comment. In D59673#143 , @aaronpuchert wrote: > In D59673#1438716 , @dblaikie wrote: > > > Use llvm-dwarfdump rather than llvm-objdump to dump the contents of the > > debug_info section and te

[PATCH] D60163: [ThinLTO] Handle -fno-builtin* options for distributed backends

tejohnson created this revision. tejohnson added a reviewer: pcc. Herald added subscribers: kristina, dexonsmith, steven_wu, eraman, inglorion, mehdi_amini. Herald added a project: clang. Without this patch, we were ignoring the -fno-builtin* options for clang invocations performing ThinLTO distr

[PATCH] D60161: Expose non-trivial struct helpers for Swift.

allevato created this revision. allevato added a reviewer: rjmccall. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. This change exposes the helper functions that generate ctors/dtors for non-trivial structs so that they can be called from the Swift compiler (see h

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

hintonda updated this revision to Diff 193379. hintonda added a comment. - Remove spaces in docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59802/new/ https://reviews.llvm.org/D59802 Files: clang-tools-extra/clang-tidy/llvm/CMakeLists.txt

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/llvm-prefer-isa-or-dyn-cast-in-conditionals.rst:6 + + Looks at conditionals and finds cases of ``cast<>``, which will + assert rather than return a null pointer, and ``dyn_cast<>`` where

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

hintonda updated this revision to Diff 193376. hintonda added a comment. - Renamed and updated docs. - Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59802/new/ https://reviews.llvm.org/D59802 Files: clang-tools-extra/clang-tidy/l

[PATCH] D49863: [istream] Fix error flags and exceptions propagated from input stream operations

ldionne reopened this revision. ldionne added a comment. This revision is now accepted and ready to land. In D49863#1452126 , @aprantl wrote: > It looks like this may have broken some LLDB data formatters: > http://green.lab.llvm.org/green/view/LLDB/job/l

[PATCH] D59797: [COFF] Reduce the size of Chunk and SectionChunk, NFC

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL357535: [COFF] Reduce the size of Chunk and SectionChunk, NFC (authored by rnk, committed by ). Changed prior to commit:

[PATCH] D49863: [istream] Fix error flags and exceptions propagated from input stream operations

aprantl added a comment. It looks like this may have broken some LLDB data formatters: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/22934/ http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/22934/testReport/junit/lldb-Suite/functionalities_data-formatter_data-formatter-stl_libcx

[PATCH] D59797: [COFF] Reduce the size of Chunk and SectionChunk, NFC

rnk updated this revision to Diff 193371. rnk added a comment. - last update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59797/new/ https://reviews.llvm.org/D59797 Files: lld/COFF/Chunks.cpp lld/COFF/Chunks.h lld/COFF/ICF.cpp lld/COFF/Ma

r357532 - [HIP-Clang] Fat binary should not be produced for non GPU code

Author: aaronenyeshi Date: Tue Apr 2 14:54:41 2019 New Revision: 357532 URL: http://llvm.org/viewvc/llvm-project?rev=357532&view=rev Log: [HIP-Clang] Fat binary should not be produced for non GPU code clang-format the changes to CUDA and HIP fat binary. Reviewers: yaxunl, tra Differential Revi

[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

tra added a comment. In D60141#1452019 , @ashi1 wrote: > Hi Artem, I had just committed the change. IS this change OK or should I > revert it? The `if` condition could use some clang-formatting, but other than that the patch still looks OK to me. Rep

[PATCH] D60112: [analyzer] Treat write into a top-level parameter variable with destructor as escape.

NoQ marked an inline comment as done. NoQ added a comment. In D60112#1451198 , @Szelethus wrote: > Woah, the code looks amazing, cheers on the refactoring! I'll be honest, I'm > struggling a bit with the sentence "we're now in the top frame". In order, I

[PATCH] D60151: [clang-tidy] Add using SmallSet to LLVM.h to fix bug in typedef in llvm checkers.

hintonda created this revision. hintonda added a reviewer: alexfh. Herald added a subscriber: xazax.hun. Herald added a project: clang. Fixed ambiguous namespace bug in llvm checkers that add the llvm namespace to clang::tidy, by adding using declaration for SmallSet. Repository: rG LLVM Githu

[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

ashi1 added a comment. Hi Artem, I had just committed the change. IS this change OK or should I revert it? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60141/new/ https://reviews.llvm.org/D60141 ___ cfe-commits mail

[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

This revision was automatically updated to reflect the committed changes. Closed by commit rL357526: [HIP-Clang] Fat binary should not be produced for non GPU code 2 (authored by aaronenyeshi, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r357526 - [HIP-Clang] Fat binary should not be produced for non GPU code 2

Author: aaronenyeshi Date: Tue Apr 2 13:49:41 2019 New Revision: 357526 URL: http://llvm.org/viewvc/llvm-project?rev=357526&view=rev Log: [HIP-Clang] Fat binary should not be produced for non GPU code 2 Also for CUDA, we need to disable producing these fat binary functions when there is no GPU

[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

tra accepted this revision. tra added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:475-476 return nullptr; + if (IsHIP && EmittedKernels.empty() && DeviceVars.empty()) +return nullptr; // void __{cuda|hip}_register_globals(void* handle); yax

[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

yaxunl added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:475-476 return nullptr; + if (IsHIP && EmittedKernels.empty() && DeviceVars.empty()) +return nullptr; // void __{cuda|hip}_register_globals(void* handle); tra wrote: > I think this wo

[PATCH] D49863: [istream] Fix error flags and exceptions propagated from input stream operations

mclow.lists accepted this revision. mclow.lists added a comment. I'm OK with this. I think, strictly speaking, that libc++ is following the standard, and everyone else is not - but what everyone else is doing makes sense. Comment at: libcxx/include/istream:365 __input_arith

[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

tra added a comment. General nit: please use diffs with very large context when you submit patches with Phabricator. https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Comment at: lib/CodeGen/CGCUDANV.cpp:475-476 return nullptr; + if (IsHIP

r357520 - [HIP-Clang] Fat binary should not be produced for non GPU code

Author: aaronenyeshi Date: Tue Apr 2 13:10:18 2019 New Revision: 357520 URL: http://llvm.org/viewvc/llvm-project?rev=357520&view=rev Log: [HIP-Clang] Fat binary should not be produced for non GPU code Skip producing the fat binary functions for HIP when no device code is present. Reviewers: yax

[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60141/new/ https://reviews.llvm.org/D60141 ___ cfe-c

[PATCH] D60101: [Sema] Fix a use-after-deallocate of a ParsedAttr

This revision was automatically updated to reflect the committed changes. Closed by commit rC357516: [Sema] Fix a use-after-deallocate of a ParsedAttr (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D60101?vs=193185&id=193348#toc Repository: rC Clang CH

[PATCH] D60099: [CodeGen] Fix a regression by emitting lambda expressions in EmitLValue

This revision was automatically updated to reflect the committed changes. Closed by commit rC357515: [CodeGen] Fix a regression by emitting lambda expressions in EmitLValue (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D60099?vs=193179&id=193347#toc Repo

r357515 - [CodeGen] Fix a regression by emitting lambda expressions in EmitLValue

Author: epilk Date: Tue Apr 2 12:48:07 2019 New Revision: 357515 URL: http://llvm.org/viewvc/llvm-project?rev=357515&view=rev Log: [CodeGen] Fix a regression by emitting lambda expressions in EmitLValue This ability was removed in r351487, but it's needed when a lambda appears as an OpaqueValueE

r357516 - [Sema] Fix a use-after-deallocate of a ParsedAttr

Author: epilk Date: Tue Apr 2 12:48:11 2019 New Revision: 357516 URL: http://llvm.org/viewvc/llvm-project?rev=357516&view=rev Log: [Sema] Fix a use-after-deallocate of a ParsedAttr moveAttrFromListToList only makes sense when moving an attribute to a list with a pool that's either equivalent, or

r357514 - [OPENMP]Add codegen for private vars with allocate clause.

Author: abataev Date: Tue Apr 2 12:44:46 2019 New Revision: 357514 URL: http://llvm.org/viewvc/llvm-project?rev=357514&view=rev Log: [OPENMP]Add codegen for private vars with allocate clause. Added codegen/test for the privatized variables with the allocate clause. Modified: cfe/trunk/lib/C

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 🔍

stephanemoore added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/SuperSelfCheck.cpp:112 + << Message->getMethodDecl() + << FixItHint::CreateReplacement(Message->getSourceRange(), + StringRef("[super init]")); --

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 🔍

stephanemoore updated this revision to Diff 193340. stephanemoore marked an inline comment as done. stephanemoore added a comment. Add a test case where a macro emits just `self` in the message expression. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D56924: Special case ObjCPropertyDecl for printing

dgoldman added a comment. Herald added a subscriber: dexonsmith. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D59797: [COFF] Reorder fields in Chunk and SectionChunk to reduce their size

rnk added a comment. I think I've addressed all the comments, and I know that @ruiu is currently travelling or recovering from travel to Japan, so I'll go ahead and land this. Feel free to provide post-commit feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D60139: [clang-tidy] Add misc-placement-new-target-size check

Eugene.Zelenko added inline comments. Comment at: clang-tidy/misc/PlacementNewTargetSizeCheck.cpp:10 +#include + +#include "PlacementNewTargetSizeCheck.h" Unnecessary empty line. Please run Clang-format after fixing. Comment at: clang-tidy/mis

r357506 - [driver][mips] Check both `gnuabi64` and `gnu` suffixes in `getMultiarchTriple`

Author: atanasyan Date: Tue Apr 2 11:03:31 2019 New Revision: 357506 URL: http://llvm.org/viewvc/llvm-project?rev=357506&view=rev Log: [driver][mips] Check both `gnuabi64` and `gnu` suffixes in `getMultiarchTriple` In case of N64 ABI toolchain paths migth have `mips-linux-gnuabi64` or `mips-linu

r357505 - [driver] clang-format. Fix indentation, split long lines. NFC

Author: atanasyan Date: Tue Apr 2 11:03:15 2019 New Revision: 357505 URL: http://llvm.org/viewvc/llvm-project?rev=357505&view=rev Log: [driver] clang-format. Fix indentation, split long lines. NFC Modified: cfe/trunk/lib/Driver/Driver.cpp cfe/trunk/lib/Driver/ToolChains/Gnu.cpp cfe/t

[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

ashi1 created this revision. ashi1 added a reviewer: yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. Do not produce Fat binary functions for HIP when no device code is present. Repository: rC Clang https://reviews.llvm.org/D60141 Files: lib/CodeGen/CGCUDANV.c

Re: Default -fomit-frame-pointer for PowerPC

On 4/2/19 12:31 PM, Roman Lebedev via cfe-commits wrote: > Best to submit patches to phabricator https://reviews.llvm.org/ Please follow the instructions here: http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface - This will make it much easier for us to track this. Th

[PATCH] D60108: [os_log] Mark os_log_helper `nounwind`

This revision was automatically updated to reflect the committed changes. Closed by commit rC357501: [os_log] Mark os_log_helper `nounwind` (authored by vedantk, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D60108?vs=193217&id=193322#toc Repo

r357501 - [os_log] Mark os_log_helper `nounwind`

Author: vedantk Date: Tue Apr 2 10:42:38 2019 New Revision: 357501 URL: http://llvm.org/viewvc/llvm-project?rev=357501&view=rev Log: [os_log] Mark os_log_helper `nounwind` Allow the optimizer to remove unnecessary EH cleanups surrounding calls to os_log_helper, to save some code size. As a foll

Re: Default -fomit-frame-pointer for PowerPC

Best to submit patches to phabricator https://reviews.llvm.org/ On Tue, Apr 2, 2019 at 8:30 PM George Koehler via cfe-commits wrote: > > Hello cfe-commits, > > The attached patch is for clang to use -fomit-frame-pointer by default > for all PowerPC targets when optimizing code. Right now, clang

Default -fomit-frame-pointer for PowerPC

Hello cfe-commits, The attached patch is for clang to use -fomit-frame-pointer by default for all PowerPC targets when optimizing code. Right now, clang uses -fomit-frame-pointer for PowerPC Linux and NetBSD but not for other targets. I have been running `clang -target powerpc-openbsd`. The pat

[PATCH] D60108: [os_log] Mark os_log_helper `nounwind`

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60108/new/ https://reviews.llvm.org/D60108 ___ cfe-commits mailing list c

[PATCH] D60139: Add clang-tidy/checks/misc-placement-new-target-size check

DennisL created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Finds placement-new calls where the size of the pointee type of the placement parameter is smaller than the size of the constructed type and the pointer is implicitly cast to ``void *``

[PATCH] D55463: Introduce a source minimizer that reduces source to directives that might affect the dependency list for a compilation

dexonsmith added a comment. In D55463#1451166 , @tschuett wrote: > Are you planning to do this recursively? > The minimizer does not help much for the following example, while Sema.h > contains 10,000 lines of useless code. > > #include "clang/Sema/Sem

[PATCH] D60130: gn build: Add build files for clangd xpc framework code

thakis updated this revision to Diff 193313. thakis added a comment. Use {{source_file_part}} in bundle_data where possible. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60130/new/ https://reviews.llvm.org/D60130 Files: clang-tools-extra/clangd/xpc/framework/CMakeLists.txt clang-t

[PATCH] D53633: [AArch64] Implement FP16FML intrinsics

SjoerdMeijer added a comment. FYI: a new ACLE version has been published, please find it here: https://developer.arm.com/architectures/system-architectures/software-standards/acle The "Neon Intrinsics" section contains these new intrinsics. Repository: rL LLVM CHANGES SINCE LAST ACTION

r357488 - [OPENMP]Fix mapping of the pointers captured by reference.

Author: abataev Date: Tue Apr 2 09:03:40 2019 New Revision: 357488 URL: http://llvm.org/viewvc/llvm-project?rev=357488&view=rev Log: [OPENMP]Fix mapping of the pointers captured by reference. If the pointer is captured by reference, it must be mapped as _PTR_AND_OBJ kind of mapping to correctly

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ymandel added a comment. I've removed the dependency on NodeIds given our (off thread) discussions regarding their overall value and appropriateness in clang::tooling vs clang::ast_matchers. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5937

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ymandel updated this revision to Diff 193306. ymandel added a comment. Remove dependency on NodeIds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59376/new/ https://reviews.llvm.org/D59376 Files: clang/include/clang/Tooling/Refactoring/Transfor

[PATCH] D59815: [Driver] Enable -fsanitize-address-globals-dead-stripping by default on PS4.

This revision was automatically updated to reflect the committed changes. Closed by commit rC357480: [Driver] Enable -fsanitize-address-globals-dead-stripping by default on PS4. (authored by pgousseau, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

r357480 - [Driver] Enable -fsanitize-address-globals-dead-stripping by default on PS4.

Author: pgousseau Date: Tue Apr 2 08:20:26 2019 New Revision: 357480 URL: http://llvm.org/viewvc/llvm-project?rev=357480&view=rev Log: [Driver] Enable -fsanitize-address-globals-dead-stripping by default on PS4. Can be safely enabled on PS4. Reviewed By: probinson Differential Revision: https:

[PATCH] D60120: check-clang-tools: Actually build and run XPC test

thakis added a comment. (I noticed this while working on D60130 ) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60120/new/ https://reviews.llvm.org/D60120 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D60099: [CodeGen] Fix a regression by emitting lambda expressions in EmitLValue

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60099/new/ https://reviews.llvm.org/D60099 ___ cfe-commit

[PATCH] D60130: gn build: Add build files for clangd xpc framework code

thakis created this revision. thakis added reviewers: mbonadei, sdefresne. Herald added subscribers: jdoerfert, kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov, mgorny. Herald added a project: LLVM. thakis edited the summary of this revision. This is a bit of a larger change since thi

[PATCH] D60123: [AST] Forbid copy/move of statements/types.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60123/new/ https://reviews.llvm.org/D60123 ___

[PATCH] D60101: [Sema] Fix a use-after-deallocate of a ParsedAttr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor nits. Thanks for this! Comment at: clang/include/clang/Sema/ParsedAttr.h:896 + void takeOneFrom(ParsedAttributes &attrs, ParsedAtt

[PATCH] D60124: gn build: Add build files for non-framework xpc clangd bits

This revision was automatically updated to reflect the committed changes. Closed by commit rL357476: gn build: Add build files for non-framework xpc clangd bits (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D60124?vs=193264&id=193290#toc Repository: rL

[PATCH] D60124: gn build: Add build files for non-framework xpc clangd bits

thakis marked 2 inline comments as done. thakis added inline comments. Comment at: llvm/utils/gn/secondary/clang-tools-extra/clangd/xpc/BUILD.gn:17 + configs += [ "//llvm/utils/gn/build:clang_code" ] + deps = [ +"//clang-tools-extra/clangd", mbonadei wrote:

[PATCH] D60029: Add const children() accessors to all AST nodes.

nicolas updated this revision to Diff 193288. nicolas retitled this revision from "Add const children() accessors to Stmts" to "Add const children() accessors to all AST nodes.". nicolas edited the summary of this revision. nicolas added a comment. Added children() const to all AST nodes. CHANG

[PATCH] D60128: Add const children accessors to all nodes.

nicolas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add const children accessors to all AST nodes where non const accessors exist. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D60128 Files: clang/include/clang/AST/Expr.h c

[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

Tyker updated this revision to Diff 193284. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59467/new/ https://reviews.llvm.org/D59467 Files: clang/include/clang/AST/Stmt.h clang/include/clang/AST/StmtCXX.h clang/include/clang/AST/TextNodeDumper.h clang/include/clang/Basic/Attr.td

[PATCH] D60124: gn build: Add build files for non-framework xpc clangd bits

mbonadei accepted this revision. mbonadei added a comment. This revision is now accepted and ready to land. LGTM, just a couple of comments. Comment at: llvm/utils/gn/secondary/clang-tools-extra/clangd/xpc/BUILD.gn:17 + configs += [ "//llvm/utils/gn/build:clang_code" ] + deps

[PATCH] D59988: [PR41276] Generate address space cast of 'this' for objects attributed by an address space in C++

Anastasia updated this revision to Diff 193281. Anastasia added a comment. - Use `AggValueSlot` in the constructor call generation to store/retrieve address space of 'this'. - Fixed detecting the address space conversion while performing qualification conversion. CHANGES SINCE LAST ACTION ht

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

sammccall added a comment. Not sure what the implications of design changes are, so will defer reviewing details of tokencollector (which generally looks good, but is of course highly coupled to lexer/pp) and range mapping (which I suspect could be simplified, but depends heavily on the model).

[PATCH] D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable

ztamas marked 3 inline comments as done. ztamas added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-too-small-loop-variable.rst:33 + + Upper limit for the magnitue bits of the loop variable. If it's set the check + filters out those catches in

[PATCH] D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready.

ilya-biryukov added a comment. Leaving a few first comments, have to run. Will take another look later, sorry about the delay today (also feel free to add more reviewers in case this is urgent). Comment at: clangd/ClangdServer.cpp:197 return CB(llvm::make_error()); +

[PATCH] D60126: [clangd] Use identifiers in file as completion candidates when build is not ready.

ioeric created this revision. ioeric added a reviewer: sammccall. Herald added subscribers: cfe-commits, jdoerfert, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. o Lex the code to get the identifiers and put them into a "symbol" index. o Adds a new completion

[PATCH] D60123: [AST] Forbid copy/move of statements/types.

riccibruno updated this revision to Diff 193271. riccibruno retitled this revision from "[AST] Forbid copy/move of statements/declarations/types." to "[AST] Forbid copy/move of statements/types.". Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60123/new/ https://r

[PATCH] D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable

ztamas updated this revision to Diff 193277. ztamas added a comment. Fixed typo. Mentioned the default value in release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59870/new/ https://reviews.llvm.org/D59870 Files: clang-tools-extra/clang-tidy/bugprone/TooSmallLoopVariableChe

[PATCH] D60123: [AST] Forbid copy/move of statements/declarations/types.

riccibruno added a comment. In D60123#1451307 , @riccibruno wrote: > In D60123#1451303 , @lebedev.ri > wrote: > > > Probably `Decl` too? > > > Yep. I though it was already done but after checking it seems I remembe

[PATCH] D59932: [clang-tidy] **Prototype**: Add fix description to clang-tidy checks.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.h:109 + /// not supported. + virtual llvm::StringRef fixDescription() { return ""; } + alexfh wrote: > Checks can provide differen

[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

Tyker updated this revision to Diff 193269. Tyker added a comment. fixed the CFG issue is an proper way CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59467/new/ https://reviews.llvm.org/D59467 Files: clang/include/clang/AST/Stmt.h clang/include/clang/AST/StmtCXX.h clang/include/c

[PATCH] D60123: [AST] Forbid copy/move of statements/declarations/types.

riccibruno updated this revision to Diff 193267. riccibruno retitled this revision from "[AST] Forbid copy/move of Stmt." to "[AST] Forbid copy/move of statements/declarations/types.". riccibruno edited the summary of this revision. riccibruno added a reviewer: lebedev.ri. Repository: rC Clang

[PATCH] D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready.

ioeric updated this revision to Diff 193268. ioeric added a comment. - Rebase Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59811/new/ https://reviews.llvm.org/D59811 Files: clangd/ClangdServer.cpp clangd/CodeComplete.h clangd/TUScheduler.cpp

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

sammccall added inline comments. Comment at: clang/include/clang/Tooling/Syntax/TokenBuffer.h:1 +//===- TokenBuffer.h - store tokens of preprocessed files -*- C++ -*-=// +// ilya-biryukov wrote: > sammccall wrote: > > are you sure TokenBuffer is the cent

[PATCH] D60123: [AST] Forbid copy/move of Stmt.

riccibruno added a comment. In D60123#1451303 , @lebedev.ri wrote: > Probably `Decl` too? Yep. I though it was already done but after checking it seems I remembered incorrectly. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D60123: [AST] Forbid copy/move of Stmt.

lebedev.ri added a comment. Probably `Decl` too? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60123/new/ https://reviews.llvm.org/D60123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D60124: gn build: Add build files for non-framework xpc clangd bits

thakis created this revision. thakis added a reviewer: mbonadei. Herald added subscribers: jdoerfert, kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov, mgorny. Herald added a project: LLVM. With this, check-clang-tools unit tests are complete, but the lit tests still don't run the one

[PATCH] D60123: [AST] Forbid copy/move of Stmt.

riccibruno created this revision. riccibruno added a reviewer: aaron.ballman. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. Statements and expressions are not supposed to be moved, and trying to do so is only going to result in tears. Someone tripped on this a few day

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ymandel added a comment. Thank you for the extremely helpful and detailed review!! Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:110 + // constructed with the builder class. + static constexpr char RootId[] = "___root___"; +}; ilya-biryuko

  1   2   >