hokein marked an inline comment as done.
hokein added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.h:109
+ /// not supported.
+ virtual llvm::StringRef fixDescription() { return ""; }
+
----------------
alexfh wrote:
> Checks can provide different fixes with different semantics depending on the
> context. It seems incorrect to assume that there can be one reasonable
> description for all of them.
Yes, as mentioned in the comment, this is the limitation of this approach -- I
assume we don't have a large number of these checks, most checks are providing
a single fix.
Another alternative is to use some heuristic mechanisms to do a translation
from the `Replacement`, like we do in clangd,
https://github.com/llvm-mirror/clang-tools-extra/blob/master/clangd/Diagnostics.cpp#L350.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59932/new/
https://reviews.llvm.org/D59932
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
