tra added a comment.
General nit: please use diffs with very large context when you submit patches
with Phabricator.
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
================
Comment at: lib/CodeGen/CGCUDANV.cpp:475-476
return nullptr;
+ if (IsHIP && EmittedKernels.empty() && DeviceVars.empty())
+ return nullptr;
// void __{cuda|hip}_register_globals(void* handle);
----------------
I think this would make sense for CUDA, too.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60141/new/
https://reviews.llvm.org/D60141
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
