xbolva00 updated this revision to Diff 165204.
xbolva00 added a comment.
Adjusted regexes in two more tests
https://reviews.llvm.org/D51847
Files:
lib/Frontend/DependencyFile.cpp
test/Frontend/dependency-gen-escaping.c
test/Frontend/dependency-gen.c
test/Modules/relative-dep-gen.cpp
In
Author: marshall
Date: Wed Sep 12 19:23:52 2018
New Revision: 342103
URL: http://llvm.org/viewvc/llvm-project?rev=342103&view=rev
Log:
Mark LWG#3102 as complete. No code changes, but I updated a test or two
Modified:
libcxx/trunk/test/std/containers/views/span.iterators/end.pass.cpp
libcx
Author: trong
Date: Wed Sep 12 16:45:04 2018
New Revision: 342100
URL: http://llvm.org/viewvc/llvm-project?rev=342100&view=rev
Log:
[AArch64] Support reserving x1-7 registers.
Summary: Reserving registers x1-7 is used to support CONFIG_ARM64_LSE_ATOMICS
in Linux kernel. This change adds support
rsmith added a comment.
Thanks, some comments but the approach here looks great.
Comment at: include/clang/Basic/DiagnosticLexKinds.td:428-429
+def err_pp_file_not_found_typo_not_fatal
+: Error<"'%0' file not found due to leading or trailing non-alphanumeric "
+
shuaiwang created this revision.
shuaiwang added reviewers: lebedev.ri, JonasToth.
Herald added subscribers: cfe-commits, Szelethus, mikhail.ramalho, a.sidorin,
szepet, xazax.hun.
Herald added a reviewer: george.karpenkov.
We used to treat an `Expr` mutated whenever it's passed as non-const
refer
beanz added a comment.
I agree that changing the naming scheme probably makes sense, but I also think
that you can probably make a fairly well contained change to the LLVM CMake
module that maps components to libnames to special case Polly and make this all
work.
I’d really like to see us avoi
Hello everyone,
Below are some buildbot numbers for the last week of 9/02/2018 - 9/08/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed
Hello everyone,
Below are some buildbot numbers for the week of 8/26/2018 - 9/01/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to r
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342100: [AArch64] Support reserving x1-7 registers.
(authored by trong, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D48581?vs=165132&id=165
erik.pilkington added inline comments.
Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1267-1269
+ // Instantiate the attributes on both the template declaration and the
associated record declaration.
+ SemaRef.InstantiateAttrsForDecl(TemplateArgs, Pattern, Inst, La
Author: rsmith
Date: Wed Sep 12 16:37:58 2018
New Revision: 342098
URL: http://llvm.org/viewvc/llvm-project?rev=342098&view=rev
Log:
Remove dead code made unnecessary by r342018.
Modified:
cfe/trunk/lib/Sema/SemaLookup.cpp
Modified: cfe/trunk/lib/Sema/SemaLookup.cpp
URL:
http://llvm.org/vie
Author: rsmith
Date: Wed Sep 12 16:37:00 2018
New Revision: 342097
URL: http://llvm.org/viewvc/llvm-project?rev=342097&view=rev
Log:
Track definition merging on the canonical declaration even when local
submodule visibility is disabled.
Attempting to pick a specific declaration to make visible wh
DiamondLovesYou added a comment.
In https://reviews.llvm.org/D51986#1232440, @beanz wrote:
> After line 18 in this file you could do something like:
>
> if(WITH_POLLY)
> list(APPEND LLVM_LINK_COMPONENTS Polly)
> endif()
>
>
> Then you can get rid of the `target_link_libraries` call.
It tu
Author: rsmith
Date: Wed Sep 12 16:09:23 2018
New Revision: 342096
URL: http://llvm.org/viewvc/llvm-project?rev=342096&view=rev
Log:
When we leave a module header, make that header visible in its
includer's context, even if its overall module is unavailable.
Added:
cfe/trunk/test/Modules/Inpu
nickdesaulniers accepted this revision.
nickdesaulniers added a comment.
Great work Tri, thank you!
https://reviews.llvm.org/D48581
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
christylee updated this revision to Diff 165162.
christylee edited the summary of this revision.
christylee added a comment.
Emit non-fatal error for typo if file exists.
https://reviews.llvm.org/D51333
Files:
include/clang/Basic/DiagnosticLexKinds.td
lib/Lex/PPDirectives.cpp
Index: lib/L
kadircet added a comment.
Wonder if we can still keep the onCancelRequest registry within
ProtocolHandler's scope, so that it is clear that we implement it. Other than
that seems fascinating, thanks!
Comment at: clangd/JSONRPCDispatcher.cpp:246
+ auto StrID = llvm::to_string
manojgupta added a comment.
In https://reviews.llvm.org/D51713#1232497, @srhines wrote:
> In https://reviews.llvm.org/D51713#1232414, @manojgupta wrote:
>
> > What is the call generated with -pg for AMR32, __gnu_mcount_nc or _mount?
> > __gnu_mcount_nc with "-pg" is known to be broken (
> > ht
sammccall added a comment.
In https://reviews.llvm.org/D51996#1232459, @kadircet wrote:
> Seems a lot cleaner now, thanks!
>
> Do you plan to have other changes like moving control to JSONRPCDispatcher
> and recording timings for analysis on this patch?
https://reviews.llvm.org/D52004 is the J
sammccall updated this revision to Diff 165158.
sammccall marked 2 inline comments as done.
sammccall added a comment.
Address comments by adding comments!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51996
Files:
clangd/Cancellation.cpp
clangd/Cancellation.h
clangd/Cla
srhines added a comment.
In https://reviews.llvm.org/D51713#1232414, @manojgupta wrote:
> What is the call generated with -pg for AMR32, __gnu_mcount_nc or _mount?
> __gnu_mcount_nc with "-pg" is known to be broken (
> https://bugs.llvm.org/show_bug.cgi?id=33845)
I CCed myself on that issue
sammccall created this revision.
sammccall added reviewers: ilya-biryukov, kadircet.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric.
The cancelable scopes are managed by JSONRPCDispatcher so that all Handlers
run in cancelable contexts.
(Previously ClangdServer did this,
kadircet added a comment.
Seems a lot cleaner now, thanks!
Do you plan to have other changes like moving control to JSONRPCDispatcher and
recording timings for analysis on this patch? If not maybe we can add some
fixme's so that we won't forget. Also the somewhat "caching" of cancellation
toke
lebedev.ri added a comment.
In https://reviews.llvm.org/D51949#1232443, @kbobyrev wrote:
> I've been thinking about corner-cases (e.g. don't split `DeclStmt`s within
> init-statement declaration) a while and it seems that there might be many of
> them.
It should at least diagnose these cases.
DiamondLovesYou added a comment.
In https://reviews.llvm.org/D51986#1232440, @beanz wrote:
> After line 18 in this file you could do something like:
>
> if(WITH_POLLY)
> list(APPEND LLVM_LINK_COMPONENTS Polly)
> endif()
>
>
> Then you can get rid of the `target_link_libraries` call.
Ah, i
kbobyrev added a comment.
I've been thinking about corner-cases (e.g. don't split `DeclStmt`s within
init-statement declaration) a while and it seems that there might be many of
them.
I didn't notice https://reviews.llvm.org/D27621 in the first place, it seems to
have a solid test suite (and i
beanz added a comment.
After line 18 in this file you could do something like:
if(WITH_POLLY)
list(APPEND LLVM_LINK_COMPONENTS Polly)
endif()
Then you can get rid of the `target_link_libraries` call.
Repository:
rC Clang
https://reviews.llvm.org/D51986
_
DiamondLovesYou added a comment.
In https://reviews.llvm.org/D51986#1232419, @DiamondLovesYou wrote:
> In https://reviews.llvm.org/D51986#1232320, @beanz wrote:
>
> > I don’t think this is the right solution. The build system knows what
> > components are in the dylib and should remove them from
DiamondLovesYou added a comment.
In https://reviews.llvm.org/D51986#1232320, @beanz wrote:
> I don’t think this is the right solution. The build system knows what
> components are in the dylib and should remove them from the list of libraries
> linked individually. You should be able to make Po
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342078: [Hexagon] Remove fp-contract=fast setting for at O3
(authored by bcahoon, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D4?vs=158029&id=165143#toc
Repository:
rC Clang
Author: bcahoon
Date: Wed Sep 12 13:35:56 2018
New Revision: 342078
URL: http://llvm.org/viewvc/llvm-project?rev=342078&view=rev
Log:
[Hexagon] Remove fp-contract=fast setting for at O3
Change Hexagon so that the setting for fp-contract is the default setting.
This makes Hexagon consistent with a
manojgupta added a comment.
What is the call generated with -pg for AMR32, __gnu_mcount_nc or _mount?
__gnu_mcount_nc with "-pg" is known to be broken (
https://bugs.llvm.org/show_bug.cgi?id=33845)
Repository:
rC Clang
https://reviews.llvm.org/D51713
zhaomo added inline comments.
Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:1767
+ bool InBounds = shouldInterleaveVTables(VTableClass) ? false : true;
return llvm::ConstantExpr::getGetElementPtr(VTable->getValueType(), VTable,
pcc wrote:
> Remind me why
erichkeane created this revision.
erichkeane added a reviewer: rsmith.
Herald added a subscriber: cfe-commits.
In the feedback in https://reviews.llvm.org/D51650
(https://reviews.llvm.org/D51650),
@rsmith points out an implementation detail of CPU-Dispatch
is improperly done. I'd like to fix thi
mclow.lists closed this revision.
mclow.lists added a comment.
landed as revision 342073
https://reviews.llvm.org/D51955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: marshall
Date: Wed Sep 12 12:41:40 2018
New Revision: 342073
URL: http://llvm.org/viewvc/llvm-project?rev=342073&view=rev
Log:
Implement the infrastructure for feature-test macros. Very few actual feature
test macros, though. Reviewed as: https://reviews.llvm.org/D51955
Added:
libcx
trong updated this revision to Diff 165132.
trong added a comment.
Added test cases for combination of -ffixed flags.
https://reviews.llvm.org/D48581
Files:
docs/ClangCommandLineReference.rst
include/clang/Driver/Options.td
lib/Driver/ToolChains/Arch/AArch64.cpp
test/Driver/aarch64-fixe
kristina added a comment.
To elaborate, consider a scenario where a customer wants to build the clang
driver, `diagtool` and just for the sake of the argument `change-namespace`
from extras. Clang tools do not provide nearly the same level of control as
most LLVM tools, so in that scenario, you
cdavis5x added a comment.
Ping.
Repository:
rUNW libunwind
https://reviews.llvm.org/D51657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
beanz added a comment.
I don’t think this is the right solution. The build system knows what
components are in the dylib and should remove them from the list of libraries
linked individually. You should be able to make Polly behave like an LLVM
component, then tools don’t need to care if the dy
sammccall added inline comments.
Comment at: include/clang/Basic/VirtualFileSystem.h:135
+ // For compatibility with old Status-based API. Prefer using Path directly.
+ StringRef getName() const { return Path; }
+};
bkramer wrote:
> sammccall wrote:
> > Backwar
Author: marshall
Date: Wed Sep 12 11:53:02 2018
New Revision: 342071
URL: http://llvm.org/viewvc/llvm-project?rev=342071&view=rev
Log:
Actually mark LWG#2953, don't just say you've done so in r342070
Modified:
libcxx/trunk/www/cxx2a_status.html
Modified: libcxx/trunk/www/cxx2a_status.html
UR
Author: marshall
Date: Wed Sep 12 11:51:12 2018
New Revision: 342070
URL: http://llvm.org/viewvc/llvm-project?rev=342070&view=rev
Log:
mark LWG#2953 as complete. No code changes required, but added a couple of
extra tests.
Modified:
libcxx/trunk/test/std/containers/sequences/deque/deque.mod
kristina added a comment.
I'm in support as long as it's a configuration option defaulting similar to
LLVM's one. Should likely follow the same naming convention as LLVM, ie.
`clang-shlib`. Clang has a lot of tools it ships with especially if you
consider extras, I think this is one of the case
Author: mattd
Date: Wed Sep 12 11:27:21 2018
New Revision: 342068
URL: http://llvm.org/viewvc/llvm-project?rev=342068&view=rev
Log:
[Diagnostic] Fix a warning typo. NFC.
s/aligment/alignment/
Modified:
cfe/trunk/docs/DiagnosticsReference.rst
cfe/trunk/include/clang/Basic/DiagnosticSemaK
ldionne added a comment.
This patch is missing support for partial specializations and explicit
specializations. The part I don't understand is how to get the `CXXRecordDecl`s
to have the right attribute below. Here's the AST dump for the test file with
the current patch:
TranslationUnitDecl
lebedev.ri added a comment.
> The motivation for this library is to
> be used by Clang tools that use Clang's C++ api. They no longer need to
> link against the individual static libraries.
I would personally consider that to be a regression.
It hides layering violations.
Of course, in downstre
sammccall updated this revision to Diff 165125.
sammccall added a comment.
Fix includes, formatting tweak.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51996
Files:
clangd/Cancellation.cpp
clangd/Cancellation.h
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
cla
pirama added a comment.
As I mentioned in the discussion, we decided to carry build rules for the
proposed library in downstream. I've updated this to make it more general, and
will leave it open in case there's more interest to revive it in the future.
Repository:
rC Clang
https://reviews
bkramer added inline comments.
Comment at: include/clang/Basic/VirtualFileSystem.h:135
+ // For compatibility with old Status-based API. Prefer using Path directly.
+ StringRef getName() const { return Path; }
+};
sammccall wrote:
> Backwards-compatibility note
ldionne created this revision.
ldionne added a reviewer: rsmith.
Herald added subscribers: cfe-commits, dexonsmith.
Attributes on member classes of class templates (and other similar entities)
are not currently instantiated. This was discovered by Richard Smith here:
http://lists.llvm.org/piper
sammccall created this revision.
sammccall added reviewers: ilya-biryukov, kadircet.
Herald added subscribers: cfe-commits, jfb, arphaman, jkorous, MaskRay, ioeric.
Task is no longer exposed:
- task cancellation is hidden as a std::function
- task creation returns the new context directly
- check
pirama updated this revision to Diff 165118.
pirama added a comment.
Herald added a subscriber: fedor.sergeev.
Add empty source file to silence CMake warning.
Support more platforms, similar to libLLVM.so
Repository:
rC Clang
https://reviews.llvm.org/D50359
Files:
CMakeLists.txt
tools/CM
JonasToth added inline comments.
Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:35
+
+ std::string TypeAndName =
+ VarType.getAsString(TypePrinter) + " " + D->getNameAsString();
kbobyrev wrote:
> `llvm::Twine` here? Seems like this one is used a lo
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
I like it
Repository:
rC Clang
https://reviews.llvm.org/D51729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
erik.pilkington added a comment.
Ping!
https://reviews.llvm.org/D48896
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
simark added a comment.
In https://reviews.llvm.org/D51725#1232092, @ilya-biryukov wrote:
> Wow, this is getting somewhat complicated.
>
> Have you considered rerunning clangd whenever someone changes an option like
> that?
> Would that be much more complicated on your side?
>
> Not opposed to
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
Thanks! I don't like feature test macros either, but we should still strive for
conformance.
https://reviews.llvm.org/D51955
___
cfe-commits m
kbobyrev updated this revision to Diff 165110.
kbobyrev marked an inline comment as done.
kbobyrev added a comment.
@ilya-biryukov thanks! I was assuming that the `StringRef` constructor parses
user-provided string :(
`llvm::json::Array` is used now.
https://reviews.llvm.org/D51971
Files:
c
Author: marshall
Date: Wed Sep 12 09:59:09 2018
New Revision: 342063
URL: http://llvm.org/viewvc/llvm-project?rev=342063&view=rev
Log:
Update the failure annotations for the uncaught_exceptions test. The underlying
abi library on some Mac OS versions does not support the plural
uncaught_exceptio
aprantl added inline comments.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2369
+ ? CGM.getObjCRuntime().ComputeBitfieldBitOffset(CGM, ID, Field)
+ : 0;
} else {
JDevlieghere wrote:
> JDevlieghere wrote:
> > aprantl wrote:
> > > a
Author: abataev
Date: Wed Sep 12 09:31:59 2018
New Revision: 342062
URL: http://llvm.org/viewvc/llvm-project?rev=342062&view=rev
Log:
[OPENMP] Fix PR38902: support ADL for declare reduction constructs.
Added support for argument-dependent lookup when trying to find the
required declare reduction
lebedev.ri added a comment.
Ping once again :)
Repository:
rC Clang
https://reviews.llvm.org/D50250
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lebedev.ri added a comment.
Ping once again :)
Repository:
rC Clang
https://reviews.llvm.org/D50901
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov added a comment.
A small drive-by comment.
PS it'd be cool to have an interface to cl that does not rely on global state...
Comment at: clangd/index/dex/dexp/Dexp.cpp:163
+
+struct {
+ const char *Name;
Maybe use a named struct?
C++ is powerful,
ilya-biryukov added a comment.
In https://reviews.llvm.org/D51971#1232064, @kbobyrev wrote:
> Apparently, the parsing seems to be wrong; I should fix that first.
Oh, yeah, just use `llvm::json::parse`
https://reviews.llvm.org/D51971
___
cfe-commi
ilya-biryukov added a comment.
Wow, this is getting somewhat complicated.
Have you considered rerunning clangd whenever someone changes an option like
that?
Would that be much more complicated on your side?
Not opposed to having an option too, just want to be aware of the costs
involved on you
JDevlieghere added inline comments.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2369
+ ? CGM.getObjCRuntime().ComputeBitfieldBitOffset(CGM, ID, Field)
+ : 0;
} else {
JDevlieghere wrote:
> aprantl wrote:
> > aprantl wrote:
> > > I
JDevlieghere added inline comments.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2369
+ ? CGM.getObjCRuntime().ComputeBitfieldBitOffset(CGM, ID, Field)
+ : 0;
} else {
aprantl wrote:
> aprantl wrote:
> > It might help to attempt so
kbobyrev planned changes to this revision.
kbobyrev marked an inline comment as done.
kbobyrev added a comment.
Apparently, the parsing seems to be wrong; I should fix that first.
https://reviews.llvm.org/D51971
___
cfe-commits mailing list
cfe-comm
Author: rogfer01
Date: Wed Sep 12 08:55:14 2018
New Revision: 342060
URL: http://llvm.org/viewvc/llvm-project?rev=342060&view=rev
Log:
[RISCV] Explicitly set an empty --sysroot in the test
In rL341655 we added additional behaviour to the Driver for riscv32-unknown-elf
when the sysroot is empty.
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342060: [RISCV] Explicitly set an empty --sysroot in the
test (authored by rogfer01, committed by ).
Herald added a subscriber: jrtc27.
Repository:
rC Clang
https://reviews.llvm.org/D51972
Files:
te
aprantl added inline comments.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2369
+ ? CGM.getObjCRuntime().ComputeBitfieldBitOffset(CGM, ID, Field)
+ : 0;
} else {
aprantl wrote:
> It might help to attempt some git blame archeology.
aprantl requested changes to this revision.
aprantl added inline comments.
This revision now requires changes to proceed.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2369
+ ? CGM.getObjCRuntime().ComputeBitfieldBitOffset(CGM, ID, Field)
+ : 0;
} e
ilya-biryukov added a comment.
Thanks for the comments everyone!
Will land this tomorrow, since I'm buildcop this week anyway.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51987
___
cfe-commits mailing list
cfe-commits@lists.llvm
ioeric accepted this revision.
ioeric added a comment.
In https://reviews.llvm.org/D51987#1232021, @sammccall wrote:
> In https://reviews.llvm.org/D51987#1231993, @ioeric wrote:
>
> > In https://reviews.llvm.org/D51987#1231990, @ilya-biryukov wrote:
> >
> > > > You beat it to me, but I thought we
sammccall added a comment.
In https://reviews.llvm.org/D51987#1231993, @ioeric wrote:
> In https://reviews.llvm.org/D51987#1231990, @ilya-biryukov wrote:
>
> > > You beat it to me, but I thought we didn't use indexer as it could be
> > > confused with the actual indexing?
> >
> > Sorry. Not a bi
takuto.ikuta added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5244
+ false))
+CmdArgs.push_back("-fvisibility-inlines-hidden");
+
rnk wrote:
> takuto.ikuta wrote:
> > hans wrote:
> > > takuto.ikuta wrote:
> > > > hans
rogfer01 added a comment.
Thanks I will do it shortly.
https://reviews.llvm.org/D51972
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lewis-revill added a comment.
Great, go ahead.
https://reviews.llvm.org/D51972
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rogfer01 added a comment.
I can commit it.
https://reviews.llvm.org/D51972
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
simark added a comment.
Not sure who should review this, please feel free to add anybody who would be
appropriate.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51725
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
JDevlieghere created this revision.
JDevlieghere added reviewers: aprantl, dexonsmith.
We generate incorrect values for the DW_AT_data_bit_offset for interfaces in
Objective-C. I can only speculate as to what we were trying to achieve by
taking the modulo of the bit size with the byte size, but
ioeric added a comment.
In https://reviews.llvm.org/D51987#1231990, @ilya-biryukov wrote:
> > You beat it to me, but I thought we didn't use indexer as it could be
> > confused with the actual indexing?
>
> Sorry. Not a big deal, can revert back if needed.
> Mostly like indexer since it's short
kbobyrev added a comment.
My 2 cents: `clangd-indexer` looks great! Typing 3-token tool name is always
sad for me :( It's also easier to remember/understand in the first place.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51987
_
ilya-biryukov added a comment.
> You beat it to me, but I thought we didn't use indexer as it could be
> confused with the actual indexing?
Sorry. Not a big deal, can revert back if needed.
Mostly like indexer since it's shorter. Also not very confusing, since we call
the thing it produces an "
ioeric added a comment.
In https://reviews.llvm.org/D51987#1231971, @ilya-biryukov wrote:
> `clangd-indexer` looks nice and short. @ioeric, WDYT?
You beat it to me, but I thought we didn't use `indexer` as it could be
confused with the actual `indexing`?
Repository:
rCTE Clang Tools Extra
ilya-biryukov updated this revision to Diff 165092.
ilya-biryukov added a comment.
- Rename to clangd-indexer
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51987
Files:
clangd/CMakeLists.txt
clangd/global-symbol-builder/CMakeLists.txt
clangd/global-symbol-builder/GlobalS
lewis-revill added a comment.
@asb @kristina can we get this committed?
https://reviews.llvm.org/D51972
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jkorous added a comment.
I got some test failure with the patch, still investigating the issue.
Repository:
rC Clang
https://reviews.llvm.org/D51488
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
rogfer01 added a comment.
Thanks for the review!
https://reviews.llvm.org/D51972
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov added a comment.
`clangd-indexer` looks nice and short. @ioeric, WDYT?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51987
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
sammccall accepted this revision.
sammccall added a comment.
Much better.
I think `clangd-indexer` might be **even** better, but up to you.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51987
___
cfe-commits mailing list
cfe-commit
Author: marshall
Date: Wed Sep 12 07:46:17 2018
New Revision: 342057
URL: http://llvm.org/viewvc/llvm-project?rev=342057&view=rev
Log:
Implement LWG #3017. list splice functions should use addressof
Modified:
libcxx/trunk/include/list
libcxx/trunk/test/std/containers/sequences/list/list.o
DiamondLovesYou updated this revision to Diff 165090.
DiamondLovesYou added a comment.
- Fix cmake warning
Repository:
rC Clang
https://reviews.llvm.org/D51986
Files:
tools/driver/CMakeLists.txt
Index: tools/driver/CMakeLists.txt
==
sammccall created this revision.
sammccall added a reviewer: kbobyrev.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric, ilya-biryukov.
We can use cl::ResetCommandLineParser() to support different types of
command-lines, as long as we're careful about option lif
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp:21
+using clang::clangd::loadIndex;
+using clang::clangd::SymbolIndex;
We don't need the usings, just shorten the name on usage sites (usages are
inside nam
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
+1 to making this hidden. Users (most of them) shouldn't care about it.
Is there any motivation on why we someone would want to disable it currently?
Maybe we want to deprecate it
lewis-revill accepted this revision.
lewis-revill added a comment.
This revision is now accepted and ready to land.
The reasoning seems sound for this testcase change. I think the behaviour of
`computeSysRoot()` makes sense under this condition since it follows what the
user specified, it's just
I mean `clangd-symbol-builder`
On Wed, Sep 12, 2018 at 4:32 PM Eric Liu via Phabricator <
revi...@reviews.llvm.org> wrote:
> ioeric accepted this revision.
> ioeric added a comment.
> This revision is now accepted and ready to land.
>
> lgtm
>
> +1 to `clang-symbol-builder`
>
>
> Repository:
>
1 - 100 of 138 matches
Mail list logo
