ioeric accepted this revision. ioeric added a comment. In https://reviews.llvm.org/D51987#1232021, @sammccall wrote:
> In https://reviews.llvm.org/D51987#1231993, @ioeric wrote: > > > In https://reviews.llvm.org/D51987#1231990, @ilya-biryukov wrote: > > > > > > You beat it to me, but I thought we didn't use indexer as it could be > > > > confused with the actual indexing? > > > > > > Sorry. Not a big deal, can revert back if needed. > > > Mostly like indexer since it's shorter. Also not very confusing, since > > > we call the thing it produces an "index", so calling it an "indexer" > > > seems fine. > > > > > > What's the index you're referring to? Building data structures for faster > > > search? > > > > > > Yes. The current symbol builder produces *symbol table*, which can be > > easily confused with an index. We might have a different tool that builds > > the symbol index structure (e.g. serialized dex), which might be a better > > candidate for the name "indexer". > > > Part of the reason I like "indexer" here is I don't think it should be a > separate tool - it'd be nice if this tool would spit out a RIFF file with Dex > posting lists ready to be loaded. > (For huge codebases, things look different - but we've been talking about > using a different entrypoint for those anyway due to bifurcation around > merge-on-the-fly etc) I wasn't aware that we are also expanding the scope of the symbol builder. If being short is not the only reason here, I have no problem. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51987 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
