I don't think this was reviewed. The differential is not in 'accepted' state.
Roman.
On Fri, Aug 31, 2018 at 2:25 AM, Stephen Kelly via cfe-commits
wrote:
> Author: steveire
> Date: Thu Aug 30 16:25:38 2018
> New Revision: 341144
>
> URL: http://llvm.org/viewvc/llvm-project?rev=341144&view=rev
>
I don't think this was reviewed. The differential is not in 'accepted' state.
Roman.
On Fri, Aug 31, 2018 at 2:11 AM, Stephen Kelly via cfe-commits
wrote:
> Author: steveire
> Date: Thu Aug 30 16:11:01 2018
> New Revision: 341141
>
> URL: http://llvm.org/viewvc/llvm-project?rev=341141&view=rev
>
I don't think this was reviewed. The differential is not in 'accepted' state.
Roman.
On Fri, Aug 31, 2018 at 2:10 AM, Stephen Kelly via cfe-commits
wrote:
> Author: steveire
> Date: Thu Aug 30 16:10:52 2018
> New Revision: 341140
>
> URL: http://llvm.org/viewvc/llvm-project?rev=341140&view=rev
>
Author: akirtzidis
Date: Thu Aug 30 20:51:33 2018
New Revision: 341161
URL: http://llvm.org/viewvc/llvm-project?rev=341161&view=rev
Log:
[clang-move] Explicitly ignore implicit UsingDirectiveDecls instead of
depending on them missing source locations
This is adjustment to allow the logic to work
kristina added inline comments.
Comment at: test/Misc/pragma-attribute-supported-attributes-list.test:100
+// CHECK-NEXT: ObjCReturnsInnerPointer (SubjectMatchRule_objc_method,
SubjectMatchRule_objc_property)
+// CHECK-NEXT: ObjCRootClass (SubjectMatchRule_objc_interface)
// CH
rsmith marked an inline comment as done.
rsmith added a comment.
Based on the comments so far, my inclination is to allow `#pragma clang
attribute` on all these attributes, including the highlighted ones where it's
hard to think of cases where it'd be useful. I think our policy should be that
w
rsmith added inline comments.
Comment at: lib/Sema/SemaInit.cpp:830
+
+ for (FieldDecl *FD : CXXRD->fields())
+if (auto *CXXRDMember = FD->getType()->getAsCXXRecordDecl())
rsmith wrote:
> I think this now checks too much: only those subobjects for which we f
rsmith added a comment.
This is in good shape. Some relatively minor comments (plus there are some
unrelated whitespace changes in a few files); the only nontrivial comment I
have is that I think it'd be cleaner to cache `StringLiteral*`s rather than
adding a new form of `LValueBase` for the ca
ahatanak added a comment.
ping
Repository:
rC Clang
https://reviews.llvm.org/D45898
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kristina added inline comments.
Comment at: test/Misc/pragma-attribute-supported-attributes-list.test:100
+// CHECK-NEXT: ObjCReturnsInnerPointer (SubjectMatchRule_objc_method,
SubjectMatchRule_objc_property)
+// CHECK-NEXT: ObjCRootClass (SubjectMatchRule_objc_interface)
// CH
cdavis5x abandoned this revision.
cdavis5x added a comment.
Consensus seems clear to me. Patch abandoned.
Repository:
rUNW libunwind
https://reviews.llvm.org/D50413
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
kristina added inline comments.
Comment at: test/Misc/pragma-attribute-supported-attributes-list.test:58
// CHECK-NEXT: IFunc (SubjectMatchRule_function)
+// CHECK-NEXT: InitPriority (SubjectMatchRule_variable)
// CHECK-NEXT: InternalLinkage (SubjectMatchRule_variable,
Subject
kristina added a comment.
LGTM.
Would allow for less repetition, ie. `always_inline` is an excellent candidate
for cases like small functions that act as wrappers around bits of context
sensitive inline asm and are usually clustered together in a header, a lot of
embedded use cases come to min
rsmith marked an inline comment as done.
rsmith added inline comments.
Comment at: test/Misc/pragma-attribute-supported-attributes-list.test:27-32
+// CHECK-NEXT: CUDAConstant (SubjectMatchRule_variable)
+// CHECK-NEXT: CUDADevice (SubjectMatchRule_function,
SubjectMatchRule_var
rnk added a comment.
So, basically, if we have no internal users for these typedefs, there's no
reason to clutter up headers that get installed into system header directories
everywhere with dead ifdefed out code. Sounds good to me, let's not do it.
Repository:
rUNW libunwind
https://review
Author: maskray
Date: Thu Aug 30 17:26:46 2018
New Revision: 341152
URL: http://llvm.org/viewvc/llvm-project?rev=341152&view=rev
Log:
Import lit.llvm after rL341130
Modified:
clang-tools-extra/trunk/test/lit.site.cfg.in
Modified: clang-tools-extra/trunk/test/lit.site.cfg.in
URL:
http://llvm
Author: maskray
Date: Thu Aug 30 17:24:36 2018
New Revision: 341151
URL: http://llvm.org/viewvc/llvm-project?rev=341151&view=rev
Log:
Import lit.llvm after rC341132
Modified:
cfe/trunk/test/lit.site.cfg.py.in
Modified: cfe/trunk/test/lit.site.cfg.py.in
URL:
http://llvm.org/viewvc/llvm-proje
aheejin added a comment.
Ping pong
Repository:
rC Clang
https://reviews.llvm.org/D51448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341146: Remove vestiges of configure buildsystem (authored
by steveire, committed by ).
Herald added a subscriber: llvm-co
Author: steveire
Date: Thu Aug 30 16:41:03 2018
New Revision: 341146
URL: http://llvm.org/viewvc/llvm-project?rev=341146&view=rev
Log:
Remove vestiges of configure buildsystem
Summary:
Subscribers: mgorny, cfe-commits
Differential Revision: https://reviews.llvm.org/D50738
Modified:
cfe/tru
steveire updated this revision to Diff 163447.
steveire added a comment.
Move comment
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51192
Files:
clang-tidy/ClangTidy.cpp
Index: clang-tidy/ClangTidy.cpp
===
---
steveire marked 2 inline comments as done.
steveire added a comment.
Thanks, I fixed the issues before committing. This commit was a prerequisite to
https://reviews.llvm.org/D51261
Repository:
rL LLVM
https://reviews.llvm.org/D51260
___
cfe-comm
Author: steveire
Date: Thu Aug 30 16:25:38 2018
New Revision: 341144
URL: http://llvm.org/viewvc/llvm-project?rev=341144&view=rev
Log:
Extract runCommandsInFile method
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D51260
Modified:
clang-tools-extra/trunk/clang-que
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE341145: Add preload option to clang-query (authored by
steveire, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51261?vs=162555&id=163445#toc
Repository:
rCTE Clang Tools Extra
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341144: Extract runCommandsInFile method (authored by
steveire, committed by ).
Herald added a subscriber: llvm-commits.
Author: steveire
Date: Thu Aug 30 16:25:44 2018
New Revision: 341145
URL: http://llvm.org/viewvc/llvm-project?rev=341145&view=rev
Log:
Add preload option to clang-query
Summary: This allows loading a file with pre-defined let commands for example.
Subscribers: cfe-commits
Differential Revision:
steveire marked an inline comment as done.
steveire added inline comments.
Comment at: lib/ASTMatchers/Dynamic/Parser.cpp:362
+bool Parser::parseBindID(std::string &BindID, TokenInfo &CloseToken) {
+ // Parse .bind("foo")
klimek wrote:
> CloseToken seems to no
kristina added a comment.
Probably not, I'm personally against adding more and more typedefs for things
that are just `stdint/inttypes.h` stuff and I say here the change is
insignificant enough to warrant having to define even more types. It's not
causing any problems but unless there are actua
This revision was automatically updated to reflect the committed changes.
Closed by commit rC341142: Allow binding to NamedValue resulting from let
expression (authored by steveire, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51259?vs=162553&id=163443#toc
Repository:
r
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341142: Allow binding to NamedValue resulting from let
expression (authored by steveire, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51259
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341141: Extract parseBindID method (authored by steveire,
committed by ).
Herald added a subscriber: llvm-commits.
Change
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341140: Add dump() method for SourceRange (authored by
steveire, committed by ).
Herald added a subscriber: llvm-commits.
Author: steveire
Date: Thu Aug 30 16:11:09 2018
New Revision: 341142
URL: http://llvm.org/viewvc/llvm-project?rev=341142&view=rev
Log:
Allow binding to NamedValue resulting from let expression
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D51259
Modified:
cfe/trun
Author: steveire
Date: Thu Aug 30 16:11:01 2018
New Revision: 341141
URL: http://llvm.org/viewvc/llvm-project?rev=341141&view=rev
Log:
Extract parseBindID method
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D51258
Modified:
cfe/trunk/include/clang/ASTMatchers/Dyn
Author: steveire
Date: Thu Aug 30 16:10:52 2018
New Revision: 341140
URL: http://llvm.org/viewvc/llvm-project?rev=341140&view=rev
Log:
Add dump() method for SourceRange
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D50662
Modified:
cfe/trunk/include/clang/Basic/So
echristo added a comment.
LGTM, but let's get Stephen to ack as well.
Repository:
rC Clang
https://reviews.llvm.org/D51521
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
saugustine created this revision.
saugustine added a reviewer: srhines.
Herald added a subscriber: cfe-commits.
Refactor Addlibgcc to make the when and what logic more straightfoward.
No functional change. A forthcoming change will add support
for -shared-libgcc.
Repository:
rC Clang
https:/
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM. Can you update lib/Target/X86/X86.td in LLVM repo as well?
Repository:
rC Clang
https://reviews.llvm.org/D51510
___
cfe-comm
Author: nico
Date: Thu Aug 30 15:11:16 2018
New Revision: 341132
URL: http://llvm.org/viewvc/llvm-project?rev=341132&view=rev
Log:
Remove LIT_SITE_CFG_IN_FOOTER, clang
It's always replaced with the same (short) static string, so just put that
there directly.
No intended behavior change.
https://
Author: nico
Date: Thu Aug 30 15:10:13 2018
New Revision: 341130
URL: http://llvm.org/viewvc/llvm-project?rev=341130&view=rev
Log:
Remove LIT_SITE_CFG_IN_FOOTER, clang-tools-extra
It's always replaced with the same (short) static string, so just put that
there directly.
No intended behavior chan
tra added inline comments.
Comment at: test/Misc/pragma-attribute-supported-attributes-list.test:27-32
+// CHECK-NEXT: CUDAConstant (SubjectMatchRule_variable)
+// CHECK-NEXT: CUDADevice (SubjectMatchRule_function,
SubjectMatchRule_variable)
+// CHECK-NEXT: CUDAGlobal (SubjectMa
rnk added a comment.
Do we still need or want this? It doesn't look like it would hurt.
Repository:
rUNW libunwind
https://reviews.llvm.org/D50413
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rUNW libunwind
https://reviews.llvm.org/D51509
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
rnk added inline comments.
Comment at: src/assembly.h:76-78
+ .section .drectve,"yn" SEPARATOR\
+ .ascii "-export:", #name, "\0" SEPARATOR\
+ .text
Maybe .pushsection / .popsection is better than assuming you were in .te
dexonsmith added inline comments.
Comment at: test/Misc/pragma-attribute-supported-attributes-list.test:50
// CHECK-NEXT: EnumExtensibility (SubjectMatchRule_enum)
+// CHECK-NEXT: ExtVectorType (SubjectMatchRule_type_alias)
// CHECK-NEXT: ExternalSourceSymbol ((SubjectMatchRule
thiagomacieira created this revision.
thiagomacieira added reviewers: erichkeane, GBuella.
Herald added a subscriber: cfe-commits.
The instruction set first appeared with Westmere, but not all processors
in that and the next few generations have the instructions. According to
Wikipedia[1], the fir
cdavis5x created this revision.
cdavis5x added reviewers: mstorsjo, rnk.
Herald added subscribers: cfe-commits, christof.
That attribute has no effect on Windows anyway--classes are hidden by
default.
Repository:
rUNW libunwind
https://reviews.llvm.org/D51509
Files:
src/AddressSpace.hpp
cdavis5x created this revision.
cdavis5x added reviewers: mstorsjo, rnk.
Herald added subscribers: cfe-commits, christof.
By default, symbols aren't visible outside of the module that defines
them. To make them visible, they must be exported. The easiest way to do
that is to embed an `-export:symn
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341125: Add support for SEH unwinding on Windows. (authored
by cdavis, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D50564
Files:
libunwind/trunk/include/__libunwind_config.h
libun
Author: cdavis
Date: Thu Aug 30 14:29:00 2018
New Revision: 341125
URL: http://llvm.org/viewvc/llvm-project?rev=341125&view=rev
Log:
Add support for SEH unwinding on Windows.
Summary:
I've tested this implementation on x86-64 to ensure that it works. All
`libc++abi` tests pass, as do all `libc++`
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D50564#1211477, @mstorsjo wrote:
> Not much more comments from me. The implementation seems reasonable, and
> works for one simple test I did (with an earlier revision of
rsmith added a comment.
+@tra for CUDA attributes
Comment at: test/Misc/pragma-attribute-supported-attributes-list.test:1
// RUN: clang-tblgen -gen-clang-test-pragma-attribute-supported-attributes
-I%src_include_dir %src_include_dir/clang/Basic/Attr.td -o - | FileCheck %s
-
rsmith added a comment.
In https://reviews.llvm.org/D30009#1218669, @dexonsmith wrote:
> In https://reviews.llvm.org/D30009#1218647, @rsmith wrote:
>
> > If we really want an "only documented attribtues can use this feature" rule
> > (and I'm really not convinced that is a useful rule to enforce
rsmith created this revision.
rsmith added reviewers: aaron.ballman, arphaman.
We previously disallowed use of undocumented attributes with #pragma clang
attribute, but the justification for doing so was weak and it prevented many
reasonable use cases.
Repository:
rC Clang
https://reviews.llv
rsmith added a comment.
Instead of guessing whether the corrected filename would be valid, why not
strip off the leading and trailing non-alphanumeric characters, look up the
resulting filename, and find out? If we did that, then not only could we be a
lot more confident that we'd found the fil
tra added a comment.
Tests reverted in https://reviews.llvm.org/rL341118.
Repository:
rC Clang
https://reviews.llvm.org/D51441
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith accepted this revision.
rsmith added a comment.
Thank you for doing this!
Repository:
rC Clang
https://reviews.llvm.org/D50353
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
tra added a comment.
Reverted in https://reviews.llvm.org/rL341115 &
https://reviews.llvm.org/rL341118.
Repository:
rC Clang
https://reviews.llvm.org/D51312
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
This revision was automatically updated to reflect the committed changes.
Closed by commit rC341117: [MS ABI] Fix mangling issue with dynamic initializer
stubs. (authored by zturner, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llvm.org/D51500
tra added a comment.
Tests reverted in https://reviews.llvm.org/rL341118
Repository:
rL LLVM
https://reviews.llvm.org/D50845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: tra
Date: Thu Aug 30 13:53:15 2018
New Revision: 341118
URL: http://llvm.org/viewvc/llvm-project?rev=341118&view=rev
Log:
Revert the tests that should've been reverted in rL341115
Removed:
cfe/trunk/test/Preprocessor/aux-triple.c
Modified:
cfe/trunk/test/Preprocessor/predefined-ma
Author: zturner
Date: Thu Aug 30 13:53:11 2018
New Revision: 341117
URL: http://llvm.org/viewvc/llvm-project?rev=341117&view=rev
Log:
[MS ABI] Fix mangling issue with dynamic initializer stubs.
There are two types of dynamic initializer stubs. There's
`dynamic initializer for 'x''(void)
and
tra added a comment.
Reverted in https://reviews.llvm.org/rL341115.
Repository:
rC Clang
https://reviews.llvm.org/D51441
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra added a comment.
Reverted in https://reviews.llvm.org/rL341115
Repository:
rL LLVM
https://reviews.llvm.org/D50845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: tra
Date: Thu Aug 30 13:43:39 2018
New Revision: 341115
URL: http://llvm.org/viewvc/llvm-project?rev=341115&view=rev
Log:
Reverted the "[CUDA/OpenMP] Define only some host macros during device
compilation"
The changes were breaking CUDA compilation.
Reverted revisions:
r340681 D50845
Author: saugustine
Date: Thu Aug 30 13:42:49 2018
New Revision: 341114
URL: http://llvm.org/viewvc/llvm-project?rev=341114&view=rev
Log:
Revert r341107. That change breaks lto-android in a way is untested.
Modified:
cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp
Modified: cfe/trunk/lib/Drive
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Not sure that every test for line-tables-only needs to also test
line-directives-only, but not a huge deal either way. (only the cases where
there's actually a different codepath to test/n
steveire added a comment.
@rsmith Could you approve this please?
Repository:
rC Clang
https://reviews.llvm.org/D50353
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra added a comment.
That, and r340967 https://reviews.llvm.org/D51441. I'm running check-clang now
and will land reverted changes shortly.
Repository:
rL LLVM
https://reviews.llvm.org/D50845
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
Hahnfeld added a comment.
In https://reviews.llvm.org/D50845#1219865, @gtbercea wrote:
> In https://reviews.llvm.org/D50845#1219859, @Hahnfeld wrote:
>
> > removing `InitializePredefinedAuxMacros` and the new test completely should
> > do.
>
>
> Yep they also contain https://reviews.llvm.org/D51
gtbercea added a comment.
In https://reviews.llvm.org/D50845#1219859, @Hahnfeld wrote:
> removing `InitializePredefinedAuxMacros` and the new test completely should
> do.
Yep they also contain https://reviews.llvm.org/D51312 in case you're rolling
back individual commits.
Repository:
rL L
Author: rsmith
Date: Thu Aug 30 13:15:28 2018
New Revision: 341110
URL: http://llvm.org/viewvc/llvm-project?rev=341110&view=rev
Log:
[cxx_status] Use the correct color for a feature in "SVN" status
Modified:
cfe/trunk/www/cxx_status.html
Modified: cfe/trunk/www/cxx_status.html
URL:
http://l
On Thu, 30 Aug 2018 at 12:27, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Thu, Aug 30, 2018 at 3:21 PM, Richard Smith - zygoloid via
> Phabricator wrote:
> > rsmith marked an inline comment as done.
> > rsmith added inline comments.
> >
> >
> >
> > Com
Hahnfeld added a comment.
In https://reviews.llvm.org/D50845#1219853, @tra wrote:
> In https://reviews.llvm.org/D50845#1219819, @Hahnfeld wrote:
>
> > Ok, the top preprocessor condition for that function is `#ifndef
> > __SSE2_MATH__` - the exact same macro that was part of the motivation. Can
Author: saugustine
Date: Thu Aug 30 13:07:23 2018
New Revision: 341107
URL: http://llvm.org/viewvc/llvm-project?rev=341107&view=rev
Log:
Refactor Addlibgcc to make the when and what logic more straightfoward.
No functional change. A forthcoming change will add support
for -shared-libgcc.
Modifi
tra added a comment.
In https://reviews.llvm.org/D50845#1219819, @Hahnfeld wrote:
> Ok, the top preprocessor condition for that function is `#ifndef
> __SSE2_MATH__` - the exact same macro that was part of the motivation. Can
> you please test compiling a simple C file (including `math.h`) with
sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51504
Files:
clangd/CodeComplete.cpp
clangd/global-symbol-builder/G
RaviNarayanaswamy accepted this revision.
RaviNarayanaswamy added a comment.
Ok.
Thanks.
Repository:
rC Clang
https://reviews.llvm.org/D51378
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Author: dyung
Date: Thu Aug 30 12:52:57 2018
New Revision: 341106
URL: http://llvm.org/viewvc/llvm-project?rev=341106&view=rev
Log:
Change %clang++ to %clangxx in test run line as it was expanding to clang.exe++
on Windows.
Modified:
cfe/trunk/test/Driver/linux-ld.c
Modified: cfe/trunk/test
On Thu, Aug 30, 2018 at 3:21 PM, Richard Smith - zygoloid via
Phabricator wrote:
> rsmith marked an inline comment as done.
> rsmith added inline comments.
>
>
>
> Comment at: utils/TableGen/ClangAttrEmitter.cpp:3881
> +SpellingKind K = (SpellingKind)Kind;
> +// FIXME: Why
On Thu, 30 Aug 2018 at 12:18, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Thu Aug 30 12:17:11 2018
> New Revision: 341099
>
> URL: http://llvm.org/viewvc/llvm-project?rev=341099&view=rev
> Log:
> Add test file missed from r341097.
>
Sorry, typo, thi
rsmith marked an inline comment as done.
rsmith added inline comments.
Comment at: utils/TableGen/ClangAttrEmitter.cpp:3881
+SpellingKind K = (SpellingKind)Kind;
+// FIXME: Why are Microsoft spellings not listed?
+if (K == SpellingKind::Microsoft)
aar
Hahnfeld added a comment.
In https://reviews.llvm.org/D50845#1219746, @tra wrote:
> In our case the headers from a relatively old glibc and compiler errors out
> on this:
>
> /* This function is used in the `isfinite' macro. */
> __MATH_INLINE int
> __NTH (__finite (double __x))
> {
>
Author: rsmith
Date: Thu Aug 30 12:19:15 2018
New Revision: 341100
URL: http://llvm.org/viewvc/llvm-project?rev=341100&view=rev
Log:
Update FIXME as requested in code review.
Modified:
cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp
Modified: cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp
URL:
Author: rsmith
Date: Thu Aug 30 12:17:11 2018
New Revision: 341099
URL: http://llvm.org/viewvc/llvm-project?rev=341099&view=rev
Log:
Add test file missed from r341097.
Added:
cfe/trunk/test/SemaCXX/cxx14-compat.cpp
Added: cfe/trunk/test/SemaCXX/cxx14-compat.cpp
URL:
http://llvm.org/viewvc/l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341097: Improve attribute documentation to list which
spellings are used in which… (authored by rsmith, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm
Author: rsmith
Date: Thu Aug 30 12:16:33 2018
New Revision: 341097
URL: http://llvm.org/viewvc/llvm-project?rev=341097&view=rev
Log:
Improve attribute documentation to list which spellings are used in which
syntaxes.
Summary:
Instead of listing all the spellings (including attribute namespaces)
Author: rsmith
Date: Thu Aug 30 12:16:35 2018
New Revision: 341098
URL: http://llvm.org/viewvc/llvm-project?rev=341098&view=rev
Log:
Add missing -Wc++11-compat / -Wc++14-compat warnings for:
* generic lambdas
* return type deduction
* class template argument deduction
Added:
cfe/trunk/tes
Hahnfeld added a comment.
In https://reviews.llvm.org/D50845#1219797, @tra wrote:
> I've sent out https://reviews.llvm.org/D51501. It unbreaks CUDA compilation
> and keeps OpenMP unchanged.
I think a full revert would make more sense. And you definitely want to
reinstantiate
// FIXME: This
tra added a comment.
I've sent out https://reviews.llvm.org/D51501. It unbreaks CUDA compilation and
keeps OpenMP unchanged.
Repository:
rL LLVM
https://reviews.llvm.org/D50845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
tra created this revision.
tra added a reviewer: Hahnfeld.
Herald added subscribers: bixia, jlebar, sanjoy.
This keeps predefined macros for CUDA to work as they were before and lets
OpenMP control the set of macros it needs.
https://reviews.llvm.org/D51501
Files:
clang/lib/Frontend/InitPrep
Author: abataev
Date: Thu Aug 30 11:56:11 2018
New Revision: 341093
URL: http://llvm.org/viewvc/llvm-project?rev=341093&view=rev
Log:
[OPENMP] Fix PR38710: static functions are not emitted as implicitly
'declare target'.
All the functions, referenced in implicit|explicit target regions must
be em
gtbercea added a comment.
In https://reviews.llvm.org/D50845#1219746, @tra wrote:
> Also, whatever macros we generate do not prevent headers from using x86
> inline assembly. I see quite a few inline asm code in preprocessed output.
> The headers are from libc ~2.19.
Did you try adding
Bui
This revision was automatically updated to reflect the committed changes.
Closed by commit rC341092: [analyzer] InnerPointerChecker: Fix a segfault when
checking symbolic strings. (authored by dergachev, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51385?vs=162963&id=16338
Author: dergachev
Date: Thu Aug 30 11:45:05 2018
New Revision: 341092
URL: http://llvm.org/viewvc/llvm-project?rev=341092&view=rev
Log:
[analyzer] InnerPointerChecker: Fix a segfault when checking symbolic strings.
Return value of dyn_cast_or_null should be checked before use.
Otherwise we may pu
tra added a comment.
In https://reviews.llvm.org/D50845#1219733, @Hahnfeld wrote:
> In https://reviews.llvm.org/D50845#1219726, @gtbercea wrote:
>
> > In general, it looks like this patch leads to some host macros having to be
> > defined again for the auxiliary triple case. It is not clear to m
patricklyster added a comment.
In https://reviews.llvm.org/D51378#1219474, @RaviNarayanaswamy wrote:
> I did not see the code where check is done if Nestingdepth is 0 at end of
> compilation.
Sorry I should clarify. You will get an error if you have an unmatched `#pragma
omp declare target` o
NoQ added a comment.
Ok, i'll get to the rest of the stuff a bit later (unless you pick it up).
Repository:
rC Clang
https://reviews.llvm.org/D51385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
tra added a comment.
In our case the headers from a relatively old glibc and compiler errors out on
this:
/* This function is used in the `isfinite' macro. */
__MATH_INLINE int
__NTH (__finite (double __x))
{
return (__extension__
(union { double __d; int __i[2]; }) {_
Hahnfeld added a comment.
In https://reviews.llvm.org/D50845#1219726, @gtbercea wrote:
> In general, it looks like this patch leads to some host macros having to be
> defined again for the auxiliary triple case. It is not clear to me how to
> exhaustively identify the missing macros, so far it'
1 - 100 of 214 matches
Mail list logo
