Hahnfeld added a comment.

In https://reviews.llvm.org/D50845#1219797, @tra wrote:

> I've sent out https://reviews.llvm.org/D51501. It unbreaks CUDA compilation 
> and keeps OpenMP unchanged.


I think a full revert would make more sense. And you definitely want to 
reinstantiate

  // FIXME: This will create multiple definitions for most of the predefined
  // macros. This is not the right way to handle this.

which is what I meant with "broken".

In any case, I'd like to request some more time to investigate. For now it 
looks like Clang was never able to parse that code, so we cannot come across 
this in the past.


Repository:
  rL LLVM

https://reviews.llvm.org/D50845



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to