[PATCH] D51426: [Sema] Prohibit function-scope compound literals with address spaces.

ebevhan added inline comments. Comment at: lib/Sema/SemaExpr.cpp:5745 +// C99 6.5.2.5p6: Function scope compound literals must have automatic +// storage which generally excludes address space-qualified ones. +Diag(LParenLoc, diag::err_compound_literal_with_address_sp

[PATCH] D49074: [Analyzer] [WIP] Basic support for multiplication and division in the constraint manager

baloghadamsoftware added a comment. Disabled? No, that was a different thing. I have some ideas there as well, how to solve it, but it was the rearrangement in the `SValBuilder`. This one is one level lower, the `ConstraintManager` which only calculate the range for a symbol where we have and a

[PATCH] D51434: [HIP] Add -fvisibility hidden option to clang

arsenm added inline comments. Comment at: lib/Driver/ToolChains/HIP.cpp:256 +CC1Args.append({"-fvisibility", "hidden"}); } We should probably start subclassing the HIP toolchain from AMDGPU and share more of this https://reviews.llvm.org/D51434 _

[PATCH] D51390: [analyzer] CallDescription: Improve array management.

MTC accepted this revision. MTC added a comment. Thank you for digging in to delete that meaningless constructor, NoQ! And sorry for my technology debt : ). Repository: rC Clang https://reviews.llvm.org/D51390 ___ cfe-commits mailing list cfe-co

[PATCH] D51473: Improve attribute documentation to list which spellings are used in which syntaxes.

rsmith created this revision. rsmith added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Instead of listing all the spellings (including attribute namespaces) in the section heading, only list the actual attribute names there, and list the spellings in the supported syntaxes t

r341013 - Ensure canonical type is actually canonical.

Author: rtrieu Date: Wed Aug 29 18:57:52 2018 New Revision: 341013 URL: http://llvm.org/viewvc/llvm-project?rev=341013&view=rev Log: Ensure canonical type is actually canonical. ASTContext::applyObjCProtocolQualifiers will return a canonical type when given a canonical type and an array of canoni

[PATCH] D51395: [analyzer] Dump a reproducible, deterministic ID of program state to exploded graph

george.karpenkov added a comment. F7076011: image.png https://reviews.llvm.org/D51395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51395: [analyzer] Dump a reproducible, deterministic ID of program state to exploded graph

george.karpenkov updated this revision to Diff 163247. https://reviews.llvm.org/D51395 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h clang/lib/StaticAnalyzer/Core/ExprEngine.cpp clang/lib/StaticAnalyzer/Core/ProgramState.cpp Index: clang/lib/StaticAnalyzer/Co

[PATCH] D51395: [analyzer] Dump a reproducible, deterministic ID of program state to exploded graph

george.karpenkov updated this revision to Diff 163246. https://reviews.llvm.org/D51395 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h clang/lib/StaticAnalyzer/Core/ExprEngine.cpp clang/lib/StaticAnalyzer/Core/ProgramState.cpp Index: clang/lib/StaticAnalyzer/Co

[PATCH] D30009: Add support for '#pragma clang attribute'

dexonsmith added a subscriber: erik.pilkington. dexonsmith added a comment. In https://reviews.llvm.org/D30009#1218647, @rsmith wrote: > One consequence of this patch (see https://reviews.llvm.org/rL341002) is that > adding documentation to an existing attribute //changes the behavior of > Clan

[PATCH] D30009: Add support for '#pragma clang attribute'

rsmith added a comment. In https://reviews.llvm.org/D30009#1218647, @rsmith wrote: > One consequence of this patch (see https://reviews.llvm.org/rL341002) is that > adding documentation to an existing attribute //changes the behavior of > Clang//. That does not seem acceptable to me: documentat

r341009 - Adjust Attr representation so that changes to documentation don't affect

Author: rsmith Date: Wed Aug 29 18:01:07 2018 New Revision: 341009 URL: http://llvm.org/viewvc/llvm-project?rev=341009&view=rev Log: Adjust Attr representation so that changes to documentation don't affect how we parse source code. Instead of implicitly opting all undocumented attributes out of '

[PATCH] D30009: Add support for '#pragma clang attribute'

rsmith added a comment. Herald added a subscriber: llvm-commits. One consequence of this patch (see https://reviews.llvm.org/rL341002) is that adding documentation to an existing attribute //changes the behavior of Clang//. That does not seem acceptable to me: documentation improvements should

[PATCH] D51190: [AttrDocs]: document gnu_inline function attribute

rupprecht added a comment. BTW, seems like these docs have tests that weren't updated. Fixed with https://reviews.llvm.org/rL341002, but please take a look if that's not the right fix. Repository: rL LLVM https://reviews.llvm.org/D51190 ___ cfe

r341002 - [AttrDocs] Fix build bots: add missing GNUInline pragma to test.

Author: rupprecht Date: Wed Aug 29 17:04:34 2018 New Revision: 341002 URL: http://llvm.org/viewvc/llvm-project?rev=341002&view=rev Log: [AttrDocs] Fix build bots: add missing GNUInline pragma to test. Modified: cfe/trunk/test/Misc/pragma-attribute-supported-attributes-list.test Modified: cfe

Buildbot numbers for the week of 8/12/2018 - 8/18/2018

Hello everyone, Below are some buildbot numbers for the week of 8/12/2018 - 8/18/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to r

Buildbot numbers for the week of 8/19/2018 - 8/25/2018

Hello everyone, Below are some buildbot numbers for the last week of 8/19/2018 - 8/25/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

[PATCH] D51393: Provide a method for generating deterministic IDs for pointers allocated in BumpPtrAllocator

NoQ added a comment. In https://reviews.llvm.org/D51393#1218544, @george.karpenkov wrote: > In fact, generating a single "long" seems even better. `ptrdiff_t` seems to express what we're trying to say pretty accurately. https://reviews.llvm.org/D51393 __

[PATCH] D51393: Provide a method for generating deterministic IDs for pointers allocated in BumpPtrAllocator

george.karpenkov updated this revision to Diff 163224. george.karpenkov edited the summary of this revision. george.karpenkov added a comment. In fact, generating a single "long" seems even better. https://reviews.llvm.org/D51393 Files: llvm/include/llvm/Support/Allocator.h Index: llvm/incl

[PATCH] D51300: [analyzer][UninitializedObjectChecker] No longer using nonloc::LazyCompoundVal

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp:448-449 Loc ThisLoc = Context.getSValBuilder().getCXXThis(CtorDecl->getParent(), Context.getStackFrame(

[libcxx] r340992 - Last week, someone noted that a couple of the time_point member functions were not constexpr. I looked, and they were right. They were made constexpr in p0505, so I looked at all th

Author: marshall Date: Wed Aug 29 16:02:15 2018 New Revision: 340992 URL: http://llvm.org/viewvc/llvm-project?rev=340992&view=rev Log: Last week, someone noted that a couple of the time_point member functions were not constexpr. I looked, and they were right. They were made constexpr in p0505, s

r340990 - [analyzer] Document that pointer arithmetic is not represented by SymExprs.

Author: dergachev Date: Wed Aug 29 15:57:52 2018 New Revision: 340990 URL: http://llvm.org/viewvc/llvm-project?rev=340990&view=rev Log: [analyzer] Document that pointer arithmetic is not represented by SymExprs. Add assertions to verify that. Modified: cfe/trunk/include/clang/StaticAnalyzer/

[PATCH] D51390: [analyzer] CallDescription: Improve array management.

NoQ added a comment. Yeah, i guess i should've split those up. Well, i had to fix the other code when i fixed the first code, because it contains a hardcoded duplicate of the vector type. So i decided to fix it in a slightly more intelligent manner. Repository: rC Clang https://reviews.llv

[PATCH] D51464: clang: fix MIPS/N32 triple and paths

wzssyqa created this revision. wzssyqa added a reviewer: atanasyan. Herald added subscribers: cfe-commits, jrtc27, arichardson, sdardis, srhines. Guess N32 ABI when no abi option is given based on llvm patch. It now support mips64(el)-linux-gnuabin32 and mipsn32(el). The include and library paths

[PATCH] D51390: [analyzer] CallDescription: Improve array management.

george.karpenkov added a comment. Strictly speaking those two seem like completely unrelated changes , right? Repository: rC Clang https://reviews.llvm.org/D51390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[PATCH] D50850: clang: Add triples support for MIPS r6

wzssyqa updated this revision to Diff 163221. Repository: rC Clang https://reviews.llvm.org/D50850 Files: lib/Driver/ToolChains/Arch/Mips.cpp lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Linux.cpp test/CodeGen/atomics-inlining.c test/CodeGen/mips-zero-sized-struct.c test/Cod

[PATCH] D51190: [AttrDocs]: document gnu_inline function attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rL340987: [AttrDocs]: document gnu_inline function attribute (authored by nickdesaulniers, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D51190 Fi

r340987 - [AttrDocs]: document gnu_inline function attribute

Author: nickdesaulniers Date: Wed Aug 29 15:50:47 2018 New Revision: 340987 URL: http://llvm.org/viewvc/llvm-project?rev=340987&view=rev Log: [AttrDocs]: document gnu_inline function attribute Summary: This wasn't documented https://clang.llvm.org/docs/AttributeReference.html, and briefly mentio

[PATCH] D51190: [AttrDocs]: document gnu_inline function attribute

rsmith added a comment. Looks good, thanks for improving our documentation! Repository: rC Clang https://reviews.llvm.org/D51190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51323: [analyzer] Improve tracing for uninitialized struct fields

This revision was automatically updated to reflect the committed changes. Closed by commit rC340986: [analyzer] Improve tracing for uninitialized struct fields (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.or

r340986 - [analyzer] Improve tracing for uninitialized struct fields

Author: george.karpenkov Date: Wed Aug 29 15:48:50 2018 New Revision: 340986 URL: http://llvm.org/viewvc/llvm-project?rev=340986&view=rev Log: [analyzer] Improve tracing for uninitialized struct fields rdar://13729267 Differential Revision: https://reviews.llvm.org/D51323 Added: cfe/trunk/t

[PATCH] D51190: [AttrDocs]: document gnu_inline function attribute

nickdesaulniers updated this revision to Diff 163215. nickdesaulniers added a comment. - link to correct doc - explicitly mention extern inline - s/c89/GNU inline extension/g and mention -std=gnu89/-fgnu89-inline - Take rsmith's sugguested wording. Add info about __GNUC_STDC_INLINE__. - some final

r340984 - [analyzer] Support modeling no-op BaseToDerived casts in ExprEngine.

Author: dergachev Date: Wed Aug 29 15:43:31 2018 New Revision: 340984 URL: http://llvm.org/viewvc/llvm-project?rev=340984&view=rev Log: [analyzer] Support modeling no-op BaseToDerived casts in ExprEngine. Introduce a new MemRegion sub-class, CXXDerivedObjectRegion, which is the opposite of CXXBas

[PATCH] D51191: [analyzer] Support modelling no-op BaseToDerived casts in ExprEngine

This revision was automatically updated to reflect the committed changes. Closed by commit rC340984: [analyzer] Support modeling no-op BaseToDerived casts in ExprEngine. (authored by dergachev, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.or

r340982 - [analyzer] CFRetainReleaseChecker: Don't check C++ methods with the same name.

Author: dergachev Date: Wed Aug 29 15:39:20 2018 New Revision: 340982 URL: http://llvm.org/viewvc/llvm-project?rev=340982&view=rev Log: [analyzer] CFRetainReleaseChecker: Don't check C++ methods with the same name. Don't try to understand what's going on when there's a C++ method called eg. CFRet

[PATCH] D50866: [analyzer] CFRetainReleaseChecker: Avoid checking C++ methods with the same name.

This revision was automatically updated to reflect the committed changes. Closed by commit rC340982: [analyzer] CFRetainReleaseChecker: Don't check C++ methods with the same name. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D50866 Files: lib/StaticA

[PATCH] D50855: [analyzer] pr37578: Fix lvalue/rvalue problem in field-of-temporary adjustments.

This revision was automatically updated to reflect the committed changes. Closed by commit rL340977: [CFG] [analyzer] Disable argument construction contexts for variadic functions. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://

r340977 - [CFG] [analyzer] Disable argument construction contexts for variadic functions.

Author: dergachev Date: Wed Aug 29 15:05:35 2018 New Revision: 340977 URL: http://llvm.org/viewvc/llvm-project?rev=340977&view=rev Log: [CFG] [analyzer] Disable argument construction contexts for variadic functions. The analyzer doesn't make use of them anyway and they seem to have pretty weird A

[PATCH] D50824: [CFG] [analyzer] pr37769: Disable argument construction contexts for variadic functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL340975: [CFG] [analyzer] Disable argument construction contexts for variadic functions. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://

r340975 - [CFG] [analyzer] Disable argument construction contexts for variadic functions.

Author: dergachev Date: Wed Aug 29 14:50:52 2018 New Revision: 340975 URL: http://llvm.org/viewvc/llvm-project?rev=340975&view=rev Log: [CFG] [analyzer] Disable argument construction contexts for variadic functions. The analyzer doesn't make use of them anyway and they seem to have pretty weird A

[PATCH] D51434: [HIP] Add -fvisibility hidden option to clang

yaxunl updated this revision to Diff 163196. yaxunl added a comment. Revised by Artem's comments. https://reviews.llvm.org/D51434 Files: lib/Driver/ToolChains/HIP.cpp test/Driver/hip-toolchain.hip Index: test/Driver/hip-toolchain.hip ===

[PATCH] D51190: [AttrDocs]: document gnu_inline function attribute

rsmith added inline comments. Comment at: include/clang/Basic/AttrDocs.td:3518 +the behavior of ``inline`` in both C99 inline semantics and C++ inline +semantics). + Might be useful to be a bit more explicit about how it differs: > [...] is just a hint. In parti

[PATCH] D51434: [HIP] Add -fvisibility hidden option to clang

tra added inline comments. Comment at: lib/Driver/ToolChains/HIP.cpp:255 + options::OPT_fvisibility_ms_compat)) { +CC1Args.push_back("-fvisibility"); +CC1Args.push_back("hidden"); Nit: You could collapse multiple `push_back` calls

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

rsmith added a comment. You also need to update the various other places that create `AttributedType`s (eg, template instantiation, ASTImporter, deserialization) to pass in the macro name. You can try removing the default argument from `ASTContext::getAttributedType` to find other places that

r340972 - [analyzer] Fix tests on 32-bit platforms by specifying the tuple explicitly

Author: george.karpenkov Date: Wed Aug 29 14:18:47 2018 New Revision: 340972 URL: http://llvm.org/viewvc/llvm-project?rev=340972&view=rev Log: [analyzer] Fix tests on 32-bit platforms by specifying the tuple explicitly Modified: cfe/trunk/test/Analysis/casts.c Modified: cfe/trunk/test/Analys

[PATCH] D51393: Provide a method for generating deterministic IDs for pointers allocated in BumpPtrAllocator

NoQ added a comment. In https://reviews.llvm.org/D51393#1217644, @aprantl wrote: > Just for consideration: The raw pointers in dumps are sometimes useful while > in a debugger session, because you can cast a pointer and dump the object in > the debugger. Yup, i use that as well from time to t

[PATCH] D51434: [HIP] Add -fvisibility hidden option to clang

yaxunl updated this revision to Diff 163186. yaxunl retitled this revision from "[HIP] Add -amdgpu-internalize-symbols option to opt" to "[HIP] Add -fvisibility hidden option to clang". yaxunl edited the summary of this revision. yaxunl added a comment. Use -fvisibility hidden. https://reviews.

[PATCH] D51057: [analyzer][UninitializedObjectChecker] Fixed dereferencing

Szelethus updated this revision to Diff 163185. Szelethus added a comment. Fixed two crashes. Interesting how many much better this approach works, as I've never encountered `FunctionType`d objects or only forward declared typed pointers after dereferencing. https://reviews.llvm.org/D51057 Fi

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51209: AMDGPU: Default to hidden visibility

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! https://reviews.llvm.org/D51209 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

r340968 - [OPENMP] Do not create offloading entry for declare target variables

Author: abataev Date: Wed Aug 29 13:41:37 2018 New Revision: 340968 URL: http://llvm.org/viewvc/llvm-project?rev=340968&view=rev Log: [OPENMP] Do not create offloading entry for declare target variables declarations. We should not create offloading entries for declare target var declarations as i

[PATCH] D51441: Add predefined macro __gnu_linux__ for proper aux-triple

This revision was automatically updated to reflect the committed changes. Closed by commit rC340967: Add predefined macro __gnu_linux__ for proper aux-triple (authored by yaxunl, committed by ). Repository: rC Clang https://reviews.llvm.org/D51441 Files: lib/Frontend/InitPreprocessor.cpp

r340967 - Add predefined macro __gnu_linux__ for proper aux-triple

Author: yaxunl Date: Wed Aug 29 13:39:22 2018 New Revision: 340967 URL: http://llvm.org/viewvc/llvm-project?rev=340967&view=rev Log: Add predefined macro __gnu_linux__ for proper aux-triple Clang predefine macro __linx__ for aux-triple with Linux OS but does not predefine macro __gnu_linux__. Thi

[PATCH] D51252: [analyzer] Resolve the crash in ReturnUndefChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rL340965: [analyzer] Resolve the crash in ReturnUndefChecker (authored by george.karpenkov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D5125

[PATCH] D51252: [analyzer] Resolve the crash in ReturnUndefChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rC340965: [analyzer] Resolve the crash in ReturnUndefChecker (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D51252

[PATCH] D51251: [analyzer] Move analyzer-eagerly-assume to AnalyzerOptions, enable by default

This revision was automatically updated to reflect the committed changes. Closed by commit rL340963: [analyzer] Move analyzer-eagerly-assume to AnalyzerOptions, enable by default (authored by george.karpenkov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[PATCH] D51251: [analyzer] Move analyzer-eagerly-assume to AnalyzerOptions, enable by default

This revision was automatically updated to reflect the committed changes. Closed by commit rC340963: [analyzer] Move analyzer-eagerly-assume to AnalyzerOptions, enable by default (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: htt

r340965 - [analyzer] Resolve the crash in ReturnUndefChecker

Author: george.karpenkov Date: Wed Aug 29 13:29:59 2018 New Revision: 340965 URL: http://llvm.org/viewvc/llvm-project?rev=340965&view=rev Log: [analyzer] Resolve the crash in ReturnUndefChecker By making sure the returned value from getKnownSVal is consistent with the value used inside expression

[PATCH] D51250: [analyzer] [NFC] Remove unused argument from makeSymExprValNN

This revision was automatically updated to reflect the committed changes. Closed by commit rC340962: [analyzer] [NFC] Remove unused "state" argument from makeSymExprValNN (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://revi

r340964 - [analyzer] [NFC] Move class definition out of the function

Author: george.karpenkov Date: Wed Aug 29 13:29:39 2018 New Revision: 340964 URL: http://llvm.org/viewvc/llvm-project?rev=340964&view=rev Log: [analyzer] [NFC] Move class definition out of the function Differential Revision: https://reviews.llvm.org/D51322 Modified: cfe/trunk/lib/StaticAnaly

r340963 - [analyzer] Move analyzer-eagerly-assume to AnalyzerOptions, enable by default

Author: george.karpenkov Date: Wed Aug 29 13:29:17 2018 New Revision: 340963 URL: http://llvm.org/viewvc/llvm-project?rev=340963&view=rev Log: [analyzer] Move analyzer-eagerly-assume to AnalyzerOptions, enable by default Differential Revision: https://reviews.llvm.org/D51251 Modified: cfe/tr

r340962 - [analyzer] [NFC] Remove unused "state" argument from makeSymExprValNN

Author: george.karpenkov Date: Wed Aug 29 13:28:54 2018 New Revision: 340962 URL: http://llvm.org/viewvc/llvm-project?rev=340962&view=rev Log: [analyzer] [NFC] Remove unused "state" argument from makeSymExprValNN Differential Revision: https://reviews.llvm.org/D51250 Modified: cfe/trunk/incl

r340961 - [analyzer] Better retain count rules for OSObjects

Author: george.karpenkov Date: Wed Aug 29 13:28:33 2018 New Revision: 340961 URL: http://llvm.org/viewvc/llvm-project?rev=340961&view=rev Log: [analyzer] Better retain count rules for OSObjects Differential Revision: https://reviews.llvm.org/D51184 Modified: cfe/trunk/lib/StaticAnalyzer/Che

r340960 - [analyzer] [NFC] Follow the convention when naming classes

Author: george.karpenkov Date: Wed Aug 29 13:28:13 2018 New Revision: 340960 URL: http://llvm.org/viewvc/llvm-project?rev=340960&view=rev Log: [analyzer] [NFC] Follow the convention when naming classes Renames InvalidateRegionsWorker and RemoveDeadBindingsWorker Differential Revision: https://re

[PATCH] D51441: Add predefined macro __gnu_linux__ for proper aux-triple

yaxunl added a comment. In https://reviews.llvm.org/D51441#1218034, @yaxunl wrote: > In https://reviews.llvm.org/D51441#1218010, @tra wrote: > > > While we're here, perhaps `Builder.defineMacro("__linux__")` should be > > changed to `DefineStd("linux")` which defines `linux/__linux/__linux__`? >

[PATCH] D51378: [OPENMP] Add support for nested 'declare target' directives

RaviNarayanaswamy added a comment. We should just go with generating an error if the DeclareTargetNestingLevel is not 0 at the end of compilation unit. Hard to detect if user accidentally forgot to have end declare in header file and had it in the include file or it was intentional. Reposito

[PATCH] D46140: [coroutines] std::task type (WIP)

GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. Herald added a subscriber: jfb. LGTM With couple of suggestions. 1. Remove swap. It is not part of the proposal at the moment. 2. If you feel like, add a lazy alias to task, that way

[PATCH] D51378: [OPENMP] Add support for nested 'declare target' directives

patricklyster added a comment. In https://reviews.llvm.org/D51378#1216600, @RaviNarayanaswamy wrote: > Is there a way to tell if the header files have matching omp declare > target/omp end declare target. > The reason is if one of the header files is missing a matching omp end > declare targ

[PATCH] D50892: [analyzer][UninitializedObjectChecker] Correct dynamic type is acquired for record pointees

NoQ accepted this revision. NoQ added a comment. Let's commit then? https://reviews.llvm.org/D50892 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51057: [analyzer][UninitializedObjectChecker] Fixed dereferencing

Szelethus added a comment. I managed to cause a bunch of crashes with this patch, so consider it as a work in progress for now :/ https://reviews.llvm.org/D51057 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D50892: [analyzer][UninitializedObjectChecker] Correct dynamic type is acquired for record pointees

Szelethus added inline comments. Comment at: test/Analysis/cxx-uninitialized-object-inheritance.cpp:802 +struct DynTBase2 { + int x; // expected-note{{uninitialized field 'static_cast(this->bptr)->DynTBase2::x'}} +}; NoQ wrote: > Szelethus wrote: > > NoQ wrote:

[PATCH] D51434: [HIP] Add -amdgpu-internalize-symbols option to opt

arsenm added a comment. In https://reviews.llvm.org/D51434#1218017, @yaxunl wrote: > In https://reviews.llvm.org/D51434#1217971, @arsenm wrote: > > > https://reviews.llvm.org/D51209 is the patch. I think HIP will need an > > additional patch, since I think it isn’t subclassing the amdgpu toolcha

[PATCH] D51441: Add predefined macro __gnu_linux__ for proper aux-triple

yaxunl added a comment. In https://reviews.llvm.org/D51441#1218010, @tra wrote: > While we're here, perhaps `Builder.defineMacro("__linux__")` should be > changed to `DefineStd("linux")` which defines `linux/__linux/__linux__`? Will do when committing. Thanks. https://reviews.llvm.org/D51441

[PATCH] D49074: [Analyzer] [WIP] Basic support for multiplication and division in the constraint manager

george.karpenkov added a comment. > where addition and subtraction is already supported? Is it though? From what I recall we had to disable it from the default set of options due to the fact that it gives rise to the exponential running time in some cases. I am somewhat afraid of similar unexpe

[PATCH] D51416: [RTTI] Align rtti type string to prevent over-alignment

efriedma added a comment. Could we make CreateOrReplaceCXXRuntimeVariable take the alignment as an argument, so we can be sure we're consistently setting the alignment for these variables? This seems easy to mess up if we're scattering calls all over the place. Sort of orthogonal, but CreateO

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

leonardchan added inline comments. Comment at: lib/AST/TypePrinter.cpp:1370 + +// Remove the underlying address space so it won't be printed. +SplitQualType SplitTy = T->getModifiedType().split(); rsmith wrote: > leonardchan wrote: > > rsmith wrote: > > >

[PATCH] D50892: [analyzer][UninitializedObjectChecker] Correct dynamic type is acquired for record pointees

NoQ added inline comments. Comment at: test/Analysis/cxx-uninitialized-object-inheritance.cpp:802 +struct DynTBase2 { + int x; // expected-note{{uninitialized field 'static_cast(this->bptr)->DynTBase2::x'}} +}; Szelethus wrote: > NoQ wrote: > > Mmm, what's the v

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

leonardchan updated this revision to Diff 163155. Repository: rC Clang https://reviews.llvm.org/D51329 Files: include/clang/AST/ASTContext.h include/clang/AST/Type.h include/clang/Lex/Preprocessor.h include/clang/Sema/ParsedAttr.h lib/AST/ASTContext.cpp lib/AST/TypePrinter.cpp li

[PATCH] D51434: [HIP] Add -amdgpu-internalize-symbols option to opt

yaxunl added a comment. In https://reviews.llvm.org/D51434#1217971, @arsenm wrote: > https://reviews.llvm.org/D51209 is the patch. I think HIP will need an > additional patch, since I think it isn’t subclassing the amdgpu toolchain Yes since HIP has different toolchain. This does not affect ke

r340954 - Revert "[libFuzzer] Port to Windows"

Author: morehouse Date: Wed Aug 29 11:40:41 2018 New Revision: 340954 URL: http://llvm.org/viewvc/llvm-project?rev=340954&view=rev Log: Revert "[libFuzzer] Port to Windows" This reverts r340949 due to bot breakage again. Modified: cfe/trunk/lib/Driver/ToolChains/MSVC.cpp Modified: cfe/trunk

[PATCH] D51441: Add predefined macro __gnu_linux__ for proper aux-triple

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. While we're here, perhaps `Builder.defineMacro("__linux__")` should be changed to `DefineStd("linux")` which defines `linux/__linux/__linux__`? https://reviews.llvm.org/D51441 __

[PATCH] D51448: [WebAssembly] clang-format (NFC)

aheejin created this revision. Herald added subscribers: cfe-commits, jfb, sunfish, jgravelle-google, sbc100, dschuff. This patch runs clang-format on all wasm-only files. Repository: rC Clang https://reviews.llvm.org/D51448 Files: lib/Driver/ToolChains/WebAssembly.cpp lib/Driver/ToolCh

r340953 - [OPENMP][NVPTX] Add support for lightweight runtime.

Author: abataev Date: Wed Aug 29 11:32:21 2018 New Revision: 340953 URL: http://llvm.org/viewvc/llvm-project?rev=340953&view=rev Log: [OPENMP][NVPTX] Add support for lightweight runtime. If the target construct can be executed in SPMD mode + it is a loop based directive with static scheduling, we

[PATCH] D51381: [clang-tidy] fix check_clang_tidy to properly mix CHECK-NOTES and CHECK-MESSAGES

lebedev.ri added a comment. In https://reviews.llvm.org/D51381#1217047, @JonasToth wrote: > @lebedev.ri lets do it in the the other patch, to not split discussions. Let's do it here instead, since that differential requires some changes to this script. In https://reviews.llvm.org/D51381#12170

[PATCH] D51434: [HIP] Add -amdgpu-internalize-symbols option to opt

arsenm added a comment. https://reviews.llvm.org/D51209 is the patch. I think HIP will need an additional patch, since I think it isn’t subclassing the amdgpu toolchain https://reviews.llvm.org/D51434 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D51440: [ToolChains] Link to compiler-rt with -L + -l when possible

manojgupta added a comment. In https://reviews.llvm.org/D51440#1217910, @mstorsjo wrote: > In https://reviews.llvm.org/D51440#1217839, @manojgupta wrote: > > > Just a minor comment regarding test cases: Since you are adding both > > -L/path/ and -l, the test cases should be updated to check fo

[PATCH] D51434: [HIP] Add -amdgpu-internalize-symbols option to opt

arsenm added a comment. I have a patch to change the default visibility which I think is a better option https://reviews.llvm.org/D51434 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D51441: Add predefined macro __gnu_linux__ for proper aux-triple

yaxunl updated this revision to Diff 163145. yaxunl added a comment. Revised by Artem's comments. https://reviews.llvm.org/D51441 Files: lib/Frontend/InitPreprocessor.cpp test/Preprocessor/predefined-macros.c Index: test/Preprocessor/predefined-macros.c ===

[PATCH] D51434: [HIP] Add -amdgpu-internalize-symbols option to opt

scott.linder added a reviewer: arsenm. scott.linder added a comment. +Matt to confirm, but our executable format is a shared object and we eventually want to support preemptible symbols through the PLT. We already generate GOT entries for globals. Currently we work around the lack of PLT suppor

r340949 - [libFuzzer] Port to Windows

Author: morehouse Date: Wed Aug 29 11:08:34 2018 New Revision: 340949 URL: http://llvm.org/viewvc/llvm-project?rev=340949&view=rev Log: [libFuzzer] Port to Windows Summary: Port libFuzzer to windows-msvc. This patch allows libFuzzer targets to be built and run on Windows, using -fsanitize=fuzzer

[PATCH] D51446: [OpenMP][bugfix] Add missing macros for Power

gtbercea created this revision. gtbercea added reviewers: ABataev, Hahnfeld, caomhin. Herald added subscribers: cfe-commits, guansong. Add missing macros when the auxiliary triple points to the PPC architecture. Repository: rC Clang https://reviews.llvm.org/D51446 Files: lib/Frontend/InitP

[PATCH] D51359: Adding HardLink Support to VirtualFileSystem.

ilya-biryukov added a comment. Could we try removing `Status` from the base class and move it into `InMemoryFile` and `InMemoryDir`? It shouldn't be too much work and would give safer interfaces for our new hierarchy. Comment at: lib/Basic/VirtualFileSystem.cpp:470 -enum In

[PATCH] D51440: [ToolChains] Link to compiler-rt with -L + -l when possible

mstorsjo added a comment. In https://reviews.llvm.org/D51440#1217839, @manojgupta wrote: > Just a minor comment regarding test cases: Since you are adding both -L/path/ > and -l, the test cases should be updated to check for the -L/path/ > argument as well. I guess I could do that, although

[PATCH] D51441: Add predefined macro __gnu_linux__ for proper aux-triple

tra added inline comments. Comment at: lib/Frontend/InitPreprocessor.cpp:1126 Builder.defineMacro("__linux__"); +if (AuxTriple.getEnvironment() == llvm::Triple::GNU) + Builder.defineMacro("__gnu_linux__"); AFAICT, we always define `__gnu_linix__` on

[PATCH] D51440: [ToolChains] Link to compiler-rt with -L + -l when possible

lebedev.ri added a comment. Since the libraries will no longer be specified with their full path, how will you know that the **right** library will be picked, the one compiler intended? Repository: rC Clang https://reviews.llvm.org/D51440 ___ cf

[PATCH] D51440: [ToolChains] Link to compiler-rt with -L + -l when possible

manojgupta added a comment. Just a minor comment regarding test cases: Since you are adding both -L/path/ and -l, the test cases should be updated to check for the -L/path/ argument as well. Repository: rC Clang https://reviews.llvm.org/D51440 __

r340941 - [MinGW] Don't mark external variables as DSO local

Author: mstorsjo Date: Wed Aug 29 10:26:58 2018 New Revision: 340941 URL: http://llvm.org/viewvc/llvm-project?rev=340941&view=rev Log: [MinGW] Don't mark external variables as DSO local Since MinGW supports automatically importing external variables from DLLs even without the DLLImport attribute,

[PATCH] D51382: [MinGW] Don't mark external variables as DSO local

This revision was automatically updated to reflect the committed changes. Closed by commit rC340941: [MinGW] Don't mark external variables as DSO local (authored by mstorsjo, committed by ). Repository: rC Clang https://reviews.llvm.org/D51382 Files: lib/CodeGen/CodeGenModule.cpp test/Cod

[PATCH] D51434: [HIP] Add -amdgpu-internalize-symbols option to opt

tra added a comment. I could not find anything about PLTs in AMDGPU-ABI , nor could I find anything relevant on google. I still have no idea why PLTs are required in this case. Without that info, the problem

[PATCH] D51333: Diagnose likely typos in include statements

christylee updated this revision to Diff 163132. christylee edited the summary of this revision. christylee added a comment. Merged warning with existing file_not_found_error. https://reviews.llvm.org/D51333 Files: include/clang/Basic/DiagnosticLexKinds.td lib/Lex/PPDirectives.cpp lib/Lex

  1   2   >