Author: jolesiak
Date: Sun Jul 8 23:54:52 2018
New Revision: 336520
URL: http://llvm.org/viewvc/llvm-project?rev=336520&view=rev
Log:
[clang-format/ObjC] Improve split priorities for ObjC methods
Reduce penalty for aligning ObjC method arguments using the colon alignment as
this is the canonical
balazske added inline comments.
Comment at: lib/AST/ASTImporter.cpp:6905
Decl *ToD = Pos->second;
+// FIXME: remove this call from this function
ASTNodeImporter(*this).ImportDefinitionIfNeeded(FromD, ToD);
I think this comment is not needed (or with
balazske marked an inline comment as done.
balazske added inline comments.
Comment at: unittests/AST/StructuralEquivalenceTest.cpp:489
+
+TEST_F(StructuralEquivalenceRecordTest, DISABLED_Methods) {
+ auto t = makeNamedDecls(
a_sidorin wrote:
> balazske wrote:
>
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336519: [clang-format/ObjC] Prohibit breaking after a
bracket opening ObjC method… (authored by jolesiak, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.ll
Author: jolesiak
Date: Sun Jul 8 23:04:58 2018
New Revision: 336519
URL: http://llvm.org/viewvc/llvm-project?rev=336519&view=rev
Log:
[clang-format/ObjC] Prohibit breaking after a bracket opening ObjC method
expression
Summary:
Don't break after a "[" opening an ObjC method expression.
Tests ar
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336518: [clang-format/ObjC] Fix counting selector name parts
for ObjC (authored by jolesiak, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D48716
Author: jolesiak
Date: Sun Jul 8 22:58:51 2018
New Revision: 336518
URL: http://llvm.org/viewvc/llvm-project?rev=336518&view=rev
Log:
[clang-format/ObjC] Fix counting selector name parts for ObjC
Summary:
Counts selector parts also for method declarations and counts correctly for
methods withou
a_sidorin accepted this revision.
a_sidorin added a comment.
LGTM too. Thank you!
Repository:
rC Clang
https://reviews.llvm.org/D48941
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
a_sidorin added inline comments.
Comment at: unittests/AST/StructuralEquivalenceTest.cpp:489
+
+TEST_F(StructuralEquivalenceRecordTest, DISABLED_Methods) {
+ auto t = makeNamedDecls(
balazske wrote:
> a_sidorin wrote:
> > Could you add a comment why this test is
a_sidorin added a comment.
Hi Gabor,
I like the new syntax. There are some comments inline; most of them are just
stylish.
Comment at: lib/AST/ASTImporter.cpp:94
+ void updateAttrAndFlags(const Decl *From, Decl *To) {
+// check if some flags or attrs are new in 'From' and
mstorsjo created this revision.
mstorsjo added reviewers: rnk, martell, compnerd, smeenai.
In this setup, skip adding all the default windows import libraries, if linking
to windowsapp (which replaces them, when targeting the windows store/UWP api
subset).
With GCC, the same is achieved by usin
NoQ added a comment.
Much symbols!
Comment at: lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp:126
+ NewSet = F.add(NewSet, RawPtr.getAsSymbol());
+ if (!NewSet.isEmpty()) {
+State = State->set(ObjRegion, NewSet);
rnkovacs wrote:
rnkovacs created this revision.
rnkovacs added reviewers: NoQ, xazax.hun, george.karpenkov.
Herald added subscribers: mikhail.ramalho, a.sidorin, dkrupp, szepet,
baloghadamsoftware, whisperity.
Repository:
rC Clang
https://reviews.llvm.org/D49058
Files:
include/clang/StaticAnalyzer/Checkers
rnkovacs added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp:121
+ if (State->contains(ObjRegion)) {
+NewSet = *State->get(ObjRegion);
+if (NewSet.contains(RawPtr.getAsSymbol()))
xazax.hun wrote:
>
rnkovacs updated this revision to Diff 154520.
rnkovacs marked an inline comment as done.
https://reviews.llvm.org/D49057
Files:
lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp
test/Analysis/dangling-internal-buffer.cpp
Index: test/Analysis/dangling-internal-buffer.cpp
xazax.hun added a comment.
Thanks! The changes look good, I forgot to mark one double lookup though in my
previous review.
Comment at: lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp:121
+ if (State->contains(ObjRegion)) {
+NewSet = *State->get(ObjRe
rnkovacs added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp:126
+ NewSet = F.add(NewSet, RawPtr.getAsSymbol());
+ if (!NewSet.isEmpty()) {
+State = State->set(ObjRegion, NewSet);
xazax.hun wrote:
> I
rnkovacs updated this revision to Diff 154519.
rnkovacs marked 5 inline comments as done.
rnkovacs edited the summary of this revision.
rnkovacs added a comment.
Addressed comments.
https://reviews.llvm.org/D49057
Files:
lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp
test/Ana
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D48712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
RKSimon added a comment.
LGTM - @craig.topper any comments?
https://reviews.llvm.org/D48712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
Overall looks good, some nits inline. Let's run it on some projects to exercise
this change.
Comment at: lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp:
rnkovacs created this revision.
rnkovacs added reviewers: NoQ, xazax.hun, george.karpenkov.
Herald added subscribers: mikhail.ramalho, a.sidorin, dkrupp, szepet,
baloghadamsoftware, whisperity.
Previously, the checker only tracked one raw pointer symbol for each container
object. But member func
22 matches
Mail list logo
