aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM as well, for what little it's worth. :-)
https://reviews.llvm.org/D47804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Hahnfeld abandoned this revision.
Hahnfeld added a comment.
See https://reviews.llvm.org/D47804
Repository:
rC Clang
https://reviews.llvm.org/D47201
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
Hahnfeld accepted this revision.
Hahnfeld added a subscriber: fwyzard.
Hahnfeld added a comment.
Works for me, I'll abandon https://reviews.llvm.org/D47201 if you prefer this.
https://reviews.llvm.org/D47804
___
cfe-commits mailing list
cfe-commits@
EricWF closed this revision.
EricWF added a comment.
r334069
Repository:
rCXX libc++
https://reviews.llvm.org/D46806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Tue Jun 5 23:42:27 2018
New Revision: 334069
URL: http://llvm.org/viewvc/llvm-project?rev=334069&view=rev
Log:
Remove unused code from __functional_base. NFC.
Patch from Arthur O'Dwyer.
`__user_alloc_construct_impl` is used by , but
this `__user_alloc_construct` is never us
mstorsjo accepted this revision.
mstorsjo added a comment.
Sounds sensible to me; I've tested the patch in the setup that showed the issue
this original patch tried to fix, and it seems to work fine there.
https://reviews.llvm.org/D38680
___
cfe-co
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334067: [Analyzer][Z3] Test fixes for Z3 constraint manager
(authored by vlad.tsyrklevich, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47726?vs=149786&id=150076#toc
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334067: [Analyzer][Z3] Test fixes for Z3 constraint manager
(authored by vlad.tsyrklevich, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47726
Author: vlad.tsyrklevich
Date: Tue Jun 5 23:25:51 2018
New Revision: 334067
URL: http://llvm.org/viewvc/llvm-project?rev=334067&view=rev
Log:
[Analyzer][Z3] Test fixes for Z3 constraint manager
Summary:
Since Z3 tests have been not been running [1] some tests needed to be
updated. I also added a
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334065: [Analyzer] Fix Z3ConstraintManager crash (PR37646)
(authored by vlad.tsyrklevich, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47617?vs=149796&id=150074#toc
Repository:
Author: vlad.tsyrklevich
Date: Tue Jun 5 23:09:02 2018
New Revision: 334065
URL: http://llvm.org/viewvc/llvm-project?rev=334065&view=rev
Log:
[Analyzer] Fix Z3ConstraintManager crash (PR37646)
Summary:
Fix another Z3ConstraintManager crash, use fixAPSInt() to extend a
boolean APSInt.
Reviewers:
EricWF added a comment.
I think we should sink the `DiagnoseUnavailableAlignedAllocation` into
`DiagnoseUseOfDecl`, and then adds call's in the few places they're needed.
Most paths we care about already pass through there.
Comment at: include/clang/Sema/Sema.h:5169
+ void
fidget324 abandoned this revision.
fidget324 added a comment.
That's fine. Your patch was much more thorough, anyways.
Repository:
rCXX libc++
https://reviews.llvm.org/D47802
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334063: [Fuchsia] Include install-distribution-stripped in
bootstrap targets (authored by phosek, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.o
Author: phosek
Date: Tue Jun 5 22:18:39 2018
New Revision: 334063
URL: http://llvm.org/viewvc/llvm-project?rev=334063&view=rev
Log:
[Fuchsia] Include install-distribution-stripped in bootstrap targets
This enables the use of install-distribution-stripped target in the
2-stage builds.
Differenti
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334062: [Sema] Fix parsing of anonymous union in language
linkage specification (authored by jkorous, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45884?vs=143736&id=150069#toc
Re
Author: jkorous
Date: Tue Jun 5 22:16:34 2018
New Revision: 334062
URL: http://llvm.org/viewvc/llvm-project?rev=334062&view=rev
Log:
[Sema] Fix parsing of anonymous union in language linkage specification
C++17 [dcl.link]p4:
A linkage specification does not establish a scope.
C++17 [class.union
Author: ctopper
Date: Tue Jun 5 21:51:52 2018
New Revision: 334061
URL: http://llvm.org/viewvc/llvm-project?rev=334061&view=rev
Log:
[X86] Move the vec_set/vec_ext builtins for 64-bit elements to
BuiltinsX86_64.def.
The instructions these correspond to and the intrinsics that use them are only
Quuxplusone planned changes to this revision.
Quuxplusone added a comment.
Once the dependencies (https://reviews.llvm.org/D47111 and
https://reviews.llvm.org/D47358) are merged, I need to update the unit tests in
this patch to reflect the unit tests that were committed. Right now, the unit
tes
Quuxplusone updated this revision to Diff 150067.
Quuxplusone edited the summary of this revision.
Quuxplusone added a comment.
Also, `` doesn't need a full definition of
`std::tuple`; just the forward declaration in `<__tuple>` will suffice.
Repository:
rCXX libc++
https://reviews.llvm.org/
EricWF added a comment.
In https://reviews.llvm.org/D45015#1123164, @ahatanak wrote:
> In https://reviews.llvm.org/D45015#1123097, @EricWF wrote:
>
> > In https://reviews.llvm.org/D45015#1121874, @ahatanak wrote:
> >
> > > I see, thank you.
> > >
> > > clang front-end currently fails to issue a w
ahatanak added a comment.
In https://reviews.llvm.org/D45015#1123097, @EricWF wrote:
> In https://reviews.llvm.org/D45015#1121874, @ahatanak wrote:
>
> > I see, thank you.
> >
> > clang front-end currently fails to issue a warning or error when an aligned
> > allocation/deallocation functions ar
NoQ added a comment.
In https://reviews.llvm.org/D47671#1122994, @george.karpenkov wrote:
> From my understanding, that's just how c++17 is defined, and that's unrelated
> to what compiler implementation is used.
Yeah, but this patch is specifically about supporting the pre-C++17 AST, where
c
rnk added a comment.
In https://reviews.llvm.org/D47672#1122013, @ethanhs wrote:
> In https://reviews.llvm.org/D47672#1121181, @rnk wrote:
>
> >
>
>
>
>
> > They are a hint to the processor that this is a short critical section, and
> > it is likely that the entire critical section can be entere
Author: rnk
Date: Tue Jun 5 18:44:10 2018
New Revision: 334060
URL: http://llvm.org/viewvc/llvm-project?rev=334060&view=rev
Log:
Fix std::tuple errors
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/tr
Author: rnk
Date: Tue Jun 5 18:35:08 2018
New Revision: 334059
URL: http://llvm.org/viewvc/llvm-project?rev=334059&view=rev
Log:
Implement bittest intrinsics generically for non-x86 platforms
I tested these locally on an x86 machine by disabling the inline asm
codepath and confirming that it doe
EricWF added a comment.
@fidget324 Thanks for the patch! Unfortunatly I didn't know you were planning
on contributing a fix, so I went ahead and fixed it myself in r334053.
Repository:
rCXX libc++
https://reviews.llvm.org/D47802
___
cfe-commits
tra added a comment.
Just to make it clear, I'm not against making a sensible default choice, but
rather want to make sure that it is possible to override it if the user needs
to.
https://reviews.llvm.org/D47376
___
cfe-commits mailing list
cfe-co
tra requested changes to this revision.
tra added a comment.
This revision now requires changes to proceed.
I'm not sure this is the right thing to do. What if user explicitly wants
device-side dependencies and runs `clang --cuda-device-only -M` ? This patch
makes it impossible.
I'd rather tell
Author: ctopper
Date: Tue Jun 5 17:24:55 2018
New Revision: 334057
URL: http://llvm.org/viewvc/llvm-project?rev=334057&view=rev
Log:
[X86] Add builtins for vector element insert and extract for different 128 and
256 bit vector types. Use them to implement the extract and insert intrinsics.
Prev
EricWF added a comment.
In https://reviews.llvm.org/D45015#1121874, @ahatanak wrote:
> I see, thank you.
>
> clang front-end currently fails to issue a warning or error when an aligned
> allocation/deallocation functions are required but not available in a few
> cases (e.g., delete called from
Author: ericwf
Date: Tue Jun 5 17:13:49 2018
New Revision: 334056
URL: http://llvm.org/viewvc/llvm-project?rev=334056&view=rev
Log:
Fix test failures after r334053.
Modified:
libcxx/trunk/test/std/containers/associative/map/map.cons/move.pass.cpp
libcxx/trunk/test/std/containers/associa
tra added a comment.
I'll wait to see if that fixes @Hahnfeld's problem.
AFAICT, nv_weak is not used for anything interesting other than the device-side
runtime stubs that return errors (apparently, until they are linked with the
proper device runtime which would have strong version of the symb
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
What could possibly go wrong.
https://reviews.llvm.org/D47804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
tra created this revision.
tra added reviewers: Hahnfeld, aaron.ballman, jlebar.
Herald added subscribers: bixia, sanjoy.
An alternative to implementing nv_weak attribute
(https://reviews.llvm.org/D47201).
The patch should make runtime sub functions to have .weak attribute in PTX and
that shoul
leonardchan added a comment.
@ebevhan Does everything look good in this patch? I'm almost done with the next
one. Writing tests for it still.
Repository:
rC Clang
https://reviews.llvm.org/D46911
___
cfe-commits mailing list
cfe-commits@lists.llv
tra added a comment.
I've experimented a bit and I think that we may not need this patch at all.
As far as I can tell, nv_weak is only applicable to __device__ functions. It's
ignored for __global__ kernels and is apparently forbidden for data.
For __device__ functions nvcc produces .weak attribu
tra added a comment.
With the updated patch description + the discussion I'm OK with the approach
from the general "how do we compile/use CUDA" point of view. I'll leave the
question of whether the approach works for OpenMP to someone more familiar with
it.
While I'm not completely convinced t
Author: ctopper
Date: Tue Jun 5 15:40:03 2018
New Revision: 334054
URL: http://llvm.org/viewvc/llvm-project?rev=334054&view=rev
Log:
[X86] Implement __builtin_ia32_vec_ext_v2si correctly even though we only use
it with an index of 0.
This builtin takes an index as its second operand, but the co
Author: ericwf
Date: Tue Jun 5 15:32:52 2018
New Revision: 334053
URL: http://llvm.org/viewvc/llvm-project?rev=334053&view=rev
Log:
Fix PR37694 - std::vector doesn't correctly move construct allocators.
C++2a[container.requirements.general]p8 states that when move constructing
a container, the a
Meinersbur added a comment.
In https://reviews.llvm.org/D47267#1123013, @dmgreen wrote:
> I see your point about the mix of underscores. "nounroll_and_jam" also comes
> from the Intel docs, and theres already "nounroll" vs "unroll". The "no"
> becomes a qualifier on "unroll_and_jam". "no_unroll
fidget324 created this revision.
fidget324 added reviewers: hiraditya, EricWF.
Herald added a subscriber: cfe-commits.
Fix an issue that was preventing std::vector from invoking the move
constructor on its allocator when appropriate.
Added a constructor to __vector_base which accepts an rvalue re
joerg updated this revision to Diff 150049.
joerg added a comment.
After a careful review of newer GCC / libgcc and the assembler annotations from
LLVM, I have come to the following conclusions:
(1) The semantics have been somewhat changed by GCC in recent years. There is
no actual specificatio
dmgreen added a comment.
I quite like the UnrollAndFuse naming. I'd not heard that the xlc compiler
called it that. The UnrollAndJam pass was origin named that before I renamed
for similar reasons (UnrollAndJam being more well known).
I see your point about the mix of underscores. "nounroll_and
xazax.hun added a comment.
In https://reviews.llvm.org/D47671#1122994, @george.karpenkov wrote:
> > So having an analyzer-config option would be useful for those codebases
> > that are expected to be compiled with less advanced compilers that do not
> > elide copies or not doing it aggressively
Author: ctopper
Date: Tue Jun 5 14:54:35 2018
New Revision: 334051
URL: http://llvm.org/viewvc/llvm-project?rev=334051&view=rev
Log:
[X86] Make __builtin_ia32_vec_ext_v2si require ICE for its index argument. Add
warnings for out of range indices for __builtin_ia32_vec_ext_v2si,
__builtin_ia32_v
george.karpenkov added a comment.
> So having an analyzer-config option would be useful for those codebases that
> are expected to be compiled with less advanced compilers that do not elide
> copies or not doing it aggressively enough.
I'm not sure it makes sense. From my understanding, that's
tra added a comment.
Looks OK overall, but I'm not very familiar with CGCall, so you may want to dig
through the history and find someone with more expertise.
Comment at: test/CodeGenCUDA/kernel-args-amdgcn.cu:1
+// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -fcuda-is-device -e
Sunil_Srivastava added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6729
def err_no_dynamic_cast_with_fno_rtti : Error<
- "cannot use dynamic_cast with -fno-rtti">;
+ "use of dynamic_cast requires enabling RTTI">;
wristow wrote:
>
Sunil_Srivastava updated this revision to Diff 150038.
Sunil_Srivastava added a comment.
Changed as per Paul's suggestion.
https://reviews.llvm.org/D47291
Files:
include/clang/Basic/DiagnosticSemaKinds.td
test/SemaCXX/no-rtti.cpp
Index: test/SemaCXX/no-rtti.cpp
===
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
As is the case with https://reviews.llvm.org/D47097, this helps preserve more
scope information after SROA. LGTM. Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D47720
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D46541
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
gramanas added inline comments.
Comment at: test/CodeGen/debug-info-inline-for.c:13
+
+// CHECK: ![[DbgLoc]] = !DILocation(
aprantl wrote:
> Shouldn't you also check *which* location is attached to it?
I wasn't sure if this should be an artificial location or not
gramanas updated this revision to Diff 150036.
gramanas marked an inline comment as done.
gramanas added a comment.
Add artificial debug location to the phi instruction
Repository:
rC Clang
https://reviews.llvm.org/D47720
Files:
lib/CodeGen/CGExprScalar.cpp
test/CodeGen/debug-info-inline
yunlian updated this revision to Diff 150028.
https://reviews.llvm.org/D44788
Files:
include/clang/Driver/Options.td
lib/Driver/ToolChains/CommonArgs.cpp
test/Driver/lto-dwo.c
Index: test/Driver/lto-dwo.c
===
--- /dev/null
++
craig.topper updated this revision to Diff 150027.
craig.topper added a comment.
Add subtract builtins to SemaChecking.cpp
Repository:
rC Clang
https://reviews.llvm.org/D47724
Files:
include/clang/Basic/BuiltinsX86.def
lib/CodeGen/CGBuiltin.cpp
lib/Headers/avx512fintrin.h
lib/Sema/Se
mcgrathr accepted this revision.
mcgrathr added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rC Clang
https://reviews.llvm.org/D47758
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
shuaiwang added a comment.
Thanks a lot for the review!
Could you also help commit this diff as well? Thanks!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45679
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
shuaiwang updated this revision to Diff 150026.
shuaiwang marked an inline comment as done.
shuaiwang added a comment.
Remove stale comment
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45679
Files:
clang-tidy/utils/CMakeLists.txt
clang-tidy/utils/ExprMutationAnalyzer.cpp
juliehockett added inline comments.
Comment at: clang-doc/YAMLGenerator.cpp:265
+// and thus register the generator.
+volatile int YAMLGeneratorAnchorSource = 0;
+
ioeric wrote:
> nit: add `static`?
`static` declares it as file-local, and so the `extern` referenc
GBuella marked an inline comment as done.
GBuella added inline comments.
Comment at: test/CodeGen/target-features-error-2.c:39
__m128d need_avx(__m128d a, __m128d b) {
return _mm_cmp_sd(a, b, 0); // expected-error {{'__builtin_ia32_cmpsd' needs
target feature avx}}
}
--
GBuella updated this revision to Diff 150018.
https://reviews.llvm.org/D46541
Files:
lib/CodeGen/CodeGenFunction.cpp
lib/CodeGen/CodeGenModule.cpp
lib/CodeGen/CodeGenModule.h
test/CodeGen/target-features-error-2.c
test/CodeGen/target-features-error.c
Index: test/CodeGen/target-features
pcc added inline comments.
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:435
+ CmdArgs.push_back(
+ Args.MakeArgString(Twine("-plugin-opt=objcopy=") + Objcopy));
+ CmdArgs.push_back(
You no longer need to pass `objcopy=`, see D47091.
https
wristow added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6729
def err_no_dynamic_cast_with_fno_rtti : Error<
- "cannot use dynamic_cast with -fno-rtti">;
+ "use of dynamic_cast requires enabling RTTI">;
probinson wrote:
> wristow
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
I'm happy to refactor this after landing it as is, or you can do it if you like.
Comment at: lib/CodeGen/CGBuiltin.cpp:2808
case Builtin::BI_setjmpex: {
if (getTarget
Author: sammccall
Date: Tue Jun 5 11:00:48 2018
New Revision: 334033
URL: http://llvm.org/viewvc/llvm-project?rev=334033&view=rev
Log:
[clangd] Fix inverted test again, sigh
Modified:
clang-tools-extra/trunk/clangd/Quality.cpp
Modified: clang-tools-extra/trunk/clangd/Quality.cpp
URL:
http:
Author: sammccall
Date: Tue Jun 5 10:58:12 2018
New Revision: 334032
URL: http://llvm.org/viewvc/llvm-project?rev=334032&view=rev
Log:
[clangd] Quality fixes (uninit var, missing debug output, pattern decl CCRs).
Modified:
clang-tools-extra/trunk/clangd/Quality.cpp
Modified: clang-tools-ext
On Tue, Jun 5, 2018 at 2:33 AM Martin Storsjö wrote:
> > // Many of MSVC builtins are on both x64 and ARM; to avoid repeating
> code, we
> > // handle them here.
>
> This doesn't seem thought through wrt non-x86 architectures. I'm not sure
> if there's any similar suitable instruction to use on A
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: clangd/Quality.cpp:33
+static SymbolQualitySignals::SymbolCategory categorize(const NamedDecl &ND) {
+ class Switch
Have you considered `
Meinersbur added a comment.
In https://reviews.llvm.org/D47267#1122425, @dmgreen wrote:
> I noticed in the paper that you used the name "unrollandjam", minus
> underscores. Should I change this use that spelling here? I have no strong
> opinion of one over the other (was just using what I had f
yunlian marked an inline comment as done.
yunlian added a comment.
Herald added a subscriber: steven_wu.
ping?
https://reviews.llvm.org/D44788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
alekseyshl abandoned this revision.
alekseyshl added a comment.
Experimental.
Repository:
rC Clang
https://reviews.llvm.org/D47600
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aprantl added inline comments.
Comment at: test/CodeGen/debug-info-inline-for.c:13
+
+// CHECK: ![[DbgLoc]] = !DILocation(
Shouldn't you also check *which* location is attached to it?
Repository:
rC Clang
https://reviews.llvm.org/D47720
__
probinson added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6729
def err_no_dynamic_cast_with_fno_rtti : Error<
- "cannot use dynamic_cast with -fno-rtti">;
+ "use of dynamic_cast requires enabling RTTI">;
wristow wrote:
> Sunil_S
trixirt updated this revision to Diff 150003.
trixirt added a comment.
cleanup of last patch
Repository:
rC Clang
https://reviews.llvm.org/D47554
Files:
include/clang/AST/ExprCXX.h
include/clang/ASTMatchers/ASTMatchers.h
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/AST/ExprC
sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ilya-biryukov.
Numbers are guesses to be adjusted later.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47787
Files:
clangd/Quality.cpp
clangd/Quali
ioeric added inline comments.
Comment at: unittests/clangd/QualityTests.cpp:1
//===-- SourceCodeTests.cpp *- C++
-*-===//
//
sammccall wrote:
> ioeric wrote:
> > sammccall wrote:
> > > ioeric wrote:
> > > > Could you also a
Author: sammccall
Date: Tue Jun 5 09:30:25 2018
New Revision: 334026
URL: http://llvm.org/viewvc/llvm-project?rev=334026&view=rev
Log:
[clangd] Boost code completion results that are narrowly scoped (local, members)
Summary:
This signal is considered a relevance rather than a quality signal beca
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334026: [clangd] Boost code completion results that are
narrowly scoped (local, members) (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https:/
sammccall marked an inline comment as done.
sammccall added inline comments.
Comment at: unittests/clangd/QualityTests.cpp:1
//===-- SourceCodeTests.cpp *- C++
-*-===//
//
ioeric wrote:
> sammccall wrote:
> > ioeric wrote:
juliehockett updated this revision to Diff 149997.
juliehockett marked 3 inline comments as done.
juliehockett added a comment.
Fixing comments
https://reviews.llvm.org/D43667
Files:
clang-doc/CMakeLists.txt
clang-doc/Generators.cpp
clang-doc/Generators.h
clang-doc/Representation.h
cl
martong added a comment.
> Are you OK with incremental review?
Hi Aleksei, thanks for reviewing this! Of course I am OK with an incremental
review. Just a minor thing, I'll be back in the office only at the 18th, so I
can address all of the comments only then.
Repository:
rC Clang
https://
Anastasia added inline comments.
Comment at: test/Sema/address_spaces.c:17
int *_AS1 _AS2 *Z; // expected-error {{multiple address spaces specified
for type}}
+ int *_AS1 _AS1 *M;
ebevhan wrote:
> bader wrote:
> > I think it might be valuable to give a wa
craig.topper added inline comments.
Comment at: test/CodeGen/target-features-error-2.c:39
__m128d need_avx(__m128d a, __m128d b) {
return _mm_cmp_sd(a, b, 0); // expected-error {{'__builtin_ia32_cmpsd' needs
target feature avx}}
}
GBuella wrote:
> craig.top
gramanas updated this revision to Diff 149996.
gramanas added a comment.
Add comment explaining the test
Repository:
rC Clang
https://reviews.llvm.org/D47720
Files:
test/CodeGen/debug-info-inline-for.c
Index: test/CodeGen/debug-info-inline-for.c
==
ruiu added a comment.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D47669
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
GBuella added inline comments.
Comment at: test/CodeGen/target-features-error-2.c:39
__m128d need_avx(__m128d a, __m128d b) {
return _mm_cmp_sd(a, b, 0); // expected-error {{'__builtin_ia32_cmpsd' needs
target feature avx}}
}
craig.topper wrote:
> The 4 com
craig.topper added inline comments.
Comment at: test/CodeGen/target-features-error-2.c:39
__m128d need_avx(__m128d a, __m128d b) {
return _mm_cmp_sd(a, b, 0); // expected-error {{'__builtin_ia32_cmpsd' needs
target feature avx}}
}
The 4 compare functions he
Author: yaxunl
Date: Tue Jun 5 08:11:02 2018
New Revision: 334021
URL: http://llvm.org/viewvc/llvm-project?rev=334021&view=rev
Log:
[CUDA][HIP] Do not emit type info when compiling for device
CUDA/HIP does not support RTTI on device side, therefore there
is no point of emitting type info when co
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334021: [CUDA][HIP] Do not emit type info when compiling for
device (authored by yaxunl, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D47694
Files:
lib/CodeGen/CodeGenModule.cpp
t
arm-chrjan01 created this revision.
arm-chrjan01 added reviewers: simon_tatham, majnemer, rnk.
Herald added subscribers: cfe-commits, chrib.
Repository:
rC Clang
https://reviews.llvm.org/D47784
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/ms-setjmp.c
Index: test/CodeGen/ms-setjmp.c
ioeric added a comment.
fyi, you could actually accept your own patch phab (e.g. when you would like
post-commit review) :P
Repository:
rL LLVM
https://reviews.llvm.org/D47737
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
dmgreen added a comment.
Thanks.
I noticed in the paper that you used the name "unrollandjam", minus
underscores. Should I change this use that spelling here? I have no strong
opinion of one over the other (was just using what I had found from the Intel
docs).
https://reviews.llvm.org/D47267
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334018: [clangd] Remove unused variables (authored by
malaperle, committed by ).
Herald added a subscriber: llvm-commits.
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE334018: [clangd] Remove unused variables (authored by
malaperle, committed by ).
Changed prior to commit:
https://rev
Author: malaperle
Date: Tue Jun 5 07:07:45 2018
New Revision: 334018
URL: http://llvm.org/viewvc/llvm-project?rev=334018&view=rev
Log:
[clangd] Remove unused variables
Summary: Signed-off-by: Marc-Andre Laperle
Subscribers: klimek, ilya-biryukov, ioeric, MaskRay, jkorous, cfe-commits
Differen
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334017: [clangd] Add "member" symbols to the index
(authored by malaperle, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D44954
Files:
clang-t
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE334017: [clangd] Add "member" symbols to the
index (authored by malaperle, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44954?vs=149532&id=149970#toc
Repository:
rCTE Clang To
Author: malaperle
Date: Tue Jun 5 07:01:40 2018
New Revision: 334017
URL: http://llvm.org/viewvc/llvm-project?rev=334017&view=rev
Log:
[clangd] Add "member" symbols to the index
Summary:
This adds more symbols to the index:
- member variables and functions
- enum constants in scoped enums
The c
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: clangd/Quality.cpp:70
+return SymbolRelevanceSignals::ClassScope;
+ if (D.getLinkageInternal() < ExternalLinkage)
+return SymbolRelevanceSignals::Fi
1 - 100 of 131 matches
Mail list logo
