rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land.
lgtm I'm happy to refactor this after landing it as is, or you can do it if you like. ================ Comment at: lib/CodeGen/CGBuiltin.cpp:2808 case Builtin::BI_setjmpex: { if (getTarget().getTriple().isOSMSVCRT()) { llvm::Type *ArgTypes[] = {Int8PtrTy, Int8PtrTy}; ---------------- We should probably refactor all this to use shared code. Repository: rC Clang https://reviews.llvm.org/D47784 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits