ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
================
Comment at: clangd/Quality.cpp:33
+static SymbolQualitySignals::SymbolCategory categorize(const NamedDecl &ND) {
+ class Switch
----------------
Have you considered `index::getSymbolInfo(ND)` and reusing the other
`categorize`?
================
Comment at: clangd/Quality.cpp:51
+ MAP(FunctionTemplateDecl, Function);
+ MAP(Decl, Unknown);
+ };
----------------
ni: `#undefine MAP`?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47787
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
