Author: courbet
Date: Wed May 16 23:46:15 2018
New Revision: 332576
URL: http://llvm.org/viewvc/llvm-project?rev=332576&view=rev
Log:
Fix rL332458: [AST] Added a helper to extract a user-friendly text of a comment.
Older gcc versions do not support raw string literals within macros.
Modified:
dberris created this revision.
dberris added reviewers: dblaikie, echristo.
This is related to http://llvm.org/PR32274.
When building with XRay, always depend on a C++ standard library.
We're doing this to automate the linking of the C++ ABI functionality
that the modes use by default. In partic
tzik added a comment.
In https://reviews.llvm.org/D46929#1101780, @rnk wrote:
> I searched around, and I noticed that `VTableContext::getMethodVTableIndex`
> has the same implied contract that the caller must always provide a canonical
> declaration or things will break. It looks like it has th
tzik updated this revision to Diff 147244.
Repository:
rC Clang
https://reviews.llvm.org/D46929
Files:
lib/AST/VTableBuilder.cpp
lib/CodeGen/CGCXX.cpp
lib/CodeGen/ItaniumCXXABI.cpp
lib/CodeGen/MicrosoftCXXABI.cpp
test/CodeGenCXX/PR37481.cpp
Index: test/CodeGenCXX/PR37481.cpp
===
Author: bion
Date: Wed May 16 21:59:34 2018
New Revision: 332571
URL: http://llvm.org/viewvc/llvm-project?rev=332571&view=rev
Log:
[libcxx] [test] Remove unused local typedef in
test/std/numerics/rand/rand.eng/rand.eng.lcong/default.pass.cpp
Modified:
libcxx/trunk/test/std/numerics/rand/rand
tzik marked an inline comment as done.
tzik added inline comments.
Comment at: test/SemaCXX/PR24986.cpp:12
+ f<&__uuidof(0)>();
+}
thakis wrote:
> Maybe this test could be in test/SemaCXX/ms-uuid.cpp instead?
OK, moved there.
Repository:
rC Clang
https://re
tzik updated this revision to Diff 147238.
Repository:
rC Clang
https://reviews.llvm.org/D46820
Files:
lib/Sema/SemaTemplate.cpp
test/SemaCXX/ms-uuid.cpp
Index: test/SemaCXX/ms-uuid.cpp
===
--- test/SemaCXX/ms-uuid.cpp
+++ t
waltl updated this revision to Diff 147233.
waltl added a comment.
Address CR comments
Repository:
rL LLVM
https://reviews.llvm.org/D46452
Files:
clang/lib/Driver/ToolChains/CommonArgs.cpp
Index: clang/lib/Driver/ToolChains/CommonArgs.cpp
=
rjmccall added a comment.
In https://reviews.llvm.org/D46665#1102348, @rsmith wrote:
> In https://reviews.llvm.org/D46665#1102290, @rjmccall wrote:
>
> > I believe static and dynamic linkers — at least on ELF and Mach-O — will
> > always drop weak symbols for strong ones. Now, I think that isn'
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D45900
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Author: bion
Date: Wed May 16 19:58:26 2018
New Revision: 332567
URL: http://llvm.org/viewvc/llvm-project?rev=332567&view=rev
Log:
Add void casts to suppress nodiscard on linear_congruential_engine.
Modified:
libcxx/trunk/test/std/numerics/rand/rand.eng/rand.eng.lcong/assign.pass.cpp
libc
rsmith added a comment.
In https://reviews.llvm.org/D46665#1102413, @efriedma wrote:
> What exactly is the asan odr checker actually checking for? The distinction
> between common/linkonce_odr/linkonce/weak_odr/weak only affects IR
> optimizers, not code generation.
It's checking that there
efriedma added a comment.
What exactly is the asan odr checker actually checking for? The distinction
between common/linkonce_odr/linkonce/weak_odr/weak only affects IR optimizers,
not code generation.
Repository:
rC Clang
https://reviews.llvm.org/D46665
dexonsmith added a comment.
In https://reviews.llvm.org/D46834#1102407, @rsmith wrote:
> In https://reviews.llvm.org/D46834#1102395, @dexonsmith wrote:
>
> > In https://reviews.llvm.org/D46834#1102391, @rsmith wrote:
> >
> > > The policy certainly seems designed around the CLI use case. For
> >
rsmith added a comment.
In https://reviews.llvm.org/D46834#1102395, @dexonsmith wrote:
> In https://reviews.llvm.org/D46834#1102391, @rsmith wrote:
>
> > The policy certainly seems designed around the CLI use case. For serialized
> > diagnostics, it would make sense to either serialize the snipp
jlebar created this revision.
jlebar added a reviewer: tra.
Herald added subscribers: llvm-commits, sanjoy.
Herald added a reviewer: EricWF.
Repository:
rT test-suite
https://reviews.llvm.org/D46995
Files:
External/CUDA/complex.cu
Index: External/CUDA/complex.cu
===
dexonsmith added a comment.
In https://reviews.llvm.org/D46834#1102391, @rsmith wrote:
> In https://reviews.llvm.org/D46834#1101586, @jkorous wrote:
>
> > We reconsidered this in light of the policy - thanks for pointing that out
> > Richard!
> > Just to be sure that I understand it - the poli
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
https://reviews.llvm.org/D46993
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
rsmith added a comment.
In https://reviews.llvm.org/D46834#1101586, @jkorous wrote:
> We reconsidered this in light of the policy - thanks for pointing that out
> Richard!
> Just to be sure that I understand it - the policy is meant for CLI and not
> serialized diagnostics, right?
The polic
jlebar created this revision.
jlebar added a reviewer: tra.
Herald added subscribers: llvm-commits, mgorny, sanjoy.
Previously (https://reviews.llvm.org/D46993) std::min/max didn't work in C++14
mode with a C++11
stdlib; we'd assumed that compiler std=c++14 implied stdlib in C++14
mode.
Reposit
jlebar created this revision.
jlebar added a reviewer: rsmith.
Herald added a subscriber: sanjoy.
https://reviews.llvm.org/D46993
Files:
clang/lib/Headers/cuda_wrappers/algorithm
Index: clang/lib/Headers/cuda_wrappers/algorithm
=
rsmith added a comment.
In https://reviews.llvm.org/D46665#1102361, @efriedma wrote:
> The only difference between weak_odr and linkonce_odr is that the LLVM
> optimizers can discard linkonce_odr globals. From your description, you want
> to remove the odr-ness, by changing the linkage to "lin
efriedma added a comment.
The only difference between weak_odr and linkonce_odr is that the LLVM
optimizers can discard linkonce_odr globals. From your description, you want
to remove the odr-ness, by changing the linkage to "linkonce", I think?
That said, I don't think the usage here violates
On 17 February 2017 at 18:03, Richard Smith wrote:
> On 22 July 2016 at 21:05, Faisal Vali via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: faisalv
>> Date: Fri Jul 22 23:05:19 2016
>> New Revision: 276514
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=276514&view=rev
>> Lo
rsmith added a comment.
In https://reviews.llvm.org/D46665#1102290, @rjmccall wrote:
> I believe static and dynamic linkers — at least on ELF and Mach-O — will
> always drop weak symbols for strong ones. Now, I think that isn't LLVM's
> posted semantics for linkonce_odr, but to me that means t
leonardchan created this revision.
leonardchan added reviewers: phosek, mcgrathr, jakehehrlich.
leonardchan added a project: clang.
This patch contains changes for multiplication on saturated _Fract types.
Since we already upcast the underlying integer for the fixed point type, we can
do a simpl
rjmccall added a comment.
I believe static and dynamic linkers — at least on ELF and Mach-O — will always
drop weak symbols for strong ones. Now, I think that isn't LLVM's posted
semantics for linkonce_odr, but to me that means that LLVM's semantics are
inadequate, not that we should decline t
leonardchan created this revision.
leonardchan added reviewers: phosek, mcgrathr, jakehehrlich.
leonardchan added a project: clang.
This patch includes the logic for subtraction on saturated _Fract types and a
test for thm.
- Also fixed incorrect minimum value for each _Fract type
- Getters for
Author: george.karpenkov
Date: Wed May 16 15:46:47 2018
New Revision: 332544
URL: http://llvm.org/viewvc/llvm-project?rev=332544&view=rev
Log:
[analyzer] Change the warning message for GCD antipattern checker
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/GCDAntipatternChecker.cpp
cfe/tr
Author: george.karpenkov
Date: Wed May 16 15:47:05 2018
New Revision: 332546
URL: http://llvm.org/viewvc/llvm-project?rev=332546&view=rev
Log:
[analyzer] Extend ObjCAutoreleaseWriteChecker to catch block declarations with
autoreleasing variables
Differential Revision: https://reviews.llvm.org/D4
Author: george.karpenkov
Date: Wed May 16 15:47:03 2018
New Revision: 332545
URL: http://llvm.org/viewvc/llvm-project?rev=332545&view=rev
Log:
[ASTMatchers] Introduce a blockDecl matcher for matching block declarations
Blocks can be matched just as well as functions or Objective-C methods.
Diffe
leonardchan created this revision.
leonardchan added reviewers: phosek, mcgrathr, jakehehrlich.
leonardchan added a project: clang.
This patch contains tests for validating the logic behind each builtin
operation on fixed point types and tests on addition between saturated _Fract
types.
- More
Author: pcc
Date: Wed May 16 15:40:12 2018
New Revision: 332543
URL: http://llvm.org/viewvc/llvm-project?rev=332543&view=rev
Log:
Condition usage of locale stdlib functions on Android API version
Some *_l functions were not available in some versions of Bionic. This CL
checks that the NDK version
Sunil_Srivastava created this revision.
Sunil_Srivastava added a reviewer: filcab.
Herald added a subscriber: cfe-commits.
NFC for targets other than PS4.
This patch is a change in behavior for PS4, in that PS4 will no longer enable
RTTI when -fexceptions is specified (RTTI and Exceptions are dis
majnemer added inline comments.
Comment at: lib/CodeGen/CGException.cpp:1164
+ CurrentFuncletPad);
+ llvm::BasicBlock *CatchStartBlock = nullptr;
+ if (EHPersonality::get(*this).isWasmPersonality()) {
Maybe this should be called WasmCatchStartBlock?
rsmith added a comment.
This is causing ASan's ODR violation detector to fire. I think the problematic
case looks like this:
TU 1:
struct X;
/*...*/ typeid(X*); /*...*/
TU 2:
struct X { virtual void f(); };
void X::f() {}
Now, TU 1 will emit a `linkonce_odr` definition of the `_ZTS`
rkirsling added a comment.
If there are no objections to this change, may I request a commit based on the
approval that @jfb provided?
Repository:
rC Clang
https://reviews.llvm.org/D46024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
saar.raz updated this revision to Diff 147190.
saar.raz added a comment.
Adjusted to changes in dependent patches.
Repository:
rC Clang
https://reviews.llvm.org/D44352
Files:
include/clang/AST/DeclTemplate.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/AST/TemplateBase.h
inc
mikerice added a comment.
In https://reviews.llvm.org/D46652#1101952, @kimgr wrote:
>
> - Can you test what happens when you do `clang-cl.exe /Yc stdafx.h /Tp
> stdafx.h`, i.e. compile the header directly as C++ code and generate .pch
> from it? The normal MSVC modus operandi is to have st
saar.raz updated this revision to Diff 147188.
saar.raz added a comment.
- Fixed handling of empty/non-expression after trailing requires keyword.
- Unified satisfaction check for templated/non-templated constraint exprs
Repository:
rC Clang
https://reviews.llvm.org/D43357
Files:
include/c
leonardchan created this revision.
leonardchan added reviewers: phosek, mcgrathr, jakehehrlich.
leonardchan added a project: clang.
This patch contains changes and a test for checking that fixed point types can
be converted between all other valid types. Fixed point types can be converted
betwee
saar.raz updated this revision to Diff 147187.
saar.raz added a comment.
- Adjusted constraint normalization to piecewise constraint substitution
- Normalized constraints are now represented as described in the standard (a
non-substituted expression along with a list of "template arguments").
R
Also few other builders are affected:
http://lab.llvm.org:8011/builders/clang-x86_64-linux-abi-test
http://lab.llvm.org:8011/builders/clang-lld-x86_64-2stage
http://lab.llvm.org:8011/builders/clang-with-lto-ubuntu
Thanks
Galina
On Wed, May 16, 2018 at 12:58 PM, Galina Kistanova
wrote:
> Hell
mclow.lists added a comment.
I should probably add some tests for the implicit deduction guides, too.
https://reviews.llvm.org/D46975
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erik.pilkington accepted this revision.
erik.pilkington added a comment.
Great, LGTM!
https://reviews.llvm.org/D46747
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jkorous updated this revision to Diff 147184.
jkorous added a comment.
This revision is now accepted and ready to land.
After some internal discussion we agreed that we can simplify things and get
consistent behaviour by using dot everywhere in diagnostics.
This is pretty much revert of r219124
r332520 fixed the broken build in clangd.
On Wed, May 16, 2018 at 9:48 PM Eric Liu wrote:
> Looking... sorry that I missed the email from this bot.
>
> On Wed, May 16, 2018 at 9:43 PM Galina Kistanova
> wrote:
>
>> Hello Eric,
>>
>> This commit broke one of our builders:
>> http://lab.llvm.org:
mclow.lists created this revision.
mclow.lists added a reviewer: EricWF.
Based off of
http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0433r2.html
https://reviews.llvm.org/D46975
Files:
include/deque
test/std/containers/sequences/deque/deque.cons/deduct.pass.cpp
Index: test/std/c
Author: ioeric
Date: Wed May 16 13:31:38 2018
New Revision: 332520
URL: http://llvm.org/viewvc/llvm-project?rev=332520&view=rev
Log:
Second attempt to fix buildbot failure caused by r332363
http://lab.llvm.org:8011/builders/clang-x86_64-linux-abi-test/builds/26501
Modified:
clang-tools-extra
jkorous added a comment.
LGTM but my review was fairly superficial.
Comment at: utils/hmaptool/hmaptool:55
+# The number of buckets must be a power of two.
+if num_buckets == 0 or (num_buckets & num_buckets - 1) != 0:
+raise SystemExit("e
ioeric updated this revision to Diff 147167.
ioeric added a comment.
- Add vfs::FileSystem::getRealPath; change getCanonicalName to use getRealPath
Repository:
rC Clang
https://reviews.llvm.org/D46942
Files:
include/clang/Basic/VirtualFileSystem.h
lib/Basic/FileManager.cpp
lib/Basic/Vi
DavidKreitzer added a comment.
This looks good to me, Craig. I am not worried about the constant folding
issue, as I think constant folding these conversion intrinsics (assuming
round-to-nearest) is a perfectly valid optimization in the absence of
FENV_ACCESS. (FWIW, we don't do this constant f
kimgr added a comment.
I've done some terrible things with MSVC PCHs over the years, so I'll pile on
some more questions:
- Can you test what happens when you do `clang-cl.exe /Yc stdafx.h /Tp
stdafx.h`, i.e. compile the header directly as C++ code and generate .pch from
it? The normal MSVC m
aaron.ballman closed this revision.
aaron.ballman added a comment.
Committed in r332519, thank you for the patch!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45702
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
Author: aaronballman
Date: Wed May 16 13:12:06 2018
New Revision: 332519
URL: http://llvm.org/viewvc/llvm-project?rev=332519&view=rev
Log:
Add a new check, readability-simplify-subscript-expr, that diagnoses array
subscript expressions that can be simplified.
Currently, diagnoses code that calls
Author: ioeric
Date: Wed May 16 13:10:10 2018
New Revision: 332518
URL: http://llvm.org/viewvc/llvm-project?rev=332518&view=rev
Log:
[clang-move] Fix a potential bug where realpath doesn't work on VFS.
Modified:
clang-tools-extra/trunk/clang-move/ClangMove.cpp
Modified: clang-tools-extra/tru
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332516: [clang-tidy/google-readability-casting] Disable
check for Objective-C++ (authored by benhamilton, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.ll
Author: benhamilton
Date: Wed May 16 13:07:19 2018
New Revision: 332516
URL: http://llvm.org/viewvc/llvm-project?rev=332516&view=rev
Log:
[clang-tidy/google-readability-casting] Disable check for Objective-C++
Summary:
Previously, `google-readability-casting` was disabled for Objective-C.
The Go
benhamilton added inline comments.
Comment at: clang-tidy/google/AvoidCStyleCastsCheck.cpp:103-104
// The rest of this check is only relevant to C++.
- if (!getLangOpts().CPlusPlus)
+ // We also disable it for Objective-C++.
+ if (!getLangOpts().CPlusPlus || getLangOpts().O
malaperle added a comment.
@ioeric You mentioned in https://reviews.llvm.org/D46751 that it would make
sense to add a flag to disable indexing members. Could you comment on that?
What kind of granularity were you thinking? Would a "member" flag cover both
class members (member vars and function
Author: ioeric
Date: Wed May 16 12:59:49 2018
New Revision: 332515
URL: http://llvm.org/viewvc/llvm-project?rev=332515&view=rev
Log:
Attempt to fix buildbot failure caused by r332363
Log: http://lab.llvm.org:8011/builders/clang-x86_64-linux-abi-test/builds/26399
Modified:
clang-tools-extra/t
Hello Ilya,
This commit broke build step for couple of our builders:
http://lab.llvm.org:8011/builders/clang-with-lto-ubuntu/builds/8541
http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu
. . .
FAILED:
tools/clang/unittests/AST/CMakeFiles/ASTTests.dir/CommentTextTest.cpp.o
/usr/bin/c++
Looking... sorry that I missed the email from this bot.
On Wed, May 16, 2018 at 9:43 PM Galina Kistanova
wrote:
> Hello Eric,
>
> This commit broke one of our builders:
> http://lab.llvm.org:8011/builders/clang-x86_64-linux-abi-test/builds/26399
>
> . . .
> 387.403 [725/64/4163] Building CXX obj
Hello Eric,
This commit broke one of our builders:
http://lab.llvm.org:8011/builders/clang-x86_64-linux-abi-test/builds/26399
. . .
387.403 [725/64/4163] Building CXX object
tools/clang/tools/extra/clangd/CMakeFiles/clangDaemon.dir/CodeComplete.cpp.o
FAILED:
tools/clang/tools/extra/clangd/CMakeFi
yaxunl abandoned this revision.
yaxunl added a comment.
I have updated https://reviews.llvm.org/D46476 to skip backend and assembler
phases for amdgcn, therefore this patch is no longer needed.
https://reviews.llvm.org/D46489
___
cfe-commits mailin
yaxunl updated this revision to Diff 147156.
yaxunl added a comment.
Skip backend and assemmbler phases for amdgcn since it does not support linking
of object files.
https://reviews.llvm.org/D46476
Files:
lib/Driver/Driver.cpp
test/Driver/cuda-phases.cu
Index: test/Driver/cuda-phases.cu
=
stephanemoore accepted this revision.
stephanemoore added inline comments.
Comment at: clang-tidy/google/AvoidCStyleCastsCheck.cpp:103-104
// The rest of this check is only relevant to C++.
- if (!getLangOpts().CPlusPlus)
+ // We also disable it for Objective-C++.
+ if (!ge
whitequark updated this revision to Diff 147153.
whitequark added a comment.
Reuploaded diff with context.
Repository:
rUNW libunwind
https://reviews.llvm.org/D46971
Files:
src/DwarfInstructions.hpp
Index: src/DwarfInstructions.hpp
whitequark created this revision.
whitequark added a reviewer: compnerd.
Herald added a subscriber: JDevlieghere.
If prolog info lists the RA register as unused, it means that
the current stack frame corresponds to a leaf function which never
needs to save the RA register. The RA register is of co
sbc100 added a comment.
ping
Repository:
rCXX libc++
https://reviews.llvm.org/D46443
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: whitequark
Date: Wed May 16 12:09:48 2018
New Revision: 332513
URL: http://llvm.org/viewvc/llvm-project?rev=332513&view=rev
Log:
[OR1K] Add the EPCR special-purpose register to register state.
This makes it possible to unwind hardware exception stack frames,
which necessarily save every r
Author: whitequark
Date: Wed May 16 12:09:41 2018
New Revision: 332512
URL: http://llvm.org/viewvc/llvm-project?rev=332512&view=rev
Log:
[OR1K] Add a dedicated PC register to register state.
Before this commit, R9, the link register, was used as PC register.
However, a stack frame may have R9 not
rnk added a comment.
@hans @thakis, do you remember how these flags are supposed to work? I've
forgotten anything I ever knew about them...
https://reviews.llvm.org/D46652
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332509: [Sema] Fix assertion when constructor is disabled
with partially specialized… (authored by vsapsai, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://revi
Author: vsapsai
Date: Wed May 16 11:28:58 2018
New Revision: 332509
URL: http://llvm.org/viewvc/llvm-project?rev=332509&view=rev
Log:
[Sema] Fix assertion when constructor is disabled with partially specialized
template.
The added test case was triggering assertion
> Assertion failed:
> (!Spec
rnk added a comment.
I searched around, and I noticed that `VTableContext::getMethodVTableIndex` has
the same implied contract that the caller must always provide a canonical
declaration or things will break. It looks like it has three callers, and they
all do this. We should probably sink the
vsapsai added a comment.
Thanks for the quick review, Richard. I'll keep in mind the idea with comparing
results of multiple lookups when I work on other partial specialization-related
bugs.
https://reviews.llvm.org/D46909
___
cfe-commits mailing
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:1560-1566
// If the size is known to be zero, we're done.
if (StateZeroSize && !StateNonZeroSize) {
StateZeroSize = StateZeroSize->BindExpr(CE, LCtx, DstVal);
shuaiwang added a comment.
In https://reviews.llvm.org/D45702#1101136, @aaron.ballman wrote:
> In https://reviews.llvm.org/D45702#1097294, @shuaiwang wrote:
>
> > Addressed review comments.
>
>
> This patch was approved; do you need someone to commit this for you?
Yes please :)
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332506: [Timers] TimerGroup: add constructor from
StringMap (authored by lebedevri, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46939?vs=147055&id=147140#toc
Reposito
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332504: [Timers] TimerGroup::printJSONValue(): print doubles
with no precision loss (authored by lebedevri, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46937?vs=147053&id=147138#t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332505: [Timers] TimerGroup: make printJSONValues() method
public (authored by lebedevri, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46938?vs=147054&id=147139#toc
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332503: [Timers] TimerGroup::printJSONValues(): print mem
timer with .mem suffix (authored by lebedevri, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46936?vs=147052&id=147137#toc
lebedev.ri added inline comments.
Comment at: clang-tidy/tool/ClangTidyMain.cpp:188
+format to stderr. When this option is passed,
+these per-TU profiles are instead stored as YAML.)"),
+ cl::value_desc("prefix"),
Quux
Quuxplusone added inline comments.
Comment at: clang-tidy/tool/ClangTidyMain.cpp:188
+format to stderr. When this option is passed,
+these per-TU profiles are instead stored as YAML.)"),
+ cl::value_desc("prefix"),
Dri
mclow.lists created this revision.
mclow.lists added a reviewer: EricWF.
According to
http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0433r2.html
Once this is reviewed, I'll do the rest of the sequence containers.
https://reviews.llvm.org/D46964
Files:
include/array
test/std/cont
jdenny updated this revision to Diff 147130.
jdenny retitled this revision from "[Attr] Fix printing attrs for enum forward
decl at file scope" to "[Attr] Fix loss of enum forward decl from decl context".
jdenny edited the summary of this revision.
jdenny added a comment.
Made the suggested chang
leonardchan updated this revision to Diff 147131.
Repository:
rC Clang
https://reviews.llvm.org/D46963
Files:
lib/AST/ASTContext.cpp
lib/CodeGen/CGExprScalar.cpp
test/Frontend/fixed_point_all_builtin_operations.c
Index: test/Frontend/fixed_point_all_builtin_operations.c
george.karpenkov added a comment.
> Not sure yet whether i will land them right away, or wait for clang-tidy part.
I think it's better to land, as otherwise you risk merge conflicts, and
implicit conflicts (git reports no errors, but the resulting code is bad) can
be very annoying.
Repository
lebedev.ri added a comment.
In https://reviews.llvm.org/D46603#1101047, @lebedev.ri wrote:
> In https://reviews.llvm.org/D46603#1100455, @george.karpenkov wrote:
>
> > I see four separate changes: s/.sys/mem one (can be committed without
> > review), exposing printJSONValues and consequent addin
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D46937
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
ebevhan added inline comments.
Comment at: lib/StaticAnalyzer/Core/RegionStore.cpp:1344
// This is a signed value, since it's used in arithmetic with signed indices.
- return svalBuilder.makeIntVal(RegionSize / EleSize, false);
+ return svalBuilder.makeIntVal(RegionSize / El
leonardchan created this revision.
leonardchan added reviewers: phosek, mcgrathr, jakehehrlich.
leonardchan added a project: clang.
This patch includes a test for checking that all supported builtin operations
can be syntactically declared with fixed point types. Tests for asserting the
correctn
lebedev.ri updated this revision to Diff 147120.
lebedev.ri marked 2 inline comments as done.
lebedev.ri added a comment.
Rename getter/setter functions.
Thank you for taking a look!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46602
Files:
clang-tidy/ClangTidy.cpp
clang
jkorous abandoned this revision.
jkorous added a comment.
We reconsidered this in light of the policy - thanks for pointing that out
Richard!
Just to be sure that I understand it - the policy is meant for CLI and not
serialized diagnostics, right?
Repository:
rC Clang
https://reviews.llvm.
erichkeane added a comment.
Woops, forgot the tests when commiting, so see R332492 for the lit tests.
Repository:
rC Clang
https://reviews.llvm.org/D43352
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
Author: erichkeane
Date: Wed May 16 10:04:47 2018
New Revision: 332492
URL: http://llvm.org/viewvc/llvm-project?rev=332492&view=rev
Log:
Add lit tests forgotten for R332470
I forgot to svn-add the lit tests for R332470.
Added here!
Added:
cfe/trunk/test/CodeGenCXX/code_seg1.cpp (with pro
Author: bruno
Date: Wed May 16 10:00:24 2018
New Revision: 332491
URL: http://llvm.org/viewvc/llvm-project?rev=332491&view=rev
Log:
[Modules] Do not diagnose missing import in recovery mode if there isn't a decl
to lookup
Clang often tries to create implicit module import for error recovery,
whi
a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.
So, we fail to add injected name to a CXXRecordDecl that has a described class
template? Nice catch! LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D46958
___
leonardchan created this revision.
leonardchan added reviewers: phosek, mcgrathr, jakehehrlich.
leonardchan added a project: clang.
This patch contains the addition of the precision macros for integral and
fractional bits according to clause 7.18a.3 of
http://www.open-std.org/jtc1/sc22/wg14/www/
1 - 100 of 210 matches
Mail list logo
