rsmith added a comment.

In https://reviews.llvm.org/D46665#1102361, @efriedma wrote:

> The only difference between weak_odr and linkonce_odr is that the LLVM 
> optimizers can discard linkonce_odr globals.  From your description, you want 
> to remove the odr-ness, by changing the linkage to "linkonce", I think?


The odr-ness is fine; the definitions are all the same. The symbol emitted with 
the key function should be non-discardable, which is why I'm suggesting we 
change the linkage to `weak_odr` rather than changing it to `linkonce_odr`.


Repository:
  rC Clang

https://reviews.llvm.org/D46665



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to