lebedev.ri added a comment. In https://reviews.llvm.org/D46603#1101047, @lebedev.ri wrote:
> In https://reviews.llvm.org/D46603#1100455, @george.karpenkov wrote: > > > I see four separate changes: s/.sys/mem one (can be committed without > > review), exposing printJSONValues and consequent adding of a lock, adding a > > constructor accepting a map, and fixing formatting in `printJSONValue`. All > > four look good to me, but probably should be reviewed separately. > > > Thank you for taking a look! > Posted as https://reviews.llvm.org/D46936, https://reviews.llvm.org/D46937, > https://reviews.llvm.org/D46938, https://reviews.llvm.org/D46939 @alexfh & @george.karpenkov Thanks for reviewing those! Not sure yet whether i will land them right away, or wait for clang-tidy part. Repository: rL LLVM https://reviews.llvm.org/D46603 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
