r317993 - Fix AST matcher documentation typo

2017-11-11 Thread Dave Lee via cfe-commits
Author: kastiglione Date: Sat Nov 11 15:53:27 2017 New Revision: 317993 URL: http://llvm.org/viewvc/llvm-project?rev=317993&view=rev Log: Fix AST matcher documentation typo Modified: cfe/trunk/docs/LibASTMatchersReference.html cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h Modified: c

[PATCH] D39940: Add ObjC exception statement AST matchers

2017-11-11 Thread Dave Lee via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL317992: Add ObjC exception statement AST matchers (authored by kastiglione). Repository: rL LLVM https://reviews.llvm.org/D39940 Files: cfe/trunk/docs/LibASTMatchersReference.html cfe/trunk/includ

r317992 - Add ObjC exception statement AST matchers

2017-11-11 Thread Dave Lee via cfe-commits
Author: kastiglione Date: Sat Nov 11 14:46:15 2017 New Revision: 317992 URL: http://llvm.org/viewvc/llvm-project?rev=317992&view=rev Log: Add ObjC exception statement AST matchers Summary: Add AST matchers for Objective-C @throw, @try, @catch and @finally. Reviewers: aaron.ballman, malcolm.parso

[PATCH] D39462: [Sema] Implement -Wmaybe-tautological-constant-compare for when the tautologicalness is data model dependent

2017-11-11 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. In https://reviews.llvm.org/D39462#917421, @rjmccall wrote: > So, that change makes this very interesting, because I think the right way of > looking at it is as the first in a larger family of warnings that attempt to > treat typedefs as if they were a much stronger

[PATCH] D38216: [C++17] Fix class template argument deduction for default constructors without an initializer

2017-11-11 Thread Zhihao Yuan via Phabricator via cfe-commits
lichray added a comment. In https://reviews.llvm.org/D38216#922709, @Rakete wrote: > @lichray Isn't [dcl.type.auto.deduct] only for `auto` and `decltype(auto)`? Sorry, reasoned on a confusingly similar part... Here is updated information: > 10.1.7.5 [dcl.type.class.deduct] > If a placehol

[PATCH] D39161: [bindings] remove unique_external test failure

2017-11-11 Thread Masud Rahman via Phabricator via cfe-commits
frutiger abandoned this revision. frutiger added a comment. Fixed by r317986. https://reviews.llvm.org/D39161 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39810: [python] [tests] Fix test_linkage for unique external linkage

2017-11-11 Thread Michał Górny via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL317986: [python] [tests] Fix test_linkage for unique external linkage (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D39810?vs=122575&id=122590#toc Repository: rL LLVM https

r317986 - [python] [tests] Fix test_linkage for unique external linkage

2017-11-11 Thread Michal Gorny via cfe-commits
Author: mgorny Date: Sat Nov 11 12:01:41 2017 New Revision: 317986 URL: http://llvm.org/viewvc/llvm-project?rev=317986&view=rev Log: [python] [tests] Fix test_linkage for unique external linkage Starting with r314037, anonymous namespaces no longer give unique-external linkage to variables. Howev

[PATCH] D39940: Add ObjC exception statement AST matchers

2017-11-11 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D39940 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D39810: [python] [tests] Fix test_linkage for unique external linkage

2017-11-11 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D39810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D39166: [NFC] Add some assertions to placate my paranoia about sharing a variant bit across FunctionDecl and CXXDeductionGuideDecl - should I do this?

2017-11-11 Thread Faisal Vali via Phabricator via cfe-commits
faisalv abandoned this revision. faisalv added a comment. Just added an additional bit-field to FunctionDecl in https://reviews.llvm.org/rL317984 Comment at: include/clang/AST/InlineDeclMembers.h:35 + +#endif //LLVM_CLANG_AST_INLINEDECLMEMBERS_H + aaron.ballm

r317984 - Adjust r316292 - remove the anonymous union for sharing a bitfield in FunctionDecl.

2017-11-11 Thread Faisal Vali via cfe-commits
Author: faisalv Date: Sat Nov 11 10:02:29 2017 New Revision: 317984 URL: http://llvm.org/viewvc/llvm-project?rev=317984&view=rev Log: Adjust r316292 - remove the anonymous union for sharing a bitfield in FunctionDecl. The anonymous union did NOT save us storage, but instead behaved as if we adde

r317983 - [cxx_status] Add resolution of CWG issue 1581, since it's an important, visible change.

2017-11-11 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sat Nov 11 10:00:16 2017 New Revision: 317983 URL: http://llvm.org/viewvc/llvm-project?rev=317983&view=rev Log: [cxx_status] Add resolution of CWG issue 1581, since it's an important, visible change. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_st

r317982 - [cxx_status] Update for moved Albuquerque papers.

2017-11-11 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sat Nov 11 09:54:46 2017 New Revision: 317982 URL: http://llvm.org/viewvc/llvm-project?rev=317982&view=rev Log: [cxx_status] Update for moved Albuquerque papers. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL: http://llvm.org/viewvc/

[PATCH] D39940: Add ObjC exception statement AST matchers

2017-11-11 Thread Dave Lee via Phabricator via cfe-commits
kastiglione created this revision. Herald added a subscriber: klimek. Add AST matchers for Objective-C @throw, @try, @catch and @finally. https://reviews.llvm.org/D39940 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp

[PATCH] D39768: [coroutines] Promote cleanup.dest.slot allocas to registers to avoid storing it in the coroutine frame

2017-11-11 Thread Gor Nishanov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL317981: [coroutines] Promote cleanup.dest.slot allocas to registers to avoid storing it… (authored by GorNishanov). Changed prior to commit: https://reviews.llvm.org/D39768?vs=122004&id=122585#toc Repo

r317981 - [coroutines] Promote cleanup.dest.slot allocas to registers to avoid storing it in the coroutine frame

2017-11-11 Thread Gor Nishanov via cfe-commits
Author: gornishanov Date: Sat Nov 11 09:00:43 2017 New Revision: 317981 URL: http://llvm.org/viewvc/llvm-project?rev=317981&view=rev Log: [coroutines] Promote cleanup.dest.slot allocas to registers to avoid storing it in the coroutine frame Summary: We don't want to store cleanup dest slot saved

[PATCH] D39641: [CodeGen] make cbrt and fma constant (never set errno)

2017-11-11 Thread Sanjay Patel via Phabricator via cfe-commits
spatel updated this revision to Diff 122584. spatel marked an inline comment as done. spatel added a comment. Patch updated: 1. Fix predicate for detecting MSVC - isOSMSVCRT(). 2. Use switch on BuiltinID instead of string matching for "fma". https://reviews.llvm.org/D39641 Files: include/cla

[PATCH] D38216: [C++17] Fix class template argument deduction for default constructors without an initializer

2017-11-11 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete added a comment. @lichray Isn't [dcl.type.auto.deduct] only for `auto` and `decltype(auto)`? Class template argument deduction is in [dcl.type.class.deduct], which doesn't seem to disallow declarations without an initializer. About that `extern` business, yes that's indeed counter in

[PATCH] D38216: [C++17] Fix class template argument deduction for default constructors without an initializer

2017-11-11 Thread Zhihao Yuan via Phabricator via cfe-commits
lichray added a comment. The standard hasn't allowed deducing any placeholder type without an initializer (10.1.7.4.1 [dcl.type.auto.deduct]/2) yet. It's unclear to me what extern A x; wants to archive. Usually when people writing `extern` then expect an initializer to appear somewhere els

Re: r315614 - [Sema] Diagnose tautological comparison with type's min/max values

2017-11-11 Thread Roman Lebedev via cfe-commits
On Fri, Nov 10, 2017 at 9:14 PM, Hans Wennborg wrote: > On Thu, Oct 12, 2017 at 2:33 PM, Roman Lebedev via cfe-commits > wrote: >> On Fri, Oct 13, 2017 at 12:12 AM, Nico Weber wrote: >>> Huh, I consider clang not warning on this a feature, not a bug. Why are we >>> trying to match what gcc does

[PATCH] D38216: [C++17] Fix class template argument deduction for default constructors without an initializer

2017-11-11 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 122576. Rakete added a comment. Slight change + rebased + friendly ping :) https://reviews.llvm.org/D38216 Files: lib/Sema/SemaDecl.cpp test/CXX/dcl.dcl/dcl.spec/dcl.type/dcl.type.class.deduct/p1.cpp test/Parser/cxx1z-class-template-argument-de

[PATCH] D39810: [python] [tests] Fix test_linkage for unique external linkage

2017-11-11 Thread Michał Górny via Phabricator via cfe-commits
mgorny updated this revision to Diff 122575. mgorny retitled this revision from "[clang] [python] [tests] Disable the broken unique-external linkage test" to "[python] [tests] Fix test_linkage for unique external linkage". mgorny edited the summary of this revision. mgorny added reviewers: jbcoe,

[PATCH] D39937: [Sema] Improve diagnostics for const- and ref-qualified member functions

2017-11-11 Thread Jacob Bandes-Storch via Phabricator via cfe-commits
jtbandes created this revision. Adjust wording for const-qualification mismatch to be a little more clear. Also add another diagnostic for a ref qualifier mismatch, which previously produced a useless error (this error path is simply very old; see https://reviews.llvm.org/rL119336): Before: