On Fri, Nov 10, 2017 at 9:14 PM, Hans Wennborg <h...@chromium.org> wrote: > On Thu, Oct 12, 2017 at 2:33 PM, Roman Lebedev via cfe-commits > <cfe-commits@lists.llvm.org> wrote: >> On Fri, Oct 13, 2017 at 12:12 AM, Nico Weber <tha...@chromium.org> wrote: >>> Huh, I consider clang not warning on this a feature, not a bug. Why are we >>> trying to match what gcc does here? >> Because i have been bitten by this more than once. >> It did result in big amount of wasted time, and this "thread": >> https://lists.llvm.org/pipermail/llvm-dev/2017-August/116390.html >> >> As with all the clang diagnostics, you can disable them >> I personally don't have any opinion on comparisons with >> std::numeric_limits<...>::{min,max}()
> To disable the new warning Will the https://reviews.llvm.org/D39462 address the reasons for disabling it? > but keep the ones we used to have enabled, > we now need to pass -Wno-tautological-constant-compare > -Wtautological-unsigned-zero-compare > -Wtautological-constant-out-of-range-compare, which is quite a > mouthful. It would perhaps be better if the new warning could have > been behind a flag that could be disabled separately. _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
