mgorny updated this revision to Diff 122575.
mgorny retitled this revision from "[clang] [python] [tests] Disable the broken 
unique-external linkage test" to "[python] [tests] Fix test_linkage for unique 
external linkage".
mgorny edited the summary of this revision.
mgorny added reviewers: jbcoe, aaron.ballman, frutiger.
mgorny added a comment.
Yay, I've found a way to get the desired linkage! ;-)


https://reviews.llvm.org/D39810

Files:
  bindings/python/tests/cindex/test_linkage.py


Index: bindings/python/tests/cindex/test_linkage.py
===================================================================
--- bindings/python/tests/cindex/test_linkage.py
+++ bindings/python/tests/cindex/test_linkage.py
@@ -15,7 +15,8 @@
         tu = get_tu("""
 void foo() { int no_linkage; }
 static int internal;
-namespace { extern int unique_external; }
+namespace { struct unique_external_type {} }
+unique_external_type unique_external;
 extern int external;
 """, lang = 'cpp')
 


Index: bindings/python/tests/cindex/test_linkage.py
===================================================================
--- bindings/python/tests/cindex/test_linkage.py
+++ bindings/python/tests/cindex/test_linkage.py
@@ -15,7 +15,8 @@
         tu = get_tu("""
 void foo() { int no_linkage; }
 static int internal;
-namespace { extern int unique_external; }
+namespace { struct unique_external_type {} }
+unique_external_type unique_external;
 extern int external;
 """, lang = 'cpp')
 
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to