NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
> these kinds of tasks should have the same level of attention as others
Dunno really. I'm not sure anybody actually reads that doc instead of
accidentally finding the checker code by debugging how
Quolyk updated this revision to Diff 122395.
Quolyk retitled this revision from "[clangd][WIP] -foptimization-record-file=
should imply -fsave-optimization-record" to "[clangd]
-foptimization-record-file= should imply -fsave-optimization-record".
Quolyk added a comment.
Added 1 test, I guess it'
NoQ added a comment.
In https://reviews.llvm.org/D39862#921075, @george.karpenkov wrote:
> Of course I'm new, but I disagree with this statement: in order to have a
> robust API, the function should not crash, unless the caller violates an
> explicit precondition.
> `getSVal` is just a functio
dberris added a comment.
Reverted in https://reviews.llvm.org/rL317877 -- I'm going to try again next
week instead.
Repository:
rL LLVM
https://reviews.llvm.org/D39114
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
Author: dberris
Date: Thu Nov 9 23:00:55 2017
New Revision: 317877
URL: http://llvm.org/viewvc/llvm-project?rev=317877&view=rev
Log:
Revert "[XRay][darwin] Initial XRay in Darwin Support"
This reverts r317875.
Modified:
cfe/trunk/include/clang/Driver/XRayArgs.h
cfe/trunk/lib/Driver/Tool
dberris added a comment.
Landing now, will deal with the test and dynamic/
Comment at: compiler-rt/trunk/lib/xray/xray_trampoline_x86_64.S:75
- .globl __xray_FunctionEntry
+ .globl ASM_TSAN_SYMBOL(__xray_FunctionEntry)
.align 16, 0x90
kuba
kubamracek added inline comments.
Comment at: compiler-rt/trunk/lib/xray/xray_trampoline_x86_64.S:75
- .globl __xray_FunctionEntry
+ .globl ASM_TSAN_SYMBOL(__xray_FunctionEntry)
.align 16, 0x90
Since we want to use `ASM_TSAN_SYMBOL` outside
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317875: [XRay][darwin] Initial XRay in Darwin Support
(authored by dberris).
Changed prior to commit:
https://reviews.llvm.org/D39114?vs=122352&id=122391#toc
Repository:
rL LLVM
https://reviews.llvm
Author: dberris
Date: Thu Nov 9 21:50:13 2017
New Revision: 317875
URL: http://llvm.org/viewvc/llvm-project?rev=317875&view=rev
Log:
[XRay][darwin] Initial XRay in Darwin Support
Summary:
This change implements the changes required in both clang and
compiler-rt to allow building XRay-instrumente
t-tye accepted this revision.
t-tye added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D39877
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Author: ctopper
Date: Thu Nov 9 21:20:32 2017
New Revision: 317873
URL: http://llvm.org/viewvc/llvm-project?rev=317873&view=rev
Log:
[X86] Reduce the number of FMA builtins needed by the frontend by adding
negates to operands of the fmadd and fmaddsub builtins.
The backend should be able to com
tk1012 created this revision.
This patch fixes wrong conflict detections for unnamed structures.
Current ASTImporter mistakenly identifies two different unnamed structs as the
same one.
This is because ASTImporter checks the name of each RecordDecl for the conflict
identification and the both of
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/CopyConstructorInitCheck.cpp:69
+ (Ctor->getAccess() == AS_private || Ctor->isDeleted())) {
+NonCopyableBase = true;
+break;
xazax.hun wrote:
> aaron.ballman wrote:
> > What
t-tye accepted this revision.
t-tye added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D39878
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
aaron.ballman added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:1502-1503
+evaluated at compile-time;
+ - A dependent integral value which depends on one or more template arguments,
+be they type or non-type e.g. ``sizeof(T)`` within the scope of
+``
jakehehrlich updated this revision to Diff 122382.
jakehehrlich added a comment.
fixed typo
Repository:
rL LLVM
https://reviews.llvm.org/D39821
Files:
CMakeLists.txt
include/clang/Config/config.h.cmake
lib/Driver/ToolChains/CommonArgs.cpp
Index: lib/Driver/ToolChains/CommonArgs.cpp
=
On Nov 9, 2017, at 12:13, Reimar Döffinger wrote:
>
> Hello!
>
> On Wed, Nov 08, 2017 at 12:36:00PM -0800, Volodymyr Sapsai wrote:
>> Thanks for the patch, Reimar. Can you please add tests to ensure this
>> functionality doesn’t regress? As null character is required by the standard
>> (27.7.2
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317860: [Driver] Make clang/cc conforms to UNIX standard
(authored by steven_wu).
Repository:
rL LLVM
https://reviews.llvm.org/D39502
Files:
cfe/trunk/lib/Driver/Compilation.cpp
cfe/trunk/test/Dri
Author: steven_wu
Date: Thu Nov 9 17:32:47 2017
New Revision: 317860
URL: http://llvm.org/viewvc/llvm-project?rev=317860&view=rev
Log:
[Driver] Make clang/cc conforms to UNIX standard
Summary:
This is basically reverting r261774 with a tweak for clang-cl. UNIX
standard states:
When c99 encounter
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM for CUDA-related functionality & tests. Thank you for the patch!
https://reviews.llvm.org/D39502
___
cfe-commits mailing list
cfe-commits@lists.ll
steven_wu updated this revision to Diff 122376.
steven_wu added a comment.
Add more tests! The new tests can trigger two errors during the compilation
but only one should be emitted.
https://reviews.llvm.org/D39502
Files:
lib/Driver/Compilation.cpp
test/Driver/cuda-bail-out.cu
test/Driver
Author: eugenezelenko
Date: Thu Nov 9 16:59:22 2017
New Revision: 317854
URL: http://llvm.org/viewvc/llvm-project?rev=317854&view=rev
Log:
[AST] Fix some Clang-tidy modernize and Include What You Use warnings; other
minor fixes (NFC).
Modified:
cfe/trunk/include/clang/AST/ASTUnresolvedSet.h
tra added inline comments.
Comment at: test/Driver/cuda-bail-out.cu:47
+// CHECK-HOST-ERROR: Error during compilation for host
+// CHECK-HOST-ERROR-NOT: Error during compilation for sm_35
steven_wu wrote:
> tra wrote:
> > steven_wu wrote:
> > > tra wrote:
> > > >
sammccall created this revision.
This allows us to limit the number of results we return and still allow them
to be surfaced by refining a query (https://reviews.llvm.org/D39852).
The initial algorithm is very conservative - it accepts a completion if the
filter is any case-insensitive sub-sequen
steven_wu updated this revision to Diff 122372.
steven_wu added a comment.
I think I understand what you mean now. You want some cases when the
compilation doesn't failed on the first source it process.
I add a testcase which compiles for host + sm_35 + sim_60. I run the test
3 times and each tim
vsk updated this revision to Diff 122368.
vsk edited the summary of this revision.
vsk added a comment.
- Consider logical nots and some binary comparison operators in the hash, per
an offline conversation with @bogner
https://reviews.llvm.org/D39446
Files:
lib/CodeGen/CodeGenPGO.cpp
test/
steven_wu added inline comments.
Comment at: test/Driver/cuda-bail-out.cu:47
+// CHECK-HOST-ERROR: Error during compilation for host
+// CHECK-HOST-ERROR-NOT: Error during compilation for sm_35
tra wrote:
> steven_wu wrote:
> > tra wrote:
> > > steven_wu wrote:
>
hfinkel added a comment.
In https://reviews.llvm.org/D39611#918654, @hfinkel wrote:
> In https://reviews.llvm.org/D39611#918275, @spatel wrote:
>
> > Patch updated:
> > I don't know if we have agreement on the behavior that we want yet,
>
>
> I just sent a note to the Austin group mailing list t
tra added inline comments.
Comment at: test/Driver/cuda-bail-out.cu:47
+// CHECK-HOST-ERROR: Error during compilation for host
+// CHECK-HOST-ERROR-NOT: Error during compilation for sm_35
steven_wu wrote:
> tra wrote:
> > steven_wu wrote:
> > > tra wrote:
> > > >
kzhuravl created this revision.
Herald added subscribers: tpr, dstuttard, yaxunl, nhaehnle, wdng.
https://reviews.llvm.org/D39879
Files:
include/clang/Driver/Options.td
lib/Driver/ToolChains/AMDGPU.cpp
test/Driver/amdgpu-features.c
Index: test/Driver/amdgpu-features.c
kzhuravl created this revision.
Herald added subscribers: tpr, dstuttard, yaxunl, nhaehnle, wdng.
https://reviews.llvm.org/D39878
Files:
include/clang/Driver/Options.td
test/Driver/amdgpu-features.c
Index: test/Driver/amdgpu-features.c
===
kzhuravl created this revision.
Herald added subscribers: tpr, dstuttard, yaxunl, nhaehnle, wdng.
https://reviews.llvm.org/D39877
Files:
lib/Driver/ToolChains/AMDGPU.cpp
lib/Driver/ToolChains/AMDGPU.h
lib/Driver/ToolChains/Clang.cpp
Index: lib/Driver/ToolChains/Clang.cpp
==
dberris updated this revision to Diff 122352.
dberris retitled this revision from "[XRay] Initial XRay in Darwin Support" to
"[XRay][darwin] Initial XRay in Darwin Support".
dberris edited the summary of this revision.
dberris removed subscribers: echristo, pelikan.
dberris added a comment.
This r
jlebar added a comment.
I abdicate as a reviewer in favor of tra -- if he's happy, I'm happy.
https://reviews.llvm.org/D39502
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: george.karpenkov
Date: Thu Nov 9 15:33:37 2017
New Revision: 317849
URL: http://llvm.org/viewvc/llvm-project?rev=317849&view=rev
Log:
[analyzer] [NFC] Minor ExprEngineC refactoring
Move a repeated block of code into a function.
Differential Revision: https://reviews.llvm.org/D39584
Mod
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317849: [analyzer] [NFC] Minor ExprEngineC refactoring
(authored by george.karpenkov).
Changed prior to commit:
https://reviews.llvm.org/D39584?vs=121814&id=122345#toc
Repository:
rL LLVM
https://re
dberris planned changes to this revision.
dberris added a comment.
In https://reviews.llvm.org/D39114#920591, @kubamracek wrote:
> > When linking the final binary, the XRay runtime can't seem to find the
> > `__{start,stop}_xray_{fn_idx,instr_map}` symbols. I've marked them weak,
> > but they s
sammccall updated this revision to Diff 122342.
sammccall added a comment.
Oops, sorting was backwards (test caught it, but I forgot to run it)
https://reviews.llvm.org/D39852
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/ClangdUnit.cpp
clangd/
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Yes, looks great. Thanks!
https://reviews.llvm.org/D39584
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
nathawes planned changes to this revision.
nathawes added a comment.
In https://reviews.llvm.org/D39050#920451, @ioeric wrote:
> In https://reviews.llvm.org/D39050#900830, @arphaman wrote:
>
> > I think this patch should be split into a number of smaller patches to help
> > the review process.
>
francisco.lopes added a comment.
OK. I do agree serialization, etc, is a stumbling block on delivering large
results fast. I just wanted to warn on this because I've just seen ycmd devs
went through this, where sorting was one of the bottlenecks, like, to
`std::sort` 43k results instead of simp
sammccall added a comment.
In https://reviews.llvm.org/D39738#921103, @francisco.lopes wrote:
> I'm still in the process of construction of a general jsonrpc/LSP client and
> didn't start consuming clangd yet.
If you concerns about clangd's responsiveness, I recommend testing using
VSCode, wh
francisco.lopes added a comment.
I'm still in the process of construction a general jsonrpc client and didn't
start consuming clangd yet. But, I do have previous experience with libclang,
and I don't know whether clangd will be able to return completion results at
global scope (not necessarily
jdenny updated this revision to Diff 122329.
jdenny added a comment.
Hi Alexey. Thanks for your comments. This update should address them all.
https://reviews.llvm.org/D39859
Files:
lib/Sema/SemaExpr.cpp
test/OpenMP/parallel_firstprivate_messages.cpp
Index: test/OpenMP/parallel_firstpri
AlexVlx updated this revision to Diff 122327.
https://reviews.llvm.org/D39857
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/CodeGen/TargetInfo.cpp
lib/Sema/SemaDeclAttr.cpp
Index: lib/Sema/SemaDeclAttr.cpp
=
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317839: [analyzer] do not crash when trying to convert an
APSInt to an unexpected type (authored by george.karpenkov).
Changed prior to commit:
https://reviews.llvm.org/D39862?vs=122306&id=122328#toc
R
Author: george.karpenkov
Date: Thu Nov 9 13:49:38 2017
New Revision: 317839
URL: http://llvm.org/viewvc/llvm-project?rev=317839&view=rev
Log:
[analyzer] do not crash when trying to convert an APSInt to an unexpected type
This is the issue breaking the postgresql bot, purely by chance exposed
thr
george.karpenkov added a comment.
> I'm curious if the crash would turn into an assertion failure during
> getRawSVal() after https://reviews.llvm.org/D38801 is committed.
I guess we would see?
> If this problem is fixed on the checker side (it probably should be - the
> checker , we can proba
Author: sammccall
Date: Thu Nov 9 13:45:27 2017
New Revision: 317838
URL: http://llvm.org/viewvc/llvm-project?rev=317838&view=rev
Log:
[clangd] Fix compilation database detection
Modified:
clang-tools-extra/trunk/clangd/GlobalCompilationDatabase.cpp
Modified: clang-tools-extra/trunk/clangd/
sabel83 added a comment.
In https://reviews.llvm.org/D5767#920085, @rsmith wrote:
> I'm not entirely sure what's happening with this and
> https://reviews.llvm.org/D38818, but the direction looks good to me, and I
> left a couple of comments on the other review thread.
This was the original p
sabel83 updated this revision to Diff 122325.
sabel83 marked an inline comment as done.
https://reviews.llvm.org/D5767
Files:
include/clang/Driver/CC1Options.td
include/clang/Frontend/FrontendActions.h
include/clang/Frontend/FrontendOptions.h
include/clang/FrontendTool/Utils.h
include/c
AlexVlx marked an inline comment as done.
AlexVlx added a comment.
In https://reviews.llvm.org/D39857#920814, @kzhuravl wrote:
> Hi Alex, can you rebase on top of trunk (I think you brought in some extra
> changes from hcc branch) and upload a full diff?
Hello Konstantine - apologies about tha
sabel83 marked an inline comment as done.
sabel83 added a comment.
The last update of the patch also contains the changes to this pull request
based on comments from https://reviews.llvm.org/D5767.
https://reviews.llvm.org/D38818
___
cfe-commits ma
AlexVlx marked 2 inline comments as done.
AlexVlx added inline comments.
Comment at: include/clang/Basic/Attr.td:1328
+ ExprArgument<"Max", 1>,
StringArgument<"ISA", 1>];
let Documentation = [AMDGPUFlatWorkGroupSizeDocs];
kzhuravl w
sabel83 marked an inline comment as done.
sabel83 added a comment.
I have moved the tests into their own directory in the last update.
Comment at: tools/CMakeLists.txt:37
add_clang_subdirectory(libclang)
+add_subdirectory(templight)
rsmith wrote:
> Did you mea
sabel83 updated this revision to Diff 122324.
https://reviews.llvm.org/D38818
Files:
include/clang/Driver/CC1Options.td
include/clang/Frontend/FrontendActions.h
include/clang/Frontend/FrontendOptions.h
include/clang/FrontendTool/Utils.h
include/clang/Sema/Sema.h
include/clang/Sema/Tem
sammccall added a comment.
In https://reviews.llvm.org/D39738#921014, @francisco.lopes wrote:
> Sorting got hardcoded? libclang has it optional. If hardcoded, it becomes a
> performance problem, since some clients may wish to order it themselves with
> private heuristics.
Is the performance r
AlexVlx updated this revision to Diff 122323.
AlexVlx marked 7 inline comments as done.
https://reviews.llvm.org/D39857
Files:
include/clang/Basic/Attr.td
lib/CodeGen/TargetInfo.cpp
lib/Sema/SemaDeclAttr.cpp
Index: lib/Sema/SemaDeclAttr.cpp
=
sammccall added a comment.
In https://reviews.llvm.org/D39836#920977, @arphaman wrote:
> In https://reviews.llvm.org/D39836#920587, @sammccall wrote:
>
> > So I probably should have started from the other end, here :-)
> >
> > I'd really like to make the completion retrieval and ranking more flex
francisco.lopes added a comment.
Sorting got hardcoded? libclang has it optional. If hardcoded it becomes a
performance problem, since some clients may wish to order it themselves with
private heuristics.
Repository:
rL LLVM
https://reviews.llvm.org/D39738
___
ABataev added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:14356
+if (S.IsOpenMPCapturedDecl(Var)) {
+ bool hasConst = DeclRefType.isConstQualified();
DeclRefType = DeclRefType.getUnqualifiedType();
`hasConst` must start from capital letter
NoQ added a comment.
I'm curious if the crash would turn into an assertion failure during
`getRawSVal()` after https://reviews.llvm.org/D38801 is committed.
The problem with this checker producing void symbols is known since
https://reviews.llvm.org/D26837. If this problem is fixed on the check
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
This seems reasonable to me. Please commit it. @NoQ can do a post-commit review
and fix it up if he would rather address the issue differently.
https://reviews.llvm.org/D39862
__
Wizard added inline comments.
Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:25
+/// we will do best effort to generate a fix, however, if the
+/// case can not be solved with a simple fix (e.g. remove prefix or change
first
+/// character), we will leave the fix to th
Wizard updated this revision to Diff 122319.
Wizard marked 6 inline comments as done.
Wizard added a comment.
address comments
https://reviews.llvm.org/D39829
Files:
clang-tidy/objc/CMakeLists.txt
clang-tidy/objc/ObjCTidyModule.cpp
clang-tidy/objc/PropertyDeclarationCheck.cpp
clang-tidy
AlexVlx updated this revision to Diff 122318.
https://reviews.llvm.org/D39857
Files:
include/clang/Basic/Attr.td
lib/CodeGen/TargetInfo.cpp
lib/Sema/SemaDeclAttr.cpp
Index: lib/Sema/SemaDeclAttr.cpp
===
--- lib/Sema/SemaDeclAt
arphaman added a comment.
In https://reviews.llvm.org/D39836#920587, @sammccall wrote:
> So I probably should have started from the other end, here :-)
>
> I'd really like to make the completion retrieval and ranking more flexible.
> In particular
>
> - incorporating results from other sources (
sammccall added a comment.
In https://reviews.llvm.org/D39799#920780, @JVApen wrote:
> How does this new file know if it should handle it's flags as it does in
> clang.exe or clang-cl.exe?
It doesn't set argv[0], so it's treated like `clang` by default.
I believe the flag `--driver-mode={gcc
Author: arphaman
Date: Thu Nov 9 12:50:59 2017
New Revision: 317832
URL: http://llvm.org/viewvc/llvm-project?rev=317832&view=rev
Log:
[index] tag declarations should use the decl role instead of ref
The 'decl' role is more canonical than the 'ref'. This helps us establish the
'specialization-of'
mgorny added reviewers: jbcoe, aaron.ballman.
mgorny added a comment.
Let's try some more reviewers.
https://reviews.llvm.org/D39161
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
george.karpenkov created this revision.
Herald added subscribers: szepet, xazax.hun.
This is the issue breaking the postgresql bot, purely by chance exposed through
taint checker, somehow appearing after https://reviews.llvm.org/D38358 got
committed.
The backstory is that the taint checker requ
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317828: [python] [tests] Update priority values in code
completion test (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D39838?vs=17&id=122304#toc
Repository:
rL LLVM
htt
Author: mgorny
Date: Thu Nov 9 12:17:41 2017
New Revision: 317828
URL: http://llvm.org/viewvc/llvm-project?rev=317828&view=rev
Log:
[python] [tests] Update priority values in code completion test
The priority for destructors and operators was reduced in r314019.
Adjust the values used in the tes
Hello!
On Wed, Nov 08, 2017 at 12:36:00PM -0800, Volodymyr Sapsai wrote:
> Thanks for the patch, Reimar. Can you please add tests to ensure this
> functionality doesn’t regress? As null character is required by the standard
> (27.7.2.3p21), a good starting point seems to be
> test/std/input.outp
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:1329
StringArgument<"ISA", 1>];
let Documentation = [AMDGPUFlatWorkGroupSizeDocs];
let Subjects = SubjectList<[Function], ErrorDiag, "ExpectedKernelFunction">;
Pleas
mgorny added a comment.
In https://reviews.llvm.org/D39838#920399, @ilya-biryukov wrote:
> LGTM.
>
> Can we run those tests as part of `check-all` cmake target or setup a
> buildbot that runs those? Seems surprising it went unnoticed for so long.
I was thinking of that but I think it'd be nice
jdenny created this revision.
[OpenMP] diagnose assign to firstprivate const
Clang does not diagnose assignments to const variables declared
firstprivate. Furthermore, codegen is broken such that, at run time,
such assignments simply have no effect. For example, the following
prints 0 not 1:
i
kzhuravl added a subscriber: cfe-commits.
kzhuravl added a reviewer: aaron.ballman.
kzhuravl added a comment.
Hi Alex, can you rebase on top of trunk (I think you brought in some extra
changes from hcc branch) and upload a full diff?
Comment at: include/clang/Basic/Attr.td:132
JVApen added a comment.
How does this new file know if it should handle it's flags as it does in
clang.exe or clang-cl.exe?
Repository:
rL LLVM
https://reviews.llvm.org/D39799
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
Author: george.karpenkov
Date: Thu Nov 9 11:06:22 2017
New Revision: 317820
URL: http://llvm.org/viewvc/llvm-project?rev=317820&view=rev
Log:
[analyzer] assume bitwise arithmetic axioms
Patches the solver to assume that bitwise OR of an unsigned value with a
constant always produces a value larg
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317820: [analyzer] assume bitwise arithmetic axioms
(authored by george.karpenkov).
Changed prior to commit:
https://reviews.llvm.org/D39707?vs=122170&id=122278#toc
Repository:
rL LLVM
https://revie
dcoughlin added a comment.
This looks good to me. It is very clean! But please add a comment in the places
where you are assuming a two's complement value representation for signed
integers.
https://reviews.llvm.org/D39707
___
cfe-commits mailing
ABataev updated this revision to Diff 122273.
ABataev added a comment.
Fixed version of OpenMP standard
https://reviews.llvm.org/D39457
Files:
docs/OpenMPSupport.rst
docs/index.rst
Index: docs/index.rst
===
--- docs/index.rst
sammccall created this revision.
All results are scored, we only process CodeCompletionStrings for the winners.
We now return CompletionList rather than CompletionItem[] (both are valid).
sortText is now based on CodeCompletionResult::orderedName (mostly the same).
This is the first clangd-only c
ashi1 updated this revision to Diff 122271.
ashi1 added subscribers: scchan, yaxunl, ashi1.
ashi1 added a comment.
Herald added a subscriber: eraman.
I've added the lit tests for this change, and also showing full context.
My lit test import_weak_type.ll follows similar format to import_opaque_ty
arphaman updated this revision to Diff 122270.
arphaman marked 5 inline comments as done.
arphaman added a comment.
Address review comments
Repository:
rL LLVM
https://reviews.llvm.org/D39706
Files:
lib/Tooling/Refactoring/CMakeLists.txt
lib/Tooling/Refactoring/Extract/CaptureVariables.c
arphaman added inline comments.
Comment at: lib/Tooling/Refactoring/Extract/CaptureVariables.cpp:36
+ return true;
+// FIXME: Capture 'self'.
+if (!VD->isLocalVarDeclOrParm())
ioeric wrote:
> and `this`?
This is a different kind of expression that wo
ABataev updated this revision to Diff 122268.
ABataev added a comment.
Update status.
https://reviews.llvm.org/D39457
Files:
docs/OpenMPSupport.rst
docs/index.rst
Index: docs/index.rst
===
--- docs/index.rst
+++ docs/index.rs
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317816: Add _LIBCPP_INLINE_VISIBILITY to
__compressed_pair_elem members (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D39751?vs=121939&id=122261#toc
Repository:
rL LLVM
h
Author: arphaman
Date: Thu Nov 9 09:54:49 2017
New Revision: 317816
URL: http://llvm.org/viewvc/llvm-project?rev=317816&view=rev
Log:
Add _LIBCPP_INLINE_VISIBILITY to __compressed_pair_elem members
The commit r300140 changed the implementation of compressed_pair, but didn't add
_LIBCPP_INLINE_VI
Author: abataev
Date: Thu Nov 9 09:32:15 2017
New Revision: 317813
URL: http://llvm.org/viewvc/llvm-project?rev=317813&view=rev
Log:
[OPENMP] Codegen for `#pragma omp target parallel for simd`.
Added codegen for `#pragma omp target parallel for simd` and clauses.
Added:
cfe/trunk/test/OpenM
kubamracek added a comment.
> When linking the final binary, the XRay runtime can't seem to find the
> `__{start,stop}_xray_{fn_idx,instr_map}` symbols. I've marked them weak, but
> they seem to either not be resolved when statically linking the binary. The
> dynamic lib version of the XRay run
kromanenkov added a comment.
@NoQ Do we need to change a `DeclaratorDecl` field in PointerToMember SVal to
something more common, like `ValueDecl`, to support `IndirectFieldDecl` as well?
https://reviews.llvm.org/D39800
___
cfe-commits mailing lis
Author: abataev
Date: Thu Nov 9 09:01:35 2017
New Revision: 317811
URL: http://llvm.org/viewvc/llvm-project?rev=317811&view=rev
Log:
[OPENMP] Treat '#pragma omp target parallel for simd' as simd directive.
`#pragma omp target parallel for simd` mistakenly was not treated as a
simd directive, fix
kubamracek added a comment.
Thanks for working on this! Can we split the patch and land parts that are
LGTM? It's getting a bit crowded here. I think the ASM changes should be a
separate patch, and the test changes as well, probably.
https://reviews.llvm.org/D39114
_
malaperle added a comment.
In https://reviews.llvm.org/D38639#920487, @ilya-biryukov wrote:
> I think we should never iterate through `SourceManager`, as it's much easier
> to get wrong than using the callbacks. I agree that all that fiddling with
> callbacks is unfortunate, but it's well worth
sammccall added a comment.
So I probably should have started from the other end, here :-)
I'd really like to make the completion retrieval and ranking more flexible. In
particular
- incorporating results from other sources (indexes: both in-memory and
external services).
- combining more quali
benhamilton added inline comments.
Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:25
+/// we will do best effort to generate a fix, however, if the
+/// case can not be solved with a simple fix (e.g. remove prefix or change
first
+/// character), we will leave the fix
benhamilton added inline comments.
Comment at: docs/clang-tidy/checks/objc-property-declaration.rst:7
+Finds property declarations in Objective-C files that do not follow the pattern
+of property names in Google's Objective-C Style Guide. The property name should
+be in the forma
sammccall added a comment.
I'm really happy you've made this work! I don't understand it enough to do a
meaningful review (keen to learn if you have time for a walkthrough when back
in the office).
https://reviews.llvm.org/D39842
___
cfe-commits m
1 - 100 of 156 matches
Mail list logo
