Author: vedantk
Date: Mon Oct 16 23:51:54 2017
New Revision: 315979
URL: http://llvm.org/viewvc/llvm-project?rev=315979&view=rev
Log:
[Coverage] Explicitly mark the l.h.s of && and || (fixes PR33465)
This makes it possible to view sub-line region counts for the l.h.s of
&& and || expressions in c
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Okay, thanks.
https://reviews.llvm.org/D38947
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
nik added a comment.
This fixes the reported bug for me :)
There is another related issue that is not addressed by this change. I've
reported it as
[preamble] Skipped ranges vanish after reparse (#ifdef with #include)
https://bugs.llvm.org/show_bug.cgi?id=34971
https://reviews.llvm.org/D385
kosarev added a comment.
Yes, some preparation code moved past the isBitField() block and generation of
TBAA info moved before creating the bit-field lvalue.
Thanks for catching the BaseExpr renaming.
https://reviews.llvm.org/D38947
___
cfe-commit
kosarev updated this revision to Diff 119257.
kosarev added a comment.
- Removed renamings that complicate reviewing.
https://reviews.llvm.org/D38947
Files:
lib/CodeGen/CGExpr.cpp
Index: lib/CodeGen/CGExpr.cpp
===
--- lib/CodeGe
rjmccall added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:3665
-LValue CodeGenFunction::EmitLValueForField(LValue base,
- const FieldDecl *field) {
- LValueBaseInfo BaseInfo = base.getBaseInfo();
- AlignmentSource fieldAlignS
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D38966
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Ok.
https://reviews.llvm.org/D38796
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D38945
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
bsdjhb marked 2 inline comments as done.
bsdjhb added inline comments.
Comment at: src/UnwindRegistersSave.S:100
+#
+DEFINE_LIBUNWIND_FUNCTION(unw_getcontext)
+ .set push
sdardis wrote:
> After looking at another implementation of libunwind and the other platfor
bsdjhb updated this revision to Diff 119245.
bsdjhb added a comment.
- Save all of the general purpose registers.
https://reviews.llvm.org/D38110
Files:
include/__libunwind_config.h
include/libunwind.h
src/Registers.hpp
src/UnwindCursor.hpp
src/UnwindRegistersRestore.S
src/UnwindReg
t-tye added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:1060
+ /// \returns Maximum device supported OpenCL workgroup size.
+ virtual unsigned getOpenCLMaxWorkGroupSize(unsigned Dim) const {
+return 0;
Is this specifically tied to OpenCL o
Author: compnerd
Date: Mon Oct 16 20:30:25 2017
New Revision: 315968
URL: http://llvm.org/viewvc/llvm-project?rev=315968&view=rev
Log:
Basic: make the nan family pure
The nan family of math routines do not rely on global state. They do
however depend on their parameter. This fits the descriptio
george.karpenkov created this revision.
Herald added subscribers: szepet, xazax.hun.
@dcoughlin I'm curious whether you'd like such a change: in general, I think it
is much better when the assert failure tells the developer _what_ value is
failing, rather than saying "oops we are dead".
I would
arphaman created this revision.
Herald added subscribers: ilya-biryukov, mgorny.
This patch adds support for editor commands that allow refactoring to be used
in editor clients like libclang or clangd.
An editor command can be bound to an refactoring action rule. Once it is bound,
it's available
tra added a comment.
Please add tests for the cases where such local->shaed conversion should and
should not happen.
I would appreciate if you could add details on what exactly your passes are
supposed to move to shared memory.
Considering that device-side code tends to be heavily inlined, it m
howard.hinnant added a comment.
Ok. Well that's why it is under a #define: to make it easier to include or
not, depending on the needs of the platform.
https://reviews.llvm.org/D38599
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
danalbert added a comment.
In https://reviews.llvm.org/D38599#899196, @howard.hinnant wrote:
> Fwiw, I wrote this code. All of that "fallback" stuff was written to make
> customer code that was incorrect, but working on OS X
> -version-that-used-libsupc++ continue to work. I.e. to be a crutch
howard.hinnant added a comment.
Fwiw, I wrote this code. All of that "fallback" stuff was written to make
customer code that was incorrect, but working on OS X
-version-that-used-libsupc++ continue to work. I.e. to be a crutch for
incorrect code. It should all be removed if you no longer wan
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315959: [libclang] Add support for querying cursor
availability (authored by jbcoe).
Changed prior to commit:
https://reviews.llvm.org/D36973?vs=118333&id=119234#toc
Repository:
rL LLVM
https://revi
Author: jbcoe
Date: Mon Oct 16 16:46:02 2017
New Revision: 315959
URL: http://llvm.org/viewvc/llvm-project?rev=315959&view=rev
Log:
[libclang] Add support for querying cursor availability
Summary:
This patch allows checking the availability of cursors through libclang and
clang.cindex (Python).
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315958: [libclang] Visit attributes for function and class
templates (authored by jbcoe).
Changed prior to commit:
https://reviews.llvm.org/D36955?vs=118330&id=119233#toc
Repository:
rL LLVM
https:/
Author: jbcoe
Date: Mon Oct 16 16:43:02 2017
New Revision: 315958
URL: http://llvm.org/viewvc/llvm-project?rev=315958&view=rev
Log:
[libclang] Visit attributes for function and class templates
Summary: Previously, `VisitAttributes` was not called for function and class
templates and thus their a
arphaman created this revision.
Herald added a subscriber: mgorny.
This patch adds an initial, skeleton outline of the "extract function"
refactoring.
The extracted function doesn't capture variables / rewrite code yet, it just
basically does a simple copy-paste.
The following initiation rules a
craig.topper added inline comments.
Comment at: lib/Headers/avx512bwintrin.h:2109
+ return _mm512_cmp_epi8_mask(_mm512_and_epi32(__A, __B),
+_mm512_setzero_qi(), 4);
}
Can you align this with the opening paren on the line above? Same with all th
Author: erichkeane
Date: Mon Oct 16 16:25:24 2017
New Revision: 315956
URL: http://llvm.org/viewvc/llvm-project?rev=315956&view=rev
Log:
Fix usage in TableGen of getValueAsString
Record::getValueAsString returns a stringref to an interned
string (apparently had been changed since most of tablegen
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315956: Fix usage in TableGen of getValueAsString (authored
by erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D38979?vs=119218&id=119227#toc
Repository:
rL LLVM
https://reviews.llvm.
Author: rnk
Date: Mon Oct 16 16:07:15 2017
New Revision: 315953
URL: http://llvm.org/viewvc/llvm-project?rev=315953&view=rev
Log:
Don't print end-of-directive tokens in -E output
This comes up when pre-processing standalone .s files containing
hash-prefixed comments. The pre-processor should skip
Yuck, sorry for the typos in the commit message. It should read:
GCC ignores qualifiers on array types. Since we seem to have this
function primarily for GCC compatibility, we should try to match that
behavior.
This also adds a few more test-cases for __builtin_types_compatible_p,
which were insp
Author: gbiv
Date: Mon Oct 16 15:58:37 2017
New Revision: 315951
URL: http://llvm.org/viewvc/llvm-project?rev=315951&view=rev
Log:
Make __builtin_types_compatible_p more like GCC's
GCC ignore qualifiers on array types. Since we seem to have this
function primarily for GCC compatibility, we should
Author: erichkeane
Date: Mon Oct 16 15:47:26 2017
New Revision: 315950
URL: http://llvm.org/viewvc/llvm-project?rev=315950&view=rev
Log:
Replace usage of std::stringstream with raw_string_ostream
Typically we don't use the stringstream, so instead use
raw_string_stream. Additionally, the depende
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you for the cleanup!
https://reviews.llvm.org/D38979
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
erichkeane created this revision.
Record::getValueAsString returns a stringref to an interned
string (apparently had been changed since most of tablegen was
written). In this patch, I audited the usage of getValueAsString
to find places where we can trivially stop storing 'std::string' and instea
gtbercea created this revision.
Herald added subscribers: mgorny, jholewinski.
This patch is part of the development effort to add support in the current
OpenMP GPU offloading implementation for implicitly sharing variables between a
target region executed by the team master thread and the worke
gtbercea created this revision.
Herald added a subscriber: jholewinski.
This patch is part of the development effort to add support in the current
OpenMP GPU offloading implementation for implicitly sharing variables between a
target region executed by the team master thread and the worker threa
arsenm updated this revision to Diff 119209.
arsenm added a comment.
Use 1024 for OpenCL
https://reviews.llvm.org/D38770
Files:
include/clang/Basic/TargetInfo.h
lib/Basic/Targets/AMDGPU.cpp
lib/Basic/Targets/AMDGPU.h
lib/CodeGen/CGBuiltin.cpp
test/CodeGenOpenCL/builtins-amdgcn.cl
te
Nebiroth marked 21 inline comments as done.
Nebiroth added inline comments.
Comment at: clangd/ClangdUnit.cpp:103
+ void AfterExecute(CompilerInstance &CI) override {
+const SourceManager &SM = CI.getSourceManager();
ilya-biryukov wrote:
> There's a much b
Hahnfeld added a comment.
In https://reviews.llvm.org/D38968#898951, @grokos wrote:
> Now that this issue has been addressed and regressions tests pass, should we
> re-enable Cmake to build libomptarget by default?
Yes, I already have a local patch which also takes care of restricting the
tes
Author: erichkeane
Date: Mon Oct 16 13:44:14 2017
New Revision: 315934
URL: http://llvm.org/viewvc/llvm-project?rev=315934&view=rev
Log:
Remove AnyX86Interrupt documentation
This documentation was copied directly from the GCC
documentaiton in r257867. Reverting and alterting
the original author
grokos added a comment.
Now that this issue has been addressed and regressions tests pass, should we
re-enable Cmake to build libomptarget by default?
https://reviews.llvm.org/D38968
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315931: Sort Attributes by "HeaderName" (authored by
erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D38969?vs=119195&id=119200#toc
Repository:
rL LLVM
https://reviews.llvm.org/D3896
Author: erichkeane
Date: Mon Oct 16 13:31:05 2017
New Revision: 315931
URL: http://llvm.org/viewvc/llvm-project?rev=315931&view=rev
Log:
Sort Attributes by "HeaderName"
Attributes in the docs were previously sorted (apparently)
by the attribute name, so AnyX86Interrupt ended up being the
first o
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
https://reviews.llvm.org/D38969
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
Author: erichkeane
Date: Mon Oct 16 13:13:36 2017
New Revision: 315929
URL: http://llvm.org/viewvc/llvm-project?rev=315929&view=rev
Log:
Clarify the 'interrupt' names in Attribute Docs
All 4 of the 'interrupt' headers were automatically named
'interrupt'. This patch gives them unique names.
Modi
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
https://reviews.llvm.org/D38970
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
rwols added a comment.
I couldn't get the protocol.test to succeed; `clangd` returns 1 now and that
trips up `lit`. I think I have to use `XFAIL` from `lit` somehow but didn't
figure it out.
https://reviews.llvm.org/D38939
___
cfe-commits mailing
rwols updated this revision to Diff 119198.
rwols added a comment.
Return 0 if shutdown was received before exit, otherwise return 1
The protocol.test test fails now.
https://reviews.llvm.org/D38939
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/Protocol.h
clangd/Pro
arphaman added inline comments.
Comment at: include/clang/Tooling/Refactoring/ASTSelection.h:74
+/// An AST selection value that corresponds to a selection of a set of
+/// statements that belong to one body of code (like one function).
+///
hokein wrote:
> I see
arphaman updated this revision to Diff 119197.
arphaman marked 6 inline comments as done.
arphaman added a comment.
Address review comments
Repository:
rL LLVM
https://reviews.llvm.org/D38835
Files:
include/clang/Tooling/Refactoring/ASTSelection.h
lib/Tooling/Refactoring/ASTSelection.cpp
erichkeane updated this revision to Diff 119195.
erichkeane added a comment.
Change the constructor in DocumentationData to take by value.
https://reviews.llvm.org/D38969
Files:
utils/TableGen/ClangAttrEmitter.cpp
Index: utils/TableGen/ClangAttrEmitter.cpp
===
erichkeane added inline comments.
Comment at: utils/TableGen/ClangAttrEmitter.cpp:3670
+ DocumentationData(const Record &Documentation, const Record &Attribute,
+const std::pair &&HeadingAndKinds)
+ : Documentation(&Documentation), Attribute(&Attribute),
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D38968
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
erichkeane created this revision.
All 4 of the 'interrupt' headers were automatically named
'interrupt'. This patch gives them unique names.
https://reviews.llvm.org/D38970
Files:
include/clang/Basic/AttrDocs.td
Index: include/clang/Basic/AttrDocs.td
===
erichkeane added a comment.
Additionally, I'm going to edit the 'interrupt' docs in a separate commit to
give each a separate header name based on the architecture. Currently they are
all named 'interrupt', so I want to rename them all interrupt (x86), etc. Look
for a future review!
==
erichkeane created this revision.
Attributes in the docs were previously sorted (apparently)
by the attribute name, so AnyX86Interrupt ended up being the
first one, rather than in a meaningful place. This resulted in the
4 'interrupt' titled sections being all in different places.
This replaces
Hahnfeld created this revision.
This allows to return the static value that we know at compile time.
https://reviews.llvm.org/D38968
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/Builtins.h
lib/AST/ExprConstant.cpp
lib/Basic/Builtins.cpp
test/OpenMP/is_initial_device.c
frutiger updated this revision to Diff 119191.
frutiger added a comment.
Added 'Location' to '__all__'.
https://reviews.llvm.org/D37905
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_location.py
tools/libclang/CXSourceLocation.cpp
Index: tools/libclang/CXSourceL
gtbercea added a comment.
LGTM
https://reviews.llvm.org/D38883
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315924: [refactor] allow the use of refactoring diagnostics
(authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D38772?vs=118701&id=119185#toc
Repository:
rL LLVM
https://revie
Author: arphaman
Date: Mon Oct 16 11:28:26 2017
New Revision: 315924
URL: http://llvm.org/viewvc/llvm-project?rev=315924&view=rev
Log:
[refactor] allow the use of refactoring diagnostics
This commit allows the refactoring library to use its own set of
refactoring-specific diagnostics to reports t
rwols added inline comments.
Comment at: test/clangd/authority-less-uri.test:33
{"jsonrpc":"2.0","id":3,"method":"shutdown"}
+# CHECK: {"jsonrpc":"2.0","id":3,"result":null}
+Content-Length: 33
sammccall wrote:
> Having the shutdown/exit boilerplate in every tes
yaxunl created this revision.
Currently clang assumes the temporary variables emitted during
codegen of atomic builtins have address space 0, which
is not true for target triple amdgcn---amdgiz and causes invalid
bitcasts.
This patch fixes that.
https://reviews.llvm.org/D38966
Files:
lib/Cod
Author: arphaman
Date: Mon Oct 16 11:07:16 2017
New Revision: 315923
URL: http://llvm.org/viewvc/llvm-project?rev=315923&view=rev
Log:
clang-refactor: Use llvm_unreachable in an unused override
As suggested by David Blaikie!
Modified:
cfe/trunk/tools/clang-refactor/ClangRefactor.cpp
Modifie
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315921: Do not link clang_rt.cfi on Android. (authored by
eugenis).
Changed prior to commit:
https://reviews.llvm.org/D38908?vs=118986&id=119180#toc
Repository:
rL LLVM
https://reviews.llvm.org/D389
Author: eugenis
Date: Mon Oct 16 11:02:57 2017
New Revision: 315921
URL: http://llvm.org/viewvc/llvm-project?rev=315921&view=rev
Log:
Do not link clang_rt.cfi on Android.
Summary:
The OS provides cross-dso CFI support starting with Android O.
Trapping mode does not require any runtime at all, and
yaxunl marked an inline comment as done.
yaxunl added a comment.
In https://reviews.llvm.org/D38857#896994, @Anastasia wrote:
> LGTM! Thanks!
>
> Can we close https://bugs.llvm.org/show_bug.cgi?id=33418 after this commit?
Will do.
Comment at: test/SemaOpenCL/null_literal.cl:
That's a good idea! I'll commit an llvm_unreachable fix for this override
then.
On 16 October 2017 at 10:32, David Blaikie wrote:
> Generally it's preferably to avoid adding dead code (partly for this
> reason - it's hard to track when it gets used and ensure it's appropriately
> tested) could t
Generally it's preferably to avoid adding dead code (partly for this reason
- it's hard to track when it gets used and ensure it's appropriately
tested) could the member function's body be replaced with llvm_unreachable
for now, then?
On Mon, Oct 16, 2017 at 10:27 AM Alex L wrote:
> At the momen
Author: arphaman
Date: Mon Oct 16 10:31:16 2017
New Revision: 315918
URL: http://llvm.org/viewvc/llvm-project?rev=315918&view=rev
Log:
Recommit r315738 "[clang-refactor] Apply source replacements"
The fixed commit ensures that ParsedSourceRange works correctly
with Windows paths.
Original messag
At the moment this method override is not used by the clang-refactor tool,
so I don't think I can add a test for it.
On 16 October 2017 at 10:11, David Blaikie wrote:
> Is there a test that could be added to cover this new code?
>
> On Fri, Oct 13, 2017 at 2:15 PM Alex Lorenz via cfe-commits <
>
On Mon, Oct 16, 2017 at 8:09 PM, David Blaikie wrote:
> Would it be better/possible to improve the warning to not have this false
> positive, rather than suppressing it?
I am willing to look into it, once there is a clear minimal test-case,
that does not boil down to completely ignoring std::numer
Is there missing test coverage for this?
On Tue, Oct 10, 2017 at 9:12 AM Ilya Biryukov via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ibiryukov
> Date: Tue Oct 10 09:12:47 2017
> New Revision: 315323
>
> URL: http://llvm.org/viewvc/llvm-project?rev=315323&view=rev
> Log:
> [clangd
Is there a test that could be added to cover this new code?
On Fri, Oct 13, 2017 at 2:15 PM Alex Lorenz via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: arphaman
> Date: Fri Oct 13 14:15:25 2017
> New Revision: 315755
>
> URL: http://llvm.org/viewvc/llvm-project?rev=315755&view=rev
Would it be better/possible to improve the warning to not have this false
positive, rather than suppressing it?
On Sun, Oct 15, 2017 at 1:12 PM Roman Lebedev via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: lebedevri
> Date: Sun Oct 15 13:12:42 2017
> New Revision: 315874
>
> URL: h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315915: [Bitfield] Add an option to access bitfield in a
fine-grained manner. (authored by wmi).
Changed prior to commit:
https://reviews.llvm.org/D36562?vs=118181&id=119170#toc
Repository:
rL LLVM
Author: wmi
Date: Mon Oct 16 09:50:27 2017
New Revision: 315915
URL: http://llvm.org/viewvc/llvm-project?rev=315915&view=rev
Log:
[Bitfield] Add an option to access bitfield in a fine-grained manner.
Currently all the consecutive bitfields are wrapped as a large integer unless
there is unamed ze
arphaman added inline comments.
Comment at: include/clang/Tooling/CommonOptionsParser.h:116
+ bool HasError;
+ std::string ErrorMessage;
std::unique_ptr Compilations;
Would it be better to have an `llvm::Error' instead of the two fields?
C
NoQ added a comment.
Neat! Tests?
https://reviews.llvm.org/D38921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
r.stahl added a comment.
If all is good, I will need someone to commit this for me please.
Comment at: unittests/AST/ASTImporterTest.cpp:100
+ // This might catch other cases.
+ Imported->dump(ToNothing);
xazax.hun wrote:
> r.stahl wrote:
> > xazax.hun wrot
r.stahl updated this revision to Diff 119162.
r.stahl marked 3 inline comments as done.
r.stahl added a comment.
addressed review comment
https://reviews.llvm.org/D38943
Files:
lib/AST/ASTImporter.cpp
unittests/AST/ASTImporterTest.cpp
Index: unittests/AST/ASTImporterTest.cpp
=
JDevlieghere added inline comments.
Comment at: clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp:76
+
+std::size_t twoPow(std::size_t Bits) {
+ const std::size_t DiscreteValues = 1ul << Bits;
Add a comment describing what this function does. I'd move and rephrase
xazax.hun added inline comments.
Comment at: unittests/AST/ASTImporterTest.cpp:100
+ // This might catch other cases.
+ Imported->dump(ToNothing);
r.stahl wrote:
> xazax.hun wrote:
> > I would elaborate a bit more on the purpose of the code below.
> I will ne
lebedev.ri updated this revision to Diff 119159.
lebedev.ri added a comment.
Address @thakis review notes: do make sure that we still warn on `NULL`.
Any other special macros/cases?
Repository:
rL LLVM
https://reviews.llvm.org/D38954
Files:
lib/Sema/Sema.cpp
test/SemaCXX/Inputs/warn-zero
sdardis added a reviewer: compnerd.
sdardis added a subscriber: compnerd.
sdardis added a comment.
Two last inlined comments and I think that's everything. @compnerd Have I
missed anything?
Comment at: src/UnwindRegistersSave.S:100
+#
+DEFINE_LIBUNWIND_FUNCTION(unw_getcontext)
lebedev.ri added a comment.
In https://reviews.llvm.org/D38954#898586, @thakis wrote:
> As said on the bug, this matches gcc's behavior,
https://bugs.llvm.org/show_bug.cgi?id=33771#c3
> and with this you won't see this warning for NULL.
Finally, an argument that can actually be addressed.
>
thakis added a comment.
As said on the bug, this matches gcc's behavior, and with this you won't see
this warning for NULL. I don't think this is better.
Repository:
rL LLVM
https://reviews.llvm.org/D38954
___
cfe-commits mailing list
cfe-commit
lebedev.ri created this revision.
lebedev.ri added a project: clang.
The warning was initially introduced in https://reviews.llvm.org/D32914 by
@thakis,
and the concerns were raised there, and later in
https://reviews.llvm.org/rL302247
and PR33771.
I do believe that it makes sense to relax the
ioeric updated this revision to Diff 119150.
ioeric added a comment.
- Add a ExecutionContext class.
https://reviews.llvm.org/D34272
Files:
include/clang/Tooling/CommonOptionsParser.h
include/clang/Tooling/Execution.h
include/clang/Tooling/ToolExecutorPluginRegistry.h
include/clang/Tool
lebedev.ri added an edge: D32914: Introduce Wzero-as-null-pointer-constant..
Users:
lebedev.ri (Auditor)
https://reviews.llvm.org/rL302247
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315902: [CUDA] Require libdevice only if needed (authored by
Hahnfeld).
Changed prior to commit:
https://reviews.llvm.org/D38901?vs=118969&id=119149#toc
Repository:
rL LLVM
https://reviews.llvm.org/
Author: hahnfeld
Date: Mon Oct 16 06:31:30 2017
New Revision: 315902
URL: http://llvm.org/viewvc/llvm-project?rev=315902&view=rev
Log:
[CUDA] Require libdevice only if needed
If the user passes -nocudalib, we can live without it being present.
Simplify the code by just checking whether LibDeviceM
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Great! I like the unit testing approach a lot!
https://reviews.llvm.org/D38731
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
r.stahl added a comment.
Thanks for the fast response. See inline comment.
Comment at: unittests/AST/ASTImporterTest.cpp:100
+ // This might catch other cases.
+ Imported->dump(ToNothing);
xazax.hun wrote:
> I would elaborate a bit more on the purpose of th
ogoffart updated this revision to Diff 119142.
ogoffart added a comment.
Updated the patch so that ActOnStartOfSwitchStmt returns void, and
ActOnFinishSwitchStmt will skip some checks in case of error
https://reviews.llvm.org/D26350
Files:
include/clang/Sema/Sema.h
lib/Parse/ParseStmt.cpp
danielmarjamaki added a comment.
LGTM
https://reviews.llvm.org/D38801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:308
if (StOutBound && !StInBound) {
+if (!Filter.CheckCStringOutOfBounds)
+ return state;
zaks.anna wrote:
> This seems to be related to the change in the test
xazax.hun updated this revision to Diff 119141.
xazax.hun marked 2 inline comments as done.
xazax.hun added a comment.
Herald added a subscriber: szepet.
- Address review comments.
https://reviews.llvm.org/D37437
Files:
include/clang/StaticAnalyzer/Core/BugReporter/BugType.h
lib/StaticAnaly
danielmarjamaki added a comment.
LGTM.. however I would like approval from somebody else also.
https://reviews.llvm.org/D38921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danielmarjamaki added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D36471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kosarev created this revision.
kosarev added a project: clang.
The main change is that now we generate TBAA info before constructing the
resulting lvalue instead of constructing lvalue with some default TBAA info and
fixing it as necessary afterwards. We also keep the TBAA info close to lvalue
1 - 100 of 120 matches
Mail list logo
