Is there missing test coverage for this? On Tue, Oct 10, 2017 at 9:12 AM Ilya Biryukov via cfe-commits < cfe-commits@lists.llvm.org> wrote:
> Author: ibiryukov > Date: Tue Oct 10 09:12:47 2017 > New Revision: 315323 > > URL: http://llvm.org/viewvc/llvm-project?rev=315323&view=rev > Log: > [clangd] Added forgotten return in UniqueFunction. > > This hasn't bitten us because we only used functions returning > 'void'. > > Modified: > clang-tools-extra/trunk/clangd/Function.h > > Modified: clang-tools-extra/trunk/clangd/Function.h > URL: > http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clangd/Function.h?rev=315323&r1=315322&r2=315323&view=diff > > ============================================================================== > --- clang-tools-extra/trunk/clangd/Function.h (original) > +++ clang-tools-extra/trunk/clangd/Function.h Tue Oct 10 09:12:47 2017 > @@ -46,7 +46,7 @@ public: > > Ret operator()(Args... As) { > assert(CallablePtr); > - CallablePtr->Call(std::forward<Args>(As)...); > + return CallablePtr->Call(std::forward<Args>(As)...); > } > > private: > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
