yamaguchi updated this revision to Diff 113027.
yamaguchi marked an inline comment as done.
yamaguchi added a comment.
Update diff. I agree that this is more generic.
https://reviews.llvm.org/D37249
Files:
clang/include/clang/Driver/Driver.h
clang/lib/Driver/Driver.cpp
Index: clang/lib/Dri
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311984: [clang-tidy] Fix 'misc-misplaced-widening-cast'
assertion error. (authored by danielmarjamaki).
Changed prior to commit:
https://reviews.llvm.org/D36670?vs=110940&id=113026#toc
Repository:
rL
Author: danielmarjamaki
Date: Mon Aug 28 23:25:24 2017
New Revision: 311984
URL: http://llvm.org/viewvc/llvm-project?rev=311984&view=rev
Log:
[clang-tidy] Fix 'misc-misplaced-widening-cast' assertion error.
Reviewers: alexfh, xazax.hun, danielmarjamaki
Differential Revision: http://reviews.llvm.
teemperor added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:1160
+void Driver::handleAutocompletions(const llvm::opt::Arg *A) const {
+ // Print out all options that start with a given argument. This is used for
I think a more generic interface wo
Author: mgorny
Date: Mon Aug 28 22:58:08 2017
New Revision: 311983
URL: http://llvm.org/viewvc/llvm-project?rev=311983&view=rev
Log:
[cmake] Support running extra clang tool tests without static analyzer
Support running the extra clang tool tests when the static analyzer
is disabled. Disable the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311983: [cmake] Support running extra clang tool tests
without static analyzer (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D37188?vs=112811&id=113024#toc
Repository:
rL LL
mgorny added a comment.
Thanks for the clarification.
Repository:
rL LLVM
https://reviews.llvm.org/D37188
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sepavloff added a comment.
@echristo Committed, thanks.
Repository:
rL LLVM
https://reviews.llvm.org/D36057
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311981: Use class to pass information about executable name
(authored by sepavloff).
Repository:
rL LLVM
https://reviews.llvm.org/D36057
Files:
cfe/trunk/include/clang/Driver/Driver.h
cfe/trunk/in
Rakete updated this revision to Diff 113020.
Rakete added a comment.
Updated test to use the -std=c++17 option + friendly ping
https://reviews.llvm.org/D36101
Files:
lib/Parse/ParseExpr.cpp
test/CXX/expr/expr.prim/expr.prim.fold/p2.cpp
Index: test/CXX/expr/expr.prim/expr.prim.fold
Author: sepavloff
Date: Mon Aug 28 22:22:26 2017
New Revision: 311981
URL: http://llvm.org/viewvc/llvm-project?rev=311981&view=rev
Log:
Use class to pass information about executable name
Information about clang executable name components, such as target and
driver mode, was passes in std::pair.
yamaguchi created this revision.
We wrote many codes in HandleImediateArgs, so I've refactored it into
handleAutocompletions.
https://reviews.llvm.org/D37249
Files:
clang/include/clang/Driver/Driver.h
clang/lib/Driver/Driver.cpp
Index: clang/lib/Driver/Driver.cpp
==
yamaguchi abandoned this revision.
yamaguchi added a comment.
https://reviews.llvm.org/D37217 has already landed, so we don't need this
anymore.
https://reviews.llvm.org/D37203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
Author: faisalv
Date: Mon Aug 28 20:04:13 2017
New Revision: 311975
URL: http://llvm.org/viewvc/llvm-project?rev=311975&view=rev
Log:
revert r311839 (ongoing cwg discussion)
apologies.
Modified:
cfe/trunk/lib/Sema/SemaExprMember.cpp
cfe/trunk/test/SemaCXX/member-expr.cpp
Modified: cfe/t
Author: yamaguchi
Date: Mon Aug 28 19:01:56 2017
New Revision: 311971
URL: http://llvm.org/viewvc/llvm-project?rev=311971&view=rev
Log:
[Bash-autocompletion] Add support for -std=
Summary:
Add support for autocompleting values of -std= by including
LangStandards.def. This patch relies on D36782,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311971: [Bash-autocompletion] Add support for -std=
(authored by yamaguchi).
Changed prior to commit:
https://reviews.llvm.org/D36820?vs=111804&id=113009#toc
Repository:
rL LLVM
https://reviews.llvm
Author: rsmith
Date: Mon Aug 28 18:52:13 2017
New Revision: 311970
URL: http://llvm.org/viewvc/llvm-project?rev=311970&view=rev
Log:
Improve constant expression evaluation of arrays of unknown bound.
The standard is not clear on how these are supposed to be handled, so we
conservatively treat as
Author: marshall
Date: Mon Aug 28 18:10:51 2017
New Revision: 311967
URL: http://llvm.org/viewvc/llvm-project?rev=311967&view=rev
Log:
Fix test for C++03
Modified:
libcxx/trunk/test/std/algorithms/alg.sorting/alg.merge/inplace_merge_comp.pass.cpp
Modified:
libcxx/trunk/test/std/algorithms/
faisalv added a comment.
In https://reviews.llvm.org/D36527#854883, @faisalv wrote:
>
> Interestingly we don't (explicitly) visit the lambda's function parameters?
This is obviously false - sorry :)
https://reviews.llvm.org/D36527
___
cfe-comm
faisalv added a comment.
In https://reviews.llvm.org/D36527#854600, @rsmith wrote:
> This patch appears to be missing some necessary changes in the following
> places:
>
> - lib/Serialization -- round-trip the new information through PCH / modules
Shouldn't the explicit template parameter info
probinson added a comment.
Dumping the whole module, the temporary DICompositeType node for CBdVfsImpl is
used both as the scope node for the DISubprogram, and also as the baseType of a
DIDerivedType which is a pointer type in the type list for the subprogram.
Given that the DICompositeType is
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D37188#854144, @mgorny wrote:
> I might be missing something but currently clang-tidy is not built at all
> when static analyzer is disabled.
Yes, but it could be
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Fine with me.
-eric
https://reviews.llvm.org/D36057
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
On Mon, Aug 28, 2017 at 5:21 PM Reid Kleckner wrote:
> On Mon, Aug 28, 2017 at 5:02 PM, David Blaikie wrote:
>
>> Feels like this alignment attribute may be a bit of a death trap, then?
>> Should other uses of the attribute be scrutinized, or could we come up with
>> a portable way to use it saf
On Mon, Aug 28, 2017 at 5:02 PM, David Blaikie wrote:
> Feels like this alignment attribute may be a bit of a death trap, then?
> Should other uses of the attribute be scrutinized, or could we come up with
> a portable way to use it safely? (using a different attribute on different
> compilers -
Author: yamaguchi
Date: Mon Aug 28 17:09:31 2017
New Revision: 311958
URL: http://llvm.org/viewvc/llvm-project?rev=311958&view=rev
Log:
Revert "Revert r311552: [Bash-autocompletion] Add support for static analyzer
flags"
This reverts commit 7c46b80c022e18d43c1fdafb117b0c409c5a6d1e.
r311552 brok
Feels like this alignment attribute may be a bit of a death trap, then?
Should other uses of the attribute be scrutinized, or could we come up with
a portable way to use it safely? (using a different attribute on different
compilers - sounded like maybe one form worked with MSVC and a different
for
On 28 August 2017 at 13:47, Akira Hatanaka via Phabricator via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> clang currently rejects "void foo(int = a);" and so does gcc.
>
> I'm trying to search the defect reports, but it looks like the c++
> standard's site is currently unreachable.
It's
On Mon, Aug 28, 2017 at 7:40 PM, Richard Smith - zygoloid via Phabricator
via cfe-commits wrote:
> rsmith added inline comments.
>
>
>
> Comment at: test/SemaCXX/destructor.cpp:27
> +#define BE_THE_HEADER
> +#include __FILE__
> +
>
> Do we guarantee that `__FILE_
probinson added a comment.
In https://reviews.llvm.org/D37038#854722, @probinson wrote:
> finalizeSubprogram() retrieves the variables from the subprogram and handles
> them; what is it missing?
For temp-md-nodes2.cpp, the assertion in mapTopLevelUniquedNode() trips on a
DICompositeType for C
On Fri, Aug 18, 2017 at 6:59 PM Stephan T. Lavavej via Phabricator via
cfe-commits wrote:
> STL_MSFT added a comment.
>
> In https://reviews.llvm.org/D36860#846232, @thakis wrote:
>
> > Many driver tests check in a basic representative directory structure
> (e.g. test/Driver/Inputs/basic_freebsd_
*nod* Thanks - let me know if you have trouble simplifying or explaining it
& I'll see if fresh eyes help :)
On Mon, Aug 28, 2017 at 4:46 PM Adrian Prantl wrote:
> It's possible that this testcase can be golfed some more. I copied it
> almost verbatim from the PR. I'll see what I can do. The imp
It's possible that this testcase can be golfed some more. I copied it almost
verbatim from the PR. I'll see what I can do. The important thing is that it
needs to trigger the situation where the frontend is creating an inlined
function.
-- adrian
> On Aug 28, 2017, at 4:43 PM, David Blaikie wr
Seems like a rather complex test case - could you explain what's going on
there? (maybe in the form of a comment in the code - what path through all
those classes is required to tickle this)
On Wed, Aug 23, 2017 at 2:25 PM Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Autho
rsmith added inline comments.
Comment at: test/SemaCXX/destructor.cpp:27
+#define BE_THE_HEADER
+#include __FILE__
+
Do we guarantee that `__FILE__` names a path that can be used to include the
current file? In other tests, we add `-include %s` to the `RUN:` lin
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
(if you'd prefer to wait for Reid or Richard to take a look, that's OK too :) )
Looks good to me, though wouldn't mind if the tests were a bit simpler - if
they can be made so.
mclow.lists added a comment.
I committed as r311952 which fixes this - based on Jan's suggestion, but not
quite the same as this patch.
https://reviews.llvm.org/D32788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
Author: alexshap
Date: Mon Aug 28 15:58:54 2017
New Revision: 311947
URL: http://llvm.org/viewvc/llvm-project?rev=311947&view=rev
Log:
[analyzer] Adjust ptr arithmetic test
Replace "long" with __UINTPTR_TYPE__
to make the test added in rL311935 Windows-friendly.
Caught by the buildbot llvm-clang-
dcoughlin added a comment.
Except for some drive-by nits, this is a high-level review.
I have some high-level questions about the design of the library:
1. **How do you intend to handle the case when there are multiple function
definitions with the same USR?** Whose responsibility it is to deal
probinson added a comment.
Trying to understand the broader context here, I looked back through the list
of revisions mentioned in PR33930 to see if that helped.
When called on a method, CodeGenModule::EmitGlobalDefinition() calls
CodeGenModule::EmitGlobalFunctionDefinition(), which in turn cal
thakis updated this revision to Diff 112981.
thakis edited the summary of this revision.
thakis added a comment.
Don't warn in unevaluated contexts. Ready for a look now.
https://reviews.llvm.org/D37235
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaExprCXX.cpp
test/SemaCX
I had compiled a bunch of code with this, but right after I sent this out
my local build of something failed with this:
../../buildtools/third_party/libc++/trunk/include/type_traits:2156:51:
error: destructor called on non-final
'Ice::VariableDeclaration::RelocInitializer' that has virtual functio
thakis created this revision.
Makes the warning useful again in a std::unique_ptr world, PR28460.
https://reviews.llvm.org/D37235
Files:
include/clang/Basic/DiagnosticSemaKinds.td
test/SemaCXX/destructor.cpp
Index: test/SemaCXX/destructor.cpp
==
Author: ruiu
Date: Mon Aug 28 14:38:14 2017
New Revision: 311936
URL: http://llvm.org/viewvc/llvm-project?rev=311936&view=rev
Log:
Remove trailing space.
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp
Modified: cfe/trunk/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp
URL:
rsmith added a comment.
In https://reviews.llvm.org/D36527#854600, @rsmith wrote:
> We'll also need to agree within the cxx-abi-dev list how to mangle lambda
> closure types for this form
I filed https://github.com/itanium-cxx-abi/cxx-abi/issues/31 for this.
https://reviews.llvm.org/D36527
Hello everyone,
LLVM buildmaster will be updated and restarted in about 3 hours (after 5 PM
Pacific time).
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Sorry for the inconvenience!
I will follow-up in the PR.
--
Mehdi
2017-08-28 12:42 GMT-07:00 Hans Wennborg :
> I reverted this in r311898 as it caused Chromium builds to fail with
> an assertion; see PR34348.
>
> On Sun, Aug 27, 2017 at 1:24 PM, Mehdi Amini via cfe-commits
> wrote:
> > Autho
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311935: [analyzer] Fix crash in modeling arithmetic
(authored by alexshap).
Changed prior to commit:
https://reviews.llvm.org/D37120?vs=112784&id=112967#toc
Repository:
rL LLVM
https://reviews.llvm.
Author: alexshap
Date: Mon Aug 28 14:15:21 2017
New Revision: 311935
URL: http://llvm.org/viewvc/llvm-project?rev=311935&view=rev
Log:
[analyzer] Fix crash in modeling arithmetic
This diff fixes modeling of arithmetic
expressions where pointers are treated as integers
(i.e. via C-style / reinte
rsmith added a comment.
This patch appears to be missing some necessary changes in the following places:
- lib/Serialization -- round-trip the new information through PCH / modules
- lib/AST/StmtPrinter.cpp -- pretty-printing lambdas with explicit template
parameters
- lib/Sema/TreeTransform.h -
hans added a comment.
In https://reviews.llvm.org/D33852#854213, @aaron.ballman wrote:
> In https://reviews.llvm.org/D33852#854176, @Prazek wrote:
>
> > In https://reviews.llvm.org/D33852#853982, @aaron.ballman wrote:
> >
> > > In https://reviews.llvm.org/D33852#853410, @Prazek wrote:
> > >
> > >
ahatanak added a comment.
clang currently rejects "void foo(int = a);" and so does gcc.
I'm trying to search the defect reports, but it looks like the c++ standard's
site is currently unreachable.
https://reviews.llvm.org/D36915
___
cfe-commits m
johannes added a comment.
Yeah, this seems to be the best solution for this. I think I ran into the same
issue when working on the StmtDataCollector - basically there can only be two
Traverse*, one in the Derived class and the other one needs to do all the magic
with walking the specialisation
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311924: Reland r311842 - [cmake] Remove i686 target that is
duplicate to i386 (authored by mgorny).
Repository:
rL LLVM
https://reviews.llvm.org/D26764
Files:
compiler-rt/trunk/cmake/Modules/Compile
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311923: Reland r311836 - [Driver] Use arch type to find
compiler-rt libraries (on Linux) (authored by mgorny).
Repository:
rL LLVM
https://reviews.llvm.org/D26796
Files:
cfe/trunk/lib/Driver/ToolCha
Author: mgorny
Date: Mon Aug 28 13:29:52 2017
New Revision: 311923
URL: http://llvm.org/viewvc/llvm-project?rev=311923&view=rev
Log:
Reland r311836 - [Driver] Use arch type to find compiler-rt libraries (on Linux)
Use llvm::Triple::getArchTypeName() when looking for compiler-rt
libraries, rather
johannes updated this revision to Diff 112951.
johannes added a comment.
use a specialized getStmtChildren to fix the order for CXXOperatorCallExpr
https://reviews.llvm.org/D37200
Files:
include/clang/AST/LexicallyOrderedRecursiveASTVisitor.h
include/clang/AST/RecursiveASTVisitor.h
unitte
lebedev.ri added a comment.
I did not test this yet, but looks better :)
Comment at: test/clang-tidy/hicpp-exception-baseclass.cpp:26
}
throw non_derived_exception(); // Bad
+ // CHECK-MESSAGES: [[@LINE-1]]:9: warning: throwing an exception whose type
'non_derived_excep
george.karpenkov added a comment.
@kcc I've disabled the relevant test on Mac in r311916, please revert my change
once this CR goes through.
https://reviews.llvm.org/D37156
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
vsapsai added a comment.
It occurred to me that another approach for fixing the crash can be setting
`IsTypeSpecifier` to `true` while we ParseCastExpression. According to
cast-expression:
unary-expression
( type-id ) cast-expression
type-id:
type-specifier-seq abstract-declarato
faisalv added a comment.
In https://reviews.llvm.org/D36915#854317, @ahatanak wrote:
> In https://reviews.llvm.org/D36915#849622, @faisalv wrote:
>
> > I don't think this approach is entirely correct for at least the following
> > reasons:
> >
> > 1. in the lambda case the machinery that diagnos
I reverted this in r311898 as it caused Chromium builds to fail with
an assertion; see PR34348.
On Sun, Aug 27, 2017 at 1:24 PM, Mehdi Amini via cfe-commits
wrote:
> Author: mehdi_amini
> Date: Sun Aug 27 13:24:09 2017
> New Revision: 311857
>
> URL: http://llvm.org/viewvc/llvm-project?rev=311857
Author: abataev
Date: Mon Aug 28 12:26:54 2017
New Revision: 311908
URL: http://llvm.org/viewvc/llvm-project?rev=311908&view=rev
Log:
[OPENMP] Remove unused header files, NFC.
Modified:
cfe/trunk/lib/Sema/SemaOpenMP.cpp
Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp
URL:
http://llvm.org/viewvc
mgorny added a comment.
@eugenis, thanks for the suggestion. I've found the problematic push (that
attempts to move the wrong file) and filed https://reviews.llvm.org/D37226 for
review.
Repository:
rL LLVM
https://reviews.llvm.org/D26796
___
cf
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D37122
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: erichkeane
Date: Mon Aug 28 11:53:17 2017
New Revision: 311905
URL: http://llvm.org/viewvc/llvm-project?rev=311905&view=rev
Log:
Change Diagnostic Category size error from runtime to compiletime
Diagnostic Categories are fairly annoying, and are only enforced
by a runtime-debug-only asser
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311905: Change Diagnostic Category size error from runtime
to compiletime (authored by erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D37122?vs=112916&id=112931#toc
Repository:
rL LLV
aprantl added inline comments.
Comment at: lib/CodeGen/CGVTables.cpp:157
+ if (DebugInfo)
+DebugInfo->replaceTemporaryNodes();
+
probinson wrote:
> aprantl wrote:
> > Have you looked at what it would take to only finalize the nodes reachable
> > via the fun
johannes updated this revision to Diff 112926.
johannes edited the summary of this revision.
johannes added a comment.
split to ASTDiff/ASTPatch
https://reviews.llvm.org/D37005
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
include/clang/Tooling/ASTDiff/ASTPatch.h
lib/Tooling/ASTDiff/ASTD
zaks.anna added a comment.
> But I've never used the taint tracking mode, so I don't know what would be a
> reasonable default for MaxComp.
that one is very experimental anyway. I'd just keep the functional changes to
tain out of this patch and use the current default that taint uses.
https:/
george.karpenkov added a comment.
I don't, but I can check whether tests pass.
https://reviews.llvm.org/D37156
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zaks.anna added a comment.
Is this blocked on the same reasons as what was raised in
https://reviews.llvm.org/D35109?
https://reviews.llvm.org/D35110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
kcc added a reviewer: george.karpenkov.
kcc added a comment.
+George, in case he knows about __attribute__((tls_model("initial-exec"))) on
Mac
Comment at:
compiler-rt/lib/sanitizer_common/sanitizer_coverage_libcdep_new.cc:218
+SANITIZER_INTERFACE_ATTRIBUTE SANITIZER_WEAK_ATTR
morehouse updated this revision to Diff 112923.
morehouse added a comment.
Herald added a subscriber: kubamracek.
- Add weak definition of __sancov_lowest_stack to runtime.
https://reviews.llvm.org/D37156
Files:
clang/lib/Driver/SanitizerArgs.cpp
compiler-rt/lib/sanitizer_common/sanitizer_c
ahatanak added a comment.
In https://reviews.llvm.org/D36915#849622, @faisalv wrote:
> I don't think this approach is entirely correct for at least the following
> reasons:
>
> 1. in the lambda case the machinery that diagnoses capture failures should be
> the machinery erroring on the lambda (
erichkeane updated this revision to Diff 112916.
erichkeane marked an inline comment as done.
erichkeane added a comment.
Moved static assert into a .cpp file, DiagnosticIDs.cpp seems like the one that
makes the most sense.
https://reviews.llvm.org/D37122
Files:
include/clang/Basic/Diagnosti
Author: rnk
Date: Mon Aug 28 10:59:24 2017
New Revision: 311899
URL: http://llvm.org/viewvc/llvm-project?rev=311899&view=rev
Log:
Fix inaccurate comment about -fdelayed-template-parsing and MSVC
Modified:
cfe/trunk/lib/Driver/ToolChains/Clang.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/Cla
rsmith added inline comments.
Comment at:
test/libcxx/utilities/function.objects/func.require/incomplete_return_type.pass.cpp:17-19
+struct IncompleteReturnType {
+ std::function fn;
+};
Would it make sense to also check that this struct is copy-constructible?
Author: hans
Date: Mon Aug 28 10:53:00 2017
New Revision: 311898
URL: http://llvm.org/viewvc/llvm-project?rev=311898&view=rev
Log:
Revert r311857 "Emit static constexpr member as available_externally definition"
It caused PR759744.
> Emit static constexpr member as available_externally definitio
eugenis added a comment.
In https://reviews.llvm.org/D26796#853446, @mgorny wrote:
> The problems:
>
> 1.
> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-android/builds/2140/steps/annotate/logs/stdio
> -- purely this change,
This one still builds i686 libraries. Maybe it needs a cl
mclow.lists added inline comments.
Comment at:
test/libcxx/utilities/function.objects/func.require/incomplete_return_type.pass.cpp:1
+//===--===//
+//
mclow.lists wrote:
> Is this file in the ri
mclow.lists added inline comments.
Comment at:
test/libcxx/utilities/function.objects/func.require/incomplete_return_type.pass.cpp:1
+//===--===//
+//
Is this file in the right place?
If it's su
rnk added inline comments.
Comment at: include/clang/Basic/AllDiagnostics.h:37
+#define STRINGIFY_NAME(NAME) #NAME
+#define VALIDATE_DIAG_SIZE(NAME)
\
+ static_assert(
\
lhames added a comment.
In https://reviews.llvm.org/D36806#848246, @hintonda wrote:
> It's just too bad llvm::cantFail() doesn't take an optional string.
> But the code is cleaner, so I won't comment further.
That's not a bad idea actually. Let me add an optional error message to
cantFail for
ddcc added inline comments.
Comment at: lib/StaticAnalyzer/Core/SValBuilder.cpp:364
if (symLHS && symRHS &&
- (symLHS->computeComplexity() + symRHS->computeComplexity()) < MaxComp)
+ (symLHS->computeComplexity() + symRHS->computeComplexity()) < MaxComp)
return
aaron.ballman added a comment.
In https://reviews.llvm.org/D33852#854176, @Prazek wrote:
> In https://reviews.llvm.org/D33852#853982, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D33852#853410, @Prazek wrote:
> >
> > > Sorry for so late fixes, but it would be good to put it in 5.0
> >
b-sumner added inline comments.
Comment at: lib/Basic/Targets/AMDGPU.cpp:362
+Builder.defineMacro(Twine("__") + Twine(GPUName));
+Builder.defineMacro(Twine("__") + Twine(GPUName) + Twine("__"));
+ }
At the meeting we discussed defining every alias of the
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
Since the dependent patch landed, this LGTM too.
https://reviews.llvm.org/D35133
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
Prazek added a comment.
In https://reviews.llvm.org/D33852#853982, @aaron.ballman wrote:
> In https://reviews.llvm.org/D33852#853410, @Prazek wrote:
>
> > Sorry for so late fixes, but it would be good to put it in 5.0
>
>
> I do not think this should be in 5.0, as I believe we're only accepting
ruiu added a comment.
Technically, this patch fixes your issue, but I don't think this is a good way
of fixing it because `parse()` function now has an internal state which is not
obvious to the user of the function. Can you review
https://reviews.llvm.org/D37217? This is an alternative fix tha
mgorny added a comment.
I might be missing something but currently clang-tidy is not built at all when
static analyzer is disabled.
Repository:
rL LLVM
https://reviews.llvm.org/D37188
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
mprobst added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:1139
+
+ // On lines containing template strings, propagate NoLineBreak even for dict
+ // and array literals. This is to force wrapping an initial function call if
djasper wrote:
>
klimek added inline comments.
Comment at:
cfe/trunk/include/clang/Tooling/Refactoring/RefactoringActionRule.h:23-37
+/// A common refactoring action rule interface.
+class RefactoringActionRule {
+public:
+ enum RuleKind { SourceChangeRefactoringRuleKind };
+
+ RuleKind getRul
alexfh added a comment.
IIUC, these are the only clang-tidy tests that need static analyzer:
clang/tools/extra/test/clang-tidy/nolint.cpp
clang/tools/extra/test/clang-tidy/static-analyzer.cpp
clang/tools/extra/test/clang-tidy/static-analyzer-config.cpp
clang/tools/extra/test/clang-tidy/temporarie
arphaman added inline comments.
Comment at:
cfe/trunk/include/clang/Tooling/Refactoring/RefactoringActionRule.h:23-37
+/// A common refactoring action rule interface.
+class RefactoringActionRule {
+public:
+ enum RuleKind { SourceChangeRefactoringRuleKind };
+
+ RuleKind getR
alexfh added a comment.
This could be done even more granularly, since clang-tidy only needs static
analyzer to run clang-analyzer-* checks. But that would involve some careful
#ifdef-ing of the parts of clang-tidy/ClangTidy.cpp, so I'll understand if you
say you have little interest in this.
klimek added inline comments.
Comment at:
cfe/trunk/include/clang/Tooling/Refactoring/RefactoringActionRule.h:23-37
+/// A common refactoring action rule interface.
+class RefactoringActionRule {
+public:
+ enum RuleKind { SourceChangeRefactoringRuleKind };
+
+ RuleKind getRul
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D37120
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
arphaman added a comment.
The fact `TraverseCXXOperatorCallExpr` can't call its super
`TraverseCXXOperatorCallExpr` makes the current solution kind of broken. The
super implementation of `TraverseCXXOperatorCallExpr` is responsible for
dispatch to WalkUp##STMT functions which actually call
`Vi
johannes updated this revision to Diff 112894.
johannes added a comment.
detect prefix/postfix from number of arguments
https://reviews.llvm.org/D37200
Files:
include/clang/AST/LexicallyOrderedRecursiveASTVisitor.h
include/clang/AST/RecursiveASTVisitor.h
unittests/Tooling/LexicallyOrdered
1 - 100 of 152 matches
Mail list logo
