[PATCH] D37104: [libc++] PR34298: Change std::function constructor and move assignment operator SFINAE checks to allow std::function with an incomplete return type

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith added inline comments.


================
Comment at: 
test/libcxx/utilities/function.objects/func.require/incomplete_return_type.pass.cpp:17-19
+struct IncompleteReturnType {
+  std::function<IncompleteReturnType ()> fn;
+};
----------------
Would it make sense to also check that this struct is copy-constructible? 
As-is, whether this test tests anything is entirely dependent on what amount to 
implementation details of the constructor.


Repository:
  rL LLVM

https://reviews.llvm.org/D37104



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits