This revision was automatically updated to reflect the committed changes.
Closed by commit rL303719: [XRay][clang] Allow imbuing arg1 logging attribute
via -fxray-always-instrument= (authored by dberris).
Changed prior to commit:
https://reviews.llvm.org/D33392?vs=99715&id=100042#toc
Repositor
Author: dberris
Date: Wed May 24 00:46:36 2017
New Revision: 303719
URL: http://llvm.org/viewvc/llvm-project?rev=303719&view=rev
Log:
[XRay][clang] Allow imbuing arg1 logging attribute via -fxray-always-instrument=
Summary:
This change allows us to add arg1 logging support to functions through
th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303718: [demangler] Fix a crash in the demangler during
parsing of a lamdba (authored by epilk).
Changed prior to commit:
https://reviews.llvm.org/D33368?vs=99930&id=100041#toc
Repository:
rL LLVM
h
Author: epilk
Date: Wed May 24 00:44:19 2017
New Revision: 303718
URL: http://llvm.org/viewvc/llvm-project?rev=303718&view=rev
Log:
[demangler] Fix a crash in the demangler during parsing of a lamdba
The problem is that multiple types could have been parsed from parse_type(),
which the lamdba par
erik.pilkington added inline comments.
Comment at: src/cxa_demangle.cpp:3036
break;
-if (db.names.size() < 2)
+assert(k0 <= k1 && "parse_type() mutated the name stack");
+if (k1 == k0)
--
erik.pilkington accepted this revision.
erik.pilkington added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Comment at: lib/Sema/SemaExpr.cpp:15747
+ // warn when it's used inappropriately (i.e. not if(@available)).
+ if (getCurFunctionOrMethodDecl
GorNishanov accepted this revision.
GorNishanov added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D33481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
GorNishanov created this revision.
Now we helpfully provide a note pointing at the promise_type in question.
https://reviews.llvm.org/D33481
Files:
lib/Sema/SemaCoroutine.cpp
test/SemaCXX/coroutine-unhandled_exception-warning.cpp
test/SemaCXX/coroutines.cpp
Index: test/SemaCXX/coroutine
GorNishanov accepted this revision.
GorNishanov added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D33479
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
GorNishanov created this revision.
- Test that coroutine promise destructor is called.
- Test that we call return_void on fallthrough
- Test that we call unhandled exception in a try catch surrounding the body
https://reviews.llvm.org/D33479
Files:
test/CodeGenCoroutines/Inputs/coroutine.h
rdwampler created this revision.
https://reviews.llvm.org/D33478
Files:
test/Index/availability.c
tools/libclang/CIndex.cpp
Index: tools/libclang/CIndex.cpp
===
--- tools/libclang/CIndex.cpp
+++ tools/libclang/CIndex.cpp
@@ -720
GorNishanov closed this revision.
GorNishanov added a comment.
Closed by commit https://reviews.llvm.org/rL303716: [coroutines] Implement
correct GRO lifetime (authored by GorNishanov)
https://reviews.llvm.org/D31670
___
cfe-commits mailing list
cf
GorNishanov accepted this revision.
GorNishanov added a comment.
This revision is now accepted and ready to land.
Landed as: https://reviews.llvm.org/rL303716
https://reviews.llvm.org/D31670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303716: [coroutines] Implement correct GRO lifetime
(authored by GorNishanov).
Changed prior to commit:
https://reviews.llvm.org/D33477?vs=100029&id=100030#toc
Repository:
rL LLVM
https://reviews.ll
Author: gornishanov
Date: Tue May 23 21:38:26 2017
New Revision: 303716
URL: http://llvm.org/viewvc/llvm-project?rev=303716&view=rev
Log:
[coroutines] Implement correct GRO lifetime
Summary:
Sema creates a declaration for gro variable as:
auto $gro = $promise.get_return_object();
However, gro v
GorNishanov created this revision.
Herald added a subscriber: EricWF.
Sema creates a declaration for gro variable as:
auto $gro = $promise.get_return_object();
However, gro variable has to outlive coroutine frame and coroutine promise, but,
it can only be initialized after the coroutine promise
GorNishanov updated this revision to Diff 100027.
GorNishanov added a comment.
merge with tot, preparing to land
https://reviews.llvm.org/D31670
Files:
lib/CodeGen/CGCoroutine.cpp
test/CodeGenCoroutines/coro-gro.cpp
Index: test/CodeGenCoroutines/coro-gro.cpp
===
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/misc-default-numerics.rst:11
+Consider scenario:
+1. Have `typedef long long BigInt` in source code
+2. Use `std::numeric_limits::min()`
May be code-block will be better?
https://reviews.l
dexonsmith added inline comments.
Comment at: src/cxa_demangle.cpp:3036
break;
-if (db.names.size() < 2)
+assert(k0 <= k1 && "parse_type() mutated the name stack");
+if (k1 == k0)
---
GorNishanov added a comment.
Fixed:
r303714 = 8832327ab89f3668378d70d1c4e5a218446ce36e
https://reviews.llvm.org/D31608
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: gornishanov
Date: Tue May 23 20:54:37 2017
New Revision: 303714
URL: http://llvm.org/viewvc/llvm-project?rev=303714&view=rev
Log:
[coroutines] Fix leak in CGCoroutine.cpp
FinalBB need to be emitted even when unused to make sure it is deleted
Modified:
cfe/trunk/lib/CodeGen/CGCoroutin
GorNishanov added a comment.
In https://reviews.llvm.org/D31608#762783, @alekseyshl wrote:
> Leaks and warnings are reported in coro-await.cpp:
> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/1400/steps/check-clang%20asan/logs/stdio.
> Please fix.
Thank you! The fi
Author: akirtzidis
Date: Tue May 23 20:38:00 2017
New Revision: 303713
URL: http://llvm.org/viewvc/llvm-project?rev=303713&view=rev
Log:
Change __has_feature(objc_diagnose_if_attr) to
__has_feature(attribute_diagnose_if_objc) for consistency with rest of
attribute checks.
Modified:
cfe/trun
mpark added a comment.
@CaseyCarter: Does this not pass with the current version?
Also, have you seen the tests in
`test/libcxx/utilities/variant/variant.variant`?
If yes, do those tests and the ones in this diff overlap at all?
Curious as to how we should merge them.
https://reviews.llvm.org/D
kastiglione created this revision.
This change allows `llvm-nm` to print symbols found in import libraries, in part
by allowing `COFFImportFile`s to be casted to `SymbolicFile`s.
https://reviews.llvm.org/D33474
Files:
include/llvm/Object/Binary.h
test/tools/llvm-nm/X86/Inputs/example.lib
mpark added a comment.
Thanks for the tests! I'll try this out with an implementation shortly.
https://reviews.llvm.org/D32515
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: akirtzidis
Date: Tue May 23 19:46:27 2017
New Revision: 303712
URL: http://llvm.org/viewvc/llvm-project?rev=303712&view=rev
Log:
Enhance the 'diagnose_if' attribute so that we can apply it for ObjC methods
and properties as well
This is an initial commit to allow using it with constant e
compnerd added a comment.
Looks generally pretty good. This is going to be a pretty cool addition!
Comment at: lib/Driver/ToolChains/BareMetal.cpp:68
+ SmallString<128> Dir(getDriver().ResourceDir);
+ llvm::sys::path::append(Dir, "lib", "baremetal");
+ return Dir.str();
---
marcel abandoned this revision.
marcel added a comment.
Closed. Patch https://reviews.llvm.org/D33368 addresses PR32890 more
comprehensively.
https://reviews.llvm.org/D33393
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
Author: bruno
Date: Tue May 23 18:53:17 2017
New Revision: 303705
URL: http://llvm.org/viewvc/llvm-project?rev=303705&view=rev
Log:
[Modules] Fix overly conservative assertion for import diagnostic
We currenltly assert when want to diagnose a missing import and the decl
in question is already vis
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303705: [Modules] Fix overly conservative assertion for
import diagnostic (authored by bruno).
Changed prior to commit:
https://reviews.llvm.org/D32828?vs=100016&id=100023#toc
Repository:
rL LLVM
ht
Any specific reason why this doesn't contain a testcase?
On Tue, May 23, 2017 at 4:37 AM, Ilya Biryukov via cfe-commits
wrote:
> Author: ibiryukov
> Date: Tue May 23 06:37:52 2017
> New Revision: 303630
>
> URL: http://llvm.org/viewvc/llvm-project?rev=303630&view=rev
> Log:
> Allow to use vfs::Fi
alekseyshl added a comment.
Leaks and warnings are reported in coro-await.cpp:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/1400/steps/check-clang%20asan/logs/stdio.
Please fix.
https://reviews.llvm.org/D31608
___
cfe-
alekseyshl added a comment.
This bot reports leaks in coro-alloc.cpp:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/1401/steps/check-clang%20asan/logs/stdio.
Please fix.
Repository:
rL LLVM
https://reviews.llvm.org/D31584
__
jroelofs updated this revision to Diff 100018.
jroelofs added a comment.
fixed the v7m/v7em part of the build
https://reviews.llvm.org/D33259
Files:
cmake/caches/BaremetalARM.cmake
lib/Driver/CMakeLists.txt
lib/Driver/Driver.cpp
lib/Driver/ToolChains/BareMetal.cpp
lib/Driver/ToolChain
bruno updated this revision to Diff 100016.
bruno added a comment.
Updated the patch after Richard's comments. Removed the assertion but bail out
early if the module is already visible.
https://reviews.llvm.org/D32828
Files:
lib/Sema/SemaDecl.cpp
lib/Sema/SemaLookup.cpp
test/Modules/Inpu
rjmccall added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:1436
+if (BaseInfo.getMayAlias())
+ TBAAInfo = CGM.getTBAAInfo(getContext().CharTy);
llvm::MDNode *TBAAPath = CGM.getTBAAStructTagInfo(TBAABaseType, TBAAInfo,
kparzysz wrote:
> rjmcc
On 23 May 2017 at 15:11, Tim Northover via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> > + if (!isImaginary) {
> >
> > Shouldn't this be "if (s != ThisTokEnd)"? (That is, if this was not a
> valid builtin suffix, reset the suffix information.)
>
> I think they're equivalent here:
>
>
Prazek created this revision.
Herald added subscribers: xazax.hun, mgorny.
This check flags usages of ``std::numeric_limits::{min,max}()`` for
unspecialized types. It is dangerous because returns T(), which might is
rarely
minimum or maximum for this type.
Consider scenario:
1. Have `typedef lon
v.g.vassilev added a subscriber: davidlt.
v.g.vassilev added a comment.
Adding David in the loop.
Repository:
rL LLVM
https://reviews.llvm.org/D33467
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
chandlerc added a comment.
What error are you trying to fix? We use flags without `.getValue()` all over
the place, I don't know why we would need to change that here.
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:173
EnablePGOInstrGen = RunPGOInstrGen;
-PGOIn
> + if (!isImaginary) {
>
> Shouldn't this be "if (s != ThisTokEnd)"? (That is, if this was not a valid
> builtin suffix, reset the suffix information.)
I think they're equivalent here:
!isImaginary => UDL is _ or time thing => extra crap on the end.
extra crap on the end => it's n
Author: rsmith
Date: Tue May 23 17:02:49 2017
New Revision: 303699
URL: http://llvm.org/viewvc/llvm-project?rev=303699&view=rev
Log:
[modules] When reparenting a local declaration, don't mark the declaration as
being visible with its owning module if we're not tracking owning modules for
local dec
nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.
Much like Eric's comments, mine shouldn't hold up approval. Feel free to
address them on the commit.
LGTM.
Comment at: lib/Sema/SemaChecking.cpp:3900
+// Which takes th
v.g.vassilev created this revision.
Herald added a subscriber: mehdi_amini.
Recent changes within GCC 7 libstdc++ caused build errors inside embedded LLVM.
Patch by David Abdurachmanov!
Repository:
rL LLVM
https://reviews.llvm.org/D33467
Files:
lib/Transforms/IPO/PassManagerBuilder.cpp
aprantl accepted this revision.
aprantl added a comment.
This is good from my point of view now. You might want to wait for an ok from
@spyffe.
https://reviews.llvm.org/D32724
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
On 23 May 2017 at 14:41, Tim Northover via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: tnorthover
> Date: Tue May 23 16:41:49 2017
> New Revision: 303694
>
> URL: http://llvm.org/viewvc/llvm-project?rev=303694&view=rev
> Log:
> Sema: allow imaginary constants via GNU extension if UD
t.p.northover closed this revision.
t.p.northover added a comment.
Thanks Richard, I've committed it as r303694 with your suggestions.
https://reviews.llvm.org/D33424
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
Author: tnorthover
Date: Tue May 23 16:41:49 2017
New Revision: 303694
URL: http://llvm.org/viewvc/llvm-project?rev=303694&view=rev
Log:
Sema: allow imaginary constants via GNU extension if UDL overloads not present.
C++14 added user-defined literal support for complex numbers so that you can
wri
kparzysz added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:1436
+if (BaseInfo.getMayAlias())
+ TBAAInfo = CGM.getTBAAInfo(getContext().CharTy);
llvm::MDNode *TBAAPath = CGM.getTBAAStructTagInfo(TBAABaseType, TBAAInfo,
rjmccall wrote:
> Hmm.
Author: d0k
Date: Tue May 23 15:48:21 2017
New Revision: 303686
URL: http://llvm.org/viewvc/llvm-project?rev=303686&view=rev
Log:
[Frontend] Don't index into an empty string.
Found by msan!
Modified:
cfe/trunk/lib/Frontend/TextDiagnostic.cpp
Modified: cfe/trunk/lib/Frontend/TextDiagnostic.c
rjmccall added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:1436
+if (BaseInfo.getMayAlias())
+ TBAAInfo = CGM.getTBAAInfo(getContext().CharTy);
llvm::MDNode *TBAAPath = CGM.getTBAAStructTagInfo(TBAABaseType, TBAAInfo,
Hmm. Should we be cons
rsmith added a comment.
In https://reviews.llvm.org/D29951#750885, @v.g.vassilev wrote:
> In order to create a reasonable test I need to use
> `-error-on-deserialized-decl` and I hit a bug:
> https://bugs.llvm.org/show_bug.cgi?id=32988
>
> Richard, could you help me out with the test? Maybe we
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
I like it, and it seems like it would nicely generalize if there are more cases
that we find need this treatment.
Comment at: clang/lib/Lex/LiteralSupport.cpp:676-682
-
hiraditya added a comment.
Ping
https://reviews.llvm.org/D30268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
t.p.northover updated this revision to Diff 99974.
t.p.northover added a comment.
OK, that seems doable. After playing around I came up with this new patch (and
remembered to "git add" my own test this time).
It feels like a bit of a hack, but I played around with some alternatives and
couldn't
rsmith added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:2661-2669
+// If we're in local visibility mode, we reuse this allocation function
+// in all submodules of the current module. To make sure that the other
+// submodules can lookup this function, we u
malhar1995 updated this revision to Diff 99970.
malhar1995 added a comment.
Applied clang-format only to the changed lines in the final code.
Repository:
rL LLVM
https://reviews.llvm.org/D32449
Files:
.gitignore
lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp
test/Analysis/pthreadlo
jroelofs planned changes to this revision.
jroelofs added inline comments.
Comment at: cmake/caches/BaremetalARM.cmake:10
+
+set(BUILTINS_armv7m-none-eabi_CMAKE_SYSROOT ${BAREMETAL_ARMV7M_SYSROOT} CACHE
STRING "armv7m-none-eabi Sysroot")
+set(BUILTINS_armv7m-none-eabi_CMAKE_SYST
echristo requested changes to this revision.
echristo added a comment.
This revision now requires changes to proceed.
I probably would have added this as a feature in ARMTargetInfo similar to
CRC/soft-float/etc.
Thoughts?
-eric
https://reviews.llvm.org/D33448
__
rsmith added inline comments.
Comment at: include/clang/Serialization/ASTReader.h:551
+ llvm::SmallVector PendingLazySpecializationIDs;
+
I'm not sure we can safely use global state for this: loading update records
can trigger the import of a declaration and
Typz added inline comments.
Comment at: include/clang/Format/Format.h:158
+ ///
+ bool AllowEmptyFunctionBodyOnASingleLine;
+
maybe this should be a nested option inside BraceWrapping?
or this should be donc implicit when breaking after function
(BraceWrappin
jtony updated this revision to Diff 99966.
https://reviews.llvm.org/D33053
Files:
include/clang/Basic/BuiltinsPPC.def
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/CodeGen/CGBuiltin.cpp
lib/Headers/altivec.h
lib/Sema/SemaChecking.cpp
test/CodeGen/builtins-
Author: marshall
Date: Tue May 23 13:55:32 2017
New Revision: 303675
URL: http://llvm.org/viewvc/llvm-project?rev=303675&view=rev
Log:
Implement LWG#2790: Remove istreambuf_iterator::operator->. It never did
anything useful.
Removed:
libcxx/trunk/test/std/iterators/stream.iterators/istreamb
Author: yamaguchi
Date: Tue May 23 13:52:27 2017
New Revision: 303672
URL: http://llvm.org/viewvc/llvm-project?rev=303672&view=rev
Log:
Remove trailing whitespace
Modified:
cfe/trunk/utils/bash-autocomplete.sh
Modified: cfe/trunk/utils/bash-autocomplete.sh
URL:
http://llvm.org/viewvc/llvm-p
erik.pilkington added a comment.
> but having a constant like this ("7") sounds wrong. Why not 6, or 8, or 42?
7 is correct here because we inserting into a specific point into a string that
was inserted into db.names just above this (but out of context from the diff).
The only problem is that
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D33392
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: yamaguchi
Date: Tue May 23 13:39:08 2017
New Revision: 303670
URL: http://llvm.org/viewvc/llvm-project?rev=303670&view=rev
Log:
[GSoC] Shell autocompletion for clang
Summary:
This is a first patch for GSoC project, bash-completion for clang.
To use this on bash, please run `source clang/u
echristo accepted this revision.
echristo added a comment.
Couple of small nits and a request to make some of the change separately, but
otherwise LGTM. For the split part please don't actually submit another patch,
just go ahead and do it :)
Thanks!
-eric
Comment at: inclu
inouehrs added inline comments.
Comment at: test/CodeGen/builtins-ppc-error.c:23
+void testXXPERMDI(void) {
+ int index = 5;
+ vec_xxpermdi(vsi); //expected-error {{too few arguments to function call,
expected at least 3, have 1}}
jtony wrote:
> inouehrs wrote
kcc added a comment.
I don't know this code and can't properly comment, but having a constant like
this ("7") sounds wrong.
Why not 6, or 8, or 42?
https://reviews.llvm.org/D33393
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
jtony updated this revision to Diff 99955.
jtony marked 6 inline comments as done.
jtony added a comment.
Address more comments from Nemanja and Hiroshi.
https://reviews.llvm.org/D33053
Files:
include/clang/Basic/BuiltinsPPC.def
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sem
jtony added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:3900
+// vector short vec_xxsldwi(vector short, vector short, int);
+bool Sema::SemaBuiltinVSX(CallExpr *TheCall, unsigned NumArgs) {
+ if (TheCall->getNumArgs() < NumArgs)
nemanjai wrote:
> I as
vsk added a comment.
Ping.
https://reviews.llvm.org/D32724
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsk added a subscriber: george.karpenkov.
vsk added a comment.
Ping. (@george.karpenkov, do you have the time to take a look?)
https://reviews.llvm.org/D32842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
erik.pilkington added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2889
+ "use if (%select{@available|__builtin_available}0) instead">,
+ InGroup>;
Might be a bit more clear if you mention in words that @available can only be
the s
jroelofs updated this revision to Diff 99950.
https://reviews.llvm.org/D33259
Files:
cmake/caches/BaremetalARM.cmake
lib/Driver/CMakeLists.txt
lib/Driver/Driver.cpp
lib/Driver/ToolChains/BareMetal.cpp
lib/Driver/ToolChains/BareMetal.h
test/Driver/Inputs/baremetal_arm/include/c++/v1/.k
arphaman created this revision.
We should warn about uses of `@available` in all places except for `if
(@available(...))` because we only support the guarded availability checking
using `if (@available(...))`.
Repository:
rL LLVM
https://reviews.llvm.org/D33450
Files:
include/clang/Basic
Author: gkistanova
Date: Tue May 23 11:56:10 2017
New Revision: 303653
URL: http://llvm.org/viewvc/llvm-project?rev=303653&view=rev
Log:
Removed fallthrough annotation which does not directly precede switch label.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/lib/Basic/Target
kparzysz updated this revision to Diff 99939.
kparzysz added a comment.
Checking for offset 0 in the TBAA info.
Repository:
rL LLVM
https://reviews.llvm.org/D33328
Files:
lib/CodeGen/CGExpr.cpp
test/CodeGen/union-tbaa1.c
test/CodeGenCXX/union-tbaa2.cpp
Index: test/CodeGenCXX/union-tba
Author: arphaman
Date: Tue May 23 11:47:01 2017
New Revision: 303651
URL: http://llvm.org/viewvc/llvm-project?rev=303651&view=rev
Log:
[index] The references to enum constants from member enums that are
from template instantiations should refer to the enum constant in the pattern
enum in the base
fhahn created this revision.
Herald added subscribers: javed.absar, mehdi_amini, aemerson.
The thumb-mode target feature is used to force Thumb or ARM code
generation on a per-function basis. Explicitly adding +thumb-mode to
functions for thumbxx triples enables mixed ARM/Thumb code generation in
Typz added inline comments.
Comment at: unittests/Format/FormatTest.cpp:6029
+
+ //TODO: this case does not work, not sure if there is reason...
+ MergeEmptyOnly.BreakBeforeBraces = FormatStyle::BS_Custom;
When testing this patch, I found a bug when `AllowShort
Typz created this revision.
Herald added a subscriber: klimek.
This option supplements the AllowShortFunctionsOnASingleLine flag, to
merge empty function body at the beginning of the line: e.g. when the
function is not short-enough and breaking braces after function.
int f()
{}
https://revi
Author: arphaman
Date: Tue May 23 11:35:50 2017
New Revision: 303650
URL: http://llvm.org/viewvc/llvm-project?rev=303650&view=rev
Log:
[index] The references to member enums from template instantiations should
refer to the pattern member enum in the base template
rdar://32325459
Modified:
cf
Author: gkistanova
Date: Tue May 23 11:33:07 2017
New Revision: 303649
URL: http://llvm.org/viewvc/llvm-project?rev=303649&view=rev
Log:
Added LLVM_FALLTHROUGH to address gcc warning: this statement may fall through.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/lib/Basic/Tar
hfinkel added inline comments.
Comment at: test/CodeGen/union-tbaa1.c:44
+// CHECK: ![[CHAR:[0-9]+]] = !{!"omnipotent char"
+// CHECK: ![[OCPATH]] = !{![[CHAR]]
kparzysz wrote:
> hfinkel wrote:
> > Please check the path offset?
> What needs to be checked exactly?
erik.pilkington added a comment.
> You could append my test case as a quick-check.
Sure, I added the test case here to my patch and it works.
> So, I'll go ahead and abandon this revision?
Guess so, sorry for the confusion here.
https://reviews.llvm.org/D33393
_
kparzysz added inline comments.
Comment at: test/CodeGen/union-tbaa1.c:44
+// CHECK: ![[CHAR:[0-9]+]] = !{!"omnipotent char"
+// CHECK: ![[OCPATH]] = !{![[CHAR]]
hfinkel wrote:
> Please check the path offset?
What needs to be checked exactly? The offset will be
Author: arphaman
Date: Tue May 23 11:27:42 2017
New Revision: 303648
URL: http://llvm.org/viewvc/llvm-project?rev=303648&view=rev
Log:
[index] The references to type aliases and typedefs from template
instantiations should refer to the pattern type aliases / typedefs in the base
templates
rdar://
erik.pilkington updated this revision to Diff 99930.
erik.pilkington added a comment.
In this new patch:
- Add the testcase from https://reviews.llvm.org/D33393
- Add an assert() that k0 <= k1
- Use std::for_each instead of the for loop
Thanks for taking a look,
Erik
https://reviews.llvm.org/D
hfinkel added inline comments.
Comment at: test/CodeGen/union-tbaa1.c:44
+// CHECK: ![[CHAR:[0-9]+]] = !{!"omnipotent char"
+// CHECK: ![[OCPATH]] = !{![[CHAR]]
Please check the path offset?
Comment at: test/CodeGenCXX/union-tbaa2.cpp:45
+// CH
fgross added a comment.
Thanks a lot, will do.
Repository:
rL LLVM
https://reviews.llvm.org/D33354
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arphaman
Date: Tue May 23 11:25:06 2017
New Revision: 303647
URL: http://llvm.org/viewvc/llvm-project?rev=303647&view=rev
Log:
[index] The references to fields from nested records in template instantiations
should refer to the pattern fields in the nested records in the base templates
rda
Author: arphaman
Date: Tue May 23 11:23:28 2017
New Revision: 303646
URL: http://llvm.org/viewvc/llvm-project?rev=303646&view=rev
Log:
[index] The references to records from template instantiations should refer
to the pattern records in the base templates
rdar://32325459
Modified:
cfe/trunk/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303645: [clang-tidy] Do not dereference a null BaseType
(authored by chh).
Changed prior to commit:
https://reviews.llvm.org/D33430?vs=99842&id=99929#toc
Repository:
rL LLVM
https://reviews.llvm.org
Author: chh
Date: Tue May 23 11:19:04 2017
New Revision: 303645
URL: http://llvm.org/viewvc/llvm-project?rev=303645&view=rev
Log:
[clang-tidy] Do not dereference a null BaseType
Check BaseType before dereference.
Simplified test case is derived from Android Open Source code.
Differential Revisio
Thanks, I added that test case in r303642. I was struggling to identify the
behavior change.
On Mon, May 22, 2017 at 4:37 PM, Richard Smith
wrote:
> On 22 May 2017 at 15:22, Reid Kleckner via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> On Mon, May 22, 2017 at 3:17 PM, Richard Smith
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303644: [AMDGPU] Do not require opencl triple environment
for OpenCL (authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D33445?vs=99921&id=99928#toc
Repository:
rL LLVM
https://
Author: yaxunl
Date: Tue May 23 11:15:53 2017
New Revision: 303644
URL: http://llvm.org/viewvc/llvm-project?rev=303644&view=rev
Log:
[AMDGPU] Do not require opencl triple environment for OpenCL
A recent change requires opencl triple environment for compiling OpenCL
program, which causes regressio
1 - 100 of 178 matches
Mail list logo
