Typz added inline comments.
================ Comment at: include/clang/Format/Format.h:158 + /// + bool AllowEmptyFunctionBodyOnASingleLine; + ---------------- maybe this should be a nested option inside BraceWrapping? or this should be donc implicit when breaking after function (BraceWrapping.AfterFunction = true) and AllowShortFunctionOnASingleLine (hence no option added) ? Or even AllowShortBlocksOnASingleLine (though the doc limits this option to statements...) ================ Comment at: unittests/Format/FormatTest.cpp:6131 verifyFormat("union foo a = {bar};\nint n;"); // Elaborate types inside function definitions. ---------------- missing test for parsing YAML option https://reviews.llvm.org/D33447 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits