chandlerc added a comment.

What error are you trying to fix? We use flags without `.getValue()` all over 
the place, I don't know why we would need to change that here.



================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:173
     EnablePGOInstrGen = RunPGOInstrGen;
-    PGOInstrGen = PGOOutputFile;
-    PGOInstrUse = RunPGOInstrUse;
+    PGOInstrGen = RunPGOInstrGen.getValue();
+    PGOInstrUse = RunPGOInstrUse.getValue();
----------------
This isn't right -- the previous code was correct.


Repository:
  rL LLVM

https://reviews.llvm.org/D33467



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D33467: F... Vassil Vassilev via Phabricator via cfe-commits
    • [PATCH] D334... Chandler Carruth via Phabricator via cfe-commits
    • [PATCH] D334... Vassil Vassilev via Phabricator via cfe-commits
    • [PATCH] D334... David Abdurachmanov via Phabricator via cfe-commits
      • Re: [PAT... Chandler Carruth via cfe-commits
        • Re: ... David Abdurachmanov via cfe-commits
          • ... Chandler Carruth via cfe-commits
      • Re: [PAT... Richard Smith via cfe-commits
    • [PATCH] D334... Vassil Vassilev via Phabricator via cfe-commits
    • [PATCH] D334... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D334... Vassil Vassilev via Phabricator via cfe-commits

Reply via email to