rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
If we're now catching integer overflow in more cases, please add some relevant
testcases. If this is a pure refactoring that enables those additional
diagnostics to be produced in future, then
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D32455
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
For the tests I've extracted the int5 and int8 cases to cater for
different alignments for different platform ABIs. For Linux on POWER the
5 and 8 element vectors must be naturally aligned with respect to the
total "soft" vector size, despite being represented as an aggregate.
Specifically, the pat
faisalv updated this revision to Diff 96861.
faisalv added a comment.
Fixed a regression test that should have passed without emitting error
diagnostics - and now does.
https://reviews.llvm.org/D31588
Files:
include/clang/Parse/Parser.h
lib/Parse/ParseExpr.cpp
lib/Parse/ParseTemplate.cpp
faisalv updated this revision to Diff 96858.
faisalv marked 3 inline comments as done.
faisalv added a comment.
Updated the patch following Richard's feedback:
- teach ParseConstantExpression to create its own ExpressionEvaluationContext
only if asked to.
https://reviews.llvm.org/D31588
Files
dexonsmith added a comment.
Oh, and it would be nice to split out
`Preprocessor::diagnoseMissingHeaderInUmbrellaDir` in a separate NFC commit
ahead of time.
https://reviews.llvm.org/D32576
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM after a couple of changes inline.
Comment at: lib/Lex/PPLexerChange.cpp:290-292
+static void
+collectAllSubModulesWithUmbrellaHeader(Module *Mod,
+
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Thanks for your patience! LGTM with a minor comment below.
Comment at: test/Sema/vector-gcc-compat.c:101
+
+ v2i64_r = v2i64_a && 1; // expected-error {{invalid vector operand
Hey Alexey,
This is causing asan errors, e.g.:
==4735==ERROR: AddressSanitizer: heap-buffer-overflow on
address 0x61f00e70 at pc 0x00010a8a7f4a bp 0x7fff5c57a390
sp 0x7fff5c57a388
READ of size 4 at 0x61f00e70 thread T0
#0 0x10a8a7f49 in
(anonymous namespace)::DSAStackTy::hasDSA(clang:
Author: dexonsmith
Date: Wed Apr 26 20:47:22 2017
New Revision: 301508
URL: http://llvm.org/viewvc/llvm-project?rev=301508&view=rev
Log:
Darwin: Define __STDC_NO_THREADS__ on Darwin targets
Darwin doesn't support C11 threads.h. Define `__STDC_NO_THREADS__` so
that users can check for it.
rdar:/
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Thanks Alex. LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D28670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
bruno created this revision.
One of the -Wincomplete-umbrella warnings diagnoses when a header is present in
the directory but it's not present in the umbrella header. Currently, this
warning only happens on top level modules; any submodule using an umbrella
header does not get this warning. Fi
Author: rsmith
Date: Wed Apr 26 20:17:05 2017
New Revision: 301507
URL: http://llvm.org/viewvc/llvm-project?rev=301507&view=rev
Log:
Improve diagnostics for bad -std= flag.
Don't list deprecated -std= values (c++0x etc). Only produce one line of output
per standard, even if we know it by multiple
Author: chapuni
Date: Wed Apr 26 19:09:42 2017
New Revision: 301503
URL: http://llvm.org/viewvc/llvm-project?rev=301503&view=rev
Log:
clang/Lex/PPCallbacks.h: Fix a warning in r301472. [-Wdocumentation]
Modified:
cfe/trunk/include/clang/Lex/PPCallbacks.h
Modified: cfe/trunk/include/clang/Lex
jgorbe created this revision.
The current name is confusing: it looks like it should just compute the path
and return it but it has the side effect of appending it to the compilation's
list of result files. This change changes the verb in the method name from
"get" to "add" to emphasize this si
BillyONeal created this revision.
In T_size_size.pass, there is an explicit template argument to std::min to ask
for unsigned, to avoid type deduction errors. However, C1XX' warnings still
hate this use, because a 64 bit value (a size_t) is being passed to a function
accepting an unsigned (a 32 bi
Author: rsmith
Date: Wed Apr 26 18:49:57 2017
New Revision: 301500
URL: http://llvm.org/viewvc/llvm-project?rev=301500&view=rev
Log:
Remove unnecessary and somewhat inaccurate "C89" flag from language standards.
Modified:
cfe/trunk/include/clang/Frontend/LangStandard.h
cfe/trunk/include/c
Author: rsmith
Date: Wed Apr 26 18:44:33 2017
New Revision: 301497
URL: http://llvm.org/viewvc/llvm-project?rev=301497&view=rev
Log:
Don't accept -std= values that would switch us to a different source language.
We already prohibited this in most cases (in r130710), but had some bugs in our
enfor
Author: ruiu
Date: Wed Apr 26 18:15:10 2017
New Revision: 301491
URL: http://llvm.org/viewvc/llvm-project?rev=301491&view=rev
Log:
Revert r301487: Replace HashString algorithm with xxHash64
This reverts commit r301487 to make buildbots green.
Modified:
cfe/trunk/test/CodeGen/target-features-
vsk updated this revision to Diff 96847.
vsk retitled this revision from "[Profile] Warn about out-of-date profiles only
when there are mismatches" to "[Profile] Add off-by-default
-Wprofile-instr-missing warning".
vsk edited the summary of this revision.
vsk added a reviewer: davidxl.
vsk added
bruno added a comment.
@rsmith ping!
https://reviews.llvm.org/D31778
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ruiu
Date: Wed Apr 26 17:45:04 2017
New Revision: 301487
URL: http://llvm.org/viewvc/llvm-project?rev=301487&view=rev
Log:
Replace HashString algorithm with xxHash64
The previous algorithm processed one character at a time, which is very
painful on a modern CPU. Replace it with xxHash64,
Author: gbiv
Date: Wed Apr 26 17:37:38 2017
New Revision: 301486
URL: http://llvm.org/viewvc/llvm-project?rev=301486&view=rev
Log:
Fix comment. NFC
Modified:
cfe/trunk/lib/Sema/SemaExpr.cpp
Modified: cfe/trunk/lib/Sema/SemaExpr.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema
emilio added a comment.
> FWIW when I wrote https://reviews.llvm.org/D26663, I did it because arguments
> weren't inspectionable at all for `using` declarations. Actually both of them
> would've worked for me.
Also, this bit was not completely accurate, and you could inspect ones, but not
othe
emilio added a comment.
Revert + tests @ https://reviews.llvm.org/D32566
Repository:
rL LLVM
https://reviews.llvm.org/D32348
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
BillyONeal added a comment.
Hi folks, any update on this or is just fixing @rsmith's comment OK?
Thanks!
https://reviews.llvm.org/D32309
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
emilio created this revision.
emilio added a project: clang-c.
See https://reviews.llvm.org/D32348#738704
Repository:
rL LLVM
https://reviews.llvm.org/D32566
Files:
clang/test/Index/print-type.cpp
clang/tools/libclang/CXType.cpp
Index: clang/tools/libclang/CXType.cpp
==
jtbandes added a comment.
@djasper how does this look?
I could try to simplify the examples further, but I feel it's important to have
calls with many subexpressions to exercise this behavior properly. FWIW, my
real-world use case is with `<<` appearing as an output stream operator inside
a ma
ruiu added a comment.
Please add this to https://reviews.llvm.org/D32509. I'll commit this and that
as one patch.
Repository:
rL LLVM
https://reviews.llvm.org/D32565
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
scott.smith created this revision.
Herald added a subscriber: klimek.
Certain test output is dependent on the order of the hash value computed by
llvm::HashString. Correct those so https://reviews.llvm.org/D32509 can be
committed.
Repository:
rL LLVM
https://reviews.llvm.org/D32565
Files:
My fault, waited too long to land it and didn't catch the addition of the file
in between.
From: v...@apple.com on behalf of Vedant Kumar
Sent: Wednesday, April 26, 2017 9:19 PM
To: Frederich Munch
Cc: cfe-commits; Vedant Kumar
Subject: Re: r301449 - PPCallback
emilio updated this revision to Diff 96834.
emilio added a comment.
Updated per review comments, thanks :)
Repository:
rL LLVM
https://reviews.llvm.org/D32389
Files:
clang/include/clang-c/Index.h
clang/test/Index/target-info.c
clang/tools/c-index-test/c-index-test.c
clang/tools/libcl
emilio added a comment.
In https://reviews.llvm.org/D32348#738704, @rsmith wrote:
> This change looks like it introduces a regression itself: given
>
> template struct A {};
> template using B = A;
> B bi;
>
>
> ... requesting the template arguments for the type `B` changes from
> producin
Author: vedantk
Date: Wed Apr 26 16:55:17 2017
New Revision: 301482
URL: http://llvm.org/viewvc/llvm-project?rev=301482&view=rev
Log:
[ubsan] nullability-assign: Check assignments into C++ structs
Fix the nullability-assign check so that it can handle assignments into
C++ structs. Previously, suc
rsmith added a comment.
This change looks like it introduces a regression itself: given
template struct A {};
template using B = A;
B bi;
... requesting the template arguments for the type `B` changes from
producing `int` to producing `int*` with this patch, which seems to directly
oppo
On Wed, Apr 26, 2017 at 2:18 PM Vedant Kumar wrote:
>
> > On Apr 26, 2017, at 2:16 PM, David Blaikie wrote:
> >
> > Sorry about that - thought I synced up moments before the commit.
>
> No worries, it's an innocent race.
>
>
> > Stuff like this is generally easier to fix forward, imho. Though th
> On Apr 26, 2017, at 2:16 PM, David Blaikie wrote:
>
> Sorry about that - thought I synced up moments before the commit.
No worries, it's an innocent race.
> Stuff like this is generally easier to fix forward, imho. Though the fact
> that this wouldn't've compiled without the changes does p
And I reverted my revert in r301472. See the thread re: r301470.
Sorry for the noise,
vedant
> On Apr 26, 2017, at 2:12 PM, Vedant Kumar via cfe-commits
> wrote:
>
> Hi Frederich,
>
> I had to revert this to unblock myself (r301469).
>
> best,
> vedant
>
>> On Apr 26, 2017, at 1:51 PM, Evge
Author: vedantk
Date: Wed Apr 26 16:05:44 2017
New Revision: 301472
URL: http://llvm.org/viewvc/llvm-project?rev=301472&view=rev
Log:
Revert "Revert "PPCallbacks::MacroUndefined, change signature and add test.""
This reverts commit r301469. It isn't needed with r301470, which fixes
the API break
Sorry about that - thought I synced up moments before the commit.
Stuff like this is generally easier to fix forward, imho. Though the fact
that this wouldn't've compiled without the changes does provide some
misgivings about the quality of the patch (but I've certainly committed
some things as sh
Hi David,
It looks like this conflicts with my revert. I will revert my revert, since
this seems like it fixes things.
vedant
> On Apr 26, 2017, at 1:58 PM, David Blaikie via cfe-commits
> wrote:
>
> Author: dblaikie
> Date: Wed Apr 26 15:58:21 2017
> New Revision: 301470
>
> URL: http://ll
Hi Frederich,
I had to revert this to unblock myself (r301469).
best,
vedant
> On Apr 26, 2017, at 1:51 PM, Evgenii Stepanov via cfe-commits
> wrote:
>
> Please change the signature of all overriding definitions as well.
>
> /code/llvm/tools/clang/lib/CodeGen/MacroPPCallbacks.h:114:50: error
Author: vedantk
Date: Wed Apr 26 15:58:19 2017
New Revision: 301469
URL: http://llvm.org/viewvc/llvm-project?rev=301469&view=rev
Log:
Revert "PPCallbacks::MacroUndefined, change signature and add test."
This reverts commit r301449. It breaks the build with:
MacroPPCallbacks.h:114:50: error: no
Author: dblaikie
Date: Wed Apr 26 15:58:21 2017
New Revision: 301470
URL: http://llvm.org/viewvc/llvm-project?rev=301470&view=rev
Log:
Fix API breaks
Modified:
cfe/trunk/lib/CodeGen/MacroPPCallbacks.cpp
cfe/trunk/lib/CodeGen/MacroPPCallbacks.h
Modified: cfe/trunk/lib/CodeGen/MacroPPCallb
Author: dblaikie
Date: Wed Apr 26 15:58:03 2017
New Revision: 301468
URL: http://llvm.org/viewvc/llvm-project?rev=301468&view=rev
Log:
Fix API breaks
Modified:
clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.cpp
clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.h
Modified: clang-to
rsmith added a comment.
The change in direction from diagnosing the lvalue-to-rvalue conversion to
diagnosing the pointer arithmetic seems fine to me (and is likely a better
approach overall), but this means we should now treat a designator referring to
element 0 of an array of unknown / runtim
Please change the signature of all overriding definitions as well.
/code/llvm/tools/clang/lib/CodeGen/MacroPPCallbacks.h:114:50: error:
non-virtual member function marked 'override' hides virtual member
function
const MacroDefinition &MD) override;
jtbandes updated this revision to Diff 96815.
jtbandes marked 6 inline comments as done.
jtbandes added a comment.
Updates from review
https://reviews.llvm.org/D32475
Files:
lib/Format/ContinuationIndenter.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
ahatanak added a comment.
Do you need a front-end test? Since the changes are in the backend, I think
it's better to add the test to the backend (using llc).
https://reviews.llvm.org/D32543
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
The bots are red, e.g.
http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/4342
On Wed, Apr 26, 2017 at 12:47 PM, Frederich Munch via cfe-commits
wrote:
> Author: marsupial
> Date: Wed Apr 26 14:47:31 2017
> New Revision: 301449
>
> URL: http://llvm.org/viewvc/llvm-project?rev=301
Author: bruno
Date: Wed Apr 26 15:13:45 2017
New Revision: 301453
URL: http://llvm.org/viewvc/llvm-project?rev=301453&view=rev
Log:
[Modules] Fix a crash-on-invalid with overloaded functions
Do not add an overload if the function doesn't have a prototype; this
can happen if, for instance, a mispl
jtbandes added inline comments.
Comment at: unittests/Format/FormatTest.cpp:2597
+ Style.AlignAfterOpenBracket = FormatStyle::BAS_AlwaysBreak;
+ Style.BreakBeforeBinaryOperators = FormatStyle::BOS_NonAssignment;
+ Style.BinPackArguments = false;
djasper wrote:
djasper added a comment.
My point is though that even with only one argument, the BinPackArguments
setting might lead to this bug. If not, that's good :).
https://reviews.llvm.org/D32475
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
mehdi_amini added a comment.
I tend to agree with @rjmccall on the principle. Howerever:
> The optimization design seems to rely on anticipating every case that should
> disable the optimization, hence this patch adding special-case logic to the
> frontend, and the 3 other patch
I believe this
This revision was automatically updated to reflect the committed changes.
Closed by commit rL301449: PPCallbacks::MacroUndefined, change signature and
add test. (authored by marsupial).
Changed prior to commit:
https://reviews.llvm.org/D29923?vs=91627&id=96808#toc
Repository:
rL LLVM
https:
Author: marsupial
Date: Wed Apr 26 14:47:31 2017
New Revision: 301449
URL: http://llvm.org/viewvc/llvm-project?rev=301449&view=rev
Log:
PPCallbacks::MacroUndefined, change signature and add test.
Summary:
The PPCallbacks::MacroUndefined callback is currently insufficient for clients
that need to
rjmccall added a comment.
In https://reviews.llvm.org/D32401#735127, @Prazek wrote:
> In https://reviews.llvm.org/D32401#734921, @rjmccall wrote:
>
> > I continue to be really uncomfortable with the entire design of this
> > optimization, which appears to miscompile code by default, but as long
Author: rsmith
Date: Wed Apr 26 13:57:40 2017
New Revision: 301442
URL: http://llvm.org/viewvc/llvm-project?rev=301442&view=rev
Log:
Refactor frontend InputKind to prepare for treating module maps as a distinct
kind of input.
No functionality change intended.
Modified:
cfe/trunk/include/cla
jtbandes added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:923
+// Don't propagate AvoidBinPacking into subexpressions of arg/param lists.
+if (Current.FakeLParens.size() > 0 &&
+Current.FakeLParens.back() > prec::Comma) {
jtb
jtbandes added a comment.
Thanks for the feedback, I'll work on making those changes.
In https://reviews.llvm.org/D32475#738425, @djasper wrote:
> What happens if the function call where this happens actually does not have
> multiple parameters but one parameter with many operands, e.g. changin
serge-sans-paille created this revision.
Variadic templates are type safer, easier to use and don't require the extra
sentinel.
https://reviews.llvm.org/D32550
Files:
lib/CodeGen/CGBlocks.cpp
lib/CodeGen/CGBuiltin.cpp
lib/CodeGen/CGCUDANV.cpp
lib/CodeGen/CGCleanup.cpp
lib/CodeGen/CGE
v.g.vassilev accepted this revision.
v.g.vassilev added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D32342
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
rsmith added inline comments.
Comment at: lib/Parse/ParseTemplate.cpp:1203-1204
+ {
+EnterExpressionEvaluationContext EnterConstantEvaluated(
+Actions, Sema::ExpressionEvaluationContext::ConstantEvaluated);
+if (isCXXTypeId(TypeIdAsTemplateArgument)) {
--
This revision was automatically updated to reflect the committed changes.
Closed by commit rL301440: [clang-tidy] Support detecting for-range loop in
inefficient-vector-operation… (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D32436?vs=96775&id=96793#toc
Repository:
Author: hokein
Date: Wed Apr 26 13:13:05 2017
New Revision: 301440
URL: http://llvm.org/viewvc/llvm-project?rev=301440&view=rev
Log:
[clang-tidy] Support detecting for-range loop in inefficient-vector-operation
check.
Summary:
Also add an option "VectorLikeClasses" allowing user specify customiz
djasper added a comment.
What happens if the function call where this happens actually does not have
multiple parameters but one parameter with many operands, e.g. changing your
test case to:
arg3 + is + quite + long + so + it
+ f(arguments << of << its << su
a.sidorin accepted this revision.
a.sidorin added a comment.
Refactoring changes are always appreciated. I only have a minor naming nit.
Comment at: include/clang/AST/ASTStructuralEquivalence.h:33
+ /// AST contexts for which we are checking structural equivalence.
+ ASTConte
jtbandes added a reviewer: bkramer.
jtbandes added a comment.
Not exactly sure who is the right person for this.
https://reviews.llvm.org/D32475
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
a.sidorin added inline comments.
Comment at: lib/AST/ASTContext.cpp:1481
+ assert(!FD->hasBody() && "FD has a definition in current translation unit!");
+ if (!FD->getType()->getAs())
+return nullptr; // Cannot even mangle that.
xazax.hun wrote:
> a.sidorin
hokein updated this revision to Diff 96775.
hokein marked 2 inline comments as done.
hokein added a comment.
Address remaining nits.
https://reviews.llvm.org/D32436
Files:
clang-tidy/performance/InefficientVectorOperationCheck.cpp
clang-tidy/performance/InefficientVectorOperationCheck.h
d
This revision was automatically updated to reflect the committed changes.
Closed by commit rL301431: [clang-tidy] Update IdentifierNamingCheck to remove
extra leading/trailing… (authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D32333?vs=96762&id=96771#toc
Repository:
rL
Author: alexfh
Date: Wed Apr 26 11:39:11 2017
New Revision: 301431
URL: http://llvm.org/viewvc/llvm-project?rev=301431&view=rev
Log:
[clang-tidy] Update IdentifierNamingCheck to remove extra leading/trailing
underscores
Summary:
The goal of this change is to fix the following suboptimal replacem
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Comment at: clang-tidy/performance/InefficientVectorOperationCheck.cpp:152
+
+ const Stmt * LoopStmt = nullptr;
+ if (ForLoop)
hokein wrote:
> alexfh wr
Author: sanjoy
Date: Wed Apr 26 11:37:51 2017
New Revision: 301430
URL: http://llvm.org/viewvc/llvm-project?rev=301430&view=rev
Log:
Revert "Update to LLVM's use of WeakTrackingVH; NFC"
This reverts commit r301427.
Modified:
cfe/trunk/lib/CodeGen/CGDeclCXX.cpp
cfe/trunk/lib/CodeGen/CGObj
alexfh added a comment.
In https://reviews.llvm.org/D32333#738266, @jtbandes wrote:
> Done, thanks for the review!
>
> What is the procedure for merging patches in? I'm sure I don't have
> permissions to do it myself.
I'll commit the patch for you.
Thank you for working on this!
https://rev
jtbandes marked an inline comment as done.
jtbandes added a comment.
Done, thanks for the review!
What is the procedure for merging patches in? I'm sure I don't have permissions
to do it myself.
https://reviews.llvm.org/D32333
___
cfe-commits mail
Author: sanjoy
Date: Wed Apr 26 11:22:36 2017
New Revision: 301427
URL: http://llvm.org/viewvc/llvm-project?rev=301427&view=rev
Log:
Update to LLVM's use of WeakTrackingVH; NFC
Summary: Depends on D32266
Reviewers: davide, dblaikie
Subscribers: mcrosier, llvm-commits
Differential Revision: htt
jtbandes updated this revision to Diff 96762.
jtbandes added a comment.
Fixed nit
https://reviews.llvm.org/D32333
Files:
clang-tidy/readability/IdentifierNamingCheck.cpp
test/clang-tidy/readability-identifier-naming.cpp
Index: test/clang-tidy/readability-identifier-naming.cpp
AndreiGrischenko created this revision.
Our runtime for MCU X86 target supports .init_array section for globals that
should be dynamically initialized.
But default Clang generates .ctors section and even if it has option
-fuse-init-array, the option has no effect if set explicitly in a command-l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL301420: [Sema] Avoid using a null type pointer (fixes
PR32750) (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D32519?vs=96668&id=96757#toc
Repository:
rL LLVM
https://revie
Author: vedantk
Date: Wed Apr 26 10:40:21 2017
New Revision: 301420
URL: http://llvm.org/viewvc/llvm-project?rev=301420&view=rev
Log:
[Sema] Avoid using a null type pointer (fixes PR32750)
isMicrosoftMissingTypename() uses a Type pointer without first checking
that it's non-null. PR32750 reports
vsk added inline comments.
Comment at: test/SemaCXX/MicrosoftExtensions.cpp:516
+template struct A {};
+template struct B : A > { A::C::D d; }; // expected-error
{{missing 'typename' prior to dependent type name 'A::C::D'}}
+}
nikola wrote:
> nitpick: you don't
Author: abataev
Date: Wed Apr 26 10:30:36 2017
New Revision: 301417
URL: http://llvm.org/viewvc/llvm-project?rev=301417&view=rev
Log:
[OPENMP] Fix failing test.
Modified:
cfe/trunk/test/OpenMP/capturing_in_templates.cpp
Modified: cfe/trunk/test/OpenMP/capturing_in_templates.cpp
URL:
http://
Serge_Preis updated this revision to Diff 96752.
Serge_Preis added a comment.
- Minor improvement to the fix: ensure that Type is of expected kind.
- Added test for various situations causing problems with source poisition in
current implementation
https://reviews.llvm.org/D32439
Files:
lib/
Author: abataev
Date: Wed Apr 26 10:06:24 2017
New Revision: 301416
URL: http://llvm.org/viewvc/llvm-project?rev=301416&view=rev
Log:
[OPENMP] Fix handling of OpenMP code during template instantiation.
If some function template is instantiated during handling of OpenMP
code, currently it may caus
Author: abataev
Date: Wed Apr 26 09:24:21 2017
New Revision: 301410
URL: http://llvm.org/viewvc/llvm-project?rev=301410&view=rev
Log:
[OPENMP] Move handling of threadprivate vars from the stack, NFC.
Threadprivate variables do no need to be handled in the Stack of all
directives, moving it out fo
On Tue, Apr 25, 2017 at 5:46 PM, Bruno Cardoso Lopes
wrote:
> On Tue, Apr 25, 2017 at 2:34 PM, Aaron Ballman wrote:
>> On Tue, Apr 25, 2017 at 5:33 PM, Bruno Cardoso Lopes
>> wrote:
>>> On Tue, Apr 25, 2017 at 6:29 AM, Aaron Ballman
>>> wrote:
On Wed, Dec 7, 2016 at 9:13 PM, Bruno Cardoso
Author: arphaman
Date: Wed Apr 26 09:20:02 2017
New Revision: 301409
URL: http://llvm.org/viewvc/llvm-project?rev=301409&view=rev
Log:
-Wunguarded-availability should support if (@available) checks in top-level
blocks and lambdas
Prior to this commit Clang emitted the old "partial availability" w
hokein added a comment.
Thanks for the comments!
Comment at: clang-tidy/performance/InefficientVectorOperationCheck.cpp:129
+ cxxForRangeStmt(
+ hasRangeInit(declRefExpr(supportedContainerTypesMatcher())),
+ HasInterestedLoopBody, InInterestedCompoundStmt
hokein updated this revision to Diff 96738.
hokein marked 6 inline comments as done.
hokein added a comment.
Address review comments.
https://reviews.llvm.org/D32436
Files:
clang-tidy/performance/InefficientVectorOperationCheck.cpp
clang-tidy/performance/InefficientVectorOperationCheck.h
xazax.hun added a comment.
I only found two nits otherwise looks good to me.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerHelpers.h:46
+bool exprComparesTo(SVal LHSVal, BinaryOperatorKind ComparisonOp, SVal RHSVal,
+ProgramStateRef St
alexfh added a comment.
Cool! A few nits.
Comment at: clang-tidy/performance/InefficientVectorOperationCheck.cpp:56
+ast_matchers::internal::Matcher supportedContainerTypesMatcher() {
+ const auto types = cxxRecordDecl(hasAnyName(
+ "::std::vector", "::std::set", "::std::
xazax.hun updated this revision to Diff 96727.
xazax.hun marked 5 inline comments as done.
xazax.hun added a comment.
- Updates according to review comments
- Improvements to the python scripts
https://reviews.llvm.org/D30691
Files:
include/clang/AST/ASTContext.h
include/clang/AST/Mangle.h
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with a nit.
Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:378
+ StringRef Mid = StringRef(Fixed).trim("_");
+ if (Mid.size() == 0)
+Mid = "_";
-
Author: arphaman
Date: Wed Apr 26 08:09:28 2017
New Revision: 301402
URL: http://llvm.org/viewvc/llvm-project?rev=301402&view=rev
Log:
-Wdocumentation should not check the @returns command for Objective-C
function/block pointer properties
The commit r300981 allowed @param/@return commands for fun
Author: arphaman
Date: Wed Apr 26 07:46:27 2017
New Revision: 301400
URL: http://llvm.org/viewvc/llvm-project?rev=301400&view=rev
Log:
[AST] Look through attribute type locs when searching for function type
loc
Prior to this commit -Wdocumentation crashed when checking the @returns command
for de
This revision was automatically updated to reflect the committed changes.
Closed by commit rL301399: clang-format: [JS/Java] ignore Objective-C
constructs in JS & Java. (authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D32532?vs=96710&id=96720#toc
Repository:
rL LLVM
Author: mprobst
Date: Wed Apr 26 07:36:49 2017
New Revision: 301399
URL: http://llvm.org/viewvc/llvm-project?rev=301399&view=rev
Log:
clang-format: [JS/Java] ignore Objective-C constructs in JS & Java.
Summary:
Java and JavaScript support annotations and decorators, respectively, that use
a lead
This revision was automatically updated to reflect the committed changes.
Closed by commit rL301397: clang-format: [JS] prevent wraps before class
members. (authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D32531?vs=96712&id=96719#toc
Repository:
rL LLVM
https://revie
Author: mprobst
Date: Wed Apr 26 07:34:18 2017
New Revision: 301398
URL: http://llvm.org/viewvc/llvm-project?rev=301398&view=rev
Log:
formatting
Modified:
cfe/trunk/lib/Format/TokenAnnotator.cpp
Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/t
1 - 100 of 109 matches
Mail list logo
