mehdi_amini added a comment.

I tend to agree with @rjmccall on the principle. Howerever:

> The optimization design seems to rely on anticipating every case that should 
> disable the optimization, hence this patch adding special-case logic to the 
> frontend, and the 3 other patch

I believe this is patch is *removing* a special case logic that was wrong.

I agree that the whole system should be "safe". But I'm not sure it is unsafe 
as it is designed: if we are already issuing an error when merging two modules 
that have different settings IIUC.


https://reviews.llvm.org/D32401



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to