jtbandes added inline comments.
================ Comment at: unittests/Format/FormatTest.cpp:2597 + Style.AlignAfterOpenBracket = FormatStyle::BAS_AlwaysBreak; + Style.BreakBeforeBinaryOperators = FormatStyle::BOS_NonAssignment; + Style.BinPackArguments = false; ---------------- djasper wrote: > Does this bug only happen when breaking before operators? If not can you add > a test case with None? Yeah it is only when breaking before operators, because the condition which causes `mustBreak` to be true includes `Current.CanBreakBefore`. ================ Comment at: unittests/Format/FormatTest.cpp:2599 + Style.BinPackArguments = false; + Style.BinPackParameters = false; + verifyFormat(StringRef(R"( ---------------- djasper wrote: > This is not tested/changed at all, I think. That's a good point. I had this because my test code is a function call at the top level, which is treated as a signature rather than a call. I will wrap it in another block and remove the BinPackParameters setting. https://reviews.llvm.org/D32475 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
