Hahnfeld added a comment.
ping
https://reviews.llvm.org/D26244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld added a comment.
ping
https://reviews.llvm.org/D25669
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev added a comment.
Ping
https://reviews.llvm.org/D22955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nkakuev added a comment.
@alexfh, you're welcome!
Can you please commit this patch?
https://reviews.llvm.org/D26466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
Add decent blank line between declarations.
https://reviews.llvm.org/D26493
Files:
clang-move/ClangMove.cpp
unittests/clang-move/ClangMoveTests.cpp
Index: unittests/clang-move/ClangMoveTe
Author: hokein
Date: Wed Nov 9 23:33:26 2016
New Revision: 286427
URL: http://llvm.org/viewvc/llvm-project?rev=286427&view=rev
Log:
[clang-move] Support template class.
Reviewers: ioeric
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D26423
Added:
clang-tools-ext
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rL286427: [clang-move] Support template class. (authored by
hokein).
Changed prior to commit:
https://reviews.llvm.org/D26423?vs=77292&id=77447#toc
Repository:
srhines updated this revision to Diff 77446.
srhines added a comment.
Added bug link to commit message.
https://reviews.llvm.org/D26491
Files:
lib/Basic/Targets.cpp
test/Preprocessor/init.c
Index: test/Preprocessor/init.c
===
srhines created this revision.
srhines added subscribers: danalbert, eugenis, pirama, cfe-commits.
Herald added a subscriber: tberghammer.
This macro should be defined only when the user directly specifies an
API level as part of an Android target. For any regular Android target,
we leave this mac
ahatanak added a comment.
Do you think we can transform the Exprs for the uninstantiated default
arguments in TreeTransform::TransformLambdaExpr? I guess it would be
much simpler than trying to make getTemplateInstantiationArgs return the
correct template arguments.
https://reviews.llvm.org/D
ahatanak added inline comments.
Comment at: lib/Sema/SemaType.cpp:3988
// Allow arrays of auto if we are a generic lambda parameter.
// i.e. [](auto (&array)[5]) { return array[0]; }; OK
if (AT && D.getContext() != Declarator::LambdaExprParameterContext) {
--
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Looks good, thanks!
https://reviews.llvm.org/D25764
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
zaks.anna updated this revision to Diff 77435.
zaks.anna marked an inline comment as done.
https://reviews.llvm.org/D25857
Files:
lib/CodeGen/CodeGenFunction.cpp
test/CodeGen/sanitize-thread-no-checking-at-run-time.m
Index: test/CodeGen/sanitize-thread-no-checking-at-run-time.m
zaks.anna marked 4 inline comments as done.
zaks.anna added inline comments.
Comment at: test/CodeGen/sanitize-thread-no-checking-at-run-time.m:1
+// RUN: %clang_cc1 -triple x86_64-apple-darwin -x objective-c++ -emit-llvm -o
- %s | FileCheck -check-prefix=WITHOUT %s
+// RUN: %cl
alekseyshl added inline comments.
Comment at: test/Driver/fsanitize.c:288
+// RUN: %clang -target x86_64-linux-gnu -fsanitize=thread
-fsanitize-thread-data-races -fno-sanitize-thread-data-races %s -### 2>&1 |
FileCheck %s --check-prefix=CHECK-TSAN-DATA-RACES-OFF
+// CHECK-TSAN-
alekseyshl updated this revision to Diff 77432.
alekseyshl marked 2 inline comments as done.
alekseyshl added a comment.
- Rename new options to better reflect their functionality.
https://reviews.llvm.org/D26461
Files:
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs.h
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL284179.
https://reviews.llvm.org/D25522
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL286148.
https://reviews.llvm.org/D26354
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286424: [clang-tidy] Do not issue fix for functions that are
referenced outside of… (authored by flx).
Changed prior to commit:
https://reviews.llvm.org/D26203?vs=77343&id=77430#toc
Repository:
rL LL
Author: flx
Date: Wed Nov 9 19:28:22 2016
New Revision: 286424
URL: http://llvm.org/viewvc/llvm-project?rev=286424&view=rev
Log:
[clang-tidy] Do not issue fix for functions that are referenced outside of
callExpr
Summary: Suppress fixes for functions that are referenced within the
compilation u
jordan_rose added inline comments.
Comment at: lib/Sema/SemaType.cpp:3988
// Allow arrays of auto if we are a generic lambda parameter.
// i.e. [](auto (&array)[5]) { return array[0]; }; OK
if (AT && D.getContext() != Declarator::LambdaExprParameterContext) {
ahatanak added a comment.
In https://reviews.llvm.org/D26108#591270, @jordan_rose wrote:
> Ah, my apologies, @ahatanak. I was testing against the Swift branch of Clang.
That's OK. I haven't tested it yet, but the patch itself looks fine to me.
Comment at: lib/Sema/SemaType.c
jordan_rose added a comment.
Ah, my apologies, @ahatanak. I was testing against the Swift branch of Clang.
Repository:
rL LLVM
https://reviews.llvm.org/D26108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision is now accepted and ready to land.
I've not looked at all of the test changes in detail, but this looks fine to me.
https://reviews.llvm.org/D26452
___
zaks.anna added a comment.
> Added a python script to merge gcov files.
When the patches that are being reviewed are growing new functionality, it's
much more difficult to review them. Please, submit the python script as a
separate patch.
Comment at: lib/StaticAnalyzer/Core/
dcoughlin added a comment.
In https://reviews.llvm.org/D26340#590882, @khazem wrote:
> Devin, based on Artem's review of the other checker that I have posted [1] I
> am wondering about merging both this SpinLockChecker and the MutexChecker
> into PthreadLockChecker. Do you think it is still wor
dcoughlin added a comment.
Thanks for adding the path notes and adopting CallDescription. I've added some
additional comments inline, which are mostly minor nits.
Two additional important changes -- and I should have noted these in the
initial review -- is that it would be good to remove a MemR
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286419: [Sema] Use MS ABI behavior for dllexport in Itanium
(authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D26471?vs=77392&id=77418#toc
Repository:
rL LLVM
https://reviews.
Author: akirtzidis
Date: Wed Nov 9 17:58:39 2016
New Revision: 286421
URL: http://llvm.org/viewvc/llvm-project?rev=286421&view=rev
Log:
[libclang] Fix issue with clang_tokenize and make sure it interprets
CXSourceRange as half-open character range.
Patch provided by Emilio Cobos Álvarez! (https
Author: smeenai
Date: Wed Nov 9 17:52:20 2016
New Revision: 286419
URL: http://llvm.org/viewvc/llvm-project?rev=286419&view=rev
Log:
[Sema] Use MS ABI behavior for dllexport in Itanium
Similar to r284288, make the Itanium ABI follow MS ABI dllexport
semantics in the case of an explicit instantia
Malcolm, does it work for you?
On Wed, Nov 9, 2016 at 10:56 AM, Devin Coughlin wrote:
> + Anna, Alexander, and Artem.
>
> > On Nov 9, 2016, at 10:50 AM, Devin Coughlin via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
> >
> >
> >> On Nov 8, 2016, at 9:44 AM, Malcolm Parsons
> wrote:
> >>
>
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Thanks! LG
https://reviews.llvm.org/D26466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
NoQ added a comment.
In https://reviews.llvm.org/D26342#590881, @khazem wrote:
> I think that it's sensible to try merging this with PthreadLockChecker. In
> fact, I could also try merging the SpinLockChecker [1] that I've posted for
> review with PthreadLockChecker also, since they all impleme
bkramer marked 2 inline comments as done.
bkramer added a comment.
In https://reviews.llvm.org/D23130#589643, @alexfh wrote:
> > and generally frowned upon in many codebases (e.g. LLVM)
>
> Should it still be a part of google/? The old check was enforcing a part of
> the Google C++ style guide,
bkramer updated this revision to Diff 77410.
bkramer added a comment.
Add extern "C++" test case.
https://reviews.llvm.org/D23130
Files:
clang-tidy/google/CMakeLists.txt
clang-tidy/google/GlobalNamesCheck.cpp
clang-tidy/google/GlobalNamesCheck.h
clang-tidy/google/GlobalNamesInHeadersChe
Author: adrian
Date: Wed Nov 9 17:10:44 2016
New Revision: 286412
URL: http://llvm.org/viewvc/llvm-project?rev=286412&view=rev
Log:
Remove extra whitespace
Modified:
cfe/trunk/test/CodeGenCXX/debug-info-thunk.cpp
Modified: cfe/trunk/test/CodeGenCXX/debug-info-thunk.cpp
URL:
http://llvm.org
Author: adrian
Date: Wed Nov 9 17:05:16 2016
New Revision: 286411
URL: http://llvm.org/viewvc/llvm-project?rev=286411&view=rev
Log:
Relax testcase so it also works on Windows.
Modified:
cfe/trunk/test/CodeGenCXX/debug-info-thunk.cpp
Modified: cfe/trunk/test/CodeGenCXX/debug-info-thunk.cpp
U
nemanjai created this revision.
nemanjai added reviewers: hfinkel, kbarton, syzaara, lei, jtony, sfertile,
amehsan.
nemanjai added subscribers: cfe-commits, echristo.
nemanjai set the repository for this revision to rL LLVM.
This adds the following signatures into altivec.h:
vector bool long lon
dvyukov added inline comments.
Comment at: include/clang/Driver/Options.td:733
+ Group, Flags<[CC1Option]>,
+ HelpText<"Enable data race detection in
ThreadSanitizer">;
+def fno_sanitize_thread_data_races : Flag<[
dberris added inline comments.
Comment at: lib/Driver/Tools.cpp:4903-4906
if (Triple.getOS() == llvm::Triple::Linux &&
(Triple.getArch() == llvm::Triple::arm ||
- Triple.getArch() == llvm::Triple::x86_64)) {
+ Triple.getArch() == llvm::Triple::x86_64
kzhuravl created this revision.
kzhuravl added reviewers: tstellarAMD, arsenm.
kzhuravl added a subscriber: cfe-commits.
Herald added subscribers: tony-tye, yaxunl, nhaehnle, wdng.
https://reviews.llvm.org/D26476
Files:
include/clang/Basic/BuiltinsAMDGPU.def
lib/CodeGen/CGBuiltin.cpp
test/C
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286409: [Sema][NFC] Reset HasFallthroughStmt when clearing
FunctionScopeInfo (authored by epilk).
Changed prior to commit:
https://reviews.llvm.org/D22770?vs=65380&id=77399#toc
Repository:
rL LLVM
h
Author: epilk
Date: Wed Nov 9 16:52:23 2016
New Revision: 286409
URL: http://llvm.org/viewvc/llvm-project?rev=286409&view=rev
Log:
[Sema][NFC] Reset HasFallthroughStmt when clearing FunctionScopeInfo
Differential revision: https://reviews.llvm.org/D22770
Modified:
cfe/trunk/lib/Sema/ScopeIn
eugenis added inline comments.
Comment at: test/Driver/fsanitize.c:288
+// RUN: %clang -target x86_64-linux-gnu -fsanitize=thread
-fsanitize-thread-data-races -fno-sanitize-thread-data-races %s -### 2>&1 |
FileCheck %s --check-prefix=CHECK-TSAN-DATA-RACES-OFF
+// CHECK-TSAN-DAT
alekseyshl updated this revision to Diff 77398.
alekseyshl added a comment.
- Added ust test for the new command line args.
https://reviews.llvm.org/D26461
Files:
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs.h
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/B
Author: alexfh
Date: Wed Nov 9 16:31:07 2016
New Revision: 286404
URL: http://llvm.org/viewvc/llvm-project?rev=286404&view=rev
Log:
[clang-tidy docs] Minor formatting changes.
Modified:
clang-tools-extra/trunk/docs/clang-tidy/index.rst
Modified: clang-tools-extra/trunk/docs/clang-tidy/index
On Wed, Nov 09, 2016 at 03:43:52PM -, Douglas Katzman via cfe-commits wrote:
> Author: dougk
> Date: Wed Nov 9 09:43:51 2016
> New Revision: 286376
>
> URL: http://llvm.org/viewvc/llvm-project?rev=286376&view=rev
> Log:
> [Sparc] LLONG is not lock-free atomic on v8
Technically, even 32bit is
rSerge added inline comments.
Comment at: lib/Driver/Tools.cpp:4903-4906
if (Triple.getOS() == llvm::Triple::Linux &&
(Triple.getArch() == llvm::Triple::arm ||
- Triple.getArch() == llvm::Triple::x86_64)) {
+ Triple.getArch() == llvm::Triple::x86_64
smeenai created this revision.
smeenai added a reviewer: compnerd.
smeenai added a subscriber: cfe-commits.
Similar to r284288, make the Itanium ABI follow MS ABI dllexport
semantics in the case of an explicit instantiation declaration followed
by a dllexport explicit instantiation definition.
h
Author: adrian
Date: Wed Nov 9 15:43:51 2016
New Revision: 286400
URL: http://llvm.org/viewvc/llvm-project?rev=286400&view=rev
Log:
Use an artificial debug location for non-virtual thunks.
Thunks are artificial and have no corresponding source location except for the
line number on the DISubprogr
eugenis added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:735
+ OPT_fno_sanitize_thread_data_races,
+ Opts.SanitizeThreadDataRaces);
+ Opts.SanitizeThreadStackTraces =
alekseyshl wrote:
> eugenis wrote:
>
Oh, looks like someone already sent a fix: https://reviews.llvm.org/D26163
On Wed, Nov 9, 2016 at 4:41 PM, Nico Weber wrote:
> This apparently caused https://llvm.org/bugs/show_bug.cgi?id=30527
>
> On Tue, Jun 14, 2016 at 9:54 AM, Daniel Jasper via cfe-commits <
> cfe-commits@lists.llvm.org> wro
This apparently caused https://llvm.org/bugs/show_bug.cgi?id=30527
On Tue, Jun 14, 2016 at 9:54 AM, Daniel Jasper via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: djasper
> Date: Tue Jun 14 08:54:38 2016
> New Revision: 272668
>
> URL: http://llvm.org/viewvc/llvm-project?rev=272668&
doug.gregor accepted this revision.
doug.gregor added a comment.
This revision is now accepted and ready to land.
I don't see a better way to do this. Nice meta programming hack.
Repository:
rL LLVM
https://reviews.llvm.org/D26227
___
cfe-commits
doug.gregor accepted this revision.
doug.gregor added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D26109
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
smeenai abandoned this revision.
smeenai added a comment.
Abandoning this then. In case the new incarnation of the test needs to
overwrite any memory allocation methods, this diff has the most reliable way to
do it on OS X :)
https://reviews.llvm.org/D26150
_
doug.gregor accepted this revision.
doug.gregor added a comment.
This revision is now accepted and ready to land.
Looks good! I appreciate the refactoring of recordNullabilitySeen
Repository:
rL LLVM
https://reviews.llvm.org/D26108
___
cfe-commit
khazem marked 4 inline comments as done.
khazem added a comment.
Devin, based on Artem's review of the other checker that I have posted [1] I am
wondering about merging both this SpinLockChecker and the MutexChecker into
PthreadLockChecker. Do you think it is still worth landing this
SpinLockCh
khazem added a comment.
Thanks for the detailed review Artem!
I think that it's sensible to try merging this with PthreadLockChecker. In
fact, I could also try merging the SpinLockChecker [1] that I've posted for
review with PthreadLockChecker also, since they all implement similar
functionali
Author: alexfh
Date: Wed Nov 9 14:03:30 2016
New Revision: 286390
URL: http://llvm.org/viewvc/llvm-project?rev=286390&view=rev
Log:
[clang-tidy docs] Recommend using add_new_check.py more
Modified:
clang-tools-extra/trunk/docs/clang-tidy/index.rst
Modified: clang-tools-extra/trunk/docs/clan
ioeric added inline comments.
Comment at: clang-move/ClangMove.cpp:417
+ if (const auto *FTD = CMD->getDescribedFunctionTemplate())
+UnremovedDeclsInOldHeader.erase(FTD);
+ else
hokein wrote:
> ioeric wrote:
> > `erase(FTD ? FTD : CMD)`
> We can
dougk added a comment.
Also note: In this change, the diagnostic messages are correct; it's the enum
name that's bad. The diagnostic message is wrong for the 'section' attribute,
which is fixed by https://reviews.llvm.org/D26459
https://reviews.llvm.org/D26454
__
hokein marked 3 inline comments as done.
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:417
+ if (const auto *FTD = CMD->getDescribedFunctionTemplate())
+UnremovedDeclsInOldHeader.erase(FTD);
+ else
ioeric wrote:
> `erase(FTD
alekseyshl added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:735
+ OPT_fno_sanitize_thread_data_races,
+ Opts.SanitizeThreadDataRaces);
+ Opts.SanitizeThreadStackTraces =
eugenis wrote:
> It seems common t
eugenis added a comment.
Oh, and this needs a test. See test/Driver/fsanitize.c (search for
-fsanitize-address-use-after-scope as an example).
https://reviews.llvm.org/D26461
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
rmaprath added a comment.
In https://reviews.llvm.org/D26458#590865, @rmaprath wrote:
> Not sure if either of these tests add much value to the no-exceptions
> variant, using `std::nested_exception` with such a library seem pointless to
> me. Perhaps marking these as `UNSUPPORTED` is a better f
rmaprath added a comment.
Not sure if either of these tests add much value to the no-exceptions variant,
using `std::nested_exception` with such a library seem pointless to me. Perhaps
marking these as `UNSUPPORTED` is a better fix?
https://reviews.llvm.org/D26458
__
doug.gregor accepted this revision.
doug.gregor added a comment.
This revision is now accepted and ready to land.
This is looking great, Jordan.
Repository:
rL LLVM
https://reviews.llvm.org/D25850
___
cfe-commits mailing list
cfe-commits@lists.ll
rmaprath added a comment.
LGTM.
https://reviews.llvm.org/D26457
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eugenis added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:735
+ OPT_fno_sanitize_thread_data_races,
+ Opts.SanitizeThreadDataRaces);
+ Opts.SanitizeThreadStackTraces =
It seems common to hardcode the defau
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, thanks
Repository:
rL LLVM
https://reviews.llvm.org/D26448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg with a few nits.
Comment at: clang-move/ClangMove.cpp:417
+ if (const auto *FTD = CMD->getDescribedFunctionTemplate())
+UnremovedDeclsInOldHeader.erase(FTD);
alekseyshl created this revision.
alekseyshl added a reviewer: eugenis.
alekseyshl added a subscriber: cfe-commits.
New clang flags, all default to true:
-f[no-]sanitize-thread-data-races
-f[no-]sanitize-thread-stack-traces
-f[no-]sanitize-thread-atomics
https://reviews.llvm.org/D26461
Files:
ioeric updated this revision to Diff 77380.
ioeric added a comment.
- Added a test case with type references.
https://reviews.llvm.org/D26456
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-namespace/ChangeNamespaceTes
nkakuev marked an inline comment as done.
nkakuev added inline comments.
Comment at: test/clang-tidy/nolint.cpp:36
+}
+// CHECK-NOT: trigger_warning.h:{{.*}} warning: The left operand of '>' is a
garbage value
+// CHECK-NOT: :[[@LINE-4]]:{{.*}} note
alexfh wrote
nkakuev created this revision.
nkakuev added a reviewer: alexfh.
nkakuev added a subscriber: cfe-commits.
Test cases I've added in review https://reviews.llvm.org/D26218 were too
brittle and weren't working properly.
This patch fixes this.
https://reviews.llvm.org/D26466
Files:
test/clang-ti
+ Anna, Alexander, and Artem.
> On Nov 9, 2016, at 10:50 AM, Devin Coughlin via cfe-commits
> wrote:
>
>
>> On Nov 8, 2016, at 9:44 AM, Malcolm Parsons
>> wrote:
>>
>> On 8 November 2016 at 16:59, Alexander Kornienko wrote:
>>> On Nov 8, 2016 2:11 AM, "Malcolm Parsons" wrote:
Oh, I w
> On Nov 8, 2016, at 9:44 AM, Malcolm Parsons wrote:
>
> On 8 November 2016 at 16:59, Alexander Kornienko wrote:
>> On Nov 8, 2016 2:11 AM, "Malcolm Parsons" wrote:
>>> Oh, I was using clang-analyzer-alpha.cplusplus.VirtualCall.
>>>
>>> Should clang-tidy have an option to enable experimental
NoQ added a comment.
Sorry for inactivity, been thinking quite a bit about this checker. The checker
is very cool because it is an excellent showcase of our API problems in the
realm of C++ checkers. Once the checker is committed, we could try various
things to make it easier to develop other c
ogoffart created this revision.
ogoffart added reviewers: cfe-commits, rsmith.
Herald added a subscriber: sanjoy.
DiagnosticIDs::getDiagnosticSeverity function turns out to take a lot of time
in getDecomposedLoc. It is called quite often from different places. (For
example from Sema::CheckTempla
iid_iunknown created this revision.
iid_iunknown added a reviewer: LukeCheeseman.
iid_iunknown added a subscriber: cfe-commits.
iid_iunknown set the repository for this revision to rL LLVM.
Herald added subscribers: rengolin, aemerson.
This is a simple sema check patch for arguments of `__builtin_
kastiglione added a comment.
Thanks @arphaman, are you able to commit this?
https://reviews.llvm.org/D26406
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dtarditi updated this revision to Diff 77373.
dtarditi added a comment.
Thanks for the code review feedback - I've addressed it. Yes, we should use
reset() instead of release(). I also deleted the unnecessary brackets. I
don't have commit access, so if this looks good, could someone commit t
malcolm.parsons updated this revision to Diff 77371.
malcolm.parsons updated the summary for this revision.
malcolm.parsons added a comment.
Add ValuesOnly option to modernize-pass-by-value.
https://reviews.llvm.org/D26453
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/misc/MoveConstr
Author: phst
Date: Wed Nov 9 11:47:56 2016
New Revision: 286381
URL: http://llvm.org/viewvc/llvm-project?rev=286381&view=rev
Log:
Fix grammar
"allow" requires a direct object in this case.
Modified:
clang-tools-extra/trunk/include-fixer/tool/clang-include-fixer.el
Modified: clang-tools-ext
dougk updated this revision to Diff 77367.
dougk added a comment.
inadvertent omission of attr-section.c test
https://reviews.llvm.org/D26459
Files:
include/clang/Basic/Attr.td
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/AttributeList.h
test/Sema/attr-section.c
Index
dougk created this revision.
dougk added a reviewer: aaron.ballman.
dougk added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
ExpectedFunctionGlobalVarMethodOrProperty would previously say "functions and
global variables" instead of "functions, methods, properties, and global
v
rogfer01 created this revision.
rogfer01 added reviewers: mclow.lists, EricWF, rmaprath.
rogfer01 added a subscriber: cfe-commits.
Skip tests that expect an exception be thrown.
https://reviews.llvm.org/D26458
Files:
test/std/language.support/support.exception/except.nested/assign.pass.cpp
ioeric created this revision.
ioeric added a reviewer: hokein.
ioeric added a subscriber: cfe-commits.
https://reviews.llvm.org/D26456
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-namespace/ChangeNamespaceTests.cpp
=
rogfer01 created this revision.
rogfer01 added reviewers: EricWF, rmaprath, mclow.lists.
rogfer01 added a subscriber: cfe-commits.
Skip tests that expect an exception be thrown under no-exceptions.
https://reviews.llvm.org/D26457
Files:
test/std/utilities/memory/util.smartptr/util.smartptr.s
hans added a comment.
In https://reviews.llvm.org/D24933#590493, @sepavloff wrote:
> > For Chromium, our build system provides a specific Clang version close to
> > ToT, and obviously what flags to use when invoking it. (Developers can of
> > course override the flags when configuring if they w
Author: dougk
Date: Wed Nov 9 11:02:07 2016
New Revision: 286380
URL: http://llvm.org/viewvc/llvm-project?rev=286380&view=rev
Log:
[Sparc] Unbreak test
Modified:
cfe/trunk/test/CodeGen/atomics-inlining.c
Modified: cfe/trunk/test/CodeGen/atomics-inlining.c
URL:
http://llvm.org/viewvc/llvm-p
Thank you!
On Tue, Nov 8, 2016 at 11:57 AM, Daniel Jasper wrote:
> Fixed in r286279.
>
> On Tue, Nov 8, 2016 at 10:45 AM, Galina Kistanova
> wrote:
>
>> Hello Daniel,
>>
>> This commit broke at least one of our builders:
>> http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/234
malcolm.parsons updated this revision to Diff 77358.
malcolm.parsons added a comment.
Update comment in performance-unnecessary-value-param check.
https://reviews.llvm.org/D26453
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/misc/MoveConstructorInitCheck.cpp
clang-tidy/misc/MoveCon
malcolm.parsons added a comment.
In https://reviews.llvm.org/D26453#590636, @flx wrote:
> Is the modernize-pass-by-value check configurable in a way to only trigger
> when copied constructor arguments are not moved?
No; good idea.
https://reviews.llvm.org/D26453
__
dougk created this revision.
dougk added a reviewer: aaron.ballman.
dougk added a subscriber: cfe-commits.
This was already submitted as r284272.
Regarding the use of Attr as a local variable name, I would prefer to remain
consistent with the existing code in CodeGenFunction.cpp which was not to
flx added a comment.
Is the modernize-pass-by-value check configurable in a way to only trigger when
copied constructor arguments are not moved?
I think our use case has been to have move-constructor-init check enabled to
catch cases that can be optimized but not trigger on every constructor th
malcolm.parsons created this revision.
malcolm.parsons added reviewers: aaron.ballman, alexfh, flx.
malcolm.parsons added a subscriber: cfe-commits.
An addition to the move-constructor-init check was duplicating the
modernize-pass-by-value check.
Remove the additional check and UseCERTSemantics op
The patch https://reviews.llvm.org/D26452 implements testing for output
made with -ast-print, it fixes problems which this commit addressed
(file declare_simd_ast_print.cpp) and tests them.
Thanks,
--Serge
2016-11-02 23:39 GMT+07:00 Richard Smith :
> Test?
>
> On 30 Oct 2016 10:20 pm, "Serge Pav
sepavloff created this revision.
sepavloff added reviewers: ABataev, gribozavr, rtrieu.
sepavloff added a subscriber: cfe-commits.
Output generated by option -ast-print looks like C/C++ code, and it
really is for plain C. For C++ the produced output was not valid C++
code, but the differences were
1 - 100 of 130 matches
Mail list logo
