dvyukov added inline comments.
================ Comment at: include/clang/Driver/Options.td:733 + Group<f_clang_Group>, Flags<[CC1Option]>, + HelpText<"Enable data race detection in ThreadSanitizer">; +def fno_sanitize_thread_data_races : Flag<["-"], "fno-sanitize-thread-data-races">, ---------------- These descriptions may be confusing for users. This does not disable data race detection in tsan. Even if all files are compiled with this flag, tsan can still report races. Same for traces and atomics. Please make it clear that it only enables/disables source _instrumentation_. Does user see what's the default value? If not, then I guess some users will add flags just because they do want data races detection and stack traces. We need to make it clear that all flags are enabled by default. https://reviews.llvm.org/D26461 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
