Hahnfeld updated the summary for this revision.
Hahnfeld updated this revision to Diff 72765.
Hahnfeld added a comment.
Link PR
https://reviews.llvm.org/D24601
Files:
test/Driver/darwin-stdlib.cpp
test/lit.cfg
test/lit.site.cfg.in
Index: test/lit.site.cfg.in
=
Hahnfeld added a comment.
In https://reviews.llvm.org/D24601#553482, @vsk wrote:
> It should be fine to XFAIL this test temporarily. Is there a PR for this?
I've now created an entry in Bugzilla:
https://llvm.org/bugs/show_bug.cgi?id=30548
https://reviews.llvm.org/D24601
_
halyavin added a subscriber: halyavin.
Comment at: libcxx/include/atomic_support.h:1
@@ +1,2 @@
+//===--===
+//
Non-standard include files in the main include directory must start with __ to
ahatanak created this revision.
ahatanak added reviewers: doug.gregor, rsmith.
ahatanak added a subscriber: cfe-commits.
This patch fixes a crash that occurs when a non-prototype function is declared
before a header containing a prototype of the same function is included. This
caused Sema::Looku
sylvestre.ledru updated this revision to Diff 72759.
sylvestre.ledru added a comment.
with the full context + clang format
https://reviews.llvm.org/D24998
Files:
docs/CommandGuide/clang.rst
lib/Frontend/CompilerInvocation.cpp
test/Driver/debug-options.c
test/Preprocessor/init.c
Index:
majnemer added a subscriber: majnemer.
majnemer added a comment.
Please include full context with your diff.
Comment at: lib/Frontend/CompilerInvocation.cpp:101-103
@@ -100,1 +100,5 @@
+if (S == "g") {
+return 1;
+}
+
Please clang-format this.
george.burgess.iv created this revision.
george.burgess.iv added reviewers: joerg, rsmith.
george.burgess.iv added a subscriber: cfe-commits.
Mostly asking for a review to verify that you guys are happy with this approach.
Given that Hal said struct-path-tbaa doesn't really deal with arrays (yet)
sylvestre.ledru created this revision.
sylvestre.ledru added a reviewer: rengolin.
sylvestre.ledru added a subscriber: cfe-commits.
Just like gcc, we should have the -Og option as more and more software are
using it:
https://llvm.org/bugs/show_bug.cgi?id=20765
https://reviews.llvm.org/D24998
Fi
dcoughlin added a comment.
@parallaxe Do you need someone to commit this for you?
https://reviews.llvm.org/D23236
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Tue Sep 27 21:20:06 2016
New Revision: 282564
URL: http://llvm.org/viewvc/llvm-project?rev=282564&view=rev
Log:
Revert r282556. This change made several bots unhappy.
Modified:
cfe/trunk/include/clang/AST/ExprCXX.h
cfe/trunk/lib/CodeGen/CGCall.cpp
cfe/trunk/lib/Co
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Looks like patch was not committed.
Repository:
rL LLVM
https://reviews.llvm.org/D9127
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
jbangert created this revision.
jbangert added a reviewer: alexfh.
jbangert added a subscriber: cfe-commits.
jbangert added a project: clang-tools-extra.
This adds helper classes to add using declaractions and namespace aliases to
function bodies. These help making function calls to deeply nested
jlebar added a comment.
> What happens if there are trailing tokens after the pragma?
Added code to make this an error.
https://reviews.llvm.org/D24975
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
jlebar updated this revision to Diff 72734.
jlebar marked 2 inline comments as done.
jlebar added a comment.
Address Richard's comments.
I'm fairly neutral on whether we want to make it an error not to match all of
your "begin" pragmas with "end"s. I checked pragma push_macro, and it looks
like
Reverted in r282555.
On Tue, Sep 27, 2016 at 3:44 PM, Richard Smith
wrote:
> It looks like this will reject valid code, such as:
>
> template struct X {
> using T = typename std::conditional::type;
> X();
> X(T) = default; // either copyable or moveable, depending on B
> };
>
> On Tue, Sep
Author: matze
Date: Tue Sep 27 18:44:38 2016
New Revision: 282557
URL: http://llvm.org/viewvc/llvm-project?rev=282557&view=rev
Log:
Put new warning in a diagnostic group.
The warning I added in r282426 should be a diagnostic group.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticFrontendKi
Author: rtrieu
Date: Tue Sep 27 18:44:07 2016
New Revision: 282555
URL: http://llvm.org/viewvc/llvm-project?rev=282555&view=rev
Log:
Revert r282547 and add test to show correct behavior.
Modified:
cfe/trunk/lib/Sema/SemaDeclCXX.cpp
cfe/trunk/test/SemaCXX/cxx0x-defaulted-functions.cpp
Mod
Author: rsmith
Date: Tue Sep 27 18:44:22 2016
New Revision: 282556
URL: http://llvm.org/viewvc/llvm-project?rev=282556&view=rev
Log:
P0145R3 (C++17 evaluation order tweaks): evaluate the right-hand side of
assignment and compound-assignment operators before the left-hand side. (Even
if it's an ove
GorNishanov marked an inline comment as done.
Comment at: include/clang/Basic/Builtins.def:1293
@@ +1292,3 @@
+
+BUILTIN(__builtin_coro_id, "v*Iiv*v*v*", "n")
+BUILTIN(__builtin_coro_alloc, "bv*", "n")
rsmith wrote:
> I don't really like having builtins which will
GorNishanov updated the summary for this revision.
GorNishanov removed a reviewer: majnemer.
GorNishanov updated this revision to Diff 72732.
GorNishanov added a comment.
Herald added a subscriber: mgorny.
1. Added documentation for builtins
2. Added a couple of tests with -disable-llvm-passes to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282554: [Coverage] The coverage region for switch covers the
code after the switch. (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D24981?vs=72692&id=72733#toc
Repository:
Author: arphaman
Date: Tue Sep 27 18:30:36 2016
New Revision: 282554
URL: http://llvm.org/viewvc/llvm-project?rev=282554&view=rev
Log:
[Coverage] The coverage region for switch covers the code after the switch.
This patch fixes a regression introduced in r262697 that changed the way the
coverage
rsmith added inline comments.
Comment at: clang/lib/CodeGen/CGCXX.cpp:137-138
@@ -136,1 +136,4 @@
+ // Disallow aliases to available_externally because available_externally
+ // will not be there in the end to allow the creation of the alias (PR30341).
+ // FIXME: An extern t
hxy9243 created this revision.
hxy9243 added reviewers: sebpop, hiraditya, wmi.
hxy9243 added a subscriber: cfe-commits.
hxy9243 set the repository for this revision to rL LLVM.
This patch moves some existing functions from the memory.cpp to the memory
header file, so that they could be properly
It looks like this will reject valid code, such as:
template struct X {
using T = typename std::conditional::type;
X();
X(T) = default; // either copyable or moveable, depending on B
};
On Tue, Sep 27, 2016 at 3:28 PM, Richard Trieu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Au
rsmith added a comment.
Please add serialisation code for the push count for PCH. Should it be an error
if the count is nonzero at the end of the TU?
What happens if there are trailing tokens after the pragma?
Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1027
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL256046.
https://reviews.llvm.org/D10370
___
cfe-commits mailing list
cfe-commits@lists.ll
Author: rtrieu
Date: Tue Sep 27 17:28:59 2016
New Revision: 282547
URL: http://llvm.org/viewvc/llvm-project?rev=282547&view=rev
Log:
Fix defaulted member functions for templated classes.
In some cases, non-special member functions were being marked as being defaulted
in templated classes. This c
Author: anemet
Date: Tue Sep 27 17:19:29 2016
New Revision: 282545
URL: http://llvm.org/viewvc/llvm-project?rev=282545&view=rev
Log:
Shorten DiagnosticInfoOptimizationRemark* to OptimizationRemark*. NFC
With the new streaming interface in LLVM, these class names need to be
typed a lot and it's wa
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Looks like patch was not committed.
https://reviews.llvm.org/D11235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
jlebar updated this revision to Diff 72719.
jlebar added a comment.
Herald added a subscriber: mehdi_amini.
s/libgcc/runtime/
https://reviews.llvm.org/D24979
Files:
clang/lib/Driver/ToolChains.cpp
clang/lib/Headers/CMakeLists.txt
clang/lib/Headers/__clang_cuda_complex_builtins.h
clang/l
jlebar updated this revision to Diff 72717.
jlebar marked 2 inline comments as done.
jlebar added a comment.
Address Richard Smith's review comments:
- Change macro format.
- Add tests (these Just Worked).
https://reviews.llvm.org/D24975
Files:
clang/include/clang/Basic/DiagnosticParseKinds.
joerg added a subscriber: joerg.
joerg added a comment.
I think the comment from Daniel shows the crux of the issue. A left shift is by
nature a multiplication operation, so I don't see why it should get the
warning. A right shift works like a division and order is quite significant for
that.
loladiro updated this revision to Diff 72712.
loladiro added a comment.
Some extra _AFTER_CXX11 that may be necessary - please double check me here,
C++11 constexpr rules are not exactly my specialty ;).
Repository:
rL LLVM
https://reviews.llvm.org/D24372
Files:
include/memory
test/std/
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
LGTM and Devin's comments have been addressed.
https://reviews.llvm.org/D24915
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
majnemer added a comment.
IMO, this should be implemented in clang CodeGen so that we don't get extra
acquire/release barriers with /volatile:ms but that might be overkill; feel
free to disregard this.
https://reviews.llvm.org/D24986
___
cfe-commi
loladiro added a comment.
Before I commit this, I just realized
__libcpp_compressed_pair_imp& operator=(const __libcpp_compressed_pair_imp&
__p)
_NOEXCEPT_(is_nothrow_copy_assignable<_T1>::value &&
is_nothrow_copy_assignable<_T2>::value)
{
_T1::operator=(
hiraditya added a comment.
ping!
https://reviews.llvm.org/D24682
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added inline comments.
Comment at: clang/lib/Parse/ParsePragma.cpp:172
@@ +171,3 @@
+ PragmaForceCUDAHostDeviceStartHandler(Sema &Actions)
+ : PragmaHandler("force_cuda_host_device_begin"), Actions(Actions) {}
+ void HandlePragma(Preprocessor &PP, PragmaIntroducerKin
tra updated this revision to Diff 72707.
tra added a comment.
addressed Justin's comments.
https://reviews.llvm.org/D24946
Files:
lib/Driver/ToolChains.cpp
lib/Headers/__clang_cuda_runtime_wrapper.h
test/Driver/Inputs/CUDA/usr/local/cuda/nvvm/libdevice/libdevice.compute_20.10.bc
test/
I'd still wonder if this meets the bar for false positives (generally we
try to only add warnings that would be enabled by default, even in new
codebases - where most of what they find in a newcodebase are latent bugs,
not noise (so the cleanup is at least fairly justified as being beneficial
in it
tra marked an inline comment as done.
Comment at: lib/Headers/__clang_cuda_runtime_wrapper.h:156
@@ +155,3 @@
+#endif
+#endif
+
jlebar wrote:
> I don't understand what we are doing here...
>
> We're saying, if __USE_FAST_MATH__ is defined, and if it's not equal t
Author: anemet
Date: Tue Sep 27 15:55:12 2016
New Revision: 282540
URL: http://llvm.org/viewvc/llvm-project?rev=282540&view=rev
Log:
Adapt to LLVM optimization remark interface change. NFC
Modified:
cfe/trunk/lib/CodeGen/CodeGenAction.cpp
Modified: cfe/trunk/lib/CodeGen/CodeGenAction.cpp
URL
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL243489.
https://reviews.llvm.org/D11472
___
cfe-commits mailing list
cfe-commits@lists.ll
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
This looks good to me.
I appreciate the cleverness in the tests.
Repository:
rL LLVM
https://reviews.llvm.org/D24372
___
cfe-commit
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Looks like patch was not committed.
https://reviews.llvm.org/D12505
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D24979#554378, @jlebar wrote:
> > I' personally would prefer to force-include these files. I suspect it will
> > not change things much as we already include a
mstorsjo created this revision.
mstorsjo added a reviewer: majnemer.
mstorsjo added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
This implements what is missing for PR30394, making it possible to compile C++
for ARM in MSVC mode with MSVC headers.
https://reviews.llvm.org/D249
jlebar added inline comments.
Comment at: lib/Headers/__clang_cuda_runtime_wrapper.h:139
@@ -137,1 +138,3 @@
+// CUDA 8.0.41 relies on __USE_FAST_MATH__ and __CUDA_PREC_DIV's values
+// Previous versions used to check thether they are defined or not.
Nit, missin
jlebar added a comment.
> I' personally would prefer to force-include these files. I suspect it will
> not change things much as we already include a lot.
We have already had bugs filed by users whose root cause was that we #included
more things than nvcc #includes. I know exact compatibility
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
It makes sense to inherit the current region's counter when we see a new
switch. That should fix the 0 execution count we see on the condition.
Repository:
rL LLVM
https://revi
tra added a comment.
OK.
https://reviews.llvm.org/D24977
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra added a subscriber: echristo.
tra added a comment.
This looks like fix-includes and it may be somewhat shaky if users start
messing with include paths. You may want to get @echristo's input on that. I'
personally would prefer to force-include these files. I suspect it will not
change things
jlebar added a comment.
> That is way too much knowledge about details of standard library
> implementation.
Honestly I think this looks a lot scarier than it is. Or, to be specific, I
think we are already relying on implementation details much more implicit and
fragile than what is explicit
rmaprath created this revision.
rmaprath added reviewers: jroelofs, compnerd, logan.
rmaprath added a subscriber: cfe-commits.
Herald added subscribers: mgorny, beanz.
The EHABI unwinder is thread-agnostic, SJLJ unwinder and the DWARF unwinder
have a couple of `pthread` dependencies.
This patch
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
That is way too much knowledge about details of standard library implementation.
If it changes, I suspect users will end up with a rather uninformative error.
Is there a way to produce somewhat more s
arphaman created this revision.
arphaman added a reviewer: vsk.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch fixes a regression introduced in r262697 that changed the way the
coverage regions for switch are constructed. The PGO ins
mgorny added a comment.
In https://reviews.llvm.org/D24119#554251, @rmaprath wrote:
> Doesn't `-DLIBCXXABI_USE_LLVM_UNWINDER=ON` make it possible to build without
> `libgcc_s`? Or is this something else?
It's supposed to but it doesn't add the necessary libraries when linking
libc++.so.
Rep
Author: matze
Date: Tue Sep 27 14:38:59 2016
New Revision: 282533
URL: http://llvm.org/viewvc/llvm-project?rev=282533&view=rev
Log:
Adapt to LLVM EnableStatistics() change.
Modified:
cfe/trunk/lib/Frontend/CompilerInstance.cpp
cfe/trunk/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp
Mo
tra added a comment.
LGTM. Should we add new pragma description to docs/LanguageExtensions.rst ?
https://reviews.llvm.org/D24975
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz added inline comments.
Comment at: clang-rename/RenamingAction.cpp:74
@@ +73,3 @@
+ // FIXME: An error might happen here if USRLocFinder finds the symbol
+ // twice or if the symbol happens to be in a header included multiple
+ // times independently. Such e
alexshap added inline comments.
Comment at: clang-rename/RenamingAction.cpp:74
@@ +73,3 @@
+ // FIXME: An error might happen here if USRLocFinder finds the symbol
+ // twice or if the symbol happens to be in a header included multiple
+ // times independently. Such
malcolm.parsons added a comment.
In https://reviews.llvm.org/D24848#554145, @mgehre wrote:
> Rename the struct that was introduced in the test. Note that I need to keep
> the function Bug30487,
> because that is where the false-positive warning was emitted.
https://reviews.llvm.org/D24965 wil
rmaprath added a comment.
In https://reviews.llvm.org/D24119#554234, @mgorny wrote:
> I'm starting to regret that I've committed this. It breaks horribly any
> pure-LLVM build, i.e. without linking to libgcc_s. It seems that the build
> system is completely unprepared to link to compiler-rt or
malcolm.parsons added a subscriber: malcolm.parsons.
malcolm.parsons added a comment.
In https://reviews.llvm.org/D24886#554130, @mgehre wrote:
> 2. Also, I suspect we will want this attribute to also be written on types I
> was thinking about a case were that was useful, and didn't find any. Wh
Author: mgorny
Date: Tue Sep 27 13:54:02 2016
New Revision: 282524
URL: http://llvm.org/viewvc/llvm-project?rev=282524&view=rev
Log:
Revert r282483 - [cmake] Add linker option "-Wl,-z,defs" in standalone build
Revert r282483 as it causes build failures due to missing symbols when
not linking to -
mgorny reopened this revision.
mgorny added a comment.
This revision is now accepted and ready to land.
I'm starting to regret that I've committed this. It breaks horribly any
pure-LLVM build, i.e. without linking to libgcc_s. It seems that the build
system is completely unprepared to link to co
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: cfe-commits, jhen.
Herald added subscribers: mgorny, beanz.
We do this by wrapping and .
Tests are in the test-suite. support to come separately.
https://reviews.llvm.org/D24979
Files:
clang/lib/Driver/To
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: jhen, cfe-commits.
Currently we declare our inline __device__ math functions in namespace
std. But libstdc++ and libc++ declare these functions in an inline
namespace inside namespace std. We need to match this
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
Herald added subscribers: mgorny, beanz.
This matches the idiom we use for our other CUDA wrapper headers.
https://reviews.llvm.org/D24978
Files:
clang/lib/Frontend/CompilerInvocation.cpp
clan
jlebar created this revision.
jlebar added a reviewer: rsmith.
jlebar added subscribers: cfe-commits, jhen, tra.
These cause us to consider all functions in-between to be __host__
__device__.
You can nest these pragmas; you just can't have more 'end's than
'begin's.
https://reviews.llvm.org/D249
aaron.ballman added a comment.
In https://reviews.llvm.org/D24886#554130, @mgehre wrote:
> Thank your very much for your comments!
> Let me try to give me reasoning for those points:
>
> 1. But it's missing some pieces, like test cases I though about how to test
> this, having no semantic meani
Anastasia added inline comments.
Comment at: include/clang/Basic/OpenCLOptions.h:39
@@ +38,3 @@
+
+ void set(llvm::StringRef Ext, bool Enable = true) {
+assert(!Ext.empty() && "Extension is empty.");
yaxunl wrote:
> Better add a comments for this function abo
zaks.anna added inline comments.
Comment at: test/Analysis/copypaste/functions.cpp:7
@@ -6,3 +6,3 @@
-int max(int a, int b) { // expected-warning{{Detected code clone.}}
+int max(int a, int b) { // expected-warning{{Clone of this code was detected}}
log();
"w
On Tue, Sep 27, 2016 at 2:05 PM, Matthias Gehre wrote:
> mgehre updated this revision to Diff 72677.
> mgehre added a comment.
>
> Rename the struct that was introduced in the test. Note that I need to keep
> the function Bug30487,
> because that is where the false-positive warning was emitted.
mgehre updated this revision to Diff 72677.
mgehre added a comment.
Rename the struct that was introduced in the test. Note that I need to keep the
function Bug30487,
because that is where the false-positive warning was emitted.
https://reviews.llvm.org/D24848
Files:
clang-tidy/utils/TypeTra
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
I have no further comments.
https://reviews.llvm.org/D24278
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
mgehre added a comment.
Thank your very much for your comments!
Let me try to give me reasoning for those points:
1. But it's missing some pieces, like test cases
I though about how to test this, having no semantic meaning itself.
I could look at the AST dump, but it does not even show the
rules
bruno added a subscriber: bruno.
bruno added a comment.
Hi Daniel,
This is very nice.
In https://reviews.llvm.org/D24861#553606, @danielmarjamaki wrote:
> Compiling 2064 projects resulted in 904 warnings
>
> Here are the results:
> https://drive.google.com/file/d/0BykPmWrCOxt2N04tYl8zVHA3MXc/v
bruno added a subscriber: bruno.
Comment at: lib/Headers/module.modulemap:133
@@ -131,2 +132,3 @@
explicit module aes {
+ export sse2
header "__wmmintrin_aes.h"
The mmx case above makes sense to me, but I find conceptually odd that we need
to re-
Author: anemet
Date: Tue Sep 27 11:39:27 2016
New Revision: 282504
URL: http://llvm.org/viewvc/llvm-project?rev=282504&view=rev
Log:
Revert "Adapt to LLVM optimization remark interface change. NFC"
This reverts commit r282500.
Modified:
cfe/trunk/lib/CodeGen/CodeGenAction.cpp
Modified: cfe/
Author: anemet
Date: Tue Sep 27 11:15:21 2016
New Revision: 282500
URL: http://llvm.org/viewvc/llvm-project?rev=282500&view=rev
Log:
Adapt to LLVM optimization remark interface change. NFC
Modified:
cfe/trunk/lib/CodeGen/CodeGenAction.cpp
Modified: cfe/trunk/lib/CodeGen/CodeGenAction.cpp
URL
ahatanak created this revision.
ahatanak added reviewers: doug.gregor, rsmith.
ahatanak added a subscriber: cfe-commits.
This fixes PR30361.
clang was failing to compile the test case because it was passing "~C1"
instead of "~C1" to FindInstantiatedDecl and RebuildMemberExpr.
https://reviews.ll
ioeric updated this revision to Diff 72666.
ioeric marked 3 inline comments as done.
ioeric added a comment.
- Addressed review comments.
https://reviews.llvm.org/D24800
Files:
include/clang/Tooling/Core/Replacement.h
lib/Tooling/Core/Replacement.cpp
unittests/Tooling/RefactoringTest.cpp
ioeric added inline comments.
Comment at: lib/Tooling/Core/Replacement.cpp:179-181
@@ +178,5 @@
+llvm::Expected
+Replacements::mergeIfOrderIndependent(const Replacement &R) const {
+ Replacements Rs(R);
+ Replacements RsShiftedByReplaces(getReplacementInChangedCode(R));
+ Repla
klimek added inline comments.
Comment at: lib/Tooling/Core/Replacement.cpp:179-181
@@ +178,5 @@
+llvm::Expected
+Replacements::mergeIfOrderIndependent(const Replacement &R) const {
+ Replacements Rs(R);
+ Replacements RsShiftedByReplaces(getReplacementInChangedCode(R));
+ Repla
Author: aymanmus
Date: Tue Sep 27 10:37:31 2016
New Revision: 282492
URL: http://llvm.org/viewvc/llvm-project?rev=282492&view=rev
Log:
Update to commit r282488, fix the buildboot failure.
Modified:
cfe/trunk/lib/Headers/avx512fintrin.h
Modified: cfe/trunk/lib/Headers/avx512fintrin.h
URL:
ht
On Tue, Sep 27, 2016 at 12:15:35PM -, Michal Gorny via cfe-commits wrote:
> Author: mgorny
> Date: Tue Sep 27 07:15:35 2016
> New Revision: 282483
>
> URL: http://llvm.org/viewvc/llvm-project?rev=282483&view=rev
> Log:
> [cmake] Add linker option "-Wl,-z,defs" in standalone build
>
> Add the
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM with two minor nits.
Comment at: lib/AST/ASTImporter.cpp:5563-5564
@@ +5562,4 @@
+const TemplateArgumentLoc *FromArgArray = E->getTemplateArgs();
+for (unsigned i = 0, e = E->getNumTemplateArgs();
rmaprath updated this revision to Diff 72653.
rmaprath added a comment.
Herald added subscribers: mgorny, beanz.
Address review comments from @compnerd and @EricWF.
https://reviews.llvm.org/D24864
Files:
CMakeLists.txt
src/config.h
src/cxa_exception.cpp
src/cxa_exception_storage.cpp
s
malcolm.parsons created this revision.
malcolm.parsons added reviewers: alexfh, aaron.ballman, omtcyfz.
malcolm.parsons added subscribers: cfe-commits, mgehre.
Herald added a subscriber: nemanjai.
Handle classes with default constructors that are defaulted or are not
present in the AST.
Classes wi
rmaprath added inline comments.
Comment at: libcxx/trunk/CMakeLists.txt:329
@@ +328,3 @@
+ ${CMAKE_SYSTEM_NAME} MATCHES "OpenBSD") AND
+ NOT LLVM_USE_SANITIZER)
+set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,-z,defs")
zlei wrote:
rmaprath added inline comments.
Comment at: src/config.h:22
@@ +21,3 @@
+
+#if defined(__GNUC__) || defined(__clang__)
+#define _LIBCXXABI_PRAGMA(_parameter_) _Pragma(#_parameter_)
EricWF wrote:
> What's the point of defining `_LIBCXXABI_WARNING`? It's unused and
ioeric abandoned this revision.
ioeric added a comment.
Abandon in favor of https://reviews.llvm.org/D24800
https://reviews.llvm.org/D24717
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D24825
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
zlei added inline comments.
Comment at: libcxx/trunk/CMakeLists.txt:329
@@ +328,3 @@
+ ${CMAKE_SYSTEM_NAME} MATCHES "OpenBSD") AND
+ NOT LLVM_USE_SANITIZER)
+set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,-z,defs")
rmaprath wrote:
ioeric created this revision.
ioeric added a reviewer: hokein.
ioeric added a subscriber: cfe-commits.
https://reviews.llvm.org/D24963
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-namespace/ChangeNamespaceTests.cpp
==
Author: aymanmus
Date: Tue Sep 27 09:06:32 2016
New Revision: 282488
URL: http://llvm.org/viewvc/llvm-project?rev=282488&view=rev
Log:
[avx512] Add aliases to some missing avx512 intrinsics.
Differential Revision:https: //reviews.llvm.org/D24961
Modified:
cfe/trunk/lib/Headers/avx512fintrin.
mboehme abandoned this revision.
mboehme added a comment.
Abandoning after discussion with klimek.
https://reviews.llvm.org/D24962
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath added a subscriber: rmaprath.
Comment at: libcxx/trunk/CMakeLists.txt:329
@@ +328,3 @@
+ ${CMAKE_SYSTEM_NAME} MATCHES "OpenBSD") AND
+ NOT LLVM_USE_SANITIZER)
+set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,-z,defs")
Perh
1 - 100 of 149 matches
Mail list logo
