alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thank you!
Repository:
rL LLVM
https://reviews.llvm.org/D24201
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
Author: nico
Date: Fri Sep 2 23:27:14 2016
New Revision: 280580
URL: http://llvm.org/viewvc/llvm-project?rev=280580&view=rev
Log:
Add a test Aaron asked for that I forgot to add before landing r280578.
Modified:
cfe/trunk/test/Parser/ms-square-bracket-attributes.mm
Modified: cfe/trunk/test/
thakis closed this revision.
thakis marked an inline comment as done.
thakis added a comment.
Thanks! Landed in r280574 r280575 r280576 280578.
https://reviews.llvm.org/D23895
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
Author: nico
Date: Fri Sep 2 22:25:22 2016
New Revision: 280578
URL: http://llvm.org/viewvc/llvm-project?rev=280578&view=rev
Log:
[ms] Add support for parsing uuid as a Microsoft attribute.
Some Windows SDK classes, for example
Windows::Storage::Streams::IBufferByteAccess, use the ATL way of spe
Author: nico
Date: Fri Sep 2 22:01:32 2016
New Revision: 280576
URL: http://llvm.org/viewvc/llvm-project?rev=280576&view=rev
Log:
Let Microsoft attributes apply to the type, not the variable.
There was already a function that moved attributes off the declspec into
an attribute list for attribute
Author: nico
Date: Fri Sep 2 21:55:10 2016
New Revision: 280575
URL: http://llvm.org/viewvc/llvm-project?rev=280575&view=rev
Log:
Add plumbing for new attribute type "Microsoft".
This is for attributes in []-delimited lists preceding a class, like e.g.
`[uuid("...")] class Foo {};` Not used by
Author: nico
Date: Fri Sep 2 21:48:03 2016
New Revision: 280574
URL: http://llvm.org/viewvc/llvm-project?rev=280574&view=rev
Log:
Move calls of MaybeParseMicrosoftAttributes() before ParseExternalDeclaration()
into ParseDeclOrFunctionDefInternal() (which is called by
MaybeParseMicrosoftAttributes
Author: nico
Date: Fri Sep 2 21:41:17 2016
New Revision: 280572
URL: http://llvm.org/viewvc/llvm-project?rev=280572&view=rev
Log:
Remove function name from comment.
The comment starting with "ParseDeclarationOrFunctionDefinition -" is above
a function called ParseDeclOrFunctionDefInternal. Fix
tstellarAMD accepted this revision.
tstellarAMD added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for doing this.
https://reviews.llvm.org/D23957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
Author: gbiv
Date: Fri Sep 2 19:28:25 2016
New Revision: 280562
URL: http://llvm.org/viewvc/llvm-project?rev=280562&view=rev
Log:
[Sema] Fix how we set implicit conversion kinds.
We have invariants we like to guarantee for the
`ImplicitConversionKind`s in a `StandardConversionSequence`. These
we
Author: ericwf
Date: Fri Sep 2 19:11:33 2016
New Revision: 280561
URL: http://llvm.org/viewvc/llvm-project?rev=280561&view=rev
Log:
Define _LIBCPP_SAFE_STATIC __attribute__((require_constant_initialization)),
and apply it to memory_resource
Modified:
libcxx/trunk/include/__config
libcx
Hello everyone,
The issue with the SVN mirror in the Lab has been resolved.
Please let me know if anything seems wrong with the builders.
Thank you for understanding.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
Author: ygao
Date: Fri Sep 2 18:16:06 2016
New Revision: 280556
URL: http://llvm.org/viewvc/llvm-project?rev=280556&view=rev
Log:
(clang part) Implement MASM-flavor intel syntax behavior for inline MS asm
block.
Clang tests for verifying the following syntaxes:
1. 0xNN and NNh are accepted as va
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280553: [Sema] Relax overloading restrictions in C.
(authored by gbiv).
Changed prior to commit:
https://reviews.llvm.org/D24113?vs=69922&id=70251#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2
george.burgess.iv marked 2 inline comments as done.
Comment at: lib/Sema/SemaOverload.cpp:1813-1815
@@ -1795,5 +1812,5 @@
// and we don't know what conversions it may overlap with.
- SCS.First = ICK_C_Only_Conversion;
- SCS.Second = ICK_C_Only_Conversion;
- SCS.Third = ICK_C
Author: gbiv
Date: Fri Sep 2 17:59:57 2016
New Revision: 280553
URL: http://llvm.org/viewvc/llvm-project?rev=280553&view=rev
Log:
[Sema] Relax overloading restrictions in C.
This patch allows us to perform incompatible pointer conversions when
resolving overloads in C. So, the following code wil
rsmith accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/Sema/SemaOverload.cpp:1813-1815
@@ -1795,5 +1812,5 @@
// and we don't know what conversions it may overlap with.
- SCS.First = ICK_C_Only_Conversion;
- SCS.Second = ICK_C_Only_Conv
rsmith accepted this revision.
rsmith added a comment.
For submit, can you separate the changes to generally support `[]` attribute
syntax and the changes to parse `[uuid(...)]` into distinct commits? (I'm OK
with the `Microsoft` attribute support piece landing with no tests since the
`uuid` pa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280543: Avoid narrowing warnings in __bitset constructor
(authored by dim).
Changed prior to commit:
https://reviews.llvm.org/D23960?vs=69489&id=70231#toc
Repository:
rL LLVM
https://reviews.llvm.or
Author: dim
Date: Fri Sep 2 16:02:11 2016
New Revision: 280543
URL: http://llvm.org/viewvc/llvm-project?rev=280543&view=rev
Log:
Avoid narrowing warnings in __bitset constructor
When is compiled with warnings enabled, on a platform where
size_t is 4 bytes, it results in errors similar to:
Eugene.Zelenko updated this revision to Diff 70229.
Eugene.Zelenko added a comment.
Update to trunk.
Repository:
rL LLVM
https://reviews.llvm.org/D24201
Files:
docs/ReleaseNotes.rst
Index: docs/ReleaseNotes.rst
===
--- docs/R
dim added a comment.
@mclow.lists, I tested code generation (on i386-freebsd) with this small sample
program:
#include
void f(const std::bitset<53>&);
void g(void)
{
std::bitset<53> bs(0x1234567890abcdef);
f(bs);
}
The assembly doesn't change at all after this fix:
g
Author: hans
Date: Fri Sep 2 15:39:46 2016
New Revision: 280539
URL: http://llvm.org/viewvc/llvm-project?rev=280539&view=rev
Log:
Remove link to clang's release notes; keeping it up-to-date is hard
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.rst
Modified: clang-tools-extra/trunk/doc
bcraig added a comment.
LGTM
Comment at: src/condition_variable.cpp:86
@@ +85,3 @@
+if (tl_ptr.get() == nullptr) {
+tl_ptr.set_pointer(new __thread_struct);
+}
EricWF wrote:
> bcraig wrote:
> > The standard synopsis of notify_all_at_thread_exit i
EricWF added inline comments.
Comment at: src/condition_variable.cpp:86
@@ +85,3 @@
+if (tl_ptr.get() == nullptr) {
+tl_ptr.set_pointer(new __thread_struct);
+}
bcraig wrote:
> The standard synopsis of notify_all_at_thread_exit in the standard does
aaron.ballman added inline comments.
Comment at: test/clang-tidy/misc-enum-misuse.cpp:3
@@ +2,3 @@
+
+enum Empty {
+};
szepet wrote:
> Could you specify which part of the file seems off? I have run the clang
> format with the same options on testfiles as on the o
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with one small test case nit.
Comment at: test/Parser/ms-square-bracket-attributes.mm:43
@@ +42,3 @@
+// expected-error@+1 {{expected '('}}
+[uuid{"00A0
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: alexfh, hokein.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Repository:
rL LLVM
https://reviews.llvm.org/D24201
Files:
docs/ReleaseNotes.rst
Index: docs/
Author: ericwf
Date: Fri Sep 2 13:53:31 2016
New Revision: 280525
URL: http://llvm.org/viewvc/llvm-project?rev=280525&view=rev
Log:
Implement __attribute__((require_constant_initialization)) for safe static
initialization.
Summary:
This attribute specifies expectations about the initialization
mgorny planned changes to this revision.
mgorny added a comment.
Let's wait for the reply on https://reviews.llvm.org/D23743.
https://reviews.llvm.org/D23745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
ioeric added a comment.
In https://reviews.llvm.org/D24192#533200, @omtcyfz wrote:
> In https://reviews.llvm.org/D24192#533198, @ioeric wrote:
>
> > In https://reviews.llvm.org/D24192#533174, @omtcyfz wrote:
> >
> > > In https://reviews.llvm.org/D24192#532981, @ioeric wrote:
> > >
> > > > - It wo
EricWF updated this revision to Diff 70200.
EricWF added a comment.
Updating against recent ToT.
https://reviews.llvm.org/D23385
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/AttributeList.h
lib/Sema/Se
Author: ericwf
Date: Fri Sep 2 13:43:25 2016
New Revision: 280521
URL: http://llvm.org/viewvc/llvm-project?rev=280521&view=rev
Log:
Revert r280516 since it contained accidental changes.
Removed:
cfe/trunk/test/SemaCXX/attr-require-constant-initialization.cpp
Modified:
cfe/trunk/include/
ioeric added a comment.
In https://reviews.llvm.org/D24192#533082, @omtcyfz wrote:
> In https://reviews.llvm.org/D24192#532981, @ioeric wrote:
>
> > - You mentioned a design doc in the summary; maybe also include a link to
> > it?
>
>
> Done.
>
> > - It would make the review easier if you could
eugenis added a comment.
I would also expect -nodefaultlibs and -nostdlib to remove all standard
libraries from the link command line, including the sanitizer ones.
I like the idea of -flink-sanitizer-runtime=address, but may be without
"address" - the set of sanitizer runtime libraries can be
SVN mirror in the LLVM Lab is behind the master SVN. This affects the build
bots.
I'm looking in to this.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: aaronballman
Date: Fri Sep 2 13:31:31 2016
New Revision: 280520
URL: http://llvm.org/viewvc/llvm-project?rev=280520&view=rev
Log:
Based on post-commit feedback over IRC with dblaikie, ideally, we should have a
SmallVector constructor that accepts anything which can supply a range via ADL
EricWF added inline comments.
Comment at: src/cxa_thread_atexit.cpp:42
@@ +41,3 @@
+ // - thread_local destructors on other threads run on the first iteration
+ // through the pthread_key destructors. std::notify_all_at_thread_exit()
+ // and similar functions must be care
Author: ericwf
Date: Fri Sep 2 13:25:29 2016
New Revision: 280516
URL: http://llvm.org/viewvc/llvm-project?rev=280516&view=rev
Log:
Implement __attribute__((require_constant_initialization)) for safe static
initialization.
Summary:
This attribute specifies expectations about the initialization
omtcyfz added a comment.
In https://reviews.llvm.org/D24192#533198, @ioeric wrote:
> In https://reviews.llvm.org/D24192#533174, @omtcyfz wrote:
>
> > In https://reviews.llvm.org/D24192#532981, @ioeric wrote:
> >
> > > - It would make the review easier if you could separate the migration of
> > >
ioeric added a comment.
In https://reviews.llvm.org/D24192#533174, @omtcyfz wrote:
> In https://reviews.llvm.org/D24192#532981, @ioeric wrote:
>
> > - It would make the review easier if you could separate the migration of
> > clang-rename into another patch...
>
>
> Another point is that if I tr
thakis marked an inline comment as done.
Comment at: lib/Parse/ParseDeclCXX.cpp:4037
@@ -3945,1 +4036,3 @@
+}
+
T.consumeClose();
Aha, I had forgotten that SkipUntil() handles paren nesting intelligently, so I
think just requiring a '(' after 'uuid' with
thakis updated this revision to Diff 70197.
thakis added a comment.
Require '('.
https://reviews.llvm.org/D23895
Files:
include/clang/Basic/Attr.td
include/clang/Basic/Attributes.h
include/clang/Parse/Parser.h
include/clang/Sema/AttributeList.h
lib/Parse/ParseDecl.cpp
lib/Parse/Pars
omtcyfz abandoned this revision.
omtcyfz added a comment.
Oops, wrong patch... Abandoning this one anyway.
https://reviews.llvm.org/D23651
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
omtcyfz added a comment.
In https://reviews.llvm.org/D24192#532981, @ioeric wrote:
> - It would make the review easier if you could separate the migration of
> clang-rename into another patch...
Another point is that if I try to separate the migration - what do I do about
USREngine? USREngine
tavianator added a comment.
In https://reviews.llvm.org/D21803#532309, @EricWF wrote:
> `__thread`
>
> What do you think of this idea?
Makes sense to me, I'll integrate it into the next revision.
Comment at: src/cxa_thread_atexit.cpp:42
@@ +41,3 @@
+ // - thread_local destru
omtcyfz updated this revision to Diff 70193.
omtcyfz added a comment.
Revert diff, as the last one "deletes and creates" files instead of "moving and
changing them" in the filesystem.
https://reviews.llvm.org/D23651
Files:
CMakeLists.txt
TemplatedClassFunction.cpp
clang-refactor/CMakeLis
On Fri, Sep 2, 2016 at 10:57 AM Aaron Ballman
wrote:
> aaron.ballman added inline comments.
>
>
> Comment at: lib/Sema/SemaOverload.cpp:12996
> @@ +12995,3 @@
> + // selection expression.
> + std::vector AssocExprs(GSE->getAssocExprs().vec());
> + unsigned ResultId
omtcyfz updated this revision to Diff 70194.
omtcyfz added a comment.
Revert diff, as the last one "deletes and creates" files instead of "moving and
changing them" in the filesystem.
https://reviews.llvm.org/D24192
Files:
CMakeLists.txt
TemplatedClassFunction.cpp
clang-refactor/CMakeLis
george.burgess.iv added inline comments.
Comment at: lib/Sema/SemaOverload.cpp:12996
@@ +12995,3 @@
+ // selection expression.
+ std::vector AssocExprs(GSE->getAssocExprs().vec());
+ unsigned ResultIdx = GSE->getResultIndex();
aaron.ballman wrote:
>
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaOverload.cpp:12996
@@ +12995,3 @@
+ // selection expression.
+ std::vector AssocExprs(GSE->getAssocExprs().vec());
+ unsigned ResultIdx = GSE->getResultIndex();
george.burgess.iv wrote:
>
omtcyfz added a comment.
In https://reviews.llvm.org/D24192#532981, @ioeric wrote:
> - You mentioned a design doc in the summary; maybe also include a link to it?
Done.
> - It would make the review easier if you could separate the migration of
> clang-rename into another patch...I think clang
Hello everyone,
LLVM buildmaster will be updated and restarted after 6 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk added a comment.
Won't the mid-level optimizer turn these register variables into undefs, and
we'll end up with this kind of IR?
void f() {
int register var asm ("eax") ;
asm volatile ("add %%eax, %0\n\tret" : : "r"(var));
}
->
define void @"\01?f@@YAXXZ"() local_unnamed_addr
hans added a comment.
I think this is reasonable. Just a few comments:
Comment at: lib/Sema/SemaDecl.cpp:11796
@@ +11795,3 @@
+if (auto *DS = dyn_cast(S)) {
+ if (DS->isSingleDecl()) {
+if (auto *Var = dyn_cast_or_null(DS->getSingleDecl())) {
---
yaxunl added a comment.
The bug is due to PCHValidator is added as Listener, which causes pch is
validated even though DisableValidation is true (when -fno-validate-pch is on).
The fix is not add PCHValidator as listener when DisableValidation is true.
The bug is annoying for using pch. When pc
On 9/2/16 9:26 AM, Sean McBride via cfe-commits wrote:
Friendly ping... this is a very trivial documentation patch...
LGTM
On Wed, 10 Aug 2016 13:57:07 -0400, Sean McBride via cfe-commits said:
Fixed incorrect docs that referred to:
objc_arc_weak_unavailable
when it should be:
objc_arc_
ioeric updated this revision to Diff 70173.
ioeric added a comment.
- removed unintended changes.
https://reviews.llvm.org/D24183
Files:
CMakeLists.txt
change-namespace/CMakeLists.txt
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNamespace.h
change-namespace/tool/CMakeLi
ioeric added a comment.
- You mentioned a design doc in the summary; maybe also include a link to it?
- It would make the review easier if you could separate the migration of
clang-rename into another patch...I think clang-refactor is really the
interesting part here. And maybe also add a small
Friendly ping... this is a very trivial documentation patch...
On Wed, 10 Aug 2016 13:57:07 -0400, Sean McBride via cfe-commits said:
>Fixed incorrect docs that referred to:
> objc_arc_weak_unavailable
>when it should be:
> objc_arc_weak_reference_unavailable
>
>Cheers,
>
>Sean
>
vmiklos added a comment.
Ah, if you mean you squashed this into https://reviews.llvm.org/D24192, then I
see what you mean, ignore me. :-)
https://reviews.llvm.org/D23651
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaOverload.cpp:12996
@@ +12995,3 @@
+ // selection expression.
+ std::vector AssocExprs(GSE->getAssocExprs().vec());
+ unsigned ResultIdx = GSE->getResultIndex();
dblaikie wrote:
> george.b
omtcyfz added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:21
@@ +20,3 @@
+inline std::string formatNamespace(llvm::StringRef NS) {
+ (void)NS.ltrim(':');
+ return NS.str();
is `(void)` intended here?
Comment at: change-nam
dblaikie added inline comments.
Comment at: lib/Sema/SemaOverload.cpp:12996
@@ +12995,3 @@
+ // selection expression.
+ std::vector AssocExprs(GSE->getAssocExprs().vec());
+ unsigned ResultIdx = GSE->getResultIndex();
george.burgess.iv wrote:
> Is t
nikola created this revision.
nikola added reviewers: hans, rnk, compnerd.
nikola added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
I think the current mode is too restrictive, it will emit error for any
statement inside a naked function. Code I'm trying to compile for ARM dec
This revision was automatically updated to reflect the committed changes.
mprobst marked an inline comment as done.
Closed by commit rL280487: clang-format: [JS] merge requoting replacements.
(authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D24155?vs=70066&id=70164#toc
Author: mprobst
Date: Fri Sep 2 09:29:48 2016
New Revision: 280487
URL: http://llvm.org/viewvc/llvm-project?rev=280487&view=rev
Log:
clang-format: [JS] merge requoting replacements.
Summary:
When formatting source code that needs both requoting and reindentation,
merge the replacements to avoid
mprobst marked an inline comment as done.
Comment at: lib/Format/Format.cpp:806
@@ -805,2 +805,3 @@
FormatTokenLexer &Tokens, tooling::Replacements &Result) override {
+tooling::Replacements RunResult;
deriveLocalStyle(AnnotatedLines);
djasper
omtcyfz added a comment.
In https://reviews.llvm.org/D24183#532876, @Eugene.Zelenko wrote:
> Looks like clang-refactor idea should finally go live.
https://reviews.llvm.org/D24192 up for review.
Repository:
rL LLVM
https://reviews.llvm.org/D24183
omtcyfz created this revision.
omtcyfz added reviewers: alexfh, klimek, ioeric, bkramer.
omtcyfz added a subscriber: cfe-commits.
This patch basically creates `clang-refactor` binary and merges both
`clang-rename rename-at` and `clang-rename rename-at` a.k.a. `clang-rename`
into `clang-refactor
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280486: clang-format: [JS] handle default bindings in
imports. (authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D23973?vs=69514&id=70159#toc
Repository:
rL LLVM
https://revie
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Looks like clang-refactor idea should finally go live.
Repository:
rL LLVM
https://reviews.llvm.org/D24183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: mprobst
Date: Fri Sep 2 09:06:32 2016
New Revision: 280486
URL: http://llvm.org/viewvc/llvm-project?rev=280486&view=rev
Log:
clang-format: [JS] handle default bindings in imports.
Summary:
Default imports appear outside of named bindings in curly braces:
import A from 'a';
import A,
mprobst added a comment.
In https://reviews.llvm.org/D23973#532801, @djasper wrote:
> It would be helpful to have a before/after to review these patches.
I assumed the test case was clear enough. Before, we couldn't parse default
bindings at all, after, we do, and thus sort the imports in the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280485: clang-format: [JS] Sort all JavaScript imports if
any changed. (authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D23972?vs=69511&id=70158#toc
Repository:
rL LLVM
https
Author: mprobst
Date: Fri Sep 2 09:01:17 2016
New Revision: 280485
URL: http://llvm.org/viewvc/llvm-project?rev=280485&view=rev
Log:
clang-format: [JS] Sort all JavaScript imports if any changed.
Summary:
User feedback is that they expect *all* imports to be sorted if any import was
affected by
logan added a comment.
Thanks. Committed as https://reviews.llvm.org/rL280484.
https://reviews.llvm.org/D24080
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: logan
Date: Fri Sep 2 08:56:05 2016
New Revision: 280484
URL: http://llvm.org/viewvc/llvm-project?rev=280484&view=rev
Log:
[lit] Replace print with lit_config.note().
This commit replaces print statement with lit_config.note(). This fixes
python3 support for check-libcxxabi.
Modified:
logan added a comment.
In https://reviews.llvm.org/D24084#532724, @asl wrote:
> I totally agree with Renato. What part of libc++abi requires exactly
> libunwind's unwind.h, what is the dependency?
To be specific, we need:
- Structure Definition: `_Unwind_Control_Block` (missing from ``
bundl
aaron.ballman closed this revision.
aaron.ballman added a comment.
Commit in r280483.
https://reviews.llvm.org/D24152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Richard accepted, so claiming this as accepted so I can close it.
https://reviews.llvm.org/D24152
__
Author: aaronballman
Date: Fri Sep 2 08:45:40 2016
New Revision: 280483
URL: http://llvm.org/viewvc/llvm-project?rev=280483&view=rev
Log:
Allow a C11 generic selection expression to select a function with the
overloadable attribute as the result expression without crashing. This fixes
PR30201.
ioeric updated this revision to Diff 70155.
ioeric added a comment.
- Minor cleanup.
https://reviews.llvm.org/D24183
Files:
CMakeLists.txt
change-namespace/CMakeLists.txt
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNamespace.h
change-namespace/tool/CMakeLists.txt
cha
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D23972
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
It would be helpful to have a before/after to review these patches.
https://reviews.llvm.org/D23973
___
cfe-commits mailing list
cfe-commits@li
mprobst added a comment.
Friendly ping.
https://reviews.llvm.org/D23972
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mprobst added a comment.
Friendly ping.
https://reviews.llvm.org/D23973
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added inline comments.
Comment at: src/condition_variable.cpp:86
@@ +85,3 @@
+if (tl_ptr.get() == nullptr) {
+tl_ptr.set_pointer(new __thread_struct);
+}
The standard synopsis of notify_all_at_thread_exit in the standard doesn't have
a "Thr
rizsotto.mailinglist added a comment.
In https://reviews.llvm.org/D24040#532718, @o.gyorgy wrote:
> In https://reviews.llvm.org/D24040#530293, @rizsotto.mailinglist wrote:
>
> > Gyorgy and the ericsson team, thanks for doing this. very good job! good
> > targeted functionality. i don't want to u
omtcyfz added a comment.
In https://reviews.llvm.org/D23651#531884, @vmiklos wrote:
> Kirill, are you waiting for me on this one? AFAICS the patch in its current
> form applies on top of current trunk, but no longer builds.
Miklos, it is a bit more complicated :)
Bascially, I have another pat
rizsotto.mailinglist added a comment.
looks good to me. i like the test. :) but would keep the `pep8` cleanness.
Comment at: tools/scan-build-py/libscanbuild/report.py:38
@@ -36,3 +37,3 @@
-stamp = time.strftime('scan-build-%Y-%m-%d-%H%M%S-', time.localtime())
+stamp =
sfantao added a comment.
Hi Eugene,
The patch looks good to me. You may wait for someone that could okay the patch
to take a look too.
Thanks,
Samuel
Repository:
rL LLVM
https://reviews.llvm.org/D24165
___
cfe-commits mailing list
cfe-commits@
sfantao added a comment.
Hi Eugene,
The patch looks good to me. You may wait for someone that could okay the patch
to take a look too.
Thanks,
Samuel
Repository:
rL LLVM
https://reviews.llvm.org/D24165
___
cfe-commits mailing list
cfe-commits@
asl added a comment.
I totally agree with Renato. What part of libc++abi requires exactly
libunwind's unwind.h, what is the dependency?
https://reviews.llvm.org/D24084
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
o.gyorgy added a comment.
In https://reviews.llvm.org/D24040#530546, @mehdi_amini wrote:
> > This looks like a fairly large tool. Should it get its own "subproject
> > level" directory in the SVN instead of being nested within clang?
>
>
> I'd add that the clang-tools-extra are more closely tied
o.gyorgy added a comment.
In https://reviews.llvm.org/D24040#530293, @rizsotto.mailinglist wrote:
> Gyorgy and the ericsson team, thanks for doing this. very good job! good
> targeted functionality. i don't want to underestimate the complexity it
> requires, but to me this is a giant code. i do
omtcyfz accepted this revision.
omtcyfz added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D24178
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Basically looks good.
Comment at: lib/Format/Format.cpp:806
@@ -805,2 +805,3 @@
FormatTokenLexer &Tokens, tooling::Replacements &Result) override {
+tooling::
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D24179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
99 matches
Mail list logo
