ioeric added a comment. In https://reviews.llvm.org/D24192#533174, @omtcyfz wrote:
> In https://reviews.llvm.org/D24192#532981, @ioeric wrote: > > > - It would make the review easier if you could separate the migration of > > clang-rename into another patch... > > > Another point is that if I try to separate the migration - what do I do about > USREngine? USREngine is basically the core of clang-refactor at the moment > and I can't detach it from clang-rename at the same time. I'm not sure why USREngine is the core of clang-refactor. It seems to me that USREngine is more closely tied to clang-rename than to clang-refactor. At least USREngine is not essential to all refactor tools, and it is more like a library that sub-modules can use. https://reviews.llvm.org/D24192 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
