aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM with one small test case nit. ================ Comment at: test/Parser/ms-square-bracket-attributes.mm:43 @@ +42,3 @@ +// expected-error@+1 {{expected '('}} +[uuid{"000000A0-0000-0000-C000-000000000049"}] struct T {}; + ---------------- For giggles, can you also add: ``` // expected-error@+1 {{expected ')'}} [uuid("000000A0-0000-0000-C000-000000000049"}] struct T {}; ``` https://reviews.llvm.org/D23895 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits