weimingz retitled this revision from "[libcxx] refactor for throw or assert" to
"[libcxx] refactor for throw".
weimingz updated the summary for this revision.
weimingz updated this revision to Diff 62470.
http://reviews.llvm.org/D21706
Files:
include/__functional_03
include/__locale
includ
ABataev added a comment.
In http://reviews.llvm.org/D21904#472074, @carlo.bertolli wrote:
> I think that Kelvin is right. This is what that sentence refers to:
> int * bla = ..;
> #pragma omp target data use_device_ptr(bla)
> {
>
> .. bla .. // <-- this is the 'reference' that sentence is ab
EricWF abandoned this revision.
EricWF added a comment.
Committed in rr274330
http://reviews.llvm.org/D21918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
carlo.bertolli added a comment.
I think that Kelvin is right. This is what that sentence refers to:
int * bla = ..;
#pragma omp target data use_device_ptr(bla)
{
.. bla .. // <-- this is the 'reference' that sentence is about
}
What puzzles me about that sentence is that it seems it is asking
kkwli0 added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:11377
@@ +11376,3 @@
+// item should be a pointer or array
+if (!Type.getNonReferenceType()->isPointerType()) {
+ Diag(ELoc, diag::err_omp_usedeviceptr_not_a_pointer)
sfantao wrote:
> A
sfantao added a comment.
In http://reviews.llvm.org/D18172#471861, @jlebar wrote:
> Alexey, it seems that you're asking for "final" on all classes that are not
> inherited from. Forgive my ignorance, but would you mind pointing me to the
> document that talks about our position on "final" in L
Author: ericwf
Date: Thu Jun 30 23:07:39 2016
New Revision: 274331
URL: http://llvm.org/viewvc/llvm-project?rev=274331&view=rev
Log:
Flatten tuple_constructible, tuple_convertible and tuple_assignable.
This patch is the last in a series that replaces recursive meta-programming
in std::tuple with
ABataev added a comment.
In http://reviews.llvm.org/D18172#471861, @jlebar wrote:
> Alexey, it seems that you're asking for "final" on all classes that are not
> inherited from. Forgive my ignorance, but would you mind pointing me to the
> document that talks about our position on "final" in L
Author: ericwf
Date: Thu Jun 30 22:54:54 2016
New Revision: 274330
URL: http://llvm.org/viewvc/llvm-project?rev=274330&view=rev
Log:
Flatten the tuple_element and __make_tuple_types implementations.
This patch attempts to improve the QoI of std::tuples tuple_element and
__make_tuple_types helpers
sfantao updated this revision to Diff 62462.
sfantao added a comment.
- Remove \brief.
http://reviews.llvm.org/D18172
Files:
include/clang/Driver/Compilation.h
lib/Driver/Driver.cpp
Index: lib/Driver/Driver.cpp
===
--- lib/Dri
sfantao added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:11377
@@ +11376,3 @@
+// item should be a pointer or array
+if (!Type.getNonReferenceType()->isPointerType()) {
+ Diag(ELoc, diag::err_omp_usedeviceptr_not_a_pointer)
ABataev wrote:
>
ABataev added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:11377
@@ +11376,3 @@
+// item should be a pointer or array
+if (!Type.getNonReferenceType()->isPointerType()) {
+ Diag(ELoc, diag::err_omp_usedeviceptr_not_a_pointer)
sfantao wrote:
>
sfantao updated this revision to Diff 62460.
sfantao added a comment.
- Remove \brief.
http://reviews.llvm.org/D18171
Files:
include/clang/Driver/Action.h
include/clang/Driver/Compilation.h
include/clang/Driver/Driver.h
lib/Driver/Action.cpp
lib/Driver/Driver.cpp
lib/Driver/ToolChai
mclow.lists added a comment.
Hal and I talked about this in Oulu. In general, I'm good with this approach.
However, I think that the code could be made much clearer. (some naming
changes, some code rearrangement)
First off, I think the name `__fast_isinf` is a poor name. I think something
like
sfantao added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:11377
@@ +11376,3 @@
+// item should be a pointer or array
+if (!Type.getNonReferenceType()->isPointerType()) {
+ Diag(ELoc, diag::err_omp_usedeviceptr_not_a_pointer)
ABataev wrote:
>
sfantao added a comment.
In http://reviews.llvm.org/D18171#471824, @sfantao wrote:
> Hi Alexey,
>
> Thanks for the review! I addressed your comments in the last diff.
>
> In http://reviews.llvm.org/D18171#471044, @ABataev wrote:
>
> > No '\brief's
>
>
> When you say "no \brief" do you mean I am
ABataev added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8318
@@ -8317,1 +8317,3 @@
+def err_omp_usedeviceptr_not_a_pointer : Error<
+ "item used in 'use_device_pointer' clause is not a pointer">;
} // end of OpenMP category
It's be
Author: rnk
Date: Thu Jun 30 21:41:25 2016
New Revision: 274326
URL: http://llvm.org/viewvc/llvm-project?rev=274326&view=rev
Log:
[DebugInfo] Set DISubprogram ThisAdjustment in the MS ABI
Modified:
cfe/trunk/lib/CodeGen/CGCXXABI.h
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
cfe/trunk/lib/Co
hfinkel added a comment.
In http://reviews.llvm.org/D18639#472010, @chandlerc wrote:
> I'm fine with this change, but we should also get Steve to comment on it, and
> make sure we have a good way of explaining this to users.
>
> In particular, we probably need some documentation around these fas
chandlerc added a reviewer: scanon.
chandlerc added a comment.
I'm fine with this change, but we should also get Steve to comment on it, and
make sure we have a good way of explaining this to users.
In particular, we probably need some documentation around these fast routines
that clearly indic
hfinkel accepted this revision.
hfinkel added a reviewer: hfinkel.
hfinkel added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D5896
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
EricWF created this revision.
EricWF added a subscriber: cfe-commits.
http://reviews.llvm.org/D21918
Files:
include/__tuple
Index: include/__tuple
===
--- include/__tuple
+++ include/__tuple
@@ -228,68 +228,141 @@
template str
arsenm added a comment.
ping
http://reviews.llvm.org/D5896
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
The rationale is no different for DWARF than for CodeView, there's no other way
to get the fully qualified name of an inlined function. Unless you want to
connect this up to the existing DWARF hook for putting linkage names on inlined
subprograms? The downside there is that linkage names are p
EricWF closed this revision.
EricWF added a comment.
Committed in r274316.
http://reviews.llvm.org/D15421
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Thu Jun 30 20:24:09 2016
New Revision: 274316
URL: http://llvm.org/viewvc/llvm-project?rev=274316&view=rev
Log:
[Feature] Add a builtin for indexing into parameter packs. Patch by Louis
Dionne.
This patch adds a __nth_element builtin that allows fetching the n-th type of a
p
Author: akirtzidis
Date: Thu Jun 30 20:17:02 2016
New Revision: 274314
URL: http://llvm.org/viewvc/llvm-project?rev=274314&view=rev
Log:
[CodeCompletion] Allow system headers providing private symbols with a single
underscore.
rdar://24677150
Modified:
cfe/trunk/lib/Sema/SemaCodeComplete.cp
hfinkel added a comment.
ping
http://reviews.llvm.org/D18639
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Okay, that is peculiar. But I can repro it. If I put either orbis-ld or
orbis-ld.exe co-located with clang.exe, it builds a command line without the
.exe suffix (but using the directory where clang.exe lives).
I do think a bug report would have been appropriate, rather than just munging
the t
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: bkramer, cfe-commits.
Bug pointed out by Benjamin Kramer in r264008. I think the bug is
benign because by the time this is called, we should only have at most
two overloads to consider (either a host and a devic
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
Specifically, this patch adds testcases for all three calls to
EraseUnwantedCUDAMatches. The addr-of-overloaded-fn test I accidentally
neutered in r264207, which moved much of
CodeGenCUDA/function-
jlebar created this revision.
jlebar added a reviewer: rsmith.
jlebar added subscribers: tra, cfe-commits.
You can overload a destructor in CUDA, and SemaOverload needs to be
tweaked not to crash when it sees an explicit call to an overloaded
destructor.
http://reviews.llvm.org/D21912
Files:
l
Hello everyone,
LLVM buildmaster will be restarted around 5 PM Pacific time today.
Thank you for understanding.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar added a comment.
Alexey, it seems that you're asking for "final" on all classes that are not
inherited from. Forgive my ignorance, but would you mind pointing me to the
document that talks about our position on "final" in LLVM source? I don't see
it in the style guide, but I may be mis
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Please reformat with clang-format and then OK.
-eric
http://reviews.llvm.org/D21334
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
sfantao added a comment.
Hi Alexey,
Thanks for the review! Addressed your comments in the new diff.
I'll wait for your response on my question in http://reviews.llvm.org/D18172 to
address the issue with \brief properly.
Thanks again,
Samuel
http://reviews.llvm.org/D18172
_
sfantao updated this revision to Diff 62438.
sfantao marked 3 inline comments as done.
sfantao added a comment.
- Fix comments, annotate classes with final, and add default initializers.
http://reviews.llvm.org/D18172
Files:
include/clang/Driver/Compilation.h
lib/Driver/Driver.cpp
Index: l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274291: [Sema] Implement C++14's DR1579: Prefer returning by
converting move constructor (authored by epilk).
Changed prior to commit:
http://reviews.llvm.org/D21619?vs=62405&id=62437#toc
Repository:
Author: epilk
Date: Thu Jun 30 18:09:13 2016
New Revision: 274291
URL: http://llvm.org/viewvc/llvm-project?rev=274291&view=rev
Log:
[Sema] Implement C++14's DR1579: Prefer returning by converting move constructor
Fixes PR28096.
Differential Revision: http://reviews.llvm.org/D21619
Modified:
sfantao added a comment.
Hi Alexey,
Thanks for the review! I addressed your comments in the last diff.
In http://reviews.llvm.org/D18171#471044, @ABataev wrote:
> No '\brief's
When you say "no \brief" do you mean I am using that where I shouldn't or the
other way around. I am only adding th
On Thu, Jun 30, 2016 at 3:52 PM, Robinson, Paul
wrote:
>
>
> > -Original Message-
> > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf
> Of
> > Sean Silva via cfe-commits
> > Sent: Tuesday, June 28, 2016 5:29 PM
> > To: cfe-commits@lists.llvm.org
> > Subject: r27408
EricWF added a subscriber: EricWF.
EricWF added a comment.
Ping? Is there a reason this hasn't been committed?
http://reviews.llvm.org/D15421
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
sfantao updated this revision to Diff 62435.
sfantao marked 5 inline comments as done.
sfantao added a comment.
- Mark classes with final and fix comments.
http://reviews.llvm.org/D18171
Files:
include/clang/Driver/Action.h
include/clang/Driver/Compilation.h
include/clang/Driver/Driver.h
> -Original Message-
> From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of
> Sean Silva via cfe-commits
> Sent: Tuesday, June 28, 2016 5:29 PM
> To: cfe-commits@lists.llvm.org
> Subject: r274084 - Revert "[PS4] Tighten up a test (noticed in passing)"
>
> Author: si
Ilod added a subscriber: Ilod.
Ilod added a comment.
Hello,
When I tried your patch and added LLVM_EXPORT_SYMBOLS_FOR_PLUGINS=ON, I had
multiple errors on your python scripts, like:
File "utils/extract_symbols.py", line 399, in
calling_convention_decoration = is_32bit_windows(libs[0]
Author: ericwf
Date: Thu Jun 30 17:34:43 2016
New Revision: 274286
URL: http://llvm.org/viewvc/llvm-project?rev=274286&view=rev
Log:
Replace __make_tuple_indices implementation with superior implementation.
The previous __make_tuple_indices implementation caused O(N) instantiations
and was pretty
I think this code is accidentally OK, because the list of overloads
that callers pass in in should have at most two elements. A given
overload set may have both a __host__ and a __device__ function, or
alternatively it may have a __host__ __device__ function, but you
can't have all three.
There i
timshen updated this revision to Diff 62433.
timshen added a comment.
Done. Added a new testcase to ensure the correct behavior with exceptions
turned on.
http://reviews.llvm.org/D20499
Files:
lib/CodeGen/CGCleanup.cpp
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFu
Author: marshall
Date: Thu Jun 30 17:05:45 2016
New Revision: 274285
URL: http://llvm.org/viewvc/llvm-project?rev=274285&view=rev
Log:
Fix static assert problem on gcc; remove XFAILs that I put in in r274250
Modified:
libcxx/trunk/include/__hash_table
libcxx/trunk/include/__tree
libcx
sebpop added a comment.
LGTM.
http://reviews.llvm.org/D21907
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: spatel
Date: Thu Jun 30 16:02:40 2016
New Revision: 274278
URL: http://llvm.org/viewvc/llvm-project?rev=274278&view=rev
Log:
fix typo; NFC
Modified:
cfe/trunk/lib/CodeGen/CodeGenModule.cpp
Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe
brzycki created this revision.
brzycki added reviewers: abdulras, rengolin, jmolloy.
brzycki added subscribers: cfe-commits, sebpop, evandro.
Herald added subscribers: rengolin, aemerson.
The GNU profiling support indicates that the interface is `_mcount` rather than
`mcount` on GLIBC Linux for A
Author: ericwf
Date: Thu Jun 30 15:46:58 2016
New Revision: 274274
URL: http://llvm.org/viewvc/llvm-project?rev=274274&view=rev
Log:
Fix C++03 build.
Modified:
libcxx/trunk/test/std/containers/unord/unord.map/unord.map.cnstr/compare_copy_constructible.fail.cpp
libcxx/trunk/test/std/cont
Thank you, fix in r274269.
On Thu, Jun 30, 2016 at 12:57 PM, Yaron Keren wrote:
> Seems this commit broke a builder,
> http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6
>
> http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/builds/26133
> http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/bui
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
http://reviews.llvm.org/D21619
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
jlebar marked 4 inline comments as done.
jlebar added a comment.
http://reviews.llvm.org/D21867
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar updated this revision to Diff 62409.
jlebar added a comment.
Address Art's review.
http://reviews.llvm.org/D21867
Files:
include/clang/Basic/Cuda.h
include/clang/Driver/Action.h
lib/Basic/CMakeLists.txt
lib/Basic/Cuda.cpp
lib/Basic/Targets.cpp
lib/Driver/Action.cpp
lib/Driv
tra added inline comments.
Comment at: lib/Driver/Driver.cpp:1026-1028
@@ -1024,4 +1025,5 @@
} else if (CudaDeviceAction *CDA = dyn_cast(A)) {
-os << '"'
- << (CDA->getGpuArchName() ? CDA->getGpuArchName() : "(multiple archs)")
+os << '"' << (CDA->getGpuArch() !=
erik.pilkington updated this revision to Diff 62405.
erik.pilkington added a comment.
This new patch addresses all of Richard's comments.
http://reviews.llvm.org/D21619
Files:
include/clang/Sema/Initialization.h
include/clang/Sema/Sema.h
lib/Sema/SemaStmt.cpp
test/CXX/drs/dr15xx.cpp
t
Interestingly all the clang tests pass with that whole line commented
out. So something *really* seems missing here.
Thank you for finding this.
On Thu, Jun 30, 2016 at 5:08 AM, Benjamin Kramer wrote:
> On Tue, Mar 22, 2016 at 1:09 AM, Justin Lebar via cfe-commits
> wrote:
>> Author: jlebar
>>
rsmith added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:438
@@ -426,1 +437,3 @@
+}
EmitAnyExprToMem(E, Object, Qualifiers(), /*IsInit*/true);
+if (Size) {
Seems like you should push the cleanup before you emit the initializer; the
cleanup sh
On Thu, Jun 30, 2016 at 2:02 AM, David Chisnall wrote:
> On 29 Jun 2016, at 23:07, Richard Smith via cfe-dev <
> cfe-...@lists.llvm.org> wrote:
> >
> > Yes, those are real problems, but it's not reasonable for us to keep the
> default at C++98/03 forever. GCC has already taken the plunge here, so
Author: jlebar
Date: Thu Jun 30 15:29:29 2016
New Revision: 274269
URL: http://llvm.org/viewvc/llvm-project?rev=274269&view=rev
Log:
Fix ASTMatchersNodeTest to work on Windows.
It was failing because it had an explicit check for whether we're on
Windows.
There are a few other similar explicit ch
jlebar marked an inline comment as done.
Comment at: lib/Driver/Driver.cpp:1026-1028
@@ -1024,4 +1025,5 @@
} else if (CudaDeviceAction *CDA = dyn_cast(A)) {
-os << '"'
- << (CDA->getGpuArchName() ? CDA->getGpuArchName() : "(multiple archs)")
+os << '"' << (CDA->ge
Author: rsmith
Date: Thu Jun 30 15:24:30 2016
New Revision: 274267
URL: http://llvm.org/viewvc/llvm-project?rev=274267&view=rev
Log:
Fix typo-correction crash if a typo occurs within the operand of a
function-style cast to a non-dependent type which is then used in an invalid
way. We'd lose the "t
tra added inline comments.
Comment at: lib/Driver/Driver.cpp:1026-1028
@@ -1024,4 +1025,5 @@
} else if (CudaDeviceAction *CDA = dyn_cast(A)) {
-os << '"'
- << (CDA->getGpuArchName() ? CDA->getGpuArchName() : "(multiple archs)")
+os << '"' << (CDA->getGpuArch() !=
bcraig added a comment.
Also, can you add test cases for a lot of these things? I don't expect test
cases for the DSO side of things, but a lot of the tricky atexit cases should
be covered.
http://reviews.llvm.org/D21803
___
cfe-commits mailing l
tavianator added inline comments.
Comment at: src/cxa_thread_atexit.cpp:47
@@ +46,3 @@
+ void run_dtors(void* ptr) {
+if (pthread_setspecific(dtors, ptr) != 0) {
+ abort_message("pthread_setspecific() failed during thread_local
destruction");
bcraig wro
Seems this commit broke a builder,
http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6
http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/builds/26133
http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/builds/26134
TEST 'Clang-Unit ::
ASTMatchers/ASTMatchersTests/Declaratio
bcraig added inline comments.
Comment at: src/cxa_thread_atexit.cpp:47
@@ +46,3 @@
+ void run_dtors(void* ptr) {
+if (pthread_setspecific(dtors, ptr) != 0) {
+ abort_message("pthread_setspecific() failed during thread_local
destruction");
Why are we doi
jlebar marked an inline comment as done.
Comment at: lib/Basic/Cuda.cpp:8-19
@@ +7,14 @@
+
+const char *CudaVersionToString(CudaVersion V) {
+ switch (V) {
+ case CudaVersion::UNKNOWN:
+return "unknown";
+ case CudaVersion::CUDA_70:
+return "7.0";
+ case CudaVersion::C
carlo.bertolli added a comment.
Hi
Yes, the purpose of these patches was to check correctness of code gen for the
related clauses when targeting nvptx exclusively.
Since I wrote these tests, the base support changed to generate same code on
host and any device type, and it seemed to me that the
rsmith added a comment.
There are a few missing pieces here:
1. Analysis/CFG.cpp needs to be taught to build a correct CFG for these. You
can test this with an example like 'if (bool b; b)' which should give a
-Wuninitialized warning.
2. AST/ExprConstant.cpp needs to be taught to perform consta
tavianator updated this revision to Diff 62394.
tavianator added a comment.
Fix copy-pasta that result in an infinite loop.
http://reviews.llvm.org/D21803
Files:
cmake/config-ix.cmake
src/CMakeLists.txt
src/cxa_thread_atexit.cpp
test/CMakeLists.txt
test/cxa_thread_atexit_test.pass.cpp
Author: jlebar
Date: Thu Jun 30 13:41:33 2016
New Revision: 274261
URL: http://llvm.org/viewvc/llvm-project?rev=274261&view=rev
Log:
[CUDA] Give templated device functions internal linkage, templated kernels
external linkage.
Summary:
This lets LLVM perform IPO over these functions. In particul
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274261: [CUDA] Give templated device functions internal
linkage, templated kernels… (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D21337?vs=60728&id=62391#toc
Repository:
rL
Author: rsmith
Date: Thu Jun 30 13:36:34 2016
New Revision: 274260
URL: http://llvm.org/viewvc/llvm-project?rev=274260&view=rev
Log:
PR28373: fix crash-on-invalid if the condition of an if-statement fails
typo-correction.
Modified:
cfe/trunk/lib/Sema/SemaExpr.cpp
cfe/trunk/test/SemaCXX/c
tavianator updated this revision to Diff 62388.
tavianator added a comment.
Added missing __dso_handle declaration.
http://reviews.llvm.org/D21803
Files:
cmake/config-ix.cmake
src/CMakeLists.txt
src/cxa_thread_atexit.cpp
test/CMakeLists.txt
test/cxa_thread_atexit_test.pass.cpp
test/
tavianator marked 3 inline comments as done.
tavianator added a comment.
In http://reviews.llvm.org/D21803#470448, @bcraig wrote:
> What that means for this implementation is that I think that
> _cxa_thread_atexit is allowed to be called during run_dtors. If running the
> dtor for a thread loc
tavianator updated this revision to Diff 62386.
tavianator added a comment.
Fixed some corner cases regarding destruction order and very-late-initialized
thread_locals. Explicitly documented the known limitations compared to
__cxa_thread_atexit_impl().
http://reviews.llvm.org/D21803
Files:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274257: Don't instantiate a full host toolchain in
ASTMatchersTest. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D21810?vs=62132&id=62385#toc
Repository:
rL LLVM
http://rev
Author: jlebar
Date: Thu Jun 30 13:12:25 2016
New Revision: 274257
URL: http://llvm.org/viewvc/llvm-project?rev=274257&view=rev
Log:
Don't instantiate a full host toolchain in ASTMatchersTest.
Summary:
This test was stat()'ing large swaths of /usr/lib hundreds of times, as
every invocation of mat
chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.
In http://reviews.llvm.org/D21810#471486, @jlebar wrote:
> > But I think this is a reasonable workaround until such an API can be
> > provided.
>
>
> Should I take that as an LG, or are
Author: marshall
Date: Thu Jun 30 13:05:19 2016
New Revision: 274255
URL: http://llvm.org/viewvc/llvm-project?rev=274255&view=rev
Log:
Mark issues 2550, 2551, 2555, 2685, 2698 as complete. These issues are wording
clarifications; no code changes required.
Modified:
libcxx/trunk/www/cxx1z_sta
Author: marshall
Date: Thu Jun 30 12:59:01 2016
New Revision: 274253
URL: http://llvm.org/viewvc/llvm-project?rev=274253&view=rev
Log:
Mark issues 2667, 2669, 2670, 2671, 2673 as complete. These issues are wording
clarifications; no code changes required.
Modified:
libcxx/trunk/www/cxx1z_sta
David and Paul,
Do you think I should enable this behavior for DWARF as well? We only emit
a DW_TAG_subprogram when a function is inlined or contains inlined
functions, which might not be that many. IIRC Paul did something similar
with DW_AT_linkage_name, and the object file size cost wasn't that
Author: marshall
Date: Thu Jun 30 12:49:36 2016
New Revision: 274250
URL: http://llvm.org/viewvc/llvm-project?rev=274250&view=rev
Log:
Temporarily XFAIL the incomplete type tests for GCC while I figure out why
adding a static_assert in r274235 broken them
Modified:
libcxx/trunk/test/std/cont
hokein updated this revision to Diff 62383.
hokein marked 4 inline comments as done.
hokein added a comment.
Address review comments.
http://reviews.llvm.org/D21603
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixerContext.h
include-fixer/SymbolIndexManager.cpp
include-fix
Author: marshall
Date: Thu Jun 30 12:52:51 2016
New Revision: 274252
URL: http://llvm.org/viewvc/llvm-project?rev=274252&view=rev
Log:
Implement LWG#2688: 'clamp misses preconditions and has extraneous condition on
result'. We already did this, just added tests
Modified:
libcxx/trunk/test/st
hokein added inline comments.
Comment at: include-fixer/IncludeFixer.cpp:234
@@ +233,3 @@
+ std::string MinimizedFilePath = minimizeInclude(
+ ((FilePath[0] == '"' || FilePath[0] == '<') ? FilePath
+ : "\"" + FileP
Author: rnk
Date: Thu Jun 30 12:41:31 2016
New Revision: 274246
URL: http://llvm.org/viewvc/llvm-project?rev=274246&view=rev
Log:
[codeview] Emit qualified display names if -gline-tables-only is on
When -gmlt is on, we don't emit namespace or class scope information,
and the CodeView emission cod
jlebar added a comment.
> But I think this is a reasonable workaround until such an API can be provided.
Should I take that as an LG, or are we waiting for someone else to approve this?
http://reviews.llvm.org/D21810
___
cfe-commits mailing list
c
Author: rnk
Date: Thu Jun 30 12:41:27 2016
New Revision: 274245
URL: http://llvm.org/viewvc/llvm-project?rev=274245&view=rev
Log:
Port some more debug info tests on Windows
Modified:
cfe/trunk/test/CodeGenCXX/debug-info-line.cpp
cfe/trunk/test/CodeGenCXX/debug-info-namespace.cpp
cfe/t
weimingz added a comment.
In http://reviews.llvm.org/D21706#471091, @EricWF wrote:
> Please make the changes in the above comment.
Sure. I'm working on it. Just got interrupted/distracted by other tasks time to
time. :(
http://reviews.llvm.org/D21706
__
bruening added inline comments.
Comment at: docs/CSI.rst:75
@@ +74,3 @@
+ % clang++ -c -O3 -g -fcsi -emit-llvm bar.cpp -o bar.o
+ % clang++ foo.o bar.o my-tool.o libclang_rt.csi-x86_64.a -fuse-ld=gold -flto
-lrt -ldl -o foo
+
See below: the sanitizers pass the
Anastasia added a subscriber: Anastasia.
Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8595
@@ -8594,3 +8594,3 @@
-/// \brief Return the resulting type when an OpenCL vector is shifted
+/// \brief Return the resulting type when an vector is shifted
///by a scalar o
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: lib/Basic/Cuda.cpp:8-19
@@ +7,14 @@
+
+const char *CudaVersionToString(CudaVersion V) {
+ switch (V) {
+ case CudaVersion::UNKNOWN:
+return "unknown";
+ cas
Hahnfeld added a comment.
Hi Carlo,
I think these tests are not yet committed, right?
Thanks,
Jonas
Repository:
rL LLVM
http://reviews.llvm.org/D18286
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
Anastasia marked 12 inline comments as done.
Comment at: lib/CodeGen/CGBuiltin.cpp:2180-2181
@@ +2179,4 @@
+}
+// Could have events and/or vaargs.
+if (NumArgs >= 5) {
+ if (E->getArg(3)->getType()->isBlockPointerType()) {
bader wrote:
> [Style] M
dimitry added inline comments.
Comment at: src/cxa_thread_atexit.cpp:46
@@ +45,3 @@
+ pthread_key_delete(key_);
+}
+
bcraig wrote:
> dimitry wrote:
> > run_dtors() is called when/if libc++.so gets unloaded... but only for the
> > thread calling dlclose()
1 - 100 of 147 matches
Mail list logo
