r273388 - [AVX512] Fix _mm_setzero_di to not require avx512vl since its used by the avx512dqintrin.h. Also update the avx512dq test to not enable avx512vl feature so we can ensure correct dependencies

2016-06-21 Thread Craig Topper via cfe-commits
Author: ctopper Date: Wed Jun 22 01:36:21 2016 New Revision: 273388 URL: http://llvm.org/viewvc/llvm-project?rev=273388&view=rev Log: [AVX512] Fix _mm_setzero_di to not require avx512vl since its used by the avx512dqintrin.h. Also update the avx512dq test to not enable avx512vl feature so we can

r273386 - [AVX512] Add missing typecasts to intrinsics.

2016-06-21 Thread Craig Topper via cfe-commits
Author: ctopper Date: Wed Jun 22 01:36:16 2016 New Revision: 273386 URL: http://llvm.org/viewvc/llvm-project?rev=273386&view=rev Log: [AVX512] Add missing typecasts to intrinsics. Modified: cfe/trunk/lib/Headers/avx512vlbwintrin.h Modified: cfe/trunk/lib/Headers/avx512vlbwintrin.h URL: http

r273387 - [AVX512] __builtin_ia32_reducesd_mask and __builtin_ia32_reducess_mask should not require avx512vl.

2016-06-21 Thread Craig Topper via cfe-commits
Author: ctopper Date: Wed Jun 22 01:36:18 2016 New Revision: 273387 URL: http://llvm.org/viewvc/llvm-project?rev=273387&view=rev Log: [AVX512] __builtin_ia32_reducesd_mask and __builtin_ia32_reducess_mask should not require avx512vl. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def M

r273389 - [AVX512] Use a __v8hi vector inside of _mm_setzero_hi to match its name. Probably no real functional change.

2016-06-21 Thread Craig Topper via cfe-commits
Author: ctopper Date: Wed Jun 22 01:36:23 2016 New Revision: 273389 URL: http://llvm.org/viewvc/llvm-project?rev=273389&view=rev Log: [AVX512] Use a __v8hi vector inside of _mm_setzero_hi to match its name. Probably no real functional change. Modified: cfe/trunk/lib/Headers/avx512vlbwintrin.

Re: [clang-tools-extra] r273304 - clang-rename: add a -old-name option

2016-06-21 Thread Miklos Vajna via cfe-commits
Hi Galina, On Tue, Jun 21, 2016 at 06:17:52PM -0700, Galina Kistanova wrote: > This revision broke one of builders: > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/7435 Yes, sorry. Should be fixed by r273314. Regards, Miklos

Re: [PATCH] D21597: clang-format: [JS] recognize more type locations.

2016-06-21 Thread Martin Probst via cfe-commits
mprobst added a comment. This seems to be getting a bit tricky with the declaration contexts. If you have a better suggestion, please come forward. http://reviews.llvm.org/D21597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[libcxx] r273385 - Placate MSVC's unchecked malloc warning in thread tests.

2016-06-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jun 22 00:44:08 2016 New Revision: 273385 URL: http://llvm.org/viewvc/llvm-project?rev=273385&view=rev Log: Placate MSVC's unchecked malloc warning in thread tests. Modified: libcxx/trunk/test/std/thread/thread.threads/thread.thread.class/thread.thread.constr/F.pass.

[libcxx] r273384 - Use correct Clang feature names. I got them wrong in the previous commit

2016-06-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jun 22 00:40:17 2016 New Revision: 273384 URL: http://llvm.org/viewvc/llvm-project?rev=273384&view=rev Log: Use correct Clang feature names. I got them wrong in the previous commit Modified: libcxx/trunk/test/support/test_macros.h Modified: libcxx/trunk/test/support/

[libcxx] r273383 - Support old GCC exception and rtti detection macros

2016-06-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jun 22 00:33:52 2016 New Revision: 273383 URL: http://llvm.org/viewvc/llvm-project?rev=273383&view=rev Log: Support old GCC exception and rtti detection macros Modified: libcxx/trunk/test/support/test_macros.h Modified: libcxx/trunk/test/support/test_macros.h URL: h

[libcxx] r273382 - Add tests for RTTI/exceptions test macros.

2016-06-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jun 22 00:29:15 2016 New Revision: 273382 URL: http://llvm.org/viewvc/llvm-project?rev=273382&view=rev Log: Add tests for RTTI/exceptions test macros. Added: libcxx/trunk/test/support/test.support/ libcxx/trunk/test/support/test.support/test_convertible_header.pas

[libcxx] r273381 - Fix exception/rtti detection in tests.

2016-06-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jun 22 00:03:10 2016 New Revision: 273381 URL: http://llvm.org/viewvc/llvm-project?rev=273381&view=rev Log: Fix exception/rtti detection in tests. So the macros TEST_HAS_NO_EXCEPTIONS and TEST_HAS_NO_RTTI were always getting defined because I spelt __cpp_exceptions and __

[PATCH] D21597: clang-format: [JS] recognize more type locations.

2016-06-21 Thread Martin Probst via cfe-commits
mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. Includes parenthesized type expressions and type aliases. http://reviews.llvm.org/D21597 Files: lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp

[libcxx] r273379 - Make shared_ptr constructor tests use count_new.hpp

2016-06-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jun 21 23:51:07 2016 New Revision: 273379 URL: http://llvm.org/viewvc/llvm-project?rev=273379&view=rev Log: Make shared_ptr constructor tests use count_new.hpp Modified: libcxx/trunk/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.co

r273377 - [AVX512] Use correct types for mask parameters in avx512vlbw cmp builtin tests.

2016-06-21 Thread Craig Topper via cfe-commits
Author: ctopper Date: Tue Jun 21 23:47:55 2016 New Revision: 273377 URL: http://llvm.org/viewvc/llvm-project?rev=273377&view=rev Log: [AVX512] Use correct types for mask parameters in avx512vlbw cmp builtin tests. Modified: cfe/trunk/test/CodeGen/avx512vlbw-builtins.c Modified: cfe/trunk/tes

r273378 - [AVX512] Replace masked integer cmp and ucmp builtins with native IR.

2016-06-21 Thread Craig Topper via cfe-commits
Author: ctopper Date: Tue Jun 21 23:47:58 2016 New Revision: 273378 URL: http://llvm.org/viewvc/llvm-project?rev=273378&view=rev Log: [AVX512] Replace masked integer cmp and ucmp builtins with native IR. Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp cfe/trunk/test/CodeGen/avx512bw-builtin

[libcxx] r273375 - Make locale constructors tests use count_new.hpp

2016-06-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jun 21 23:34:24 2016 New Revision: 273375 URL: http://llvm.org/viewvc/llvm-project?rev=273375&view=rev Log: Make locale constructors tests use count_new.hpp Modified: libcxx/trunk/test/std/localization/locales/locale/locale.cons/assign.pass.cpp libcxx/trunk/test

[libcxx] r273374 - Placate MSVC's unchecked malloc warnings.

2016-06-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jun 21 23:23:54 2016 New Revision: 273374 URL: http://llvm.org/viewvc/llvm-project?rev=273374&view=rev Log: Placate MSVC's unchecked malloc warnings. Modified: libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_array_nothrow_replac

Re: [PATCH] D21564: [OpenMP] Initial implementation of parse and sema for composite pragma 'distribute parallel for'

2016-06-21 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: include/clang/AST/StmtOpenMP.h:2884-2896 @@ +2883,15 @@ + + /// Increment expression for distribute loop (OMPLoopDirective contains + /// increment expression for #for loop) + Expr *DistIncExpr; + + /// \brief EnsureUpperBound for #pr

[libcxx] r273372 - UBSan doesn't globally replace new/delete but it still makes some tests fail. Investigation needed.

2016-06-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jun 21 23:00:45 2016 New Revision: 273372 URL: http://llvm.org/viewvc/llvm-project?rev=273372&view=rev Log: UBSan doesn't globally replace new/delete but it still makes some tests fail. Investigation needed. Modified: libcxx/trunk/test/libcxx/test/config.py libc

[libcxx] r273371 - Cleanup [list.modifiers] tests.

2016-06-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jun 21 22:46:32 2016 New Revision: 273371 URL: http://llvm.org/viewvc/llvm-project?rev=273371&view=rev Log: Cleanup [list.modifiers] tests. Added: libcxx/trunk/test/libcxx/containers/sequences/list/list.modifiers/ libcxx/trunk/test/libcxx/containers/sequences/lis

r273369 - [OpenMP] Add the depend clause to target update construct (sema and parsing)

2016-06-21 Thread Kelvin Li via cfe-commits
Author: kli Date: Tue Jun 21 22:10:32 2016 New Revision: 273369 URL: http://llvm.org/viewvc/llvm-project?rev=273369&view=rev Log: [OpenMP] Add the depend clause to target update construct (sema and parsing) Differential Revision: http://reviews.llvm.org/D21532 Added: cfe/trunk/test/OpenMP/t

[libcxx] r273368 - Don't use non-conforming pointer_traits specialization it tests.

2016-06-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jun 21 21:31:32 2016 New Revision: 273368 URL: http://llvm.org/viewvc/llvm-project?rev=273368&view=rev Log: Don't use non-conforming pointer_traits specialization it tests. Modified: libcxx/trunk/test/std/utilities/memory/allocator.traits/allocator.traits.types/diffe

[libcxx] r273367 - Move remaining _LIBCPP_VERSION tests into test/libcxx

2016-06-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jun 21 21:23:22 2016 New Revision: 273367 URL: http://llvm.org/viewvc/llvm-project?rev=273367&view=rev Log: Move remaining _LIBCPP_VERSION tests into test/libcxx Added: libcxx/trunk/test/libcxx/algorithms/ libcxx/trunk/test/libcxx/algorithms/version.pass.cpp l

[libcxx] r273365 - Move more _LIBCPP_VERSION tests to test/libcxx.

2016-06-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jun 21 21:07:26 2016 New Revision: 273365 URL: http://llvm.org/viewvc/llvm-project?rev=273365&view=rev Log: Move more _LIBCPP_VERSION tests to test/libcxx. Added: libcxx/trunk/test/libcxx/atomics/version.pass.cpp libcxx/trunk/test/libcxx/diagnostics/ libcxx/tr

[libcxx] r273364 - Move all tests for _LIBCPP_VERSION in language.support to test/libcxx/language.support.

2016-06-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jun 21 20:55:59 2016 New Revision: 273364 URL: http://llvm.org/viewvc/llvm-project?rev=273364&view=rev Log: Move all tests for _LIBCPP_VERSION in language.support to test/libcxx/language.support. Added: libcxx/trunk/test/libcxx/language.support/cstdint/ libcxx/tr

[libcxx] r273362 - Move typoed dir meta.hel to meta.help

2016-06-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jun 21 20:42:39 2016 New Revision: 273362 URL: http://llvm.org/viewvc/llvm-project?rev=273362&view=rev Log: Move typoed dir meta.hel to meta.help Added: libcxx/trunk/test/std/utilities/meta/meta.help/ libcxx/trunk/test/std/utilities/meta/meta.help/bool_constant.pa

r273361 - Require an x86 target for the thinlto_backend.ll test.

2016-06-21 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Tue Jun 21 20:40:47 2016 New Revision: 273361 URL: http://llvm.org/viewvc/llvm-project?rev=273361&view=rev Log: Require an x86 target for the thinlto_backend.ll test. Modified: cfe/trunk/test/CodeGen/thinlto_backend.ll Modified: cfe/trunk/test/CodeGen/thinlto_backend.ll URL

[libcxx] r273360 - Use static_assert instead of runtime assert in std::money_base tests.

2016-06-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jun 21 20:40:46 2016 New Revision: 273360 URL: http://llvm.org/viewvc/llvm-project?rev=273360&view=rev Log: Use static_assert instead of runtime assert in std::money_base tests. Modified: libcxx/trunk/test/std/localization/locale.categories/category.monetary/locale.m

[libcxx] r273359 - Remove locale tests that depend on LC_ALL. These are non-portable.

2016-06-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jun 21 20:33:38 2016 New Revision: 273359 URL: http://llvm.org/viewvc/llvm-project?rev=273359&view=rev Log: Remove locale tests that depend on LC_ALL. These are non-portable. Modified: libcxx/trunk/test/std/localization/locale.categories/category.collate/locale.colla

Re: [PATCH] D21587: [libcxx] [test] Fix comment typos, strip trailing whitespace. No code changes.

2016-06-21 Thread Eric Fiselier via cfe-commits
EricWF closed this revision. EricWF added a comment. r273357. http://reviews.llvm.org/D21587 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r273357 - Fix comment typos, strip trailing whitespace. Patch from s...@microsoft.com

2016-06-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jun 21 20:23:51 2016 New Revision: 273357 URL: http://llvm.org/viewvc/llvm-project?rev=273357&view=rev Log: Fix comment typos, strip trailing whitespace. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/strings/char.traits/char.traits.specializations/cha

Re: [PATCH] D21587: [libcxx] [test] Fix comment typos, strip trailing whitespace. No code changes.

2016-06-21 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. I suck at spelling. Thanks. http://reviews.llvm.org/D21587 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D21587: [libcxx] [test] Fix comment typos, strip trailing whitespace. No code changes.

2016-06-21 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Fix comment typos, strip trailing whitespace. No code changes. http://reviews.llvm.org/D21587 Files: test/std/strings/char.traits/char.traits.specializations/char.traits.sp

r273356 - Specify a target triple to fix the test on non-Linux.

2016-06-21 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Tue Jun 21 20:17:30 2016 New Revision: 273356 URL: http://llvm.org/viewvc/llvm-project?rev=273356&view=rev Log: Specify a target triple to fix the test on non-Linux. Modified: cfe/trunk/test/CodeGen/thinlto_backend.ll Modified: cfe/trunk/test/CodeGen/thinlto_backend.ll URL:

Re: [PATCH] D21345: [libcxx] [test] Avoid huge main() functions and huge arrays.

2016-06-21 Thread Eric Fiselier via cfe-commits
EricWF closed this revision. EricWF added a comment. r273354. http://reviews.llvm.org/D21345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [clang-tools-extra] r273304 - clang-rename: add a -old-name option

2016-06-21 Thread Galina Kistanova via cfe-commits
Hi Miklos, This revision broke one of builders: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/7435 Please have a look at it. Thanks Galina On Tue, Jun 21, 2016 at 12:48 PM, Miklos Vajna via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author:

[libcxx] r273353 - Don't use C++17 terse static assert. Patch from s...@microsoft.com

2016-06-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jun 21 20:10:14 2016 New Revision: 273353 URL: http://llvm.org/viewvc/llvm-project?rev=273353&view=rev Log: Don't use C++17 terse static assert. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/utilities/function.objects/func.invoke/invoke.pass.cpp li

Re: [PATCH] D21350: [libcxx] [test] Avoid C++17 terse static_assert.

2016-06-21 Thread Eric Fiselier via cfe-commits
EricWF closed this revision. EricWF added a comment. r273353. http://reviews.llvm.org/D21350 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

RE: [PATCH] D21581: [libcxx] [test] Silence unused variable warnings in invoke.pass.cpp.

2016-06-21 Thread Stephan T. Lavavej via cfe-commits
Oops, that's because it touched the same file as my "avoid C++17 terse static_assert" patch, which hadn't been accepted yet. Thanks for fixing it up. STL -Original Message- From: Eric Fiselier [mailto:e...@efcs.ca] Sent: Tuesday, June 21, 2016 6:05 PM To: Stephan T. Lavavej ; mclow.li..

Re: [PATCH] D21350: [libcxx] [test] Avoid C++17 terse static_assert.

2016-06-21 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. I'm really happy to accept this patch. I was trying to run some of these tests against GCC 5.3 last week and it didn't support this form of static assert yet. I'm secretly sad that we have to

[libcxx] r273352 - Fix operator precedence mistake in valarray/not.pass.cpp. Patch from s...@microsoft.com

2016-06-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jun 21 20:04:09 2016 New Revision: 273352 URL: http://llvm.org/viewvc/llvm-project?rev=273352&view=rev Log: Fix operator precedence mistake in valarray/not.pass.cpp. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/numerics/numarray/template.valarray/va

Re: [PATCH] D21584: [libcxx] [test] Fix an operator precedence mistake in valarray.unary/not.pass.cpp.

2016-06-21 Thread Eric Fiselier via cfe-commits
EricWF closed this revision. EricWF added a comment. r273352. http://reviews.llvm.org/D21584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21584: [libcxx] [test] Fix an operator precedence mistake in valarray.unary/not.pass.cpp.

2016-06-21 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Good catch. Thanks. http://reviews.llvm.org/D21584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

r273351 - Add missing test dependency.

2016-06-21 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Tue Jun 21 20:03:15 2016 New Revision: 273351 URL: http://llvm.org/viewvc/llvm-project?rev=273351&view=rev Log: Add missing test dependency. Modified: cfe/trunk/test/CMakeLists.txt Modified: cfe/trunk/test/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/t

Re: [PATCH] D21585: [libcxx] [test] Silence MSVC's spurious "warning C4100: 'p': unreferenced formal parameter".

2016-06-21 Thread Eric Fiselier via cfe-commits
EricWF closed this revision. EricWF added a comment. r273350. http://reviews.llvm.org/D21585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r273350 - Suppress stupid and incorrect MSVC warning. patch from s...@microsoft.com

2016-06-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jun 21 20:02:08 2016 New Revision: 273350 URL: http://llvm.org/viewvc/llvm-project?rev=273350&view=rev Log: Suppress stupid and incorrect MSVC warning. patch from s...@microsoft.com Modified: libcxx/trunk/test/support/test_allocator.h Modified: libcxx/trunk/test/supp

Re: [PATCH] D21585: [libcxx] [test] Silence MSVC's spurious "warning C4100: 'p': unreferenced formal parameter".

2016-06-21 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Fix your compiler though! http://reviews.llvm.org/D21585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[libcxx] r273349 - Avoid assignment in return. Patch from s...@microsoft.com

2016-06-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jun 21 20:00:32 2016 New Revision: 273349 URL: http://llvm.org/viewvc/llvm-project?rev=273349&view=rev Log: Avoid assignment in return. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/thread/thread.mutex/thread.lock/thread.lock.guard/variadic_adopt_lock

Re: [PATCH] D21582: [libcxx] [test] Avoid mixing assignment and returning.

2016-06-21 Thread Eric Fiselier via cfe-commits
EricWF closed this revision. EricWF added a comment. r273349. http://reviews.llvm.org/D21582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21582: [libcxx] [test] Avoid mixing assignment and returning.

2016-06-21 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. I think your compiler is silly, but I'm happy with the change anyway. I like that syntax gosh darn it! http://reviews.llvm.org/D21582 ___ cfe-co

[libcxx] r273348 - Suppress unused warnings in std::invoke tests.

2016-06-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jun 21 19:58:06 2016 New Revision: 273348 URL: http://llvm.org/viewvc/llvm-project?rev=273348&view=rev Log: Suppress unused warnings in std::invoke tests. Modified: libcxx/trunk/test/std/utilities/function.objects/func.invoke/invoke.pass.cpp Modified: libcxx/trunk/t

Re: [PATCH] D21581: [libcxx] [test] Silence unused variable warnings in invoke.pass.cpp.

2016-06-21 Thread Eric Fiselier via cfe-commits
EricWF closed this revision. EricWF added a comment. For some reason your patch wouldn't apply, but I committed my own version in r273348. http://reviews.llvm.org/D21581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

Re: [PATCH] D21542: CodeGen: Replace test/CodeGen/thinlto_backend.c with a functional test.

2016-06-21 Thread Peter Collingbourne via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL273347: CodeGen: Replace test/CodeGen/thinlto_backend.c with a functional test. (authored by pcc). Changed prior to commit: http://reviews.llvm.org/D21542?vs=61328&id=61479#toc Repository: rL LLVM h

r273347 - CodeGen: Replace test/CodeGen/thinlto_backend.c with a functional test.

2016-06-21 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Tue Jun 21 19:57:26 2016 New Revision: 273347 URL: http://llvm.org/viewvc/llvm-project?rev=273347&view=rev Log: CodeGen: Replace test/CodeGen/thinlto_backend.c with a functional test. This new test tests that functions are capable of being imported, rather than that the import p

Re: [PATCH] D21542: CodeGen: Replace test/CodeGen/thinlto_backend.c with a functional test.

2016-06-21 Thread Peter Collingbourne via cfe-commits
pcc added a comment. Should be fine. This is testing an unusual feature of clang that takes IR as input, so IR is the appropriate input type here. http://reviews.llvm.org/D21542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

Re: [PATCH] D21583: [libcxx] [test] Make unord.hash/integral.pass.cpp portable.

2016-06-21 Thread Eric Fiselier via cfe-commits
EricWF closed this revision. EricWF added a comment. r273345. http://reviews.llvm.org/D21583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r273345 - Guard libc++ assumption about identity hashing in test. Patch from s...@microsoft.com

2016-06-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jun 21 19:53:35 2016 New Revision: 273345 URL: http://llvm.org/viewvc/llvm-project?rev=273345&view=rev Log: Guard libc++ assumption about identity hashing in test. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/utilities/function.objects/unord.hash/in

[PATCH] D21585: [libcxx] [test] Silence MSVC's spurious "warning C4100: 'p': unreferenced formal parameter".

2016-06-21 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Silence MSVC's spurious "warning C4100: 'p': unreferenced formal parameter". This is a C1XX bug, tracked by VSO#188582. C1XX has found some good issues, so I would like to ask

[libcxx] r273344 - Guard use of non-standard macros in denorm_min() tests.

2016-06-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jun 21 19:50:09 2016 New Revision: 273344 URL: http://llvm.org/viewvc/llvm-project?rev=273344&view=rev Log: Guard use of non-standard macros in denorm_min() tests. Modified: libcxx/trunk/test/std/language.support/support.limits/limits/numeric.limits.members/denorm_mi

[PATCH] D21584: [libcxx] [test] Fix an operator precedence mistake in valarray.unary/not.pass.cpp.

2016-06-21 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Fix an operator precedence mistake in valarray.unary/not.pass.cpp. This one was sneaky - the test happened to be passing, but totally by accident. You can thank MSVC warning C

[PATCH] D21583: [libcxx] [test] Make unord.hash/integral.pass.cpp portable.

2016-06-21 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Make unord.hash/integral.pass.cpp portable. This was assuming identity hashing, which is a non-Standard assumption. Guarding this with LIBCPP_ASSERT makes the test portable.

[PATCH] D21582: [libcxx] [test] Avoid mixing assignment and returning.

2016-06-21 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Avoid mixing assignment and returning. "return locked = true;" looks really suspicious, even though it happens to be correct here. Spend an extra statement to make the code cl

r273343 - Stmt.h: Tweak r273312 to avoid bool:1 to appease win32.

2016-06-21 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Tue Jun 21 19:41:50 2016 New Revision: 273343 URL: http://llvm.org/viewvc/llvm-project?rev=273343&view=rev Log: Stmt.h: Tweak r273312 to avoid bool:1 to appease win32. Modified: cfe/trunk/include/clang/AST/Stmt.h Modified: cfe/trunk/include/clang/AST/Stmt.h URL: http:/

[PATCH] D21581: [libcxx] [test] Silence unused variable warnings in invoke.pass.cpp.

2016-06-21 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Silence unused variable warnings in invoke.pass.cpp. Fixes MSVC warning C4101 "unreferenced local variable". http://reviews.llvm.org/D21581 Files: test/std/utilities/functi

Re: [PATCH] D5896: Emit more intrinsics for builtin functions

2016-06-21 Thread Matt Arsenault via cfe-commits
arsenm updated this revision to Diff 61472. arsenm added a comment. Attach right diff http://reviews.llvm.org/D5896 Files: lib/CodeGen/CGBuiltin.cpp test/CodeGen/builtins.c Index: test/CodeGen/builtins.c === --- test/CodeGen/b

[libcxx] r273342 - Allow placement new array test to consume extra bytes as specified by the standard.

2016-06-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jun 21 19:32:28 2016 New Revision: 273342 URL: http://llvm.org/viewvc/llvm-project?rev=273342&view=rev Log: Allow placement new array test to consume extra bytes as specified by the standard. Modified: libcxx/trunk/test/std/language.support/support.dynamic/new.delet

[libcxx] r273341 - Move native_handle thread tests to test/libcxx

2016-06-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jun 21 19:21:50 2016 New Revision: 273341 URL: http://llvm.org/viewvc/llvm-project?rev=273341&view=rev Log: Move native_handle thread tests to test/libcxx Added: libcxx/trunk/test/libcxx/thread/thread.condition/ libcxx/trunk/test/libcxx/thread/thread.condition/thr

r273340 - [analyzer] Teach trackNullOrUndefValue() about class property accessors.

2016-06-21 Thread Devin Coughlin via cfe-commits
Author: dcoughlin Date: Tue Jun 21 19:20:00 2016 New Revision: 273340 URL: http://llvm.org/viewvc/llvm-project?rev=273340&view=rev Log: [analyzer] Teach trackNullOrUndefValue() about class property accessors. Teach trackNullOrUndefValue() how to properly look through PseudoObjectExprs to find the

Re: [PATCH] D5896: Emit more intrinsics for builtin functions

2016-06-21 Thread Matt Arsenault via cfe-commits
arsenm updated this revision to Diff 61468. arsenm added a comment. It appears removing the F isn't actually necessary, unremove it http://reviews.llvm.org/D5896 Files: include/clang/Basic/Builtins.def lib/CodeGen/CGBuiltin.cpp test/CodeGen/builtins.c Index: test/CodeGen/builtins.c =

Re: [PATCH] D5896: Emit more intrinsics for builtin functions

2016-06-21 Thread Matt Arsenault via cfe-commits
arsenm added a comment. In http://reviews.llvm.org/D5896#463883, @hfinkel wrote: > Why are you removing 'F' from all of the builtin definitions? And if you need > to, why are you not removing them from copysign? That marks them as emitting a libcall. It should also be removed from copysign h

[libcxx] r273334 - Fix PR27684 - std::tuple no longer accepts reference to incomplete type in some cases.

2016-06-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jun 21 18:19:13 2016 New Revision: 273334 URL: http://llvm.org/viewvc/llvm-project?rev=273334&view=rev Log: Fix PR27684 - std::tuple no longer accepts reference to incomplete type in some cases. Libc++ has to deduce the 'allocator_arg_t' parameter as 'AllocArgT' for the

Re: [PATCH] D20352: Add XRay flags to Clang

2016-06-21 Thread Eric Christopher via cfe-commits
echristo added a reviewer: aaron.ballman. echristo added a comment. Couple of inline comments. Also adding Aaron since he normally reviews the attributes :) -eric Comment at: include/clang/Driver/Options.td:753 @@ +752,3 @@ + HelpText<"Generate XRay instrumentation sleds on f

Re: [PATCH] Restructure the propagation of -fPIC/-fPIE.

2016-06-21 Thread Joerg Sonnenberger via cfe-commits
On Tue, Jun 21, 2016 at 06:53:03PM -0400, Rafael Espíndola via cfe-commits wrote: > diff --git a/lib/Frontend/InitPreprocessor.cpp > b/lib/Frontend/InitPreprocessor.cpp > index 27ef59a..6b93c69 100644 > --- a/lib/Frontend/InitPreprocessor.cpp > +++ b/lib/Frontend/InitPreprocessor.cpp > @@ -873,10

Re: [PATCH] D5896: Emit more intrinsics for builtin functions

2016-06-21 Thread Hal Finkel via cfe-commits
hfinkel added a comment. Why are you removing 'F' from all of the builtin definitions? And if you need to, why are you not removing them from copysign? http://reviews.llvm.org/D5896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

[PATCH] Restructure the propagation of -fPIC/-fPIE.

2016-06-21 Thread Rafael Espíndola via cfe-commits
The PIC and PIE levels are not independent. In fact, if PIE is defined it is always the same as PIC. This is clear in the driver where ParsePICArgs returns a PIC level and a IsPIE boolean. Unfortunately that is currently lost and we pass two redundant levels down the pipeline. This patch keeps a

[libcxx] r273328 - Implement LWG issue 2720. Replace perms::resolve_symlinks with perms::symlink_nofollow.

2016-06-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jun 21 17:42:42 2016 New Revision: 273328 URL: http://llvm.org/viewvc/llvm-project?rev=273328&view=rev Log: Implement LWG issue 2720. Replace perms::resolve_symlinks with perms::symlink_nofollow. This changes how filesystem::permissions(p, perms) handles symlinks. Previo

r273327 - Delete dead code.

2016-06-21 Thread Rafael Espindola via cfe-commits
Author: rafael Date: Tue Jun 21 17:24:45 2016 New Revision: 273327 URL: http://llvm.org/viewvc/llvm-project?rev=273327&view=rev Log: Delete dead code. Found by gcc 6. Modified: cfe/trunk/lib/Frontend/Rewrite/RewriteModernObjC.cpp Modified: cfe/trunk/lib/Frontend/Rewrite/RewriteModernObjC.cp

[libcxx] r273325 - Implement LWG issue 2725. The issue should move this meeting

2016-06-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jun 21 17:11:16 2016 New Revision: 273325 URL: http://llvm.org/viewvc/llvm-project?rev=273325&view=rev Log: Implement LWG issue 2725. The issue should move this meeting Modified: libcxx/trunk/include/experimental/filesystem libcxx/trunk/test/std/experimental/file

Re: [PATCH] D21229: [Analyzer] Don't cache report generation ExplodedNodes

2016-06-21 Thread Anna Zaks via cfe-commits
zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. LGTM. Please, measure that this does not regress memory consumption just to be sure. Thanks! Anna. http://reviews.llvm.org/D21229 ___ cfe

Re: [libcxx] r273034 - Add Filesystem TS -- Complete

2016-06-21 Thread Eric Fiselier via cfe-commits
The issue should be fixed in r273323. Thanks for the report and for your patience. /Eric On Mon, Jun 20, 2016 at 11:27 PM, Eric Fiselier wrote: > Hi Artem, > > Sorry for the delay, I've been busy with school all day. > I'll check in a fix tomorrow morning. > > Sorry again, > > /Eric > > On Mon

[libcxx] r273323 - Allow the libc++ build/source paths to contain symlinks.

2016-06-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jun 21 16:54:23 2016 New Revision: 273323 URL: http://llvm.org/viewvc/llvm-project?rev=273323&view=rev Log: Allow the libc++ build/source paths to contain symlinks. The filesystem tests were expecting the paths to the build/source directories did not contain any symlinks.

Re: [PATCH] D21451: Emit the DWARF tag for the RenderScript language

2016-06-21 Thread Pirama Arumuga Nainar via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL273321: Emit the DWARF tag for the RenderScript language (authored by pirama). Changed prior to commit: http://reviews.llvm.org/D21451?vs=61038&id=61452#toc Repository: rL LLVM http://reviews.llvm.o

r273321 - Emit the DWARF tag for the RenderScript language

2016-06-21 Thread Pirama Arumuga Nainar via cfe-commits
Author: pirama Date: Tue Jun 21 16:35:11 2016 New Revision: 273321 URL: http://llvm.org/viewvc/llvm-project?rev=273321&view=rev Log: Emit the DWARF tag for the RenderScript language Summary: If the RenderScript LangOpt is set, either via '-x renderscript' or the '.rs' file extension, set the DWAR

Re: r273312 - Re-commit "[Temporary] Add an ExprWithCleanups for each C++ MaterializeTemporaryExpr."

2016-06-21 Thread Rafael Espíndola via cfe-commits
I think this broke the build on windows: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/7421/steps/build/logs/stdio Cheers, Rafael On 21 June 2016 at 16:29, Tim Shen via cfe-commits wrote: > Author: timshen > Date: Tue Jun 21 15:29:17 2016 > New Rev

Re: [PATCH] D19322: Concepts: Create space for requires-clause in TemplateParameterList; NFC

2016-06-21 Thread Hubert Tong via cfe-commits
hubert.reinterpretcast added a comment. Ping. http://reviews.llvm.org/D19322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21567: [OpenCL] Generate struct type for sampler_t and function call for the initializer

2016-06-21 Thread Yaxun Liu via cfe-commits
yaxunl updated this revision to Diff 61443. yaxunl added a comment. Add test deleted by accident. http://reviews.llvm.org/D21567 Files: include/clang/AST/ASTContext.h include/clang/AST/BuiltinTypes.def include/clang/AST/OperationKinds.def include/clang/AST/Type.h include/clang/Basic/D

Re: [PATCH] D20709: For RenderScript, set alignment and width of long to 64-bits

2016-06-21 Thread Pirama Arumuga Nainar via cfe-commits
pirama abandoned this revision. pirama added a comment. Abandoning this revision. Patches for an alternative approach are listed above. http://reviews.llvm.org/D20709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

Re: [PATCH] D20811: [analyzer] Model some library functions

2016-06-21 Thread Anna Zaks via cfe-commits
zaks.anna added a comment. Thanks for the patch! Here are the comments, most of which are nits. Could you add the high level description of what we are doing somewhere or maybe just describe the meaning of FunctionSpec since it encodes how functions are modeled. Also, we should explain why we

Re: r273290 - Added calculateRangesAfterReplaments() to calculate affacted ranges in the new code.

2016-06-21 Thread Eric Liu via cfe-commits
Sent a patch trying to fix this. http://reviews.llvm.org/rL273319 On Tue, Jun 21, 2016 at 10:52 PM Eric Liu wrote: > Thanks Mike! I am working on a fix. > > On Tue, Jun 21, 2016 at 10:44 PM Mike Aizatsky > wrote: > >> I think this change has buffer overflow. It breaks asan build: >> >> http://l

r273319 - Trying to fix a buffer overflow that broke buildbot sanitizer-x86_64-linux-fast/builds/13946.

2016-06-21 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Jun 21 15:49:50 2016 New Revision: 273319 URL: http://llvm.org/viewvc/llvm-project?rev=273319&view=rev Log: Trying to fix a buffer overflow that broke buildbot sanitizer-x86_64-linux-fast/builds/13946. Modified: cfe/trunk/lib/Tooling/Core/Replacement.cpp Modified: c

Re: r273290 - Added calculateRangesAfterReplaments() to calculate affacted ranges in the new code.

2016-06-21 Thread Eric Liu via cfe-commits
Thanks Mike! I am working on a fix. On Tue, Jun 21, 2016 at 10:44 PM Mike Aizatsky wrote: > I think this change has buffer overflow. It breaks asan build: > > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/13946 > > FAIL: Clang-Unit :: > Tooling/ToolingTests/Range.RangesWi

Re: r273290 - Added calculateRangesAfterReplaments() to calculate affacted ranges in the new code.

2016-06-21 Thread Mike Aizatsky via cfe-commits
I think this change has buffer overflow. It breaks asan build: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/13946 FAIL: Clang-Unit :: Tooling/ToolingTests/Range.RangesWithNonOverlappingReplacements (9361 of 9474) TEST 'Clang-Unit :: Tooling/ToolingTest

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

2016-06-21 Thread Piotr Padlewski via cfe-commits
Prazek added a comment. Thank you Samuel, that it is valuable review! I wanted to add the functionality of specifing stuff by options later. should we revert this patch? It seems that those bugs are not so critical (at least on llvm http://reviews.llvm.org/D21507). Anyway, I will fix it in one w

Re: [PATCH] D20498: [Temporary] Add an ExprWithCleanups for each C++ MaterializeTemporaryExpr

2016-06-21 Thread Tim Shen via cfe-commits
timshen added a comment. Committed as r273312. Repository: rL LLVM http://reviews.llvm.org/D20498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r273314 - Fix build of ClangRenameTests

2016-06-21 Thread Miklos Vajna via cfe-commits
Author: vmiklos Date: Tue Jun 21 15:30:40 2016 New Revision: 273314 URL: http://llvm.org/viewvc/llvm-project?rev=273314&view=rev Log: Fix build of ClangRenameTests Adapt the test to the code change introduced in r273304. Modified: clang-tools-extra/trunk/unittests/clang-rename/USRLocFindingT

r273312 - Re-commit "[Temporary] Add an ExprWithCleanups for each C++ MaterializeTemporaryExpr."

2016-06-21 Thread Tim Shen via cfe-commits
Author: timshen Date: Tue Jun 21 15:29:17 2016 New Revision: 273312 URL: http://llvm.org/viewvc/llvm-project?rev=273312&view=rev Log: Re-commit "[Temporary] Add an ExprWithCleanups for each C++ MaterializeTemporaryExpr." Since D21243 fixes relative clang-tidy tests. This reverts commit a71d9fbd

Re: [PATCH] D21241: Add an ASTMatcher for ignoring ExprWithCleanups.

2016-06-21 Thread Tim Shen via cfe-commits
timshen abandoned this revision. timshen added a comment. > I was wondering why we didn't created that Matcher: IgnoreImplicit Actually you are right. There already exists a IgnoreImplict in clang-tidy and I just switched to that. Abandoning this patch. Thanks! http://reviews.llvm.org/D2124

Re: [PATCH] D21306: [x86] AVX FP compare builtins should require AVX target feature (PR28112)

2016-06-21 Thread Sanjay Patel via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL273311: [x86] AVX FP compare builtins should require AVX target feature (PR28112) (authored by spatel). Changed prior to commit: http://reviews.llvm.org/D21306?vs=60596&id=61437#toc Repository: rL LL

r273311 - [x86] AVX FP compare builtins should require AVX target feature (PR28112)

2016-06-21 Thread Sanjay Patel via cfe-commits
Author: spatel Date: Tue Jun 21 15:22:55 2016 New Revision: 273311 URL: http://llvm.org/viewvc/llvm-project?rev=273311&view=rev Log: [x86] AVX FP compare builtins should require AVX target feature (PR28112) This is a fix for PR28112: https://llvm.org/bugs/show_bug.cgi?id=28112 The FP comparison

Re: [PATCH] D20498: [Temporary] Add an ExprWithCleanups for each C++ MaterializeTemporaryExpr

2016-06-21 Thread Tim Shen via cfe-commits
timshen added a comment. http://reviews.llvm.org/D21243 is committed. Let's do this again. Repository: rL LLVM http://reviews.llvm.org/D20498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

  1   2   >