[PATCH] D21584: [libcxx] [test] Fix an operator precedence mistake in valarray.unary/not.pass.cpp.

[Stephan T. Lavavej via cfe-commits]

STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.

Fix an operator precedence mistake in valarray.unary/not.pass.cpp. This one was 
sneaky - the test happened to be passing, but totally by accident.

You can thank MSVC warning C4805 "'==': unsafe mix of type 'bool' and type 'T' 
in operation" for this one.

http://reviews.llvm.org/D21584

Files:
  test/std/numerics/numarray/template.valarray/valarray.unary/not.pass.cpp

Index: test/std/numerics/numarray/template.valarray/valarray.unary/not.pass.cpp
===================================================================
--- test/std/numerics/numarray/template.valarray/valarray.unary/not.pass.cpp
+++ test/std/numerics/numarray/template.valarray/valarray.unary/not.pass.cpp
@@ -36,6 +36,6 @@
         std::valarray<bool> v2 = !(v + v);
         assert(v2.size() == v.size());
         for (int i = 0; i < v2.size(); ++i)
-            assert(v2[i] == !2*v[i]);
+            assert(v2[i] == !(2 * v[i]));
     }
 }



Index: test/std/numerics/numarray/template.valarray/valarray.unary/not.pass.cpp
===================================================================
--- test/std/numerics/numarray/template.valarray/valarray.unary/not.pass.cpp
+++ test/std/numerics/numarray/template.valarray/valarray.unary/not.pass.cpp
@@ -36,6 +36,6 @@
         std::valarray<bool> v2 = !(v + v);
         assert(v2.size() == v.size());
         for (int i = 0; i < v2.size(); ++i)
-            assert(v2[i] == !2*v[i]);
+            assert(v2[i] == !(2 * v[i]));
     }
 }

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits