echristo added a reviewer: aaron.ballman.
echristo added a comment.
Couple of inline comments. Also adding Aaron since he normally reviews the
attributes :)
-eric
================
Comment at: include/clang/Driver/Options.td:753
@@ +752,3 @@
+ HelpText<"Generate XRay instrumentation sleds on function entry and exit">;
+def fnoxray_instrument : Flag<["-"], "fnoxray-instrument">, Group<f_Group>,
+ Flags<[CC1Option]>;
----------------
fno-xray-instrument
================
Comment at: include/clang/Frontend/CodeGenOptions.def:74
@@ -73,3 +73,3 @@
CODEGENOPT(FunctionSections , 1, 0) ///< Set when -ffunction-sections is
enabled.
CODEGENOPT(InstrumentFunctions , 1, 0) ///< Set when -finstrument-functions is
///< enabled.
----------------
Would it make sense to turn -finstrument-functions to
-finstrument-functions=<type> to avoid tons of instrumentation type arguments?
If we want to keep -fxray-instrument still it can then just be an alias.
http://reviews.llvm.org/D20352
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
