This revision was automatically updated to reflect the committed changes.
Closed by commit rL261829: [Sema] Remove assert in
TreeTransform::TransformObjCObjectType. (authored by ahatanak).
Changed prior to commit:
http://reviews.llvm.org/D17355?vs=48247&id=49012#toc
Repository:
rL LLVM
http
Author: ahatanak
Date: Thu Feb 25 01:08:33 2016
New Revision: 261829
URL: http://llvm.org/viewvc/llvm-project?rev=261829&view=rev
Log:
[Sema] Remove assert in TreeTransform::TransformObjCObjectType.
The assert isn't correct since TypeLoc::ObjCObjectTypeLoc doesn't
indicate whether the type is a d
ahatanak added a comment.
Thanks, I'll commit this shortly.
http://reviews.llvm.org/D17355
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pxli168 added a comment.
foo((event_t)0);
Is above use have been hint by some test cases?
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7679
@@ -7678,2 +7678,3 @@
def err_wrong_sampler_addressspace: Error<
- "sampler type cannot be used with the __local and __globa
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/ObjCSuperDeallocChecker.cpp:165
@@ +164,3 @@
+ if (Desc.empty())
+Desc = "use of 'self' after it is freed with call to [super dealloc]";
+
Does "has been freed" sound better?
==
doug.gregor accepted this revision.
doug.gregor added a comment.
This revision is now accepted and ready to land.
LGTM, sorry for the delay.
http://reviews.llvm.org/D17355
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
ahatanak added a comment.
Is this OK to commit?
I've committed the patch to fix the TypeLocBuilder bug in r261260.
http://reviews.llvm.org/D17355
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
pxli168 updated this revision to Diff 49008.
pxli168 added a comment.
1. Make new indent and leave space for the incoming OpenCL C++.
2. Check for the index to see if they are integers.
http://reviews.llvm.org/D16876
Files:
include/clang/Basic/Builtins.h
include/clang/Basic/DiagnosticSemaKi
Author: abataev
Date: Wed Feb 24 23:25:57 2016
New Revision: 261824
URL: http://llvm.org/viewvc/llvm-project?rev=261824&view=rev
Log:
[OPENMP 4.5] Codegen for member decls in 'lastprivate' clause.
OpenMP 4.5 allows to privatize non-static member decls in non-static
member functions. Patch capture
pxli168 updated this revision to Diff 49007.
http://reviews.llvm.org/D16040
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/CodeGen/CodeGenFunction.cpp
lib/Parse/ParseDecl.cpp
lib/Sema/SemaChecking.cpp
lib/Sema/SemaDe
silvas added a comment.
In http://reviews.llvm.org/D15829#360006, @xur wrote:
> Here is the new patch that removes the auto detection of profile kind.
>
> In this patch, I replace the CC1 option of -fprofile-instr-use=<> with
> -fprofile-instrument={llvm-use|clang-use}. For the use compilation,
pxli168 marked 2 inline comments as done.
pxli168 added a comment.
Remove test case for access quilifier in
test/SemaOpenCL/invalid-kernel-attrs.cl.
Due to the patch http://reviews.llvm.org/D17437.
read_only can only be used in parameters with pipe and image type.
Comment at: t
Author: faisalv
Date: Wed Feb 24 23:09:30 2016
New Revision: 261823
URL: http://llvm.org/viewvc/llvm-project?rev=261823&view=rev
Log:
Twek fix for PR24473 (r261506) - Preserve the template arguments as written
(within the DeclRefExpr Node) when creating AST nodes that reference
specializations of
Author: abataev
Date: Wed Feb 24 21:59:29 2016
New Revision: 261820
URL: http://llvm.org/viewvc/llvm-project?rev=261820&view=rev
Log:
[OPENMP 4.5] Support fielddecls in 'shared' clause.
OpenMP 4.5 allows to use non-static data members of current class in
non-static member functions in different k
This or r261737 seem to be causing a bot failure:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/636
-- Sean Silva
On Wed, Feb 24, 2016 at 5:35 AM, Alexander Kornienko via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: alexfh
> Date: Wed Feb
Author: pxl
Date: Wed Feb 24 21:34:20 2016
New Revision: 261818
URL: http://llvm.org/viewvc/llvm-project?rev=261818&view=rev
Log:
[OpenCL] Add Sema checks for types
Summary:
Add Sema checks for opencl type: image, pipe
This patch is partitioned from http://reviews.llvm.org/D16047
Reviewers:
tstellarAMD accepted this revision.
tstellarAMD added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D17589
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
tstellarAMD accepted this revision.
tstellarAMD added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D17519
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
tstellarAMD accepted this revision.
tstellarAMD added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D17520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
tstellarAMD accepted this revision.
tstellarAMD added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D17515
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Those are all compelling reasons for me. Let's go with whatever you and
Dmitri think would be best for now. :)
-eric
On Wed, Feb 24, 2016 at 12:41 PM Romanova, Katya <
katya_roman...@playstation.sony.com> wrote:
> Hello,
>
>
>
> I don’t think it will too hard to convert C++ style doxygen comment
On Wed, Feb 24, 2016 at 5:36 AM, Alexander Kornienko via cfe-commits
wrote:
> Author: alexfh
> Date: Wed Feb 24 07:36:34 2016
> New Revision: 261738
>
> URL: http://llvm.org/viewvc/llvm-project?rev=261738&view=rev
> Log:
> [clang-tidy] introduce modernize-deprecated-headers check
>
> Summary:
> Th
probinson created this revision.
probinson added reviewers: jyknight, dexonsmith.
probinson added a subscriber: cfe-commits.
Herald added a reviewer: tstellarAMD.
FileCheck actually doesn't support combo suffixes. In D17587 I made it
complain, and these are the Clang tests that it caught.
http:
dcoughlin added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CheckObjCDealloc.cpp:184
@@ -144,21 +183,3 @@
- // Determine if the class subclasses NSObject.
- IdentifierInfo* NSObjectII = &Ctx.Idents.get("NSObject");
- IdentifierInfo* SenTestCaseII = &Ctx.Idents.ge
dcoughlin updated this revision to Diff 48995.
dcoughlin marked 8 inline comments as done.
dcoughlin added a comment.
This update addresses Anna's review comments. The big change is that the
program state now maps instance symbols to sets of initial ivar symbols that
must be released. (Rather th
Author: chapuni
Date: Wed Feb 24 19:12:57 2016
New Revision: 261814
URL: http://llvm.org/viewvc/llvm-project?rev=261814&view=rev
Log:
check-clang-tools: Introduce the feature "target-headers".
For now, it just detects that host is non-Windows and target is msvc.
FIXME: It should be probable for
The build should be fixed, but the tests for this check fail. I'll fix the
tests tomorrow.
On Thu, Feb 25, 2016 at 12:46 AM, Alexander Kornienko
wrote:
> I have a couple ideas, will try on the buildbot, since I don't have MSVC
> to try fixes locally.
>
> On Wed, Feb 24, 2016 at 10:27 PM, Alexand
Author: alexfh
Date: Wed Feb 24 18:39:11 2016
New Revision: 261811
URL: http://llvm.org/viewvc/llvm-project?rev=261811&view=rev
Log:
[clang-tidy] Another attempt to fix MSVC build
Modified:
clang-tools-extra/trunk/clang-tidy/modernize/DeprecatedHeadersCheck.cpp
Modified:
clang-tools-extra/t
Author: alexfh
Date: Wed Feb 24 17:48:24 2016
New Revision: 261806
URL: http://llvm.org/viewvc/llvm-project?rev=261806&view=rev
Log:
Trying to fix MSVC build
Modified:
clang-tools-extra/trunk/clang-tidy/modernize/DeprecatedHeadersCheck.cpp
Modified:
clang-tools-extra/trunk/clang-tidy/modern
I have a couple ideas, will try on the buildbot, since I don't have MSVC to
try fixes locally.
On Wed, Feb 24, 2016 at 10:27 PM, Alexander Kornienko
wrote:
> Looking into this...
>
>
> On Wed, Feb 24, 2016 at 10:21 PM, Nico Weber wrote:
>
>> This broke the Windows bot:
>> http://lab.llvm.org:80
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261803: Fix assertion failure on MaybeODRUseExprs. (authored
by mren).
Changed prior to commit:
http://reviews.llvm.org/D17576?vs=48963&id=48986#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1757
Author: mren
Date: Wed Feb 24 17:05:43 2016
New Revision: 261803
URL: http://llvm.org/viewvc/llvm-project?rev=261803&view=rev
Log:
Fix assertion failure on MaybeODRUseExprs.
In VisitNonTypeTemplateParamDecl, before SubstExpr with the default argument,
we should create a ConstantEvaluated Expressi
Author: gbiv
Date: Wed Feb 24 16:31:14 2016
New Revision: 261798
URL: http://llvm.org/viewvc/llvm-project?rev=261798&view=rev
Log:
Minor cleanup of Sema::CheckEnableIf. NFC.
Modified:
cfe/trunk/lib/Sema/SemaOverload.cpp
Modified: cfe/trunk/lib/Sema/SemaOverload.cpp
URL:
http://llvm.org/view
Author: majnemer
Date: Wed Feb 24 16:07:26 2016
New Revision: 261784
URL: http://llvm.org/viewvc/llvm-project?rev=261784&view=rev
Log:
Revert "Don't convert a char to a const char *"
This reverts commit r261780. It turns out the original code was just
fine. An overload for ltrim which takes cha
Ah, good point. I assumed that the report was valid because they aren't
showing up in the doxygen:
http://llvm.org/docs/doxygen/html/classllvm_1_1StringRef.html
I'll go ahead and revert.
On Wed, Feb 24, 2016 at 2:06 PM, Benjamin Kramer
wrote:
> Were you able to reproduce this build failure? lt
A UnaryTransformType should itself be a canonical type if its BaseType
is dependent -- that is, its CanonicalType should be QualType(this,
0). It should definitely not be treated as being canonically
equivalent to its BaseType.
On Wed, Feb 24, 2016 at 2:03 PM, Vassil Vassilev wrote:
> ping...
>
>
Author: pcc
Date: Wed Feb 24 16:03:06 2016
New Revision: 261782
URL: http://llvm.org/viewvc/llvm-project?rev=261782&view=rev
Log:
Fix build by using hasFlag instead of hasArg.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified: cfe/trunk/lib/Driver/Tools.cpp
URL:
http://llvm.org/viewvc/llvm-
Were you able to reproduce this build failure? ltrim has overloads for
"char" and "StringRef", the former being very new. From the error
message I suspect out of sync LLVM and Clang checkouts.
On Wed, Feb 24, 2016 at 10:55 PM, David Majnemer via cfe-commits
wrote:
> Author: majnemer
> Date: Wed F
On 24/02/16 23:03, Richard Smith wrote:
On Wed, Feb 24, 2016 at 2:01 PM, Vassil Vassilev wrote:
On 24/02/16 22:50, Richard Smith wrote:
On Wed, Feb 24, 2016 at 8:10 AM, Vassil Vassilev
wrote:
On 24/02/16 02:05, Richard Smith wrote:
Calling getMostRecentDecl seems like a slightly fragile way
Author: rsmith
Date: Wed Feb 24 15:59:10 2016
New Revision: 261781
URL: http://llvm.org/viewvc/llvm-project?rev=261781&view=rev
Log:
PR26237: Fix iterator invalidation bug that occurs if serializing
specializations of a template manages to trigger deserialization of more
specializations of the sam
On Wed, Feb 24, 2016 at 2:01 PM, Vassil Vassilev wrote:
> On 24/02/16 22:50, Richard Smith wrote:
>>
>> On Wed, Feb 24, 2016 at 8:10 AM, Vassil Vassilev
>> wrote:
>>>
>>> On 24/02/16 02:05, Richard Smith wrote:
Calling getMostRecentDecl seems like a slightly fragile way to avoid
it
jlebar abandoned this revision.
jlebar added a comment.
Subsumed by http://reviews.llvm.org/D17056.
http://reviews.llvm.org/D17313
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ping...
On 07/01/16 08:09, Vassil Vassilev via cfe-commits wrote:
Hi all,
I am attaching a fix for https://llvm.org/bugs/show_bug.cgi?id=26014
To which type should I tie the canonical type of the unknown
underlying type? Currently it is tied to its BaseType.
Please review.
--Vassil
___
rsmith accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:2114
@@ -2113,1 +2113,3 @@
+EnterExpressionEvaluationContext ConstantEvaluated(SemaRef,
+
On 24/02/16 22:50, Richard Smith wrote:
On Wed, Feb 24, 2016 at 8:10 AM, Vassil Vassilev wrote:
On 24/02/16 02:05, Richard Smith wrote:
Calling getMostRecentDecl seems like a slightly fragile way to avoid
iterator invalidation here. Instead...
@@ -214,6 +212,19 @@ namespace clang {
u
Author: majnemer
Date: Wed Feb 24 15:55:58 2016
New Revision: 261780
URL: http://llvm.org/viewvc/llvm-project?rev=261780&view=rev
Log:
Don't convert a char to a const char *
This fixes PR26728.
Modified:
cfe/trunk/lib/Lex/PPDirectives.cpp
Modified: cfe/trunk/lib/Lex/PPDirectives.cpp
URL:
h
Author: tra
Date: Wed Feb 24 15:54:45 2016
New Revision: 261778
URL: http://llvm.org/viewvc/llvm-project?rev=261778&view=rev
Log:
[CUDA] do not allow attribute-based overloading for __global__ functions.
__global__ functions are present on both host and device side,
so providing __host__ or __dev
Author: jlebar
Date: Wed Feb 24 15:55:11 2016
New Revision: 261779
URL: http://llvm.org/viewvc/llvm-project?rev=261779&view=rev
Log:
[CUDA] Mark all CUDA device-side function defs, decls, and calls as convergent.
Summary:
This is important for e.g. the following case:
void sync() { __syncthrea
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261779: [CUDA] Mark all CUDA device-side function defs,
decls, and calls as convergent. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D17056?vs=48261&id=48979#toc
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261777: [CUDA] Add conversion operators for threadIdx,
blockIdx, gridDim, and… (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D17561?vs=48884&id=48978#toc
Repository:
rL LLVM
majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D17056
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261773: Make test/Driver/output-file-cleanup.c hermetic.
(authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D17216?vs=47857&id=48975#toc
Repository:
rL LLVM
http://reviews.llvm.o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261774: Bail on compilation as soon as a job fails.
(authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D17217?vs=47858&id=48976#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261776: [CUDA] Add hack so code which includes "curand.h"
doesn't break. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D17562?vs=48885&id=48977#toc
Repository:
rL LLVM
http:
Author: jlebar
Date: Wed Feb 24 15:49:33 2016
New Revision: 261777
URL: http://llvm.org/viewvc/llvm-project?rev=261777&view=rev
Log:
[CUDA] Add conversion operators for threadIdx, blockIdx, gridDim, and blockDim
to uint3 and dim3.
Summary:
This lets you write, e.g.
uint3 a = threadIdx;
uint
Author: jlebar
Date: Wed Feb 24 15:49:28 2016
New Revision: 261774
URL: http://llvm.org/viewvc/llvm-project?rev=261774&view=rev
Log:
Bail on compilation as soon as a job fails.
Summary:
(Re-land of r260448, which was reverted in r260522 due to a test failure
in Driver/output-file-cleanup.c that o
Author: jlebar
Date: Wed Feb 24 15:49:30 2016
New Revision: 261775
URL: http://llvm.org/viewvc/llvm-project?rev=261775&view=rev
Log:
[CUDA] Don't specify exact line numbers in cuda-builtin-vars.cu.
This makes the test less fragile to changes to cuda_builtin_vars.h.
Test-only change.
Modified:
Author: jlebar
Date: Wed Feb 24 15:49:31 2016
New Revision: 261776
URL: http://llvm.org/viewvc/llvm-project?rev=261776&view=rev
Log:
[CUDA] Add hack so code which includes "curand.h" doesn't break.
Summary:
curand.h includes curand_mtgp32_kernel.h. In host mode, this header
redefines threadIdx a
Author: jlebar
Date: Wed Feb 24 15:49:26 2016
New Revision: 261773
URL: http://llvm.org/viewvc/llvm-project?rev=261773&view=rev
Log:
Make test/Driver/output-file-cleanup.c hermetic.
Summary:
It checks that certain files do and exist, so make sure that they don't
exist at the beginning of the test
On Wed, Feb 24, 2016 at 8:10 AM, Vassil Vassilev wrote:
>
> On 24/02/16 02:05, Richard Smith wrote:
>>
>> Calling getMostRecentDecl seems like a slightly fragile way to avoid
>> iterator invalidation here. Instead...
>>
>> @@ -214,6 +212,19 @@ namespace clang {
>> unsigned I = Record.size(
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
OK.
http://reviews.llvm.org/D17561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar added a comment.
Upon further consideration, I'm going to push this with post-submit review --
the only difference from what echristo reviewed is an obvious change to
output-file-cleanup.c.
http://reviews.llvm.org/D17217
___
cfe-commits mai
jlebar added a comment.
Friendly ping -- are we happy with this?
http://reviews.llvm.org/D17056
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar added a comment.
Upon further consideration, I think I'm going to push this with post-submit
review, as we know this test is quite broken, and I think this change is
unlikely to make the situation worse.
http://reviews.llvm.org/D17216
___
c
tra created this revision.
tra added a reviewer: jlebar.
tra added a subscriber: cfe-commits.
__global__ functions are present on both host and device side,
so providing __host__ or __device__ overloads is not going to
do anything useful.
http://reviews.llvm.org/D17581
Files:
lib/Sema/SemaOver
Looking into this...
On Wed, Feb 24, 2016 at 10:21 PM, Nico Weber wrote:
> This broke the Windows bot:
> http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10093/steps/build%20stage%201/logs/stdio
>
> FAILED: C:\PROGRA~2\MICROS~1.0\VC\bin\amd64\cl.exe /nologo /TP /DWIN32
> /D_WINDOW
This broke the Windows bot:
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10093/steps/build%20stage%201/logs/stdio
FAILED: C:\PROGRA~2\MICROS~1.0\VC\bin\amd64\cl.exe /nologo /TP /DWIN32
/D_WINDOWS /W4 -wd4141 -wd4146 -wd4180 -wd4244 -wd4258 -wd4267 -wd4291
-wd4345 -wd4351 -wd43
On Wed, Feb 24, 2016 at 4:14 PM, Samuel Benzaquen via cfe-commits
wrote:
> sbenza added a comment.
>
> I assume you checked that the new trait works on MSVC.
Yes. It's also used in ThreadSafety.cpp, so maybe at some point we may
want to consider generalizing the trait.
> Aren't both the same typ
sbenza added a comment.
I assume you checked that the new trait works on MSVC.
Aren't both the same type of expression SFINAE? Is somehow one supported but
not the other?
http://reviews.llvm.org/D17575
___
cfe-commits mailing list
cfe-commits@lists
On Wed, Feb 24, 2016 at 3:53 PM, Richard Smith
wrote:
> On Wed, Feb 24, 2016 at 10:47 AM, Nico Weber wrote:
> > Thanks for patiently explaining this. The attached patch is your email in
> > diff form. Does this look alright?
>
> Yes, it looks great. Thanks for the excellent test cases.
>
r26177
Author: nico
Date: Wed Feb 24 14:58:14 2016
New Revision: 261770
URL: http://llvm.org/viewvc/llvm-project?rev=261770&view=rev
Log:
Fix rejects-valid caused by r261297.
r261297 called hasUserProvidedDefaultConstructor() to check if defining a
const object is ok. This is incorrect for this example
On Wed, Feb 24, 2016 at 10:47 AM, Nico Weber wrote:
> Thanks for patiently explaining this. The attached patch is your email in
> diff form. Does this look alright?
Yes, it looks great. Thanks for the excellent test cases.
> Since you mention C++98: We emit this diagnostic in C++98 mode (before
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261767: Add whole-program vtable optimization feature to
Clang. (authored by pcc).
Changed prior to commit:
http://reviews.llvm.org/D16821?vs=46697&id=48968#toc
Repository:
rL LLVM
http://reviews.ll
Author: pcc
Date: Wed Feb 24 14:46:36 2016
New Revision: 261767
URL: http://llvm.org/viewvc/llvm-project?rev=261767&view=rev
Log:
Add whole-program vtable optimization feature to Clang.
This patch introduces the -fwhole-program-vtables flag, which enables the
whole-program vtable optimization fea
Hello,
I don’t think it will too hard to convert C++ style doxygen comments into C
style doxygen comments by writing a post-processing python script. However, at
first we need to decide if we really want to do that. If so, we need to settle
on the exact format. After that, I need to make sure t
yaxunl updated the summary for this revision.
yaxunl removed a reviewer: pekka.jaaskelainen.
yaxunl added a subscriber: pekka.jaaskelainen.
yaxunl set the repository for this revision to rL LLVM.
yaxunl updated this revision to Diff 48967.
yaxunl marked 5 inline comments as done.
yaxunl added a com
faisalv added inline comments.
Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:2114
@@ -2113,1 +2113,3 @@
+EnterExpressionEvaluationContext ConstantEvaluated(SemaRef,
+
Sema::ConstantEvaluated);
ExprResult Value
ashi1 created this revision.
ashi1 added reviewers: Anastasia, pxli168, yaxunl.
ashi1 added subscribers: pekka.jaaskelainen, tstellarAMD, cfe-commits.
This patch will allow the cast of 0 to event_t type.
http://reviews.llvm.org/D17578
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sem
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
OK.
http://reviews.llvm.org/D17562
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar added inline comments.
Comment at: lib/Headers/cuda_builtin_vars.h:72
@@ -66,1 +71,3 @@
+ // uint3). This function is defined after we pull in vector_types.h.
+ __attribute__((device)) operator uint3() const;
private:
tra wrote:
> Considering that built
manmanren created this revision.
manmanren added reviewers: rsmith, EricWF, faisalv.
manmanren added a subscriber: cfe-commits.
In VisitNonTypeTemplateParamDecl, before SubstExpr with the default argument,
we should create a ConstantEvaluated ExpressionEvaluationContext. Without this,
it is possib
Thanks for patiently explaining this. The attached patch is your email in
diff form. Does this look alright?
Since you mention C++98: We emit this diagnostic in C++98 mode (before and
after my change). The rule is new in C+++11, right? Should I add a check
for CPlusPlus11 before emitting this diag
Nice catch. :)
On Wed, Feb 24, 2016, 10:43 AM Bob Wilson via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: bwilson
> Date: Wed Feb 24 12:38:35 2016
> New Revision: 261762
>
> URL: http://llvm.org/viewvc/llvm-project?rev=261762&view=rev
> Log:
> Fix typo in test/CodeGen/object-size.c
Author: bwilson
Date: Wed Feb 24 12:38:35 2016
New Revision: 261762
URL: http://llvm.org/viewvc/llvm-project?rev=261762&view=rev
Log:
Fix typo in test/CodeGen/object-size.c CHECK line.
Modified:
cfe/trunk/test/CodeGen/object-size.c
Modified: cfe/trunk/test/CodeGen/object-size.c
URL:
http://
aaron.ballman created this revision.
aaron.ballman added reviewers: sbenza, klimek.
aaron.ballman added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
ASTMatchersInternal uses a custom type trait to determine the presence or
absence of a getDecl member function. While the current i
tra added inline comments.
Comment at: lib/Headers/cuda_builtin_vars.h:72
@@ -66,1 +71,3 @@
+ // uint3). This function is defined after we pull in vector_types.h.
+ __attribute__((device)) operator uint3() const;
private:
Considering that built-in variables ar
Author: tnorthover
Date: Wed Feb 24 11:57:48 2016
New Revision: 261758
URL: http://llvm.org/viewvc/llvm-project?rev=261758&view=rev
Log:
AArch64: fix Cyclone CPU features list.
It turns out we don't have CRC after all. Who knew?
Modified:
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/test/Pre
On Tue, Feb 23, 2016 at 6:39 PM, Duncan P. N. Exon Smith
wrote:
>
>> On 2016-Feb-23, at 11:18, Aaron Ballman wrote:
>>
>> On Tue, Feb 23, 2016 at 1:52 PM, Manman Ren wrote:
>>> This patch looks good to me. But I am not sure if Aaron has any comment.
>>>
>>> On Feb 22, 2016, at 6:19 PM, Duncan P.
Anastasia added inline comments.
Comment at: test/SemaOpenCL/storageclass-cl20.cl:11
@@ -10,3 +10,3 @@
static global int S2 = 5;
- static private int S3 = 5;// expected-error{{program scope variable must
reside in global or constant address space}}
+ static private int S3 =
Alexander_Droste updated this revision to Diff 48959.
Alexander_Droste added a comment.
- removed `reverse`
- fixed twine usage
I think `VariableName.insert(VariableName.size() - 1, ArrayIndices);` is needed
here.
varName, indices -> 'varname[...]' If append would be used, the second single
qu
Author: mren
Date: Wed Feb 24 11:49:50 2016
New Revision: 261756
URL: http://llvm.org/viewvc/llvm-project?rev=261756&view=rev
Log:
Objective-C: Add a size field to non-fragile category metadata.
This is mainly for extensibility. Note that fragile category metadata,
metadata for classes and protoc
Anastasia added a comment.
Yes, I think it deserves clarification. Could you submit a bug to Khronos then?
http://reviews.llvm.org/D17438
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
Anastasia added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:1572
@@ +1571,3 @@
+The __read_only, __write_only, __read_write, read_only, write_only and
+read_write names are reserved for use as access qualifiers and shall not be
+used otherwise.
An
Author: mzuckerm
Date: Wed Feb 24 11:39:35 2016
New Revision: 261755
URL: http://llvm.org/viewvc/llvm-project?rev=261755&view=rev
Log:
[CLANG] [AVX512] [BUILTIN] Adding PSHUF{L|H}W{128|256|512} builtin to clang .
Differential Revision: http://reviews.llvm.org/D17539
Modified:
cfe/trunk/inclu
davidxl added a comment.
Looks good to me -- and it makes the profile-gen and profile-use's cc1 option
handling consistent. Please check with Sean or Justin just in case before
proceeding.
http://reviews.llvm.org/D15829
___
cfe-commits mailing li
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Core/MemRegion.cpp:672
@@ +671,3 @@
+// Combine variable name with indices.
+VariableName.insert(VariableName.size() - 1, ArrayIndices);
+ }
nit: this is in fact an append. It is cleaner inst
xazax.hun added a comment.
Since we went with the twine solution, I think we can get rid of the reverse
stuff.
Note that:
Twine should be used like: (Twine(A) + B + C).str()
So the operator+ has twine as one of the operands.
Once these are fixed, it looks good to me.
Do you have commit access o
Alexander_Droste updated this revision to Diff 48953.
Alexander_Droste added a comment.
- remove string idx variable -> remove string copy assignments
- use Twine to reduce temporary string objects, built during concatenation
Is `ArrayIndices = llvm::Twine(ArrayIndices + "]" + intValAsString.str(
compnerd added inline comments.
Comment at: lib/Headers/unwind.h:61
@@ +60,3 @@
+#define _UNWIND_ARM_EHABI 0
+#endif
+
logan wrote:
> logan wrote:
> > compnerd wrote:
> > > logan wrote:
> > > > compnerd wrote:
> > > > > logan wrote:
> > > > > > Since this is `unwi
Author: majnemer
Date: Wed Feb 24 11:02:45 2016
New Revision: 261751
URL: http://llvm.org/viewvc/llvm-project?rev=261751&view=rev
Log:
[WinEH] Make sure terminate handlers have funclet operands
Calls to the terminate handler must be annotated within the exception
region they are within.
Modified
1 - 100 of 128 matches
Mail list logo
